From patchwork Sun Nov 15 17:43:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Maciej W. Rozycki" X-Patchwork-Id: 1400511 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-mips.org Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CZ01y3wmfz9sRR for ; Mon, 16 Nov 2020 04:44:04 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CC2F13846047; Sun, 15 Nov 2020 17:44:00 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from cvs.linux-mips.org (eddie.linux-mips.org [148.251.95.138]) by sourceware.org (Postfix) with ESMTP id C051638618EE for ; Sun, 15 Nov 2020 17:43:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C051638618EE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-mips.org Authentication-Results: sourceware.org; spf=none smtp.mailfrom=macro@linux-mips.org Received: from localhost.localdomain ([127.0.0.1]:55068 "EHLO localhost" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23991105AbgKORn4A31Xh (ORCPT ); Sun, 15 Nov 2020 18:43:56 +0100 Date: Sun, 15 Nov 2020 17:43:55 +0000 (GMT) From: "Maciej W. Rozycki" To: gcc-patches@gcc.gnu.org Subject: [committed] VAX: Correct a typo in PIC symbolic addition operand checks Message-ID: MIME-Version: 1.0 X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KHOP_HELO_FCRDNS, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Fix a typo and check both SImode addition operands for being incorrectly symbolic in PIC mode before issuing a diagnostic dump of the offending RTL expression. gcc/ * config/vax/vax.c (vax_output_int_add) : Also check `operands[2]' for being symbolic with PIC rather than checking `operands[1]' twice. --- Hi, No regressions in `vax-netbsdelf' testing; this diagnostic dump is not supposed to trigger. Committed as obvious. Maciej --- gcc/config/vax/vax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) gcc-vax-debug-int-add.diff Index: gcc/gcc/config/vax/vax.c =================================================================== --- gcc.orig/gcc/config/vax/vax.c +++ gcc/gcc/config/vax/vax.c @@ -1511,7 +1511,7 @@ vax_output_int_add (rtx_insn *insn, rtx if (flag_pic && (symbolic_operand (operands[1], SImode) - || symbolic_operand (operands[1], SImode))) + || symbolic_operand (operands[2], SImode))) debug_rtx (insn); return "addl3 %1,%2,%0";