From patchwork Mon Oct 26 20:59:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harald Anlauf X-Patchwork-Id: 1388105 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=f/1tFHnW; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CKnJM5Dyxz9sSn for ; Tue, 27 Oct 2020 07:59:15 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 91ACC3951015; Mon, 26 Oct 2020 20:59:13 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id 605EC3950C78; Mon, 26 Oct 2020 20:59:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 605EC3950C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=anlauf@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603745949; bh=tReV1z35H8EuVNp0LfwhVcsB3rCjU5gK+BmvVT0U9Wg=; h=X-UI-Sender-Class:From:To:Subject:Date; b=f/1tFHnWXe9lO2snX1qmydLhziu8nCJT+RRxll8JZ3MqlqP79qQCEpwvzJHdbzAmu 5rjU37rIlb7d3gluEIzrcw7FVSR9/Bo0LipCPy06bMsT3maO2tIpX+TGun3XkIVSSL 6i4HZS1hC2CP/i7qaJzKFyc1ijv8D2BM4A6AQo6Q= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [93.207.83.161] ([93.207.83.161]) by web-mail.gmx.net (3c-app-gmx-bs14.server.lan [172.19.170.66]) (via HTTP); Mon, 26 Oct 2020 21:59:09 +0100 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: fortran , gcc-patches Subject: [PATCH] PR fortran/97491 - Wrong restriction for VALUE arguments of pure procedures Date: Mon, 26 Oct 2020 21:59:09 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:YZFaGqIjPo48PttSZVtj1vI3fhM3C7bPq7rZgF/4koMqYCOd0KFN2w1tnFIhj7crhR+Dg n2si+VrUwgkjn0dDIWVCvJVa4KAOkWnprQLRCCvriKTMUkJtkpL5O3wDZ0QPfypjU3SbLB2glnHT CPRdKGAIQsfEbBKe37QfF9IoPrhXQ+/8vt95Ot1JeLE+vylKl0TCl1J/pQviOcATEPZhsNFBUhmx tsSRfO32Pc+YAr4KV+XxjijsBFOG8V7z7xU5xVHC5kItoV6NgGNZNCUCCeyIfCyPTKH34rEXjJdu AQ= X-UI-Out-Filterresults: notjunk:1;V03:K0:L45OlKq3K1A=:nprEBRW6GwcpdLJX9v/eUl g95gV4o8j2d4MD+Tmg8H7aK3a4TZkN1DkyqDzq9XaCw33XcDTBTTZbR1pbZnIN0qaeQfjhIJj /T3Jpj/8ghoDL5HXnCWpC9Sc9RrJY6NcYWvha7yeFynqdWp5/IOcjvbLoGnDuCt5S18UvXtCl 2S+6oiE2evUXjwqZpe0qw+dYEpML5ZZ/8qIKIPr8XM5A5bXMBv7hEnwBnfWFLyxjXpFEylYA+ lp3ovH/xoseyttefVAfnjAwoNnHOR28x0qUDSFvDue4n6WcPrjAcY1b+JFn8cvOxZRifFrevn qB7ibVTGcIbTqWeI2DML8zT6V18q6jqb3q5s6a8xHj7tQY4+YvznSobSSoHTWk/Pi9OHFI2A/ u99o0uyGQjd46eygfLUqLdDGGjU/8KrmCu3tApEWDnPe0LxNMFaPiUw1txILTCcQsLICIvpKt 6oI4o7NgsSiqPnkk8tWWb1+eUMCqppdcSTxUia+R+EM2s3b2ns+sOFOfwglG3gHLz0z/ZUTMH OShENPoIBYlkqAcM3Yaw4c0D97rFnEKHPhFv1kh4uNDSBiAxVTx9BWCrftwmr0+spaA29LySG t7MSZuyXRQd/4= X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" As found/reported by Thomas, the redefinition of dummy arguments with the VALUE attribute was erroneously rejected for pure procedures. A related purity check did not take VALUE into account and was therefore adjusted. Regtested on x86_64-pc-linux-gnu. OK for master? Thanks, Harald PR fortran/97491 - Wrong restriction for VALUE arguments of pure procedures A dummy argument with the VALUE attribute may be redefined in a PURE or ELEMENTAL procedure. Adjust the associated purity check. gcc/fortran/ChangeLog: * resolve.c (gfc_impure_variable): A dummy argument with the VALUE attribute may be redefined without making a procedure impure. gcc/testsuite/ChangeLog: * gfortran.dg/value_8.f90: New test. diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c index a210f9aad43..096108f4317 100644 --- a/gcc/fortran/resolve.c +++ b/gcc/fortran/resolve.c @@ -16476,6 +16507,7 @@ gfc_impure_variable (gfc_symbol *sym) proc = sym->ns->proc_name; if (sym->attr.dummy + && !sym->attr.value && ((proc->attr.subroutine && sym->attr.intent == INTENT_IN) || proc->attr.function)) return 1; diff --git a/gcc/testsuite/gfortran.dg/value_8.f90 b/gcc/testsuite/gfortran.dg/value_8.f90 new file mode 100644 index 00000000000..8273fe88b60 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/value_8.f90 @@ -0,0 +1,16 @@ +! { dg-do compile } +! PR97491 - Wrong restriction for VALUE arguments of pure procedures + +pure function foo (x) result (ret) + integer :: ret + integer, value :: x + x = x / 2 + ret = x +end function foo + +elemental function foo1 (x) + integer :: foo1 + integer, value :: x + x = x / 2 + foo1 = x +end function foo1