From patchwork Sat Oct 17 16:42:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1383727 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=Qra1xLvG; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CD83M0scGz9sSf for ; Sun, 18 Oct 2020 03:43:20 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7DBCA81BD2; Sat, 17 Oct 2020 18:43:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="Qra1xLvG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4FC6581B79; Sat, 17 Oct 2020 18:43:12 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 19BA081B79 for ; Sat, 17 Oct 2020 18:43:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1602952979; bh=0JtJ3AHKKvIJ4//NjbkDRztk5Ybr3gHcSaQzXqQEK/I=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=Qra1xLvG1/hx+XqdnntiWObq8g/YIAFoVC9xW2uR8sYbuOL1J40hv0EyikRlfgClp jnTFSreQpkVKYFs1UsICmO1d8x3HqJLGjUUWobLMpzswpY8yT4ZcU6AuJz1Y46S7gD qnsfdU1mVnoxRQ6ad+e1XT+BIhsz0W5sSIcgC8f8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([178.202.41.107]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MbAcs-1jsYfb0vNI-00bYzl; Sat, 17 Oct 2020 18:42:59 +0200 From: Heinrich Schuchardt To: Tom Rini Cc: Masahiro Yamada , Simon Glass , Bin Meng , Michal Simek , Jean-Jacques Hiblot , Jan Kiszka , Anatolij Gustschin , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] Makefile: consistent include path for out of tree build Date: Sat, 17 Oct 2020 18:42:53 +0200 Message-Id: <20201017164253.234284-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:JfC699swC59FDrJB9lcnr8DN4MD9ABlqsm5/S7MtUFN8j88FSwS 9N+wBnr1J/5xmxL07OpQtlpbWehaX7T7atP+n0u3pQ28NHMl0DMvgu9qH1JAxF8c1k3NnpD w07cWILutDaRszzgiRiUd+IeOzQvNdT3e1Yifc2IOaP4toLmHZKKwjdyR3jID6yF9VDsGP9 sybekRgO0Ul1EW/c4RIMw== X-UI-Out-Filterresults: notjunk:1;V03:K0:lvwcaF3k8ZM=:/Md/XBdrxWcioQrPUwq+E+ tCW8aU/M6jjyvR18kggqJ0qpl8gSdbPGD/6pnVidvw5ojpxMXJAQiwGxFlEtlQ55skdYmfGG5 qCy7GGsm2utKiS04qvbXVg0geqJ9MtH/l/zmxi07RFgxP7iNz9fyCb1d05jazlpCyZPEC6Y2A Ptjz3cdVa1upxdgKKgE0wtgbdkxzT2Tx3om2Bv8IZTEcUaJe2KMSH7H9DS/9L0eOEgTnAS+2w yqvKpa886/pUxz0uGV9uapYI45vEUnuorVY1yOdMfSMFWN3T7hGLJbQusmfWC202FyFpSGZ8c +RPu3cLwPNCHozxeFoxGls3ehugcyz9voFLIY8GXI2rq7h0uj64g/bOFFqS/jPdUOi8Aj6Iw2 VrZ4lP1uTqwma3VxScYyEtyva/bEl1Bqkx44qc0cDULX5jvVrbHmkomeZuERdv2WsZBI2OHBw olZIqlRFRmcu1VMN+wddFQlKzjZhhaOryGAj38gucXZzlye7TghC5qJTv6/djhXVXSHhpRZY2 ypH84XrBtsnRTnVK+/O9hncjbk7LvAJcvHNrzlumW8AcpS23mNXdAzleT6pWJJZZ0U2rLBdXg Yh/YdpBcYwDZUe39o3iIvIstwQ53wg7o5CyWPIwLyGHMhhpKDIDtrCdRjsWV8Ahl8SOQBVnDv 3HOcjy2xjwagXDvN5LBOY7XBlzLqKpFcH/1VUL2dvg7iFUfFhLw3HeZtzBWbfq4A9Q026l4p1 FUYQxp5+rlg1f/D5Smh/G5QiuhBj5f7dMD3ktFxAgu9pNZPLVw2o3eD1j/eOV4WxKZ5NLPNMM Eyj6Pcbksqx3avQ9awKqxHMfnIYGoIDwtBYT7N1O+I34UEo72aooPQwnxo147Y1IBswfMXnLy K9NKkScXf1aSSGvXwuMw== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean When compiling path/foo.c, we should not add -I$(scr_tree)/path to the gcc flags. Otherwise we get different build results for in tree and out of tree builds. Signed-off-by: Heinrich Schuchardt --- scripts/Makefile.lib | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.28.0 diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 56e9d54242..98817084f4 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -136,10 +136,8 @@ __cpp_flags = $(_cpp_flags) else # -I$(obj) locates generated .h files -# $(call addtree,-I$(obj)) locates .h files in srctree, from generated .c files -# and locates generated .h files -# FIXME: Replace both with specific CFLAGS* statements in the makefiles -__c_flags = $(if $(obj),$(call addtree,-I$(src)) -I$(obj)) \ +# FIXME: Replace with specific CFLAGS* statements in the makefiles +__c_flags = $(if $(obj), -I$(obj)) \ $(call flags,_c_flags) __a_flags = $(call flags,_a_flags) __cpp_flags = $(call flags,_cpp_flags)