From patchwork Fri Oct 9 18:08:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 1379461 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4C7GLQ5gWnz9sSG for ; Sat, 10 Oct 2020 05:09:34 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730110AbgJISJe (ORCPT ); Fri, 9 Oct 2020 14:09:34 -0400 Received: from mga07.intel.com ([134.134.136.100]:48619 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725979AbgJISJe (ORCPT ); Fri, 9 Oct 2020 14:09:34 -0400 IronPort-SDR: Gni5wQgsS6hO4ROH2YUOmXkeQXWBWK9gkUh5SHNGkfd0Gm3gZM+kxFPt1vPVqHbLDy8jTBJppV mYmtLCyjEb9w== X-IronPort-AV: E=McAfee;i="6000,8403,9769"; a="229705582" X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="229705582" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 11:08:59 -0700 IronPort-SDR: WJ0aFvTPrMeeESpGWmiodUx08WkxHS7Or6QhvJbMBy9vUvC3XShze//iblpa/RCj55Znt2K17/ GyEYZAgBJARQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="345120597" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 09 Oct 2020 11:08:57 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 0A93415C; Fri, 9 Oct 2020 21:08:56 +0300 (EEST) From: Andy Shevchenko To: Linus Walleij , linux-gpio@vger.kernel.org Cc: Andy Shevchenko , =?utf-8?q?Martin_Hu?= =?utf-8?q?ndeb=C3=B8ll?= Subject: [PATCH v2 1/2] pinctrl: mcp23s08: Use full chunk of memory for regmap configuration Date: Fri, 9 Oct 2020 21:08:55 +0300 Message-Id: <20201009180856.4738-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It appears that simplification of mcp23s08_spi_regmap_init() made a regression due to wrong size calculation for dev_kmemdup() call. It mises the fact that config variable is already a pointer, thus the sizeof() calculation is wrong and only 4 or 8 bytes were copied. Fix the parameters to devm_kmemdup() to copy full chunk of memory. Fixes: 0874758ecb2b ("pinctrl: mcp23s08: Refactor mcp23s08_spi_regmap_init()") Reported-by: Martin Hundebøll Signed-off-by: Andy Shevchenko Tested-by: Martin Hundebøll Tested-by: Jan Kundrát --- v2: fixed few typos in the commit message drivers/pinctrl/pinctrl-mcp23s08_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-mcp23s08_spi.c b/drivers/pinctrl/pinctrl-mcp23s08_spi.c index 1f47a661b0a7..7c72cffe1412 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08_spi.c +++ b/drivers/pinctrl/pinctrl-mcp23s08_spi.c @@ -119,7 +119,7 @@ static int mcp23s08_spi_regmap_init(struct mcp23s08 *mcp, struct device *dev, return -EINVAL; } - copy = devm_kmemdup(dev, &config, sizeof(config), GFP_KERNEL); + copy = devm_kmemdup(dev, config, sizeof(*config), GFP_KERNEL); if (!copy) return -ENOMEM; From patchwork Fri Oct 9 18:08:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 1379460 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4C7GLN3ffHz9sSG for ; Sat, 10 Oct 2020 05:09:32 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726211AbgJISJc (ORCPT ); Fri, 9 Oct 2020 14:09:32 -0400 Received: from mga12.intel.com ([192.55.52.136]:21095 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725979AbgJISJc (ORCPT ); Fri, 9 Oct 2020 14:09:32 -0400 IronPort-SDR: o5mXj1ABjNmeodKQqfuIP31tkePWMc9c9LRPzuz+xM5P1LJb1cK4HoYNUa/h6rMtV6FSXK/5Li HfHCnC+yLh3g== X-IronPort-AV: E=McAfee;i="6000,8403,9769"; a="144840740" X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="144840740" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 11:09:00 -0700 IronPort-SDR: cdB8IArMP2+dQk81zysh49icgw0AlBOq0DZWo3TTi+GGiU3VApkSTfQNodsgd5SzDGGH7RMnid SGWfiN0WhStw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="529021697" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 09 Oct 2020 11:08:58 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 1AAE112A; Fri, 9 Oct 2020 21:08:57 +0300 (EEST) From: Andy Shevchenko To: Linus Walleij , linux-gpio@vger.kernel.org Cc: Andy Shevchenko , =?utf-8?q?Martin_Hu?= =?utf-8?q?ndeb=C3=B8ll?= Subject: [PATCH v2 2/2] pinctrl: mcp23s08: Print error message when regmap init fails Date: Fri, 9 Oct 2020 21:08:56 +0300 Message-Id: <20201009180856.4738-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201009180856.4738-1-andriy.shevchenko@linux.intel.com> References: <20201009180856.4738-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It is useful for debugging to have the error message printed when regmap initialisation fails. Add it to the driver. Cc: Martin Hundebøll Signed-off-by: Andy Shevchenko --- v2: no changes drivers/pinctrl/pinctrl-mcp23s08_spi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-mcp23s08_spi.c b/drivers/pinctrl/pinctrl-mcp23s08_spi.c index 7c72cffe1412..9ae10318f6f3 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08_spi.c +++ b/drivers/pinctrl/pinctrl-mcp23s08_spi.c @@ -126,6 +126,8 @@ static int mcp23s08_spi_regmap_init(struct mcp23s08 *mcp, struct device *dev, copy->name = name; mcp->regmap = devm_regmap_init(dev, &mcp23sxx_spi_regmap, mcp, copy); + if (IS_ERR(mcp->regmap)) + dev_err(dev, "regmap init failed for %s\n", mcp->chip.label); return PTR_ERR_OR_ZERO(mcp->regmap); }