From patchwork Thu Oct 8 18:51:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1378830 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=EtkNOfZ4; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C6gKg3t6zz9sTK for ; Fri, 9 Oct 2020 05:51:47 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1A4A6806C5; Thu, 8 Oct 2020 20:51:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="EtkNOfZ4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1B91681BD2; Thu, 8 Oct 2020 20:51:36 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B948D801D8 for ; Thu, 8 Oct 2020 20:51:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1602183091; bh=TXpA9iPCGCoy3PGA+Aduj430QOcWiZ4sEFDoTG6a2NE=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=EtkNOfZ4BYbVaC5qjKUohJzlaZQ8OvAjxq6R/te3ZAFClL28Ge0TpKl7FZPL4JM+i 8Gd0lACcBzDxtXerbBeBD5pJcvwUj7TcLn8iSXNF5AVKh9bdEDqlLc2Yxot6TjJnJA xiq+O0bXkFTsBozMH/efKFrx3UmL1Hn5MGgUGGgo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([178.202.41.107]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MatVb-1kwtUe25xz-00cQtb; Thu, 08 Oct 2020 20:51:31 +0200 From: Heinrich Schuchardt To: Tom Rini Cc: Philippe Reynes , Patrick Oppenlander , Simon Glass , Masahiro Yamada , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH] tools: image-host.c: use correct output format Date: Thu, 8 Oct 2020 20:51:24 +0200 Message-Id: <20201008185124.6764-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:RsTnbjd7YbLgGoBdvmRhTl1+xyAsiHVNu7Gi/iP9ucRfkfEaYAt f33A6KdksgK8RZw9GnVv3Ddjc7LdyBV/8bKQmWUsGyd1G7m35Q/XjjkV2NXC11ChkoSxiF4 Ub0c1kayCltIUCgxfigqo9VeOR3AknSaiFOX3D3e2qHJJRnPRd5PMYIs4fvOLCwzzYMv48N 2tcr21dKdf0i4V8s9OAvQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:VW779B0dBZA=:7i64d1EreOJzoEt+s9sxA/ Ojzpjnew2JT2bMN1RNFNm6W/JPBnyrAkYZtQ2y5bZqfEFIwVN8ibePaGs+LWKoWLYEOinVTNB t76fUzMf/lQEotkFi0pDJbl7pztoOF13w4KUTWv9iFwOT/fJO+Um4kzq7vxX5N4s+kf+/bc0+ BcMVYYuv+hKvoaAz9dtUgOJRmcZ+37e5+2obGeiOALzEtToIQveo4RhgRQ1r0+nYpP9AqD3mR jI+F0eLugkJx8OVzzIdFx0eoWtUkR/u5XJnarHdshBCc6vTkFcfD40wNaWt5bmktQWhNike6X NixU7kRcS3ZJONYcUDSdCz5crBGb3nQi4atri93BYcgNJiPjq1EALoa+zuo1+HJk5ZHhJ9bUT Sg0QFjlEQfc8q6qbnG9t+0WAervpGgc8BywT0lsWX9YQ0UJYJV5/4m0F528LFNENCk8/ux6qc RNoURxKE3ltM44d8ivCUE/gmYEkkb+NWhdINTHRA1fsGO8l+8AJBgFfxX/9ONn6DksBc3WXHp /4vJ5cDnDObO4IEutsaz9V5CLDhlcLTT6u8s1oiRBAPALK4unGbVYVTafmFcfqlmFxcDWYmkj Qtf93Y6+LT7IbVVrIjY4u8PGmW2YICqXsuAfVkMrJ3i87uf7He+gYWpZ1ul0f8oSZT8eKsFOx Nj5oaRI/9PTiWmyS94xPBQn/Ey9bh+/bHn2H0RCB5H0u2Z8ed04aa2d7XEOee7sdVST56pvCB Po6X4u5rcafA3C8HnWpG/569NQEzzGgUoKmBTdxXWtYXr+UXvB8n26vj6LvkfHrvWBMBCfJ/J SgBva5BBVkRvJgdnwXylp71mZZNZNXHp3jRGjPHZzD8fW7MGrwV+UZeTMxD84X1V2QY2zfg1S Ab8ZC2NIa7skIZXWyTlGjySB8S6ymYGtZhs1IZaUFB7GlqFMAqKTpOIcZNUdZuhhAcKk9U5xr 9jT2g9KagDanX8njBPWpm4H8Sb058uGoYCvhJxZmPccQegYmRuDg6FFYmZRtVMGN/Ww/Kxis7 howFmCl8mAF3Q6M88Z3IKW6VJthtHjaq0LN+otTwtDuLW8DEio15s9djIY+2B1J8+8XaDPv0C UxbB3DnrJI0lJ0GU3+tMrdPy8S8ZNgB62sLuBz3kotS+pxe4T6M3p8DZ+ITVhpHDz3UhljQEV W0ZzdLhRGtMu6gQTHJ3R1tI8DS/c+U3m3Bgwr+geSCZ5uFFr/mFIcIfTUNVoPNCdu0R/31dee KMpSzHav8uzjWUSr3j8MC7LFPVTmwJJcKfbKKeQ== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean When building on a 32bit host the following warning occurs: tools/image-host.c: In function ‘fit_image_read_data’: tools/image-host.c:296:56: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘__off64_t’ {aka ‘long long int’} [-Wformat=] printf("File %s don't have the expected size (size=%ld, expected=%d)\n", ~~^ %lld filename, sbuf.st_size, expected_size); ~~~~~~~~~~~~ tools/image-host.c:311:62: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘__off64_t’ {aka ‘long long int’} [-Wformat=] printf("Can't read all file %s (read %zd bytes, expexted %ld)\n", ~~^ %lld filename, n, sbuf.st_size); ~~~~~~~~~~~~ Fix the format strings. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- tools/image-host.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.26.2 diff --git a/tools/image-host.c b/tools/image-host.c index 9a83b7f675..10e66cdaa2 100644 --- a/tools/image-host.c +++ b/tools/image-host.c @@ -293,8 +293,8 @@ static int fit_image_read_data(char *filename, unsigned char *data, /* Check file size */ if (sbuf.st_size != expected_size) { - printf("File %s don't have the expected size (size=%ld, expected=%d)\n", - filename, sbuf.st_size, expected_size); + printf("File %s don't have the expected size (size=%lld, expected=%d)\n", + filename, (long long)sbuf.st_size, expected_size); goto err; } @@ -308,8 +308,8 @@ static int fit_image_read_data(char *filename, unsigned char *data, /* Check that we have read all the file */ if (n != sbuf.st_size) { - printf("Can't read all file %s (read %zd bytes, expexted %ld)\n", - filename, n, sbuf.st_size); + printf("Can't read all file %s (read %zd bytes, expexted %lld)\n", + filename, n, (long long)sbuf.st_size); goto err; }