From patchwork Mon Dec 25 22:59:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 852886 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RHy6A39m"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OMp32CqD"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3z5F145ydWz9ryv for ; Tue, 26 Dec 2017 09:59:20 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id: Date:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=P+CCrNoNuPxUDAbkoXEDQMleUGdpUuclCdr7qKsS63Y=; b=RHy6A39mC5CP2f KuFIUiPqQRBZs1vJNtI6rptFirDmeECdcqhUWzpOGkl6+CC2g5YArvDhoJr3hhufg0LtKMxJfs8nC 52K5Ic3JdFeLr6x6/gXh63Synv2KJEN2zOosac00xyA13dNyzJ7rph59vwOZo9f43nOndhKWnWXJe vvq/kTKjOVdnARU05b5uTRt6b6bC0Krmpnm0F662JpS6l0B91A7ji30tqH8jDq7R9oBOe1EHhFVNU KOQTP8/9MNdm3ynh5dRhnCD/JlnuVkbmqKX0c27BVfq5MQ22NOL2trdYRStO5VcDEGsX7TV1ztBXK ZlgYqgm0Qw4XZsqNDsjg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eTbiA-0008NM-FD; Mon, 25 Dec 2017 22:59:10 +0000 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eTbi7-0008LM-C2 for lede-dev@lists.infradead.org; Mon, 25 Dec 2017 22:59:08 +0000 Received: by mail-pf0-x244.google.com with SMTP id u25so18151511pfg.5 for ; Mon, 25 Dec 2017 14:58:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=9tOfW3Pp58M9V+rXjDP0YLAgIYR6wF+gYI90ldonLL0=; b=OMp32CqDN9yMOdTkf3WiuVpKxClqK0Qe3i2crEp+zCP/S72CzpAjDpAOjiwftAel0f 2QmE67jHieRR5YS0zWhYSIGYOZKF6Ykki+0HoWFcaa1Rq9KwjtjcaaWf6YFyXwHAskP7 XCslgQGNoKfgV6yiLoO/2fYnigPpEK/v9LLsti9VRGNb0Tk+d810QnWUvTTcn/m/lFhP Rs4X/Qc5EhRCJ94tp8Umn4HkTPpfdUPbasn/650Tfat4vV63LGRcAoVyGgtvRXVVnAIj GXWYsdBKN7F5Cgw/Wwkt6ybPrll4XAyVaYBPV4oklSB0A3bnD5XrIh9rnpAu8f68e8uW Heeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9tOfW3Pp58M9V+rXjDP0YLAgIYR6wF+gYI90ldonLL0=; b=ajEw07Hia7bLsDPpYZsrDW9gNpC1slpjpoFWcvoNs+F9sX1jCQ3rbx7Ngl85mRRTCR seBwMZnaxa0B4qrr/qBF/ecbVB/jYc83RktrUvflqWvzvPOKp4vDpEiL2XMOmlV1OW5P bgZ08taRF/R2amBbRsvS2M7EMMMzapW2MzVjW/bevy/xM59ac0t02jplFdwXC7c/KxYv 6cZ/lNQEydjA+nhJWiFycHLbMlwrG1toVRikIkSbEP0wPKjEzU+HMv6btEFvR+6Lb5Jk pKWX9KtKnZZQF+34j+hUpoOna230DF5FSnLfMiLylhv7Re71uO7yStTGdDh2IJQUItxL yaIA== X-Gm-Message-State: AKGB3mJi1DqcKp7nVEtMktsJPiDRqbJt3OKYgp3COvCYF+t/3WkUuOLn rPYSkD6ASoQgs+aNq1J2lJo1Cdte X-Google-Smtp-Source: ACJfBosGJprSuGGxgAw81OUvGzF6pzBm0eqgVsTmQjKNFKSpEXipzCu39katNxdO2ran5mM9Ryxgmw== X-Received: by 10.98.158.89 with SMTP id s86mr23675595pfd.216.1514242734325; Mon, 25 Dec 2017 14:58:54 -0800 (PST) Received: from DESKTOP-CEH0M93.lan ([2001:470:1f05:c3e:98da:65ff:24e5:ee50]) by smtp.gmail.com with ESMTPSA id w21sm53127510pfl.50.2017.12.25.14.58.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 25 Dec 2017 14:58:53 -0800 (PST) From: Rosen Penev To: lede-dev@lists.infradead.org Date: Mon, 25 Dec 2017 14:59:00 -0800 Message-Id: <1514242740-4870-1-git-send-email-rosenp@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171225_145907_418970_9B196C55 X-CRM114-Status: UNSURE ( 6.79 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c00:0:0:0:244 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosenp[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Subject: [LEDE-DEV] [PATCH] umdnsd: Replace strerror(errno) with %m. X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rosen Penev MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Saves 352 bytes under glibc. No functional difference. Signed-off-by: Rosen Penev --- interface.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/interface.c b/interface.c index 7f814d2..9c5b048 100644 --- a/interface.c +++ b/interface.c @@ -353,7 +353,7 @@ interface_mcast_setup4(struct interface *iface) setsockopt(fd, IPPROTO_IP, IP_DROP_MEMBERSHIP, &mreq, sizeof(mreq)); if (setsockopt(fd, IPPROTO_IP, IP_ADD_MEMBERSHIP, &mreq, sizeof(mreq)) < 0) { - fprintf(stderr, "failed to join multicast group: %s\n", strerror(errno)); + fprintf(stderr, "failed to join multicast group: %m\n"); close(fd); fd = -1; return -1; @@ -387,7 +387,7 @@ interface_socket_setup6(struct interface *iface) setsockopt(fd, IPPROTO_IPV6, IPV6_LEAVE_GROUP, &mreq, sizeof(mreq)); if (setsockopt(fd, IPPROTO_IPV6, IPV6_ADD_MEMBERSHIP, &mreq, sizeof(mreq)) < 0) { - fprintf(stderr, "failed to join multicast group: %s\n", strerror(errno)); + fprintf(stderr, "failed to join multicast group: %m\n"); close(fd); fd = -1; return -1; @@ -409,7 +409,7 @@ reconnect_socket4(struct uloop_timeout *timeout) iface->fd.fd = usock(USOCK_UDP | USOCK_SERVER | USOCK_NONBLOCK | USOCK_IPV4ONLY, (iface->multicast) ? (iface->mcast_addr) : (iface->v4_addrs), "5353"); if (iface->fd.fd < 0) { - fprintf(stderr, "failed to add listener %s: %s\n", iface->mcast_addr, strerror(errno)); + fprintf(stderr, "failed to add listener %s: %m\n", iface->mcast_addr); goto retry; } @@ -456,7 +456,7 @@ reconnect_socket6(struct uloop_timeout *timeout) snprintf(mcast_addr, sizeof(mcast_addr), "%s%%%s", (iface->multicast) ? (iface->mcast_addr) : (iface->v6_addrs), iface->name); iface->fd.fd = usock(USOCK_UDP | USOCK_SERVER | USOCK_NONBLOCK | USOCK_IPV6ONLY, mcast_addr, "5353"); if (iface->fd.fd < 0) { - fprintf(stderr, "failed to add listener %s: %s\n", mcast_addr, strerror(errno)); + fprintf(stderr, "failed to add listener %s: %m\n", mcast_addr); goto retry; }