From patchwork Sun Aug 27 07:24:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haishuang Yan X-Patchwork-Id: 806201 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xg69G4XkLz9t2Q for ; Sun, 27 Aug 2017 17:34:26 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751284AbdH0HeM (ORCPT ); Sun, 27 Aug 2017 03:34:12 -0400 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:19299 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbdH0HeL (ORCPT ); Sun, 27 Aug 2017 03:34:11 -0400 X-Greylist: delayed 544 seconds by postgrey-1.27 at vger.kernel.org; Sun, 27 Aug 2017 03:34:10 EDT Received: from spf.mail.chinamobile.com (unknown[172.16.121.7]) by rmmx-syy-dmz-app06-12006 (RichMail) with SMTP id 2ee659a273cf19a-91e12; Sun, 27 Aug 2017 15:25:04 +0800 (CST) X-RM-TRANSID: 2ee659a273cf19a-91e12 X-RM-SPAM-FLAG: 00000000 Received: from localhost (unknown[223.105.0.240]) by rmsmtp-syy-appsvr04-12004 (RichMail) with SMTP id 2ee459a273ce898-67472; Sun, 27 Aug 2017 15:25:03 +0800 (CST) X-RM-TRANSID: 2ee459a273ce898-67472 From: Haishuang Yan To: Sathya Perla , jit Khaparde , Sriharsha Basavapatna , Somnath Kotur Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Haishuang Yan Subject: [PATCH] be2net: Fix some u16 fields appropriately Date: Sun, 27 Aug 2017 15:24:45 +0800 Message-Id: <1503818685-32068-1-git-send-email-yanhaishuang@cmss.chinamobile.com> X-Mailer: git-send-email 1.8.3.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In be_tx_compl_process, frag_index declared as u32, so it's better to declare last_index as u32 also. CC: Ajit Khaparde Fixes: b0fd2eb28bd4 ("be2net: Declare some u16 fields as u32 to improve performance") Signed-off-by: Haishuang Yan --- drivers/net/ethernet/emulex/benet/be.h | 2 +- drivers/net/ethernet/emulex/benet/be_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h index 674cf9d..2ba4d61 100644 --- a/drivers/net/ethernet/emulex/benet/be.h +++ b/drivers/net/ethernet/emulex/benet/be.h @@ -255,7 +255,7 @@ struct be_tx_stats { /* Structure to hold some data of interest obtained from a TX CQE */ struct be_tx_compl_info { u8 status; /* Completion status */ - u16 end_index; /* Completed TXQ Index */ + u32 end_index; /* Completed TXQ Index */ }; struct be_tx_obj { diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 319eee3..3645344 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -2606,7 +2606,7 @@ static struct be_tx_compl_info *be_tx_compl_get(struct be_tx_obj *txo) } static u16 be_tx_compl_process(struct be_adapter *adapter, - struct be_tx_obj *txo, u16 last_index) + struct be_tx_obj *txo, u32 last_index) { struct sk_buff **sent_skbs = txo->sent_skb_list; struct be_queue_info *txq = &txo->q;