From patchwork Mon Sep 7 10:12:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Barker X-Patchwork-Id: 1358729 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=cQxpjlmL; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BlPGz2RmDz9sSJ for ; Mon, 7 Sep 2020 20:12:43 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728565AbgIGKMm (ORCPT ); Mon, 7 Sep 2020 06:12:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728406AbgIGKMV (ORCPT ); Mon, 7 Sep 2020 06:12:21 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD63CC061574 for ; Mon, 7 Sep 2020 03:12:19 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id a9so13644212wmm.2 for ; Mon, 07 Sep 2020 03:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oyl52mrqZ8yf4xueQQADEoNtO/OjPzssN55EUTt66ws=; b=cQxpjlmL+i5T07fyvWP5PXMOf3K+m53U5FFdJkaZT9qQe4MLIAAzw+jH7v18qgP7Rx 1FuCDmfaUGOv7Fm3d13CO/ptZXov9i3ziOLN8pswDRKpsAN2E8mzxxTKEpjWkeiQ44Sf XxnWxCIDiIJQaZ9NloPXervv5cD2jagfIBhMk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oyl52mrqZ8yf4xueQQADEoNtO/OjPzssN55EUTt66ws=; b=VcupzDSc8CYL9L2E3fwof2PeTVJs8dM3rJGy7gMJIEuqqD/fzwqKT0avi3XZarvE7U 5yh+RmH6tP/EHcfwl7wX7wXawZw+RGWRNe0nJCwnV8ZqBbqfAvXRhNQwf50J2TZHbMuY jpSz+vt7b4VCoclUXSgGJbPRfIOBQAyV7wZHGKxc/ZqaLmcSvNf3iIH02U1kbWQotEiw BuQ4GOFxRtWRdEg5z8yGOUenWWZIGand6O/V04rn6a227NvNUcEs+HvGbZg2npEE5U/J g+zwBpyHjxWBOjvmlQSzg4Ka9c5Ii1Xnpq0Lfy+gjuCDirlpWg2fDoxYYi8loydiBtoG 2q6Q== X-Gm-Message-State: AOAM532lNl/E8XSr59yTJSeTo0JqGsNrqmuP8t8rO7y9JfAJ9XNFW2l8 xUUY97cbDpBx780EaPOXKm3WKA== X-Google-Smtp-Source: ABdhPJw2q8TQyLxIROIxNM+FqTDcvOyqlObGNd8CG5ooPrprP9QXKbU44njHET9XfaVzu6pvDpmMHQ== X-Received: by 2002:a7b:cd06:: with SMTP id f6mr20962590wmj.66.1599473537964; Mon, 07 Sep 2020 03:12:17 -0700 (PDT) Received: from ar2.home.b5net.uk ([213.48.11.149]) by smtp.gmail.com with ESMTPSA id i16sm24173748wrq.73.2020.09.07.03.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 03:12:17 -0700 (PDT) From: Paul Barker To: Woojung Huh , Microchip Linux Driver Support , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" Cc: Paul Barker , netdev@vger.kernel.org Subject: [PATCH v2 1/4] net: dsa: microchip: Make switch detection more informative Date: Mon, 7 Sep 2020 11:12:05 +0100 Message-Id: <20200907101208.1223-2-pbarker@konsulko.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200907101208.1223-1-pbarker@konsulko.com> References: <20200907101208.1223-1-pbarker@konsulko.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org To make switch detection more informative print the result of the ksz9477/ksz9893 compatibility check. With debug output enabled also print the contents of the Chip ID registers as a 40-bit hex string. As this detection is the first communication with the switch performed by the driver, making it easy to see any errors here will help identify issues with SPI data corruption or reset sequencing. Signed-off-by: Paul Barker Reviewed-by: Florian Fainelli --- drivers/net/dsa/microchip/ksz9477.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index 3cb22d149813..df5ecd0261fa 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -1426,10 +1426,12 @@ static int ksz9477_switch_detect(struct ksz_device *dev) /* Default capability is gigabit capable. */ dev->features = GBIT_SUPPORT; + dev_dbg(dev->dev, "Switch detect: ID=%08x%02x\n", id32, data8); id_hi = (u8)(id32 >> 16); id_lo = (u8)(id32 >> 8); if ((id_lo & 0xf) == 3) { /* Chip is from KSZ9893 design. */ + dev_info(dev->dev, "Found KSZ9893\n"); dev->features |= IS_9893; /* Chip does not support gigabit. */ @@ -1438,6 +1440,7 @@ static int ksz9477_switch_detect(struct ksz_device *dev) dev->mib_port_cnt = 3; dev->phy_port_cnt = 2; } else { + dev_info(dev->dev, "Found KSZ9477 or compatible\n"); /* Chip uses new XMII register definitions. */ dev->features |= NEW_XMII; From patchwork Mon Sep 7 10:12:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Barker X-Patchwork-Id: 1358732 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=R61uNwnN; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BlPH92Ckdz9sSJ for ; Mon, 7 Sep 2020 20:12:53 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728614AbgIGKMu (ORCPT ); Mon, 7 Sep 2020 06:12:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728575AbgIGKMV (ORCPT ); Mon, 7 Sep 2020 06:12:21 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 514C5C061573 for ; Mon, 7 Sep 2020 03:12:20 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id e17so13824740wme.0 for ; Mon, 07 Sep 2020 03:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h/iWzwJprojFLaXHNN6SpV7edO4SBlrOTMGBiAVdF8w=; b=R61uNwnN0I2T9xAtGFBQzNkb/eLWRlcqryGCf0jQ39h2Gc8uJxYA/rpxu1b5qSttrT k2wJvXcjJgMlt8iZarVdbYGZs8tKClS2122SwKL3cCg4LritGpBcd/yw/7HRgTy7N83h OtTW4FuZKR0IWBLYInIb/aoOCthQTw28kQIHw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h/iWzwJprojFLaXHNN6SpV7edO4SBlrOTMGBiAVdF8w=; b=f1ovxYPP5TDYfWEIfyL+JbJqxl6dY72igWVXYXD8xJjOrQNlhtOVCJkNvqTU6Sb2YV 4HOKWMGthSREdZBn7ZFj+jnZQsOoZg3RfuXeQTJsTY1KDcuF+2qfWx/Jog6d/MMbwZFC VF0yiaQeSvxDWPFw34UHHTrOnnR2qJxo5nkNNAoj6/KDSZWFaxt5ZxJttyQoUUYg2qYu 7J+4U3ggorE0fTh1CFCJ0mB+fM+fd/nlVR5nGMZkUQ7JldkmuapXdeDPxV2DuwFK4OO+ bv95s3DpIvYCobh6JmKwJyS/+eY7hb4fumm/PSx5duj40Xq+nlKGfisB2mJf4YGHg5Xb vcpQ== X-Gm-Message-State: AOAM533qA86tEqlTMx1JUDQgu/p/IARop5X0AC43zMEY5fbKwu2iHKqS X6Um7qViuDvDM6V8NCZcejDXQg== X-Google-Smtp-Source: ABdhPJyGhLWilbOzrpRHp5cBB7FuChMM0Jy2R1lW5FX+XXyj2p2VtYgD34w8J75H1RZ60DKBLjlCVg== X-Received: by 2002:a7b:c848:: with SMTP id c8mr18825723wml.184.1599473538971; Mon, 07 Sep 2020 03:12:18 -0700 (PDT) Received: from ar2.home.b5net.uk ([213.48.11.149]) by smtp.gmail.com with ESMTPSA id i16sm24173748wrq.73.2020.09.07.03.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 03:12:18 -0700 (PDT) From: Paul Barker To: Woojung Huh , Microchip Linux Driver Support , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" Cc: Paul Barker , netdev@vger.kernel.org Subject: [PATCH v2 2/4] net: dsa: microchip: Improve phy mode message Date: Mon, 7 Sep 2020 11:12:06 +0100 Message-Id: <20200907101208.1223-3-pbarker@konsulko.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200907101208.1223-1-pbarker@konsulko.com> References: <20200907101208.1223-1-pbarker@konsulko.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Always print the selected phy mode for the CPU port when using the ksz9477 driver. If the phy mode was changed, also print the previous mode to aid in debugging. To make the message more clear, prefix it with the port number which it applies to and improve the language a little. Signed-off-by: Paul Barker Reported-by: kernel test robot Reviewed-by: Florian Fainelli --- drivers/net/dsa/microchip/ksz9477.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index df5ecd0261fa..9513af057793 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -1265,6 +1265,7 @@ static void ksz9477_config_cpu_port(struct dsa_switch *ds) for (i = 0; i < dev->port_cnt; i++) { if (dsa_is_cpu_port(ds, i) && (dev->cpu_ports & (1 << i))) { phy_interface_t interface; + char *prev_msg, *prev_mode; dev->cpu_port = i; dev->host_mask = (1 << dev->cpu_port); @@ -1277,11 +1278,19 @@ static void ksz9477_config_cpu_port(struct dsa_switch *ds) interface = ksz9477_get_interface(dev, i); if (!dev->interface) dev->interface = interface; - if (interface && interface != dev->interface) - dev_info(dev->dev, - "use %s instead of %s\n", - phy_modes(dev->interface), - phy_modes(interface)); + if (interface && interface != dev->interface) { + prev_msg = " instead of "; + prev_mode = phy_modes(interface); + } else { + prev_msg = ""; + prev_mode = ""; + } + dev_info(dev->dev, + "Port%d: using phy mode %s%s%s\n", + i, + phy_modes(dev->interface), + prev_msg, + prev_mode); /* enable cpu port */ ksz9477_port_setup(dev, i, true); From patchwork Mon Sep 7 10:12:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Barker X-Patchwork-Id: 1358730 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=SNTV8BHa; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BlPH40Wjyz9sSJ for ; Mon, 7 Sep 2020 20:12:48 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728601AbgIGKMo (ORCPT ); Mon, 7 Sep 2020 06:12:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728409AbgIGKMV (ORCPT ); Mon, 7 Sep 2020 06:12:21 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 733C6C061755 for ; Mon, 7 Sep 2020 03:12:21 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id y15so1011272wmi.0 for ; Mon, 07 Sep 2020 03:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aIuHXFTT8iNlPReahxS4AxVZc+AV0svGQsmfuvJB638=; b=SNTV8BHaruyvyyhiibjlyWpTha0xScucliRh0jRwUFtVM3zSePtusSkCCUYgh9u6Oh MGZsqBtC7pSaftd4V6pNSJMJZo/767RnEpqeicNPitCD89VR+KzXs5RBBMNCeVsK02xa itVDCRVNDSYd5MBqJ9zPqcb4WI0zsqr6ky3JY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aIuHXFTT8iNlPReahxS4AxVZc+AV0svGQsmfuvJB638=; b=uQIXB852QFeqd9wDDxz7YZr2ftR8hOz1RePZM/d0N2ji8u2REc5Nc50+5RkBZDZqeo b8hIteZRByuN1USxkGKBW6AjOz7j5alFTcCEYic2IOvPhIHkA92qJqVYEJajE2Ig5vAY 4tbwU1b7o5Gfin/2WrouFWufjlOE0mR5gN6j9uP9eKVhS2NO7Hgiqk2nPgmwu+UVD+C7 6cQi6yUcXIEJrqlo+O/Z3Fvolpwvm5y5vM54jmHhsX81imPEuxDrV8M7LOJIvhBnVbK6 oumlgFR7oytJSMdCkp23WX/V1Nq7mIE3wTOLGeu/B3bHmZKXh6la6lj24Yssjxlb+FIN XqbA== X-Gm-Message-State: AOAM531eSb8I0HLziagjHrRSDcIzEf0EcnIYZdttXZJHEhFmbJwZcUqq O24XUqS0aCUaJDKwfmH0WPIDiw== X-Google-Smtp-Source: ABdhPJzrBd06xztwhsQa6CrjESbvkiuY7MO0bb9in6tdBtfv/dcZIuPN3mFHpGLsCcDQ8eTeyjwA0A== X-Received: by 2002:a1c:9883:: with SMTP id a125mr21056219wme.133.1599473540003; Mon, 07 Sep 2020 03:12:20 -0700 (PDT) Received: from ar2.home.b5net.uk ([213.48.11.149]) by smtp.gmail.com with ESMTPSA id i16sm24173748wrq.73.2020.09.07.03.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 03:12:19 -0700 (PDT) From: Paul Barker To: Woojung Huh , Microchip Linux Driver Support , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" Cc: Paul Barker , netdev@vger.kernel.org Subject: [PATCH v2 3/4] net: dsa: microchip: Disable RGMII in-band status on KSZ9893 Date: Mon, 7 Sep 2020 11:12:07 +0100 Message-Id: <20200907101208.1223-4-pbarker@konsulko.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200907101208.1223-1-pbarker@konsulko.com> References: <20200907101208.1223-1-pbarker@konsulko.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We can't assume that the link partner supports the in-band status reporting which is enabled by default on the KSZ9893 when using RGMII for the upstream port. Signed-off-by: Paul Barker Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/dsa/microchip/ksz9477.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index 9513af057793..f379ea8242e0 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -1235,6 +1235,9 @@ static void ksz9477_port_setup(struct ksz_device *dev, int port, bool cpu_port) if (dev->interface == PHY_INTERFACE_MODE_RGMII_ID || dev->interface == PHY_INTERFACE_MODE_RGMII_TXID) data8 |= PORT_RGMII_ID_EG_ENABLE; + /* On KSZ9893, disable RGMII in-band status support */ + if (dev->features & IS_9893) + data8 &= ~PORT_MII_MAC_MODE; p->phydev.speed = SPEED_1000; break; } From patchwork Mon Sep 7 10:12:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Barker X-Patchwork-Id: 1358734 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=DxE2NOyx; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BlPHS4ZPlz9sSn for ; Mon, 7 Sep 2020 20:13:08 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728536AbgIGKNH (ORCPT ); Mon, 7 Sep 2020 06:13:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728580AbgIGKMW (ORCPT ); Mon, 7 Sep 2020 06:12:22 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 677B3C061756 for ; Mon, 7 Sep 2020 03:12:22 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id s13so13794488wmh.4 for ; Mon, 07 Sep 2020 03:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+CmuBvHSLrJBh6+25r6fCP8C8dEsiulNskkxE4j9PUw=; b=DxE2NOyxZGuGlM+N84MBbRHboXyrobgPdcrERsi9jcGoo5k+sl5VpL83kePZaK9J06 WCcjG7CN1YbqmFrkOx6bZm+WOzKQcKGNY8qlR/cptXUW+GMa2hI9vKt32FsWL0tTpWRC SxjV6a+wljQkDUd0BRf8gBJs09ZQYaJh4wKhs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+CmuBvHSLrJBh6+25r6fCP8C8dEsiulNskkxE4j9PUw=; b=aYRmE9t1UQNAcg6AvBECBSz/mgd0KvBIe46tuiHD6ciMPwtjJi/FBj1g3P7sy3Yz/3 t+GmprZHI9fmFO4/EhomlXGSsTLKwb5uKtb60TxY98Ti8V2p8ZxcC4CUj0cCHhCefB9k M+UmNZQ1fv23oJcqo6fzrsrS562ujOfUwz6qGtaezfN32aVVQJU8wKMvNUMgbmMc3tWb lMksXlwVk65NDJRjiFcvh9z+pNZBqH7PcaKQRqT+4vFf/gqxR3aPrzlI1Ioh1o++KtHB NWD/VTpklJEMbtVpMgU+BvaDNLAHEVcdHd/dxuy8zwTTsLVf66F20lnVCtveS+lXidp0 vHKg== X-Gm-Message-State: AOAM532x12zZSfeAdyCRwz1GZvVrTvwthjYJD8kGm80TYfKihCg4NBZS 4v/JAljRSGk+djqehvcOXoB5rw== X-Google-Smtp-Source: ABdhPJyVAZ4DvZdxVZOXIUHHju8Zzlypi4Q2XtKa3FXrc114yHIrpcIWbwQN5sroI1N75StkNXcPRw== X-Received: by 2002:a7b:c1d3:: with SMTP id a19mr13876530wmj.19.1599473541137; Mon, 07 Sep 2020 03:12:21 -0700 (PDT) Received: from ar2.home.b5net.uk ([213.48.11.149]) by smtp.gmail.com with ESMTPSA id i16sm24173748wrq.73.2020.09.07.03.12.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 03:12:20 -0700 (PDT) From: Paul Barker To: Woojung Huh , Microchip Linux Driver Support , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" Cc: Paul Barker , netdev@vger.kernel.org Subject: [PATCH v2 4/4] net: dsa: microchip: Implement recommended reset timing Date: Mon, 7 Sep 2020 11:12:08 +0100 Message-Id: <20200907101208.1223-5-pbarker@konsulko.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200907101208.1223-1-pbarker@konsulko.com> References: <20200907101208.1223-1-pbarker@konsulko.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The datasheet for the ksz9893 and ksz9477 switches recommend waiting at least 100us after the de-assertion of reset before trying to program the device through any interface. Also switch the existing msleep() call to usleep_range() as recommended in Documentation/timers/timers-howto.rst. The 2ms range used here is somewhat arbitrary, as long as the reset is asserted for at least 10ms we should be ok. Signed-off-by: Paul Barker Reviewed-by: Florian Fainelli --- drivers/net/dsa/microchip/ksz_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index 8d53b12d40a8..a31738662d95 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -400,8 +400,9 @@ int ksz_switch_register(struct ksz_device *dev, if (dev->reset_gpio) { gpiod_set_value_cansleep(dev->reset_gpio, 1); - mdelay(10); + usleep_range(10000, 12000); gpiod_set_value_cansleep(dev->reset_gpio, 0); + usleep_range(100, 1000); } mutex_init(&dev->dev_mutex);