From patchwork Sat Sep 5 14:03:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Barker X-Patchwork-Id: 1358043 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=Gria/rGZ; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BkGW12NgKz9sSn for ; Sun, 6 Sep 2020 00:04:13 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728521AbgIEOD6 (ORCPT ); Sat, 5 Sep 2020 10:03:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726591AbgIEODk (ORCPT ); Sat, 5 Sep 2020 10:03:40 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FCC0C061245 for ; Sat, 5 Sep 2020 07:03:39 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id o21so9303800wmc.0 for ; Sat, 05 Sep 2020 07:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=r8t3Bq+9skdVRp16Sgumk9QASfxctZ6a3tE/UOz3Dr0=; b=Gria/rGZtf5NviLuBNOj1xcUjLakfLU0YYMYCY1Srrxmvda1Jtf/1IY5bd2SRNBPxf 3mFM3UJaAby/XtcbVlFw8iE0iXPRMFYnCqv3B1nYi3oZBuhms/61/ayYQm9jR2p7kYnn z4fvyqbZwJW4JGwrT51CK1prPgmKIqnWltI84= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r8t3Bq+9skdVRp16Sgumk9QASfxctZ6a3tE/UOz3Dr0=; b=s0x+tvbWD2gRDFQmEFvfzoTnZ4udkNLtqYPU3NV1FsnY/X6gGpL/RbNdsthzfgiaTu ash5k/ftx0JRkhn2YcLp+DCNZ8Ko790ub5mrgPYeIlGFP2RjTdAFRHVAtxRjJ4wkY2w7 4HgGbxAObPgS1gSRkrYhpgJgCacxaxnFvgMasqq+v9K2WazlYNlPsqmOXTqPMR63U9l4 mz5aN8f24InD4zJ3Naqvqk+90vh80IJQxHkjRIdMfHNfEQf8i15wtBoI+YbWHSERmZfd S67xluKAUCIYqvoMjz7Ts5m5S241EXYvhKGAhD2by05GHdM/4ml6jOtVEnQ82+M+HIlk dGKQ== X-Gm-Message-State: AOAM533L+wAsEu779ouaXWEDOWKpCdoU0LUX7TKVMKM8HVaOft5HstI/ W4cYXKPuV9MvoY7ndw3atAcbuQ== X-Google-Smtp-Source: ABdhPJworfGD5wUy1AnwxD8eagfKJNqIiq5UmENXJDNcoe6f2+TMHNr2wvEBc3nBVx6+YaxNVRvX5g== X-Received: by 2002:a1c:56d6:: with SMTP id k205mr12253247wmb.88.1599314617538; Sat, 05 Sep 2020 07:03:37 -0700 (PDT) Received: from ar2.home.b5net.uk ([213.48.11.149]) by smtp.gmail.com with ESMTPSA id b2sm17390369wmh.47.2020.09.05.07.03.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2020 07:03:37 -0700 (PDT) From: Paul Barker To: Woojung Huh , Microchip Linux Driver Support , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" Cc: Paul Barker , netdev@vger.kernel.org Subject: [PATCH 1/4] net: dsa: microchip: Make switch detection more informative Date: Sat, 5 Sep 2020 15:03:22 +0100 Message-Id: <20200905140325.108846-2-pbarker@konsulko.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200905140325.108846-1-pbarker@konsulko.com> References: <20200905140325.108846-1-pbarker@konsulko.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org To make switch detection more informative print the result of the ksz9477/ksz9893 compatibility check. With debug output enabled also print the contents of the Chip ID registers as a 40-bit hex string. As this detection is the first communication with the switch performed by the driver, making it easy to see any errors here will help identify issues with SPI data corruption or reset sequencing. Signed-off-by: Paul Barker --- drivers/net/dsa/microchip/ksz9477.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index 3cb22d149813..a48f5edab561 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -13,6 +13,7 @@ #include #include #include +#include #include "ksz9477_reg.h" #include "ksz_common.h" @@ -1426,10 +1427,12 @@ static int ksz9477_switch_detect(struct ksz_device *dev) /* Default capability is gigabit capable. */ dev->features = GBIT_SUPPORT; + dev_dbg(dev->dev, "Switch detect: ID=%08x%02x\n", id32, data8); id_hi = (u8)(id32 >> 16); id_lo = (u8)(id32 >> 8); if ((id_lo & 0xf) == 3) { /* Chip is from KSZ9893 design. */ + dev_info(dev->dev, "Found KSZ9893\n"); dev->features |= IS_9893; /* Chip does not support gigabit. */ @@ -1438,6 +1441,7 @@ static int ksz9477_switch_detect(struct ksz_device *dev) dev->mib_port_cnt = 3; dev->phy_port_cnt = 2; } else { + dev_info(dev->dev, "Found KSZ9477 or compatible\n"); /* Chip uses new XMII register definitions. */ dev->features |= NEW_XMII; From patchwork Sat Sep 5 14:03:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Barker X-Patchwork-Id: 1358044 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=rKKa95lT; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BkGWB0D0Fz9sSn for ; Sun, 6 Sep 2020 00:04:22 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728580AbgIEOER (ORCPT ); Sat, 5 Sep 2020 10:04:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728248AbgIEODk (ORCPT ); Sat, 5 Sep 2020 10:03:40 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45911C061246 for ; Sat, 5 Sep 2020 07:03:40 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id q9so9268711wmj.2 for ; Sat, 05 Sep 2020 07:03:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4w7lhVa/MMPsgT7b8Dk5gygQuJ2oI28kmOPvPbKnNtQ=; b=rKKa95lTC/NwFSilHI5K806RdAZ1nCITObAY5H6oTNuWplGZx/UZZNik1ItluQBR7j VzdTOHhAgFMqbxSFP1g7tcoT+qdVMxaIsumTx4SKgSEzjx8obeRE55Og5ewC992PiqV/ +9e2uzmoo4NIzCU6gAbmhl9TT4h9LAcXMhpJ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4w7lhVa/MMPsgT7b8Dk5gygQuJ2oI28kmOPvPbKnNtQ=; b=KoZon0rfSsfgr9Et1PjgJldPrhPoAU1oB8nRqVcrk5VkOT6URyNAprkr5o/bHR5Tiu MOwWgmN5jSKRY6RcyvHXxZeYWWpxMyPfmE5R3SVthgaNtZ5TYk0Lb43PKUSGfxPyG8As jRl/q4/23e1EpRyM5QKNpvy84C04xhLDl8HX6z7G/8EQerqeE22EjSQ0Lx+GEsNRqH9M xrDeA6wdmvneq5NpW9H8aOMjvakzGJuNHlvCupOWTYwIkV+IHUSSdyQNzsYBRyACYr7q hou0eP2/ThMj0u8M+gMVVUZQEX2kR/6MyL5YHZzBkE/wD91t9seL8HfxpuDai+W6QH+C sphw== X-Gm-Message-State: AOAM531u0lS/019g3Kc5+bfOeY/TpAqljtQzaB16bbeE6AD+g+pVIvvA JE1OKRcrDOBC48b/A3UNDfXtzQ== X-Google-Smtp-Source: ABdhPJw+AGxdclglSjnRVVYZt9ow7mnE7/5Pnzcz+8M9/W6ga0toIESbMCUri8//unEWRXNS0LVGrw== X-Received: by 2002:a1c:408a:: with SMTP id n132mr11692019wma.45.1599314618546; Sat, 05 Sep 2020 07:03:38 -0700 (PDT) Received: from ar2.home.b5net.uk ([213.48.11.149]) by smtp.gmail.com with ESMTPSA id b2sm17390369wmh.47.2020.09.05.07.03.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2020 07:03:38 -0700 (PDT) From: Paul Barker To: Woojung Huh , Microchip Linux Driver Support , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" Cc: Paul Barker , netdev@vger.kernel.org Subject: [PATCH 2/4] net: dsa: microchip: Add debug print for XMII port mode Date: Sat, 5 Sep 2020 15:03:23 +0100 Message-Id: <20200905140325.108846-3-pbarker@konsulko.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200905140325.108846-1-pbarker@konsulko.com> References: <20200905140325.108846-1-pbarker@konsulko.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When debug is enabled for this driver, this allows users to confirm that the correct port mode is in use. Signed-off-by: Paul Barker --- drivers/net/dsa/microchip/ksz9477.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index a48f5edab561..3e36aa628c9f 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -1211,21 +1211,25 @@ static void ksz9477_port_setup(struct ksz_device *dev, int port, bool cpu_port) ksz_pread8(dev, port, REG_PORT_XMII_CTRL_1, &data8); switch (dev->interface) { case PHY_INTERFACE_MODE_MII: + dev_dbg(dev->dev, "Port%d: MII mode\n", port); ksz9477_set_xmii(dev, 0, &data8); ksz9477_set_gbit(dev, false, &data8); p->phydev.speed = SPEED_100; break; case PHY_INTERFACE_MODE_RMII: + dev_dbg(dev->dev, "Port%d: RMII mode\n", port); ksz9477_set_xmii(dev, 1, &data8); ksz9477_set_gbit(dev, false, &data8); p->phydev.speed = SPEED_100; break; case PHY_INTERFACE_MODE_GMII: + dev_dbg(dev->dev, "Port%d: GMII mode\n", port); ksz9477_set_xmii(dev, 2, &data8); ksz9477_set_gbit(dev, true, &data8); p->phydev.speed = SPEED_1000; break; default: + dev_dbg(dev->dev, "Port%d: RGMII mode\n", port); ksz9477_set_xmii(dev, 3, &data8); ksz9477_set_gbit(dev, true, &data8); data8 &= ~PORT_RGMII_ID_IG_ENABLE; From patchwork Sat Sep 5 14:03:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Barker X-Patchwork-Id: 1358045 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=Q2vN4rum; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BkGWY5tWtz9sSn for ; Sun, 6 Sep 2020 00:04:41 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728585AbgIEOEg (ORCPT ); Sat, 5 Sep 2020 10:04:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728336AbgIEODm (ORCPT ); Sat, 5 Sep 2020 10:03:42 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A2E0C061247 for ; Sat, 5 Sep 2020 07:03:40 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id z1so10228971wrt.3 for ; Sat, 05 Sep 2020 07:03:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4LvnQQGv5OQrrtObdiwWlScTo7CXcMwrqPH8HgUosjI=; b=Q2vN4rumUQCCtxnGe7hhoAePnghvyFs5HwAx6T0M5tkkXDBZ5XDvMuTPX8vmlwlzCE n2+dc3gD8LkgsKqOUN/LhGVOZAtWQyPg1KIHIxKhj3fFAPFHP+oY0IdzFctXNWnUf4oK AbVEmzGBjXnfu86uhtv0inTAlHR26lVdKCOCQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4LvnQQGv5OQrrtObdiwWlScTo7CXcMwrqPH8HgUosjI=; b=bQZjaF0KnBLqK1blytDknoFg+HYP4P92Ej3U8rikD4N6Lj/bsOJZVC/EVgBdkwrguj w8Onq8/swo/qfoO7lOA7jzix0WxYzYK86f77QbfxMMoWe8S5ybiKX+BEjrIBaaCkeHD4 K9vmsqQRnMA7vA8oG/srG87MlrzuIgG1dRX/9m6TORmllR5N2pLHJMIgZp82zrjNXdV8 Q8d5+x9yO9tjI2fVKkmnjx2stfbgqiIKA9DCUzux++MxKZ8UyMd5RUhjBxPqliaEaE+T 2+BccwB87EErLiC+FwUdJcsoDcd6Ut85QtyIkePHCg3y/bVD6bDCYBuazr5D2zjXAYA+ 9N5w== X-Gm-Message-State: AOAM531mBnaSZ8QO81jyRPadOByUSvIuvuR5RwbeThl2yADqin7TQvgi Z9LI+wyNjLPN5H1CsyqxQcw+nA== X-Google-Smtp-Source: ABdhPJwD+BRp0vkVI0hryaQWiJSI5Axu9MwOmoiBB3S5fMvAJzoKupzd4tZAI4J4PWk+4pV5y/Be6g== X-Received: by 2002:a5d:56c1:: with SMTP id m1mr12052599wrw.87.1599314619465; Sat, 05 Sep 2020 07:03:39 -0700 (PDT) Received: from ar2.home.b5net.uk ([213.48.11.149]) by smtp.gmail.com with ESMTPSA id b2sm17390369wmh.47.2020.09.05.07.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2020 07:03:39 -0700 (PDT) From: Paul Barker To: Woojung Huh , Microchip Linux Driver Support , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" Cc: Paul Barker , netdev@vger.kernel.org Subject: [PATCH 3/4] net: dsa: microchip: Disable RGMII in-band status on KSZ9893 Date: Sat, 5 Sep 2020 15:03:24 +0100 Message-Id: <20200905140325.108846-4-pbarker@konsulko.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200905140325.108846-1-pbarker@konsulko.com> References: <20200905140325.108846-1-pbarker@konsulko.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We can't assume that the link partner supports the in-band status reporting which is enabled by default on the KSZ9893 when using RGMII for the upstream port. Signed-off-by: Paul Barker Reviewed-by: Andrew Lunn --- drivers/net/dsa/microchip/ksz9477.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index 3e36aa628c9f..2c953ab6ce16 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -1240,6 +1240,9 @@ static void ksz9477_port_setup(struct ksz_device *dev, int port, bool cpu_port) if (dev->interface == PHY_INTERFACE_MODE_RGMII_ID || dev->interface == PHY_INTERFACE_MODE_RGMII_TXID) data8 |= PORT_RGMII_ID_EG_ENABLE; + /* On KSZ9893, disable RGMII in-band status support */ + if (dev->features & IS_9893) + data8 &= ~PORT_MII_MAC_MODE; p->phydev.speed = SPEED_1000; break; } From patchwork Sat Sep 5 14:03:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Barker X-Patchwork-Id: 1358047 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=Fq/kpFRN; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BkGWn205Dz9sSn for ; Sun, 6 Sep 2020 00:04:53 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728625AbgIEOEv (ORCPT ); Sat, 5 Sep 2020 10:04:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728372AbgIEODr (ORCPT ); Sat, 5 Sep 2020 10:03:47 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC01DC061245 for ; Sat, 5 Sep 2020 07:03:46 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id c15so10154733wrs.11 for ; Sat, 05 Sep 2020 07:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/X4cwvvUFsabA0ucoN9VOvC/13JiGESTrG6cG37QFDo=; b=Fq/kpFRNovuK6ZKzdr5oSPrbu19aCAhCq8Zw3mgFW0hZMFeDupI169cb5AtWjk3W0b CbNG0sA8CejmTOxfid6UYjowOWFfmu9Y0UEYrZ6MwEmrCZLcycNejdHzp6nKT5XkVXU5 KG5QFemNlm1p8GN0txFWZYFnuIsTrJDQUtAlI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/X4cwvvUFsabA0ucoN9VOvC/13JiGESTrG6cG37QFDo=; b=H1tSlOZJb325P2gfok+eHY1SUNs+XzXInjujh/PNe6P8gyUH3CUTnL3s95WLp98tBj F6XCgIw/ZBe+Hi2DBY1+PhZueJMARRJih9nXfZBlZ61DM1My1ifuuAQZ7mxBG71d5FfD F4eViVJ1CJjiYnpsWcvuwXN6YQvBDPshEIXXIt+ywg/zNoBxBcbMZtBU2/hWDTpToKyQ 2OLPinDCJM/I17q6Itb6kdo2PKqcEeFXHFLEaRP4JDmwlpDD+D00z1PZmDOKHctqoeUD pE9Cav/VVlGJOSo6SFz7S0Hyb5NUJJ3KQIQiu3eC1/omjibRs3NRp4y+8vYvM1HYDNgV a+vg== X-Gm-Message-State: AOAM533ZQyh6kip1Cx2oogMbbOcj4zna+tE5U7ExaN12g2tn3L8+uOd2 tpOYLx9VpF/lXiBiwaM+pJCtIQ== X-Google-Smtp-Source: ABdhPJwIhiS5j0/DT/mV257lPhKlfOk8A1FlQH+vJ9NUaz38qHxvPgECgFRJLnBK6/sSWooqmdkJlA== X-Received: by 2002:adf:83c3:: with SMTP id 61mr12168867wre.287.1599314620745; Sat, 05 Sep 2020 07:03:40 -0700 (PDT) Received: from ar2.home.b5net.uk ([213.48.11.149]) by smtp.gmail.com with ESMTPSA id b2sm17390369wmh.47.2020.09.05.07.03.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2020 07:03:40 -0700 (PDT) From: Paul Barker To: Woojung Huh , Microchip Linux Driver Support , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" Cc: Paul Barker , netdev@vger.kernel.org Subject: [PATCH 4/4] net: dsa: microchip: Implement recommended reset timing Date: Sat, 5 Sep 2020 15:03:25 +0100 Message-Id: <20200905140325.108846-5-pbarker@konsulko.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200905140325.108846-1-pbarker@konsulko.com> References: <20200905140325.108846-1-pbarker@konsulko.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The datasheet for the ksz9893 and ksz9477 switches recommend waiting at least 100us after the de-assertion of reset before trying to program the device through any interface. Also switch the existing mdelay() call to usleep_range() as recommended in Documentation/timers/timers-howto.rst. The 2ms range used here is somewhat arbitrary, as long as the reset is asserted for at least 10ms we should be ok. Signed-off-by: Paul Barker --- drivers/net/dsa/microchip/ksz_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index 8d53b12d40a8..a31738662d95 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -400,8 +400,9 @@ int ksz_switch_register(struct ksz_device *dev, if (dev->reset_gpio) { gpiod_set_value_cansleep(dev->reset_gpio, 1); - mdelay(10); + usleep_range(10000, 12000); gpiod_set_value_cansleep(dev->reset_gpio, 0); + usleep_range(100, 1000); } mutex_init(&dev->dev_mutex);