From patchwork Mon Aug 31 16:58:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Falcon X-Patchwork-Id: 1354500 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=q1Psz8lX; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BgGcQ5slNz9sTK for ; Tue, 1 Sep 2020 02:58:30 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728822AbgHaQ61 (ORCPT ); Mon, 31 Aug 2020 12:58:27 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:27104 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727929AbgHaQ6U (ORCPT ); Mon, 31 Aug 2020 12:58:20 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07VGUa9C143542 for ; Mon, 31 Aug 2020 12:58:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=pp1; bh=wNiqS/mUQJ+UzDtDXdalpv64KQ+6EVfFBcSSCFewRII=; b=q1Psz8lX+Ykg1cJYGGDOoNU3daW7XMIwe24kTxGeOYpnZsN7tQwf2fK66zcTS5hTbTIE 3fE5q+1bXXhm06jCUPoDS48ukqNg9p40nG66baoOebWgljKtN4Jhx1HDGofw7VM7ccrF a4Z8XkeHJz90CBViC3cIWPQNrb+kGe3UruYlEGAM0EcDq6i+M3hrrSyLAJCSZoncfa9p rXWDnqhq7ARsz4ZcN7WOVtibL0PPhSNMGTH1evngIaf7IdH5oqVarUJBkgG44nL9VwtV hlbY8B9D7SXJqaDPYr5olEQwJhSkf80BkiiJClcxHYVrrYoWAB3KRMqUUqED/4Ad3xj2 Bg== Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0b-001b2d01.pphosted.com with ESMTP id 33949n9nfp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 31 Aug 2020 12:58:19 -0400 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07VGr0ha027543 for ; Mon, 31 Aug 2020 16:58:18 GMT Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by ppma02wdc.us.ibm.com with ESMTP id 337en99fyx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 31 Aug 2020 16:58:18 +0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07VGwH0s49676568 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 31 Aug 2020 16:58:18 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E18D5B2066; Mon, 31 Aug 2020 16:58:17 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 363F7B205F; Mon, 31 Aug 2020 16:58:17 +0000 (GMT) Received: from oc7186267434.ibm.com (unknown [9.160.96.4]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 31 Aug 2020 16:58:17 +0000 (GMT) From: Thomas Falcon To: netdev@vger.kernel.org Cc: drt@linux.vnet.ibm.com, sukadev@linux.vnet.ibm.com, ljp@linux.vnet.ibm.com, cforno12@linux.ibm.com, Thomas Falcon Subject: [PATCH net-next 1/5] ibmvnic: Create failover sysfs as part of an attribute group Date: Mon, 31 Aug 2020 11:58:09 -0500 Message-Id: <1598893093-14280-2-git-send-email-tlfalcon@linux.ibm.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1598893093-14280-1-git-send-email-tlfalcon@linux.ibm.com> References: <1598893093-14280-1-git-send-email-tlfalcon@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-31_07:2020-08-31,2020-08-31 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 impostorscore=0 mlxscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 bulkscore=0 suspectscore=3 lowpriorityscore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008310095 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Create a sysfs attribute group and make failover sysfs file a member. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 86a83e5..91b9cc3 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -5047,7 +5047,7 @@ static int ibmvnic_reset_init(struct ibmvnic_adapter *adapter, bool reset) return rc; } -static struct device_attribute dev_attr_failover; +static const struct attribute_group *dev_attr_groups[]; static int ibmvnic_probe(struct vio_dev *dev, const struct vio_device_id *id) { @@ -5126,9 +5126,9 @@ static int ibmvnic_probe(struct vio_dev *dev, const struct vio_device_id *id) netdev->min_mtu = adapter->min_mtu - ETH_HLEN; netdev->max_mtu = adapter->max_mtu - ETH_HLEN; - rc = device_create_file(&dev->dev, &dev_attr_failover); + rc = sysfs_create_groups(&dev->dev.kobj, dev_attr_groups); if (rc) - goto ibmvnic_dev_file_err; + goto ibmvnic_dev_groups_err; netif_carrier_off(netdev); rc = register_netdev(netdev); @@ -5145,14 +5145,11 @@ static int ibmvnic_probe(struct vio_dev *dev, const struct vio_device_id *id) return 0; ibmvnic_register_fail: - device_remove_file(&dev->dev, &dev_attr_failover); - -ibmvnic_dev_file_err: + sysfs_remove_groups(&dev->dev.kobj, dev_attr_groups); +ibmvnic_dev_groups_err: release_stats_token(adapter); - ibmvnic_stats_fail: release_stats_buffers(adapter); - ibmvnic_init_fail: release_sub_crqs(adapter, 1); release_crq_queue(adapter); @@ -5194,13 +5191,15 @@ static int ibmvnic_remove(struct vio_dev *dev) rtnl_unlock(); mutex_destroy(&adapter->fw_lock); - device_remove_file(&dev->dev, &dev_attr_failover); + sysfs_remove_groups(&dev->dev.kobj, dev_attr_groups); free_netdev(netdev); dev_set_drvdata(&dev->dev, NULL); return 0; } +static struct device_attribute dev_attr_failover; + static ssize_t failover_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { @@ -5237,6 +5236,20 @@ static ssize_t failover_store(struct device *dev, struct device_attribute *attr, static DEVICE_ATTR_WO(failover); +static struct attribute *dev_attrs[] = { + &dev_attr_failover.attr, + NULL, +}; + +static struct attribute_group dev_attr_group = { + .attrs = dev_attrs, +}; + +static const struct attribute_group *dev_attr_groups[] = { + &dev_attr_group, + NULL, +}; + static unsigned long ibmvnic_get_desired_dma(struct vio_dev *vdev) { struct net_device *netdev = dev_get_drvdata(&vdev->dev); From patchwork Mon Aug 31 16:58:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Falcon X-Patchwork-Id: 1354501 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=bWVRx7EQ; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BgGcZ4BjLz9sTY for ; Tue, 1 Sep 2020 02:58:38 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728845AbgHaQ6b (ORCPT ); Mon, 31 Aug 2020 12:58:31 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:18034 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726791AbgHaQ6V (ORCPT ); Mon, 31 Aug 2020 12:58:21 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07VGVdik006363 for ; Mon, 31 Aug 2020 12:58:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=pp1; bh=Va1DDesDMf3g8OsCJV+vtm44WptYCAIBhEsHmuI3Ops=; b=bWVRx7EQvc2lwk2bAcjC8nhSPYZbyT4ed0ytgHGHNm5z8RP7Py3CwK9O3QmjHeded4Rr HJ6w+nNA3K4ogAPRB3c7MivEGHc5EXu5Voy/iKB5uIiIcAJcSo2xm3a/hiLfhlJ4lVUk n2Gt0smIDoUwQ2/L6A3hYA6spS//H9RRyYKuArovc/UFfWXpbYTf6GaOaMA2zy6ZH5BK uthbss39ftdeNk2BkNQQYWxmPhF2YOb5mgEdcSR3vxoIz21p7lNkd0H+2XflfhBqaOi4 Ux9KAQ+GnWv3IpMfCstDk7Cwee1nwIDmkCETg2cnLmhsQcU0y1VNHQQCM8GdlQeSiADD vw== Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com with ESMTP id 33943w9v3x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 31 Aug 2020 12:58:20 -0400 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07VGqiM2027464 for ; Mon, 31 Aug 2020 16:58:19 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma02wdc.us.ibm.com with ESMTP id 337en99g01-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 31 Aug 2020 16:58:19 +0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07VGwI5v28639594 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 31 Aug 2020 16:58:18 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A48E5B2068; Mon, 31 Aug 2020 16:58:18 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 10678B205F; Mon, 31 Aug 2020 16:58:18 +0000 (GMT) Received: from oc7186267434.ibm.com (unknown [9.160.96.4]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 31 Aug 2020 16:58:17 +0000 (GMT) From: Thomas Falcon To: netdev@vger.kernel.org Cc: drt@linux.vnet.ibm.com, sukadev@linux.vnet.ibm.com, ljp@linux.vnet.ibm.com, cforno12@linux.ibm.com, Thomas Falcon Subject: [PATCH net-next 2/5] ibmvnic: Include documentation for ibmvnic sysfs files Date: Mon, 31 Aug 2020 11:58:10 -0500 Message-Id: <1598893093-14280-3-git-send-email-tlfalcon@linux.ibm.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1598893093-14280-1-git-send-email-tlfalcon@linux.ibm.com> References: <1598893093-14280-1-git-send-email-tlfalcon@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-31_07:2020-08-31,2020-08-31 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=1 lowpriorityscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 impostorscore=0 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008310095 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Include documentation for existing ibmvnic sysfs files, currently only for "failover," which is used to swap the active hardware port to a backup port in redundant backing hardware or failover configurations. Signed-off-by: Thomas Falcon --- Documentation/ABI/testing/sysfs-driver-ibmvnic | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-driver-ibmvnic diff --git a/Documentation/ABI/testing/sysfs-driver-ibmvnic b/Documentation/ABI/testing/sysfs-driver-ibmvnic new file mode 100644 index 0000000..7fa2920 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-driver-ibmvnic @@ -0,0 +1,14 @@ +What: /sys/devices/vio//failover +Date: June 2017 +KernelVersion: 4.13 +Contact: linuxppc-dev@lists.ozlabs.org +Description: If the ibmvnic device has been configured with redundant + physical NIC ports, the user may write "1" to the failover + file to trigger a device failover, which will reset the + ibmvnic device and swap to a backup physical port. If no + redundant physical port has been configured for the device, + the device will not reset and -EINVAL is returned. If anything + other than "1" is written to the file, -EINVAL will also be + returned. +Users: Any users of the ibmvnic driver which use redundant hardware + configurations. From patchwork Mon Aug 31 16:58:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Falcon X-Patchwork-Id: 1354504 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=CqVC3pV1; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BgGcr3Tggz9sTK for ; Tue, 1 Sep 2020 02:58:52 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728880AbgHaQ6t (ORCPT ); Mon, 31 Aug 2020 12:58:49 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:1316 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728730AbgHaQ6W (ORCPT ); Mon, 31 Aug 2020 12:58:22 -0400 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07VGVvxR146716 for ; Mon, 31 Aug 2020 12:58:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=pp1; bh=uABidDLy6bogIGlWn06ZrEYEiPQvr84B+nhE5A+kvmM=; b=CqVC3pV1tDj9FexHx2sRl0k3ZAxm2ElkuHS5BEQCoF6Ntip5riAWq1juK6Gvg9IeagEe 5CbV3FQt+1sFDe7kh2vvPyT0vvjlDXjOldJaqy/huWpRFZd7TV8tnCogVtyJ8SBWm2Lw np7cA7WWO+YDs8UVKwFssmGaNEMFgF5rrbeQL4ua9/lEVsDjMYTweEzGK/iGFyMdLXda TS1qOFXd82jv6iUC/86mlQYhNFKp4nSUDb3iAHSSSzuI9F8gjsssc+tVPnUZ7ki2/x3r zutCxc+BQJux0Lq/OIMbpFf7DDEXExZd5KU2IxgctByDI5kTf+Xjw+mhjbSrd47ozfmm qA== Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0a-001b2d01.pphosted.com with ESMTP id 33930dkv28-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 31 Aug 2020 12:58:20 -0400 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07VGr4Z8002225 for ; Mon, 31 Aug 2020 16:58:20 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma05wdc.us.ibm.com with ESMTP id 337en91heg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 31 Aug 2020 16:58:20 +0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07VGwJTg40370616 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 31 Aug 2020 16:58:19 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CA90AB2064; Mon, 31 Aug 2020 16:58:19 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C8376B2067; Mon, 31 Aug 2020 16:58:18 +0000 (GMT) Received: from oc7186267434.ibm.com (unknown [9.160.96.4]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 31 Aug 2020 16:58:18 +0000 (GMT) From: Thomas Falcon To: netdev@vger.kernel.org Cc: drt@linux.vnet.ibm.com, sukadev@linux.vnet.ibm.com, ljp@linux.vnet.ibm.com, cforno12@linux.ibm.com, Thomas Falcon Subject: [PATCH net-next 3/5] ibmvnic: Remove ACL change indication definitions Date: Mon, 31 Aug 2020 11:58:11 -0500 Message-Id: <1598893093-14280-4-git-send-email-tlfalcon@linux.ibm.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1598893093-14280-1-git-send-email-tlfalcon@linux.ibm.com> References: <1598893093-14280-1-git-send-email-tlfalcon@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-31_07:2020-08-31,2020-08-31 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 spamscore=0 malwarescore=0 adultscore=0 clxscore=1015 suspectscore=1 mlxlogscore=998 priorityscore=1501 lowpriorityscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008310095 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Access Control Lists can not be dynamically changed, so an existing device can never be notified of an update in ACL settings. Remove it. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.h | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.h b/drivers/net/ethernet/ibm/ibmvnic.h index 8da9879..e497392 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.h +++ b/drivers/net/ethernet/ibm/ibmvnic.h @@ -576,15 +576,6 @@ struct ibmvnic_get_vpd_rsp { struct ibmvnic_rc rc; } __packed __aligned(8); -struct ibmvnic_acl_change_indication { - u8 first; - u8 cmd; - __be16 change_type; -#define IBMVNIC_MAC_ACL 0 -#define IBMVNIC_VLAN_ACL 1 - u8 reserved[12]; -} __packed __aligned(8); - struct ibmvnic_acl_query { u8 first; u8 cmd; @@ -703,7 +694,6 @@ struct ibmvnic_query_map_rsp { struct ibmvnic_get_vpd_size_rsp get_vpd_size_rsp; struct ibmvnic_get_vpd get_vpd; struct ibmvnic_get_vpd_rsp get_vpd_rsp; - struct ibmvnic_acl_change_indication acl_change_indication; struct ibmvnic_acl_query acl_query; struct ibmvnic_generic_crq acl_query_rsp; struct ibmvnic_tune tune; From patchwork Mon Aug 31 16:58:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Falcon X-Patchwork-Id: 1354503 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=QorLElUg; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BgGcj4Z83z9sTK for ; Tue, 1 Sep 2020 02:58:45 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728868AbgHaQ6m (ORCPT ); Mon, 31 Aug 2020 12:58:42 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:2666 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728803AbgHaQ6Y (ORCPT ); Mon, 31 Aug 2020 12:58:24 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07VGpA3k003661 for ; Mon, 31 Aug 2020 12:58:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=pp1; bh=oXocsymrjddOGtWqnW5zr2HzNwGiTPjB5iXRxhmYkUo=; b=QorLElUg/7a82y32/T+VI+14nTT93BcCfvsc8ebf4yRb+l5702buySIau45y7RMT0l15 ckVq8HefpqqFDBbFeotxOqqnsx7DHhC5SFGJQ9lgTjIg1zw105fsrlZUzAo7nJ3Xd7jm e8z4hk55l1qqDoY+JWV4/TaDVYBDv8OFlys4kIu4p9VskGvNb6xGTT4xGBh31fIYQOQA ijAEQUTxkXoqzubipCccRCzmLbtdjTe1b9ueG9Xu/j0sHDjbPswqQ2+XjfeGPobek1aQ DUAnkMe0sArZggODNAU6Iq+dYlNvgdbSzUxTBFv7YJ2OlnQM4+uqg0k7NL69X87HBeqa 2g== Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 33953er3rx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 31 Aug 2020 12:58:22 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07VGrMdu032202 for ; Mon, 31 Aug 2020 16:58:21 GMT Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by ppma01dal.us.ibm.com with ESMTP id 337en95vf6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 31 Aug 2020 16:58:21 +0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07VGwKWu41287984 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 31 Aug 2020 16:58:20 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B3E7EB2064; Mon, 31 Aug 2020 16:58:20 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ED5B1B205F; Mon, 31 Aug 2020 16:58:19 +0000 (GMT) Received: from oc7186267434.ibm.com (unknown [9.160.96.4]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 31 Aug 2020 16:58:19 +0000 (GMT) From: Thomas Falcon To: netdev@vger.kernel.org Cc: drt@linux.vnet.ibm.com, sukadev@linux.vnet.ibm.com, ljp@linux.vnet.ibm.com, cforno12@linux.ibm.com, Thomas Falcon Subject: [PATCH net-next 4/5] ibmvnic: Reporting device ACL settings through sysfs Date: Mon, 31 Aug 2020 11:58:12 -0500 Message-Id: <1598893093-14280-5-git-send-email-tlfalcon@linux.ibm.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1598893093-14280-1-git-send-email-tlfalcon@linux.ibm.com> References: <1598893093-14280-1-git-send-email-tlfalcon@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-31_07:2020-08-31,2020-08-31 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 adultscore=0 phishscore=0 clxscore=1015 suspectscore=1 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008310095 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Access Control Lists can be defined for each IBM VNIC adapter at time of creation. MAC address and VLAN ID's may be specified, as well as a Port VLAN ID (PVID). These may all be requested though read-only sysfs files: mac_acl, vlan_acl, and pvid. When these files are read, a series of Command-Response Queue (CRQ) commands is sent to firmware. The first command requests the size of the ACL data. The driver allocates a buffer of this size and passes the address in a second CRQ command to firmware, which then writes the ACL data to this buffer. This data is then parsed and printed to the respective sysfs file. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 199 +++++++++++++++++++++++++++++++++++++ drivers/net/ethernet/ibm/ibmvnic.h | 26 ++++- 2 files changed, 222 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 91b9cc3..36dfa69 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1163,6 +1163,60 @@ static int __ibmvnic_open(struct net_device *netdev) return rc; } +static int ibmvnic_query_acl_sz(struct ibmvnic_adapter *adapter) +{ + union ibmvnic_crq crq; + + memset(&crq, 0, sizeof(crq)); + crq.acl_query.first = IBMVNIC_CRQ_CMD; + crq.acl_query.cmd = ACL_QUERY; + + if (ibmvnic_send_crq(adapter, &crq)) + return -EIO; + return 0; +} + +static int ibmvnic_request_acl_buf(struct ibmvnic_adapter *adapter) +{ + struct device *dev = &adapter->vdev->dev; + union ibmvnic_crq rcrq; + int rc; + + rc = 0; + adapter->acl_buf = kmalloc(adapter->acl_buf_sz, GFP_KERNEL); + if (!adapter->acl_buf) { + rc = -ENOMEM; + goto acl_alloc_err; + } + adapter->acl_buf_token = dma_map_single(dev, adapter->acl_buf, + adapter->acl_buf_sz, + DMA_FROM_DEVICE); + if (dma_mapping_error(dev, adapter->acl_buf_token)) { + rc = -ENOMEM; + goto acl_dma_err; + } + memset(&rcrq, 0, sizeof(rcrq)); + rcrq.acl_query.first = IBMVNIC_CRQ_CMD; + rcrq.acl_query.cmd = ACL_QUERY; + rcrq.acl_query.ioba = cpu_to_be32(adapter->acl_buf_token); + rcrq.acl_query.len = cpu_to_be32(adapter->acl_buf_sz); + if (ibmvnic_send_crq(adapter, &rcrq)) { + rc = -EIO; + goto acl_query_err; + } + return 0; +acl_query_err: + dma_unmap_single(dev, adapter->acl_buf_token, + adapter->acl_buf_sz, DMA_FROM_DEVICE); + adapter->acl_buf_token = 0; + adapter->acl_buf_sz = 0; +acl_dma_err: + kfree(adapter->acl_buf); + adapter->acl_buf = NULL; +acl_alloc_err: + return rc; +} + static int ibmvnic_open(struct net_device *netdev) { struct ibmvnic_adapter *adapter = netdev_priv(netdev); @@ -4635,6 +4689,25 @@ static int handle_query_phys_parms_rsp(union ibmvnic_crq *crq, return rc; } +static void handle_acl_query_rsp(struct ibmvnic_adapter *adapter, + union ibmvnic_crq *crq) +{ + struct net_device *netdev = adapter->netdev; + u8 rcode; + + rcode = crq->acl_query_rsp.rc.code; + adapter->fw_done_rc = rcode; + /* NOMEMORY is returned when ACL buffer size request is successful */ + if (rcode == NOMEMORY) { + adapter->acl_buf_sz = be32_to_cpu(crq->acl_query_rsp.len); + netdev_dbg(netdev, "ACL buffer size is %d.\n", + adapter->acl_buf_sz); + } else if (rcode != SUCCESS) { + netdev_err(netdev, "ACL query failed, rc = %u\n", rcode); + } + complete(&adapter->fw_done); +} + static void ibmvnic_handle_crq(union ibmvnic_crq *crq, struct ibmvnic_adapter *adapter) { @@ -4798,6 +4871,9 @@ static void ibmvnic_handle_crq(union ibmvnic_crq *crq, adapter->fw_done_rc = handle_query_phys_parms_rsp(crq, adapter); complete(&adapter->fw_done); break; + case ACL_QUERY_RSP: + handle_acl_query_rsp(adapter, crq); + break; default: netdev_err(netdev, "Got an invalid cmd type 0x%02x\n", gen_crq->cmd); @@ -5199,6 +5275,9 @@ static int ibmvnic_remove(struct vio_dev *dev) } static struct device_attribute dev_attr_failover; +static struct device_attribute dev_attr_vlan_acl; +static struct device_attribute dev_attr_mac_acl; +static struct device_attribute dev_attr_pvid; static ssize_t failover_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) @@ -5234,10 +5313,130 @@ static ssize_t failover_store(struct device *dev, struct device_attribute *attr, return count; } +static int ibmvnic_get_acls(struct ibmvnic_adapter *adapter) +{ + struct net_device *netdev = adapter->netdev; + int rc; + + mutex_lock(&adapter->fw_lock); + reinit_completion(&adapter->fw_done); + adapter->fw_done_rc = 0; + rc = ibmvnic_query_acl_sz(adapter); + if (rc) { + netdev_err(netdev, "Query ACL buffer size failed, rc = %d\n", + rc); + goto out; + } + rc = ibmvnic_wait_for_completion(adapter, &adapter->fw_done, 10000); + if (rc) { + netdev_err(netdev, + "Query ACL buffer size did not complete, rc = %d\n", + rc); + goto out; + } + /* NOMEMORY is returned when the ACL buffer size is retrieved + * successfully + */ + if (adapter->fw_done_rc != NOMEMORY) { + netdev_err(netdev, "Unable to get ACL buffer size, rc = %d\n", + adapter->fw_done_rc); + rc = -EIO; + goto out; + } + reinit_completion(&adapter->fw_done); + rc = ibmvnic_request_acl_buf(adapter); + if (rc) { + netdev_err(netdev, "ACL buffer request failed, rc = %d\n", rc); + goto out; + } + rc = ibmvnic_wait_for_completion(adapter, &adapter->fw_done, 10000); + if (rc) { + netdev_err(netdev, + "ACL buffer request did not complete, rc = %d\n", + rc); + goto out; + } + if (adapter->fw_done_rc != SUCCESS) { + netdev_err(netdev, "Unable to retrieve ACL buffer, rc = %d\n", + adapter->fw_done_rc); + rc = -EIO; + } +out: + mutex_unlock(&adapter->fw_lock); + return rc; +} + +static ssize_t acl_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct ibmvnic_acl_buffer *acl_buf; + struct ibmvnic_adapter *adapter; + struct net_device *netdev; + int num_entries; + ssize_t rsize; + int offset; + int rc; + int i; + + rsize = 0; + netdev = dev_get_drvdata(dev); + adapter = netdev_priv(netdev); + rc = ibmvnic_get_acls(adapter); + if (rc) + return rc; + acl_buf = adapter->acl_buf; + if (attr == &dev_attr_mac_acl) { + offset = be32_to_cpu(acl_buf->offset_mac_addrs); + num_entries = be32_to_cpu(acl_buf->num_mac_addrs); + if (num_entries == 0) + goto out; + for (i = 0; i < num_entries; i++) { + char *entry = (char *)acl_buf + offset + i * 6; + + rsize += scnprintf(buf + rsize, PAGE_SIZE, + "%pM\n", entry); + } + } else if (attr == &dev_attr_vlan_acl) { + offset = be32_to_cpu(acl_buf->offset_vlan_ids); + num_entries = be32_to_cpu(acl_buf->num_vlan_ids); + if (num_entries == 0) + goto out; + for (i = 0 ; i < num_entries; i++) { + char *entry = (char *)acl_buf + offset + i * 2; + + rsize += scnprintf(buf + rsize, PAGE_SIZE, "%d\n", + be16_to_cpup((__be16 *)entry)); + } + } else if (attr == &dev_attr_pvid) { + u16 pvid, vid; + u8 pri; + + pvid = be16_to_cpu(acl_buf->pvid); + vid = pvid & VLAN_VID_MASK; + pri = (pvid & VLAN_PRIO_MASK) >> VLAN_PRIO_SHIFT; + + rsize = scnprintf(buf, PAGE_SIZE, "%d\n%d\n", vid, pri); + } +out: + dma_unmap_single(dev, adapter->acl_buf_token, adapter->acl_buf_sz, + DMA_FROM_DEVICE); + kfree(adapter->acl_buf); + adapter->acl_buf = NULL; + adapter->acl_buf_token = 0; + adapter->acl_buf_sz = 0; + return rsize; +} + static DEVICE_ATTR_WO(failover); +static DEVICE_ATTR(mac_acl, 0444, acl_show, NULL); +static DEVICE_ATTR(vlan_acl, 0444, acl_show, NULL); +static DEVICE_ATTR(pvid, 0444, acl_show, NULL); static struct attribute *dev_attrs[] = { &dev_attr_failover.attr, + &dev_attr_mac_acl.attr, + &dev_attr_vlan_acl.attr, + &dev_attr_pvid.attr, NULL, }; diff --git a/drivers/net/ethernet/ibm/ibmvnic.h b/drivers/net/ethernet/ibm/ibmvnic.h index e497392..4768626 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.h +++ b/drivers/net/ethernet/ibm/ibmvnic.h @@ -195,12 +195,15 @@ struct ibmvnic_acl_buffer { #define INITIAL_VERSION_IOB 1 u8 mac_acls_restrict; u8 vlan_acls_restrict; - u8 reserved1[22]; + __be16 pvid; + u8 reserved1[52]; + __be32 max_mac_addrs; __be32 num_mac_addrs; __be32 offset_mac_addrs; + __be32 max_vlan_ids; __be32 num_vlan_ids; __be32 offset_vlan_ids; - u8 reserved2[80]; + u8 reserved2[40]; } __packed __aligned(8); /* descriptors have been changed, how should this be defined? 1? 4? */ @@ -585,6 +588,19 @@ struct ibmvnic_acl_query { u8 reserved2[4]; } __packed __aligned(8); +struct ibmvnic_acl_query_rsp { + u8 first; + u8 cmd; +#define ACL_EXISTS 0x8000 +#define VLAN_ACL_ON 0x4000 +#define MAC_ACL_ON 0x2000 +#define PVID_ON 0x1000 + __be16 flags; + u8 reserved[4]; + __be32 len; + struct ibmvnic_rc rc; +} __packed __aligned(8); + struct ibmvnic_tune { u8 first; u8 cmd; @@ -695,7 +711,7 @@ struct ibmvnic_query_map_rsp { struct ibmvnic_get_vpd get_vpd; struct ibmvnic_get_vpd_rsp get_vpd_rsp; struct ibmvnic_acl_query acl_query; - struct ibmvnic_generic_crq acl_query_rsp; + struct ibmvnic_acl_query_rsp acl_query_rsp; struct ibmvnic_tune tune; struct ibmvnic_generic_crq tune_rsp; struct ibmvnic_request_map request_map; @@ -1001,6 +1017,10 @@ struct ibmvnic_adapter { dma_addr_t login_rsp_buf_token; int login_rsp_buf_sz; + struct ibmvnic_acl_buffer *acl_buf; + dma_addr_t acl_buf_token; + int acl_buf_sz; + atomic_t running_cap_crqs; bool wait_capability; From patchwork Mon Aug 31 16:58:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Falcon X-Patchwork-Id: 1354502 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=Q7ctWZuU; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BgGcg6BYmz9sTg for ; Tue, 1 Sep 2020 02:58:43 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728875AbgHaQ6n (ORCPT ); Mon, 31 Aug 2020 12:58:43 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46028 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728211AbgHaQ6X (ORCPT ); Mon, 31 Aug 2020 12:58:23 -0400 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07VGjUTj186934 for ; Mon, 31 Aug 2020 12:58:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=pp1; bh=UhbNYWKQNFLz72Gfbsik60f05/Na1Obg3q6ckTkMXjw=; b=Q7ctWZuUy6+KoDvR2c36SbCyhPmiNtdEPxih4s5PHtV/7Yut1Y2tf7He/Ym+QbUSFjVo a3uiqVCI3f7qG2xEG3EGCA5YSyuuZZC1SKQk2JyT6rYlW3o8HfvzI/Rn7P9Zg2DXfBCN yffb/JWeYogPCgIipGCQf9OGFTNBQ+T+qJT3VpGfcyaQEX4pEntWFxY0mNbwhVCwZFPi nqBKtr/FD1U1qz6QnVEbxssGuuQIPV+3V8k6ZppkKOvRCB0ROgHSLhM/JNrrug6Jj0WR yzs//9u1xlgi2M9Um5xsef4a4wKVfHKXdW0E+eft1kcqkIEBriEUJoxhZSHgrkhGrjA8 og== Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 33950sr8mr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 31 Aug 2020 12:58:23 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07VGrMdv032202 for ; Mon, 31 Aug 2020 16:58:22 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma01dal.us.ibm.com with ESMTP id 337en95vf9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 31 Aug 2020 16:58:22 +0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07VGwLDf16057174 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 31 Aug 2020 16:58:21 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 82F56B205F; Mon, 31 Aug 2020 16:58:21 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E30D1B2065; Mon, 31 Aug 2020 16:58:20 +0000 (GMT) Received: from oc7186267434.ibm.com (unknown [9.160.96.4]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 31 Aug 2020 16:58:20 +0000 (GMT) From: Thomas Falcon To: netdev@vger.kernel.org Cc: drt@linux.vnet.ibm.com, sukadev@linux.vnet.ibm.com, ljp@linux.vnet.ibm.com, cforno12@linux.ibm.com, Thomas Falcon Subject: [PATCH net-next 5/5] ibmvnic: Provide documentation for ACL sysfs files Date: Mon, 31 Aug 2020 11:58:13 -0500 Message-Id: <1598893093-14280-6-git-send-email-tlfalcon@linux.ibm.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1598893093-14280-1-git-send-email-tlfalcon@linux.ibm.com> References: <1598893093-14280-1-git-send-email-tlfalcon@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-31_07:2020-08-31,2020-08-31 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 suspectscore=1 priorityscore=1501 bulkscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 malwarescore=0 mlxlogscore=919 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008310095 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Provide documentation for ibmvnic device Access Control List files. Signed-off-by: Thomas Falcon --- Documentation/ABI/testing/sysfs-driver-ibmvnic | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-driver-ibmvnic b/Documentation/ABI/testing/sysfs-driver-ibmvnic index 7fa2920..8c78312 100644 --- a/Documentation/ABI/testing/sysfs-driver-ibmvnic +++ b/Documentation/ABI/testing/sysfs-driver-ibmvnic @@ -12,3 +12,29 @@ Description: If the ibmvnic device has been configured with redundant returned. Users: Any users of the ibmvnic driver which use redundant hardware configurations. + +What: /sys/devices/vio//mac_acls +Date: August 2020 +KernelVersion: 5.10 +Contact: linuxppc-dev@lists.ozlabs.org +Description: Read-only file which lists the current entries in the ibmvnic + device's MAC address Access Control List. Each entry is + separated by a new line. +Users: Any users of the ibmvnic driver + +What: /sys/devices/vio//vlan_acls +Date: August 2020 +KernelVersion: 5.10 +Contact: linuxppc-dev@lists.ozlabs.org +Description: Read-only file which lists the current entries in the ibmvnic + device's VLAN ID Access Control List. Each entry is separated + by a new line. +Users: Any users of the ibmvnic driver + +What: /sys/devices/vio//pvid +Date: August 2020 +KernelVersion: 5.10 +Contact: linuxppc-dev@lists.ozlabs.org +Description: Read-only file which lists the ibmvnic device's Port VLAN + ID and Priority setting. Each entry is separated by a new line. +Users: Any users of the ibmvnic driver