From patchwork Sun Aug 23 18:15:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabian Frederick X-Patchwork-Id: 1349988 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=skynet.be Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BZNjt4YlSz9sT6 for ; Mon, 24 Aug 2020 04:16:18 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726336AbgHWSP7 (ORCPT ); Sun, 23 Aug 2020 14:15:59 -0400 Received: from mailrelay102.isp.belgacom.be ([195.238.20.129]:53438 "EHLO mailrelay102.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbgHWSP6 (ORCPT ); Sun, 23 Aug 2020 14:15:58 -0400 IronPort-SDR: zIM6P8ffbkrc+YRO3HONKTuRLyO0PH06+gga4LTnGlMGnMxwajgJK7Vas6EP26SypTdufJ+Rgw vyls4H0hcFYQexwLNGetvvz7Nsw+Wb1gm8EO1+OWhi5hLhN8tfXQwTYL5QsgaFYRKGyB2wbjYW 2Fnwr8miazCONtmB9VeKa5BPMleIJzGLsyoFvdebrJ5kLRekYkbm5Bq7Rki0IwG0aE7Dz2C/yI VqAaTpQLKIInHud6fGEZYgASf9/Ctt9aG0VHw8w8y5Tk7KlxORyNotT5X2vuSjutgJPZX32s2k XBo= X-Belgacom-Dynamic: yes IronPort-PHdr: 9a23:ySt2xh2yZ8zVUv+SsmDT+DRfVm0co7zxezQtwd8ZsesUKfTxwZ3uMQTl6Ol3ixeRBMOHsqwC0rOI+Pm6ACQp2tWoiDg6aptCVhsI2409vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6nK94iQPFRrhKAF7Ovr6GpLIj8Swyuu+54Dfbx9HiTagYL5+Ngi6oRjQu8UZnIduNLs9wQbVr3VVfOhb2XlmLk+JkRbm4cew8p9j8yBOtP8k6sVNT6b0cbkmQLJBFDgpPHw768PttRnYUAuA/WAcXXkMkhpJGAfK8hf3VYrsvyTgt+p93C6aPdDqTb0xRD+v4btnRAPuhSwaMTMy7WPZhdFqjK9DoByvuQFxzYDXbo+SO/VwcbjQcc8ZSGdbQspcTTBNDp+6YoASD+QBJ+FYr4zlqlUOtxSxHgisC/npyjRVhnH2x7M13Pk/HgHc3QwvA9EOu2nTodX7LqgdSu61wbLTzTXAb/JW3yny6JTSfh86v/6BRLR9etfexkczDQ3KlEmQqZD7MDOP0OQAq2aV4ulkWOyvimMqqx99rzavyMoxloXFm54Zx1HL+yt23Ys4K8O1RVN7bNOmDpZeuD2WOYV5TM4mQ29muDg2x7kAtJWmfyYK0IwqyhrCZ/CdboSF4QzvWPyMLTp5hH9pYq+zihe0/EO90OPzTNO030xPriddl9nMsW0C2ALL58icT/t94l+h2TGS1wDP8u1EIV47la7cK5M5xr4wkYYcvl7HHi/2n0X2l7OWel8g+uiv9+voeLHmqYKbN49xkA7+M6IultS+AeQ+LAcOQ3CW9OCh2LH54EH0Q6tGgucrnqTYsJ3WP9kXq6+hDw9QyIkj6hK/Dzm80NQfmHkKNFxFdwicgIjnIFzOO/P4DPe5g1uyjDdn3evJMaP5DpXXMnfDiKvhfap660NE0Ao818tQ55ZTCrwaJvL8RFPxtNLZDh89Lwy73fznBM961oMEVmKFGrWZP7/KsV+U+uIvJPGBZIwPtzngL/gq+eLhgGQ/mVADYamp05oXaHSkHvt4OUWVe33sgs0OEW0SpAoxUPTqiEGeUT5Uf3uyUaw96yogCIK6F4fDQp6igLqb0CimAJJcfnpGBUyUEXf0a4WEXO8BaDmJLc97kzwES7mhS4g62BG0qgD11rpnIfDI+iECqZ3j09117fXJlR4u7Tx0E9id02aVQmFygGwIWzE23KF7oUxh1FiDy7F0jOFGGtxN+fxJVhw3NYDTz+NkEdD+QAHBccmTSFagXNqmBSs9TtUrw98Be0x9Acmtjgjf3yq2BL8Yj6CEBJsu8q3Cw3j+Odxyy3Pd2aknkVYmXsVPNWyihq5j6QfTHZTFk0KDl6alba4cxjLC9H+fzWqSu0FVSAhwXrvZXX8CeETWs8/05l3NT7CwE7QrKAhBxtCYKqtMdNLpiU9KRPD5ONTRe2ixgXu/BQ6UxrOQa4rnY2sd0z/GB0gKiA0T5nWGNAg4Bii/v2LSFidhGky8K3/rpPF3one8Zkk50w+La1Fszfyy4BFRzf+VR/ce1ZoCtTsvqjFoEUz72MjZT5KOuCJ6YL9YbNV77FoDnXnTrQ1jP5uINa1uhlcCNQ9wuhDAzRJyX6tJm8kjqjsE1gd+JLiZ21AJIz2R157YIb7GLGTuuhqiPf2FkmrC2cqbr/9coM8zrE/u6Vmk X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BeCQArsUJf/xCltltfgRCBRYMYVF+NOJJKkgILAQEBAQEBAQEBJw0BAgQBAYRMgkclOBMCAwEBAQMCBQEBBgEBAQEBAQUEAYYPRUMWAYFdIoNSASMjgT8SgyYBglcpsCiCKIQQhGmBQIE4AYgjhRmBQT+BEYNOhASGMAS2P4JtgwyEWn6RMQ8hoDKSQ6FagXpNIBiDJAlHGQ2caEIwNwIGCgEBAwlXAT0BjAWBWYJGAQE X-IPAS-Result: A2BeCQArsUJf/xCltltfgRCBRYMYVF+NOJJKkgILAQEBAQEBAQEBJw0BAgQBAYRMgkclOBMCAwEBAQMCBQEBBgEBAQEBAQUEAYYPRUMWAYFdIoNSASMjgT8SgyYBglcpsCiCKIQQhGmBQIE4AYgjhRmBQT+BEYNOhASGMAS2P4JtgwyEWn6RMQ8hoDKSQ6FagXpNIBiDJAlHGQ2caEIwNwIGCgEBAwlXAT0BjAWBWYJGAQE Received: from 16.165-182-91.adsl-dyn.isp.belgacom.be (HELO localhost.localdomain) ([91.182.165.16]) by relay.skynet.be with ESMTP; 23 Aug 2020 20:15:55 +0200 From: Fabian Frederick To: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, sbrivio@redhat.com Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, Fabian Frederick Subject: [PATCH V2 1/5 nf] selftests: netfilter: fix header example Date: Sun, 23 Aug 2020 20:15:37 +0200 Message-Id: <20200823181537.13254-1-fabf@skynet.be> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org nft_flowtable.sh is made for bash not sh. Also give values which not return "RTNETLINK answers: Invalid argument" Signed-off-by: Fabian Frederick --- V2 = V1 tools/testing/selftests/netfilter/nft_flowtable.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/netfilter/nft_flowtable.sh b/tools/testing/selftests/netfilter/nft_flowtable.sh index a47d1d8322104..28e32fddf9b2c 100755 --- a/tools/testing/selftests/netfilter/nft_flowtable.sh +++ b/tools/testing/selftests/netfilter/nft_flowtable.sh @@ -11,7 +11,7 @@ # result in fragmentation and/or PMTU discovery. # # You can check with different Orgininator/Link/Responder MTU eg: -# sh nft_flowtable.sh -o1000 -l500 -r100 +# nft_flowtable.sh -o8000 -l1500 -r2000 # From patchwork Sun Aug 23 18:15:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabian Frederick X-Patchwork-Id: 1349989 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=skynet.be Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BZNjv6kFxz9sV9 for ; Mon, 24 Aug 2020 04:16:19 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726475AbgHWSQS (ORCPT ); Sun, 23 Aug 2020 14:16:18 -0400 Received: from mailrelay102.isp.belgacom.be ([195.238.20.129]:53454 "EHLO mailrelay102.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbgHWSQR (ORCPT ); Sun, 23 Aug 2020 14:16:17 -0400 IronPort-SDR: KRjEKcX+MFJ7e8uWssBY0r0Frzl3tUAv4DXnRBN775yGG6uJ9bv8R2kbT59a+I30yMRy0rVG8R mm0B8BiTYRabS08t8fniIUww7GDQMooCaW43fEOicfitRHH8tD4IldXxrtlr269GV5OWwK2QAQ DFIP5iw6/KI/9sEfnhOoIXWkHdVO5pE3lq9l0xA1suMyu2ypp/+P8Ny6UVVgC2ONknN6XeDKlS J9Ey8yiO8zBj5UQsQ7HrTOuTYekUN6H2dShxllfe4rUGT4DWduJZNYpp/EKDpusNQ8KvyuTQqd ANQ= X-Belgacom-Dynamic: yes IronPort-PHdr: 9a23:fXOzXxxfXzIUxk7XCy+O+j09IxM/srCxBDY+r6Qd0ugVIvad9pjvdHbS+e9qxAeQG9mCtbQd0rSd6vq5EUU7or+5+EgYd5JNUxJXwe43pCcHRPC/NEvgMfTxZDY7FskRHHVs/nW8LFQHUJ2mPw6arXK99yMdFQviPgRpOOv1BpTSj8Oq3Oyu5pHfeQpFiCe8bL9oMRm6sATcusYLjYd8N6o61wfErGZPd+lK321jOEidnwz75se+/Z5j9zpftvc8/MNeUqv0Yro1Q6VAADspL2466svrtQLeTQSU/XsTTn8WkhtTDAfb6hzxQ4r8vTH7tup53ymaINH2QLUpUjms86tnVBnlgzoBOjUk8m/Yl9Zwgbpbrhy/uhJxzY3aboaaO/RxZa7RYdAXSHBdUstLSyBNHoWxZJYPAeobOuZYqpHwqVsUohSlBAmjHuXvwSJIiH/sw6I1zvouERvH3AM8HNIFrXPZrNvvO6gJX+C417LIzTbDbvNQxzj99JLEfQs/rvyVW797bMXex1U1GQzfklWQtZLqPymT1ukVvWaW7O5tW+KuhmMntQ18rDihy9owhoXUmo4Yy1/K+ypkzYs7O9C1VU52bNy6HZVfqy2UOYR4T8ciTW9opio3zrsLsoO4cigS0JkqwwPTZ+aaf4WL/B7vTvudLDZ4iX5/Zb6yhhC/+lW6xOLmTMm7ylNKozJAktnLq38CyQTe6tOCSvth5keh3iuP1xzL5uFEP080ka3bJoYlwr43ipUcq0DDHi/xmEXtkK+abEEk+u+05Ov9ZrXpu5icN4puhQH/NKQigs2/AeImPQgSR2WW/fmw2Kf+8UD6XrlGlOA6n6jZvZzAOMgWp7a1AwpP3YYi7xa/AS2m0NMdnXQfIlJKYgmIj4byNlHVI/D5DfG/jEqwkDtx3P/JIKXtAo/RIXjbjLfhYbF95lZEyAUp1t9f45VUB6oHIP3tRk/xut3YDhslMwOq2ebrEtJ91pkRWWiXGK+WLLvSsUOU5uIoO+SMZ5Uatyv5K/c7+/Hjlnk5lkEBfamn3JsXbGy4Eep8I0mDZnrsmNgBG38QvgUiVOzqlEGCUTlLana8UaMx/So7CJ68DYfHWI+thqaN0zqlEZdOfGBJFkiMEWv0d4WDQ/oMczmdItVgkjwaVLihTJQs1QuwuwDny7poNPbU9jcEupLk0dh///fTmg0q9TxoE8Sd1HmAT2dqkWMUST823aR/oVBjxVeZyKR3nuJXFcJN6PNNSQo6K5HcwPJgC9zoWQLOYM2JSFC4TdWiGz0xScgxw9AWaUZnB9qilgzD3zatA7INi7OLA4Y0/bzA33fvPcl9zm3L1K8/gFk6TMtPNGmmhrJh+AjJHYLJlF+Zl6myf6QGwCHN7HuDzXaJvExAVg5/T7nFUm0BaUvIttn5+EzCQKG0Cbg9MQtO19SCKq1UZd3tl1lGQ+3jONvGaWKrh2iwHQqIxq+LbIfydWUSxj7SCEYfngAI/naHNQ4+CTm9o27EFzNhCwGnX0S56eB0rHSTSEIowQCOc0B7kb2v9VpdhvWQT/4Y9rQJpCkgryl5BhC6xd2SQ9SfjxF9ZqFRZ5Ux7RMPzmjDthJ8ObS6Iqxij0JYeANy7G300BAiJIxKkMEs5F0wwQZ/M6OT0xsVeTqS07jrOazRJ3W09h35OP2e4U3XzNvDovRH0/8/sVi25Aw= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BgCQArsUJf/xCltltfHgEBCxIMR4FFgxhUX404kkqSAgsBAQEBAQEBAQEnDQECBAEBhEyCRyU4EwIDAQEBAwIFAQEGAQEBAQEBBQQBhg9FQxYBgV0ig1IBIyOBPwkJgyYBglcpslCEEIRpgUCBOAGII4UZgUE/hF+KNASPRqZ5gm2DDIRafpExDyGgMpJDoVqBek0gGIMkCUcZDZxoQjA3AgYKAQEDCVcBPQGMBYQfAQE X-IPAS-Result: A2BgCQArsUJf/xCltltfHgEBCxIMR4FFgxhUX404kkqSAgsBAQEBAQEBAQEnDQECBAEBhEyCRyU4EwIDAQEBAwIFAQEGAQEBAQEBBQQBhg9FQxYBgV0ig1IBIyOBPwkJgyYBglcpslCEEIRpgUCBOAGII4UZgUE/hF+KNASPRqZ5gm2DDIRafpExDyGgMpJDoVqBek0gGIMkCUcZDZxoQjA3AgYKAQEDCVcBPQGMBYQfAQE Received: from 16.165-182-91.adsl-dyn.isp.belgacom.be (HELO localhost.localdomain) ([91.182.165.16]) by relay.skynet.be with ESMTP; 23 Aug 2020 20:16:15 +0200 From: Fabian Frederick To: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, sbrivio@redhat.com Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, Fabian Frederick Subject: [PATCH V2 2/5 nf] selftests: netfilter: exit on invalid parameters Date: Sun, 23 Aug 2020 20:15:59 +0200 Message-Id: <20200823181559.13306-1-fabf@skynet.be> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org exit script with comments when parameters are wrong during address addition. No need for a message when trying to change MTU with lower values: output is self-explanatory. Use short testing sequence to avoid shellcheck warnings (suggested by Stefano Brivio). Signed-off-by: Fabian Frederick --- V2: avoid shellcheck warnings .../testing/selftests/netfilter/nft_flowtable.sh | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/netfilter/nft_flowtable.sh b/tools/testing/selftests/netfilter/nft_flowtable.sh index 28e32fddf9b2c..dc05c99405979 100755 --- a/tools/testing/selftests/netfilter/nft_flowtable.sh +++ b/tools/testing/selftests/netfilter/nft_flowtable.sh @@ -96,10 +96,16 @@ do esac done -ip -net nsr1 link set veth0 mtu $omtu +if ! ip -net nsr1 link set veth0 mtu $omtu; then + exit 1 +fi + ip -net ns1 link set eth0 mtu $omtu -ip -net nsr2 link set veth1 mtu $rmtu +if ! ip -net nsr2 link set veth1 mtu $rmtu; then + exit 1 +fi + ip -net ns2 link set eth0 mtu $rmtu # transfer-net between nsr1 and nsr2. @@ -120,7 +126,10 @@ for i in 1 2; do ip -net ns$i route add default via 10.0.$i.1 ip -net ns$i addr add dead:$i::99/64 dev eth0 ip -net ns$i route add default via dead:$i::1 - ip netns exec ns$i sysctl net.ipv4.tcp_no_metrics_save=1 > /dev/null + if ! ip netns exec ns$i sysctl net.ipv4.tcp_no_metrics_save=1 > /dev/null; then + echo "ERROR: Check Originator/Responder values (problem during address addition)" + exit 1 + fi # don't set ip DF bit for first two tests ip netns exec ns$i sysctl net.ipv4.ip_no_pmtu_disc=1 > /dev/null From patchwork Sun Aug 23 18:17:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabian Frederick X-Patchwork-Id: 1349992 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=skynet.be Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BZNlH4rBVz9sR4 for ; Mon, 24 Aug 2020 04:17:31 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726730AbgHWSRZ (ORCPT ); Sun, 23 Aug 2020 14:17:25 -0400 Received: from mailrelay102.isp.belgacom.be ([195.238.20.129]:53532 "EHLO mailrelay102.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbgHWSRZ (ORCPT ); Sun, 23 Aug 2020 14:17:25 -0400 IronPort-SDR: Kv8tzqIQ8yr2Gm0qthsnJDSaxzw4SMHHtHSivb3GI/4NbBnCBlM/epqpNOrVqZxfxYc7ZRkF7o 0AuFTnUlVuqpZFhOZkdwENWVns5xwX1Ed9zjk1IzvUqeJ52ddjbEUcVWEIDkPfjkvjP+Cke2TX 9kk46FR2JMhoTUeqQ2fQa87srX5TYv6KDjP41UBtWMLx7l7MevAzghPX5CM7BpHRAPRORgK12t axRQkkbikAnvFxGWfVWJhLg56H/SR9wxCxm1clPYYuGz7Z9UE8vUT2lFotwbkjt7NGSUMLze5S fTI= X-Belgacom-Dynamic: yes IronPort-PHdr: 9a23:CFMU2xNzKLGYaWmhmVEl6mtUPXoX/o7sNwtQ0KIMzox0K/74r8bcNUDSrc9gkEXOFd2Cra4d1ayP6v6rADZbqb+681k6OKRWUBEEjchE1ycBO+WiTXPBEfjxciYhF95DXlI2t1uyMExSBdqsLwaK+i764jEdAAjwOhRoLerpBIHSk9631+ev8JHPfglEnjWwba5zIRmssAndq8gbjYR/JqovxBbCv2dFdflRyW50P1yYggzy5t23/J5t8iRQv+wu+stdWqjkfKo2UKJVAi0+P286+MPkux/DTRCS5nQHSWUZjgBIAwne4x7kWJr6rzb3ufB82CmeOs32UKw0VDG/5KplVBPklCEKPCM//WrKiMJ/kbhbrQqhqRJh3oDaboKbOv1xca3SZt4WWWlMU9xNWyFbHo+wc40CBPcBM+ZCqIn9okMDoxukCga3BePg0DlIjWL2060gzesuDB/J3BYhH90Ss3TfsdL4NKkIXu+uwqnF1i7Db/BW2Df79ofIbgotruqSUr9pd8fa1EYgGR/fgFqKtYzlIy2a1v4Ls2WD4eRtVuaihW4mpgxxvDSiyMcih5TVio4I1lzJ9Cp3zokoKNC2VkN2fN6pHZlOui+VK4d4TMwsTmVotig61LELvZi2dzUJxpQ/3xPSb+GLf5KV7h/gSuqdOyp0iXNldb6lmhq/8E6twfDmWMauylZFtC9Fn8HJtnAKyhPc9NCKSuB4/ke9wTaP0B3T6v1cLUA0i6XbL5khz6Y0lpoUrUvMBCv2mEXxjK+NakUo4Oyo6+P7bbr8op+TKoh0igTkPaQvnMyzGeU4Mg4QUGiH4emx0KDv8VfkTLhJkPE6iLTVvZHaKMgBu6K0AhdZ0oM55Ba+Czem3s4YnX4CLF9ddhKIlZPmO1/VLfDjDve+g1Ksnyl3x/zcJbLuHI3BLmLfn7f5YbZ990lcxRIrzd9F/J1UDrYBLen1WkDvqNzYAB45Mwiow+n5EtVxzIQeWXiAAqWBKqPdrUeI5v4zI+mLfIIVuyzyJOUh5/HwkXA0glkdcre13ZsZaXC4GuhmLFuDYXb2hdcBC2gKtBIkTOP2kF2CTSJTZ3GqUqIy6DA2E5mmDZvZRoCpnrOB2j23EYBIaWpeEFCDDW/od5mYW/cLcC+SOdRukiYFVbi/So8h0gqjtBXkxLV6Lurb4DEYuYj/29hy4u3ZjQsy+iBsD8SBz2GNSHl5nmUWSD8q0qB/oEh9ykud3qhimvBXCMJc5+1XXQc+LpPc0eN6BM7oWg7bfdeGVkymQtO4DjE1VN4xxMUOY0llEdW4kh/DxzaqA6MSl7GTGJM09bjc0GbtJ8lj0XnG0bIsj184TctTO22mh6p/9xTNCI7TiUmZkLyqdasE1i7X6GiD1XaOvF1fUANoV6XKQ2wfaVbIotTn/U7CUbCuBqo9Mgdbys6NNLFKatv3glVCXvvjP87eY22pkWeqGRmI3q+MbJbte2gF0iXSElMLkw4I8HadNgg/BiGhrHzCDDB0Dl3gfRCkze4rsHqxSkgcyQyWYUxly7evvBkPirjUSPof2r8PkCEstzt1GEqwxZTREdXE7wR+VL5Ae9cw5hFL2CaRrAZnP4KhKIh4i1IeehgxtETrhDttDYAVv8EgrXoshCRoJK6VylJKdHvM05n6NJXMKXj08QzpYaOAiQKW68qf5qpasKdwkF7kpgz8Tkc= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DjAQB9skJf/xCltltfHQEBAQEJARIBBQUBR4EyBQELAQGDGFRfjTiSSpICCwEBAQEBAQEBAScNAQIEAQGETIJHJTcGDgIDAQEBAwIFAQEGAQEBAQEBBQQBhg9FQxYBgV0ig1IBIyOBPxKDJgGCVymyT4QQhGeBQIE4AYgjhRmBQT+BEYNOihIiBJoPnDCCbYMMhFp+kTEPIaAyLZIWoVmBe00gGIMkCUcZDZxoQjA3AgYKAQEDCVcBPQGMBYQfAQE X-IPAS-Result: A2DjAQB9skJf/xCltltfHQEBAQEJARIBBQUBR4EyBQELAQGDGFRfjTiSSpICCwEBAQEBAQEBAScNAQIEAQGETIJHJTcGDgIDAQEBAwIFAQEGAQEBAQEBBQQBhg9FQxYBgV0ig1IBIyOBPxKDJgGCVymyT4QQhGeBQIE4AYgjhRmBQT+BEYNOihIiBJoPnDCCbYMMhFp+kTEPIaAyLZIWoVmBe00gGIMkCUcZDZxoQjA3AgYKAQEDCVcBPQGMBYQfAQE Received: from 16.165-182-91.adsl-dyn.isp.belgacom.be (HELO localhost.localdomain) ([91.182.165.16]) by relay.skynet.be with ESMTP; 23 Aug 2020 20:17:22 +0200 From: Fabian Frederick To: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, sbrivio@redhat.com Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, Fabian Frederick Subject: [PATCH V2 3/5 nf] selftests: netfilter: remove unused variable in make_file() Date: Sun, 23 Aug 2020 20:17:07 +0200 Message-Id: <20200823181707.13361-1-fabf@skynet.be> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 'who' variable was not used in make_file() Problem found using Shellcheck Signed-off-by: Fabian Frederick --- V2: new patch tools/testing/selftests/netfilter/nft_flowtable.sh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/netfilter/nft_flowtable.sh b/tools/testing/selftests/netfilter/nft_flowtable.sh index dc05c99405979..1058952d1b364 100755 --- a/tools/testing/selftests/netfilter/nft_flowtable.sh +++ b/tools/testing/selftests/netfilter/nft_flowtable.sh @@ -212,7 +212,6 @@ ns2out=$(mktemp) make_file() { name=$1 - who=$2 SIZE=$((RANDOM % (1024 * 8))) TSIZE=$((SIZE * 1024)) @@ -304,8 +303,8 @@ test_tcp_forwarding_nat() return $lret } -make_file "$ns1in" "ns1" -make_file "$ns2in" "ns2" +make_file "$ns1in" +make_file "$ns2in" # First test: # No PMTU discovery, nsr1 is expected to fragment packets from ns1 to ns2 as needed. From patchwork Sun Aug 23 18:17:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabian Frederick X-Patchwork-Id: 1349994 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=skynet.be Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BZNly47Zcz9sPC for ; Mon, 24 Aug 2020 04:18:06 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726739AbgHWSSF (ORCPT ); Sun, 23 Aug 2020 14:18:05 -0400 Received: from mailrelay102.isp.belgacom.be ([195.238.20.129]:53596 "EHLO mailrelay102.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbgHWSSD (ORCPT ); Sun, 23 Aug 2020 14:18:03 -0400 IronPort-SDR: A3xFN6t9Z0Jf7B9yz6a2cOd/UOqUdVfeyMkYmU/+dEjcClsRhFiFlDV5ULz9jOttmN/lZyskSK gSgiNnT0F3MUfyaFTlUzaTcPU7cTDumBrB1DML/vSIZ0lsboFhSEsLlrer7FfgPzjIuH0U2BJV D8eWvw6ZAdAaQ9lbUZN2bLNtp0IqNloCyiEhNcPPaL2bdilrg+aemN+8AuQaPyjXtvaEkYGsaf 1+U+OPt5KZyDwR5XIUqH6MYsrR1zHJtkosDPgqk00i0FbOTFeL6um5l4EC1F+UFZ6rwatf72hP 5rg= X-Belgacom-Dynamic: yes IronPort-PHdr: 9a23:EglLQRWlC0LMm7pov4/DkRZTf7vV8LGtZVwlr6E/grcLSJyIuqrYZRaPvadThVPEFb/W9+hDw7KP9fy5BypZuMjK6SpZOLV3FDY9wf0MmAIhBMPXQWbaF9XNKxIAIcJZSVV+9Gu6O0UGUOz3ZlnVv2HgpWVKQka3OgV6PPn6FZDPhMqrye+y54fTYwJVjzahfL9+Nhq7oRjQu8UMnIduN6c8xhTUrndWdeld2H9lK0+Ukxvg/Mm74YRt8z5Xu/Iv9s5AVbv1cqElRrFGDzooLn446tTzuRbMUQWA6H0cUn4LkhVTGAjK8Av6XpbqvSTksOd2xTSXMtf3TbAwXjSi8rtrRRr1gyoJKzI17GfagdF2galGohyuugZ/zpbUbo+LKfRwcKDTc9QVSmRORctdSy9MD5mgY4YVE+YNIeBVpJT9qVsUqhu+ABGhCuP1xTBTh3/5x6s62PkhHwHcwgMvAswBsG7VrNrpN6cZTOe4zKfSwjrYYfNbwiz96IvIcxAnv/6MQah8ftHPxkQ2EQ7Ok1qfp5D/MTyPyuQNr3aU7/BmVe+3lmMqpR19rDigy8othITEiI0bx1PF+Ch63Io4Id61RFJ0bNCkDpZeuD2WOolqT848R2xluCU3x7wbtZO6cyUHzJIqzAPRZfyAdoiH+BPjVOCJLDd+mn1lZLy/hxe28Ui81OL8TNO40FBEridDj9LCtWgN2gTX58SaUPdx40Ss1SiV2wzO6+xJIVo4mbfaJpMn37U+jIAcsV7ZES/zgEj2iaiWeVg69eWw8OTnZ6nmpoebN49plgHyKqQuldK7AeQ/KgUOW2+b9vim273n/U35R65KjuEsnqndt5DVOd4UpqqkDA9S14Ys8Re/DzG+3NQZm3kIMk5FdQqDgoT0IV3CPfP1Aemlj1ixkTpmx+rKMqDgD5nVK3jMirbhfbJz605GzwozyMhS55xOBb4aLvL+QVTxtN/YDx8/LQO03/zrB85j2Y8GQ2KAHreZML/OsV+P/u8vO/ODa5QRuDb6MPUl4eDhjWM3mV8ceampwYUYaGqiEvRhOUWZbmLmgs0dHmcSogo+UOvqhUWBUTFJenmyW7wz6S0gBYKgE4jDWo6tgL2F3CenAJJWfHpKCleWEXfnb4+EQesDaDqOIs99lTwJTbahSoE62BG1qA/60b5nIfTS+iECqJ3sysB/5/fPmhEq6Tx0E8Od3nmWT25vhGMIRiE23KF4oUFm0FeMz7V3g/xCGtxP/f9GTgA6NZvExexgF9/yQh7BfsuOSFu+RNWpHy0xTtwww98Kf0ZyBc+iggne0CW0Hb8aibiLCYcq8qLTwXfxPdxxy3XY26k7iVkpXM9POXehhq5l+AjZH5TJnFmBl6a2aaQc2zbA+3uEzWqUok5YTBB/Xr/AXX0EYEvZs8j55k3DT7+qFbQoLBFBxdSFKqtQZd3jlU9GS+v7ONTCf2KxnH+9BRCWybOQcYXlZXsd0T7DCEgLjQ8T52yKNQsgCSe7pWLREjhuGUjoY0P2/ul0sGm7QVMszwGWc01h0KK4+hAPivOHRfMexakEuCQhqjVyAlm9w8jaBMGeqFkpQKIJedo35FBv02/FuQ15IpG6aad4iRpWcA17u07l/xN6FotBldQntjUt1gU2YayH+EhdbTeV29b8N/mfMWPo/Q6ubIbM113e2crQ8aAKu9oirFC2kgijF0Mku1t93tVYyXqX5d2eAgMYX7rqUVcx+gQ8rbyMMXp13J/dyXA5afr8iTTFwd98XOY= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DPBwB9skJf/xCltltfHQEBAQEJARIBBQUBR4FDAoMYVF+NOJJKkgILAQEBAQEBAQEBJw0BAgQBAYRMgkclOBMCAwEBAQMCBQEBBgEBAQEBAQUEAYYPRUMWAYFdIoNHCwEjI4E/EoMmAYJXKbIcM4QQhGeBQIE4AYgjhRmBQT+BEYNOijQEj2UEplaCbYMMhFp+kTEPIaAykkOhWoF6TSAYO4JpCUcZDZxoQjA3AgYKAQEDCVcBPQGMBYQfAQE X-IPAS-Result: A2DPBwB9skJf/xCltltfHQEBAQEJARIBBQUBR4FDAoMYVF+NOJJKkgILAQEBAQEBAQEBJw0BAgQBAYRMgkclOBMCAwEBAQMCBQEBBgEBAQEBAQUEAYYPRUMWAYFdIoNHCwEjI4E/EoMmAYJXKbIcM4QQhGeBQIE4AYgjhRmBQT+BEYNOijQEj2UEplaCbYMMhFp+kTEPIaAykkOhWoF6TSAYO4JpCUcZDZxoQjA3AgYKAQEDCVcBPQGMBYQfAQE Received: from 16.165-182-91.adsl-dyn.isp.belgacom.be (HELO localhost.localdomain) ([91.182.165.16]) by relay.skynet.be with ESMTP; 23 Aug 2020 20:17:59 +0200 From: Fabian Frederick To: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, sbrivio@redhat.com Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, Fabian Frederick Subject: [PATCH V2 4/5 nf] selftests: netfilter: simplify command testing Date: Sun, 23 Aug 2020 20:17:39 +0200 Message-Id: <20200823181740.13413-1-fabf@skynet.be> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix some shellcheck SC2181 warnings: "Check exit code directly with e.g. 'if mycmd;', not indirectly with $?." as suggested by Stefano Brivio. Signed-off-by: Fabian Frederick --- V2: new patch .../selftests/netfilter/nft_flowtable.sh | 34 ++++++------------- 1 file changed, 11 insertions(+), 23 deletions(-) diff --git a/tools/testing/selftests/netfilter/nft_flowtable.sh b/tools/testing/selftests/netfilter/nft_flowtable.sh index 1058952d1b364..44a8798262369 100755 --- a/tools/testing/selftests/netfilter/nft_flowtable.sh +++ b/tools/testing/selftests/netfilter/nft_flowtable.sh @@ -27,8 +27,7 @@ ns2out="" log_netns=$(sysctl -n net.netfilter.nf_log_all_netns) checktool (){ - $1 > /dev/null 2>&1 - if [ $? -ne 0 ];then + if ! $1 > /dev/null 2>&1; then echo "SKIP: Could not $2" exit $ksft_skip fi @@ -187,15 +186,13 @@ if [ $? -ne 0 ]; then fi # test basic connectivity -ip netns exec ns1 ping -c 1 -q 10.0.2.99 > /dev/null -if [ $? -ne 0 ];then +if ! ip netns exec ns1 ping -c 1 -q 10.0.2.99 > /dev/null; then echo "ERROR: ns1 cannot reach ns2" 1>&2 bash exit 1 fi -ip netns exec ns2 ping -c 1 -q 10.0.1.99 > /dev/null -if [ $? -ne 0 ];then +if ! ip netns exec ns2 ping -c 1 -q 10.0.1.99 > /dev/null; then echo "ERROR: ns2 cannot reach ns1" 1>&2 exit 1 fi @@ -230,8 +227,7 @@ check_transfer() out=$2 what=$3 - cmp "$in" "$out" > /dev/null 2>&1 - if [ $? -ne 0 ] ;then + if ! cmp "$in" "$out" > /dev/null 2>&1; then echo "FAIL: file mismatch for $what" 1>&2 ls -l "$in" ls -l "$out" @@ -268,13 +264,11 @@ test_tcp_forwarding_ip() wait - check_transfer "$ns1in" "$ns2out" "ns1 -> ns2" - if [ $? -ne 0 ];then + if ! check_transfer "$ns1in" "$ns2out" "ns1 -> ns2"; then lret=1 fi - check_transfer "$ns2in" "$ns1out" "ns1 <- ns2" - if [ $? -ne 0 ];then + if ! check_transfer "$ns2in" "$ns1out" "ns1 <- ns2"; then lret=1 fi @@ -308,8 +302,7 @@ make_file "$ns2in" # First test: # No PMTU discovery, nsr1 is expected to fragment packets from ns1 to ns2 as needed. -test_tcp_forwarding ns1 ns2 -if [ $? -eq 0 ] ;then +if test_tcp_forwarding ns1 ns2; then echo "PASS: flow offloaded for ns1/ns2" else echo "FAIL: flow offload for ns1/ns2:" 1>&2 @@ -340,9 +333,7 @@ table ip nat { } EOF -test_tcp_forwarding_nat ns1 ns2 - -if [ $? -eq 0 ] ;then +if test_tcp_forwarding_nat ns1 ns2; then echo "PASS: flow offloaded for ns1/ns2 with NAT" else echo "FAIL: flow offload for ns1/ns2 with NAT" 1>&2 @@ -354,8 +345,7 @@ fi # Same as second test, but with PMTU discovery enabled. handle=$(ip netns exec nsr1 nft -a list table inet filter | grep something-to-grep-for | cut -d \# -f 2) -ip netns exec nsr1 nft delete rule inet filter forward $handle -if [ $? -ne 0 ] ;then +if ! ip netns exec nsr1 nft delete rule inet filter forward $handle; then echo "FAIL: Could not delete large-packet accept rule" exit 1 fi @@ -363,8 +353,7 @@ fi ip netns exec ns1 sysctl net.ipv4.ip_no_pmtu_disc=0 > /dev/null ip netns exec ns2 sysctl net.ipv4.ip_no_pmtu_disc=0 > /dev/null -test_tcp_forwarding_nat ns1 ns2 -if [ $? -eq 0 ] ;then +if test_tcp_forwarding_nat ns1 ns2; then echo "PASS: flow offloaded for ns1/ns2 with NAT and pmtu discovery" else echo "FAIL: flow offload for ns1/ns2 with NAT and pmtu discovery" 1>&2 @@ -410,8 +399,7 @@ ip -net ns2 route del 192.168.10.1 via 10.0.2.1 ip -net ns2 route add default via 10.0.2.1 ip -net ns2 route add default via dead:2::1 -test_tcp_forwarding ns1 ns2 -if [ $? -eq 0 ] ;then +if test_tcp_forwarding ns1 ns2; then echo "PASS: ipsec tunnel mode for ns1/ns2" else echo "FAIL: ipsec tunnel mode for ns1/ns2" From patchwork Sun Aug 23 18:18:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabian Frederick X-Patchwork-Id: 1349996 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=skynet.be Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BZNmT3Sl3z9sR4 for ; Mon, 24 Aug 2020 04:18:33 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726752AbgHWSSb (ORCPT ); Sun, 23 Aug 2020 14:18:31 -0400 Received: from mailrelay102.isp.belgacom.be ([195.238.20.129]:53622 "EHLO mailrelay102.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbgHWSS1 (ORCPT ); Sun, 23 Aug 2020 14:18:27 -0400 IronPort-SDR: wRdfGMtH/v7YGUeUfpzneb66FO/dbgm58H+vuqXISzfKbqtgU4XYbYgH29VJXJmXK+svY/3V7t 3nwsVB26GfbDOdIQPd2zhNOZAmYKO5hmoTaz0g4ldiO+2BMU+fONQtQWFYwJnc8IIZREz2k68C w+0r9vZ1seUpH7uPu/7kXKwkw0nSfeBm4rwHp4+gLWIMSlq2mk+ADwNIgehtjE4aaslhjU2NWw n+tLzdJ7J7vupbgx3Ee9aMY+wT8Fkw+EuujsY/dfZ+wDhrehwOxBiz6aMRxb346UxMNEdJtN2v eg4= X-Belgacom-Dynamic: yes IronPort-PHdr: 9a23:byg8XRCLthwAGw0knWmvUyQJP3N1i/DPJgcQr6AfoPdwSP35pMSwAkXT6L1XgUPTWs2DsrQY0rSQ6vm+EjVaut6oizMrSNR0TRgLiMEbzUQLIfWuLgnFFsPsdDEwB89YVVVorDmROElRH9viNRWJ+iXhpTEdFQ/iOgVrO+/7BpDdj9it1+C15pbffxhEiCCybL9vLRi6txjdutQXjIdtN6o91BXEqWZUdupLwm9lOUidlAvm6Meq+55j/SVQu/Y/+MNFTK73Yac2Q6FGATo/K2w669HluhfFTQuU+3sTSX4WnQZSAwjE9x71QJH8uTbnu+Vn2SmaOcr2Ta0oWTmn8qxmRgPkhDsBOjUk9mzcl85+g79BoB+5pxJx3ZPabo+WOvR5cazTcsgXSXZCU8tLSyBMGJ+wY5cJAuEcPehYtY79p14WoBW+HwajH+LvxSVOhnTr3aM6yfouHhzY0ww6HtIBrHfUp8jyOaccS++616fIwC7Yb/NV2Tb97pbHcgw7rf6XQ719aMzcwlQgGA3ZlFufs5DlPy+L2eQXtWiW9+RuWOGrhmAnqgx8oiajy8kshITUmo4Z10zI+CR2zog6ONC1RlB2bMOkHZZSqSyUOJd6TM0tTWxsuCg0yqMKtJq9cSMXy5on3wbSZviaf4SS/x7uV/idLS1liH9keL+znQu+/Emmx+bhTMe7ykxKoTBAktTUs3AN0AHc5dafR/tm+0ehxS6P1wfO6uFYOUw0lbTUK5omwrMokpoTtljMETXymEX2i6+WbVkk9vKs6+TgfrrpvJucOJJzigH7KKsum8q/Dfw5MggIQWeb5fyx2bn+8UHjXblHjeM6nrPEvJ3bJckXvLO1Dg5N3oYm8Rm/DjOm0NoCnXkAKVJIYByHgJLyNFHAO/34FvS/glSqkDh12/DKJKbuDYvVInjZjLjhZap961JbyAcr1dBQ/YlbCrUGIP/oXE/+qsDYDhE4Mwyw3+boFs992pkZWWKVDa+TKLnSvkOQ5uIzP+mMY5cYuDXnJPc44/7hk2M2lEQbfaa3wZsXZnG4HvB6I0qHe3rgmNABEX0FvgAmVuzllEWCUSJPZ3a1R6886D86BZm9DYffXICthKKO3CGhEpJLeG9MEkqMHmvwd4WYR/cMbzqfItR6nTweVLihVY4h1Ra1uQ/g1bVoM+rU9TcEtZ75yNd14OjTnwko9TNoF8Sdz32NT2Zsk2MOWTA2wK5/oU15ylefz6d4meVUGsFN6PNXTAg6MYXRz/J1C9/sQALNZNSJR0i8QtWgHz4xSsg9w9gUY0ZyA9+ilAzM3zK2A78JkLyGHIA78qXG33fvO8Zy1WzJ1Kw6glkgXMRPKWOmhq979wjPGYHJiV+Vl6GwdaQTxCTN7nuMzXKSvEFEVw59SaPFUm4DZkTLs9v5+FjPT6GhCbs5KAtN082CJbVQat3vk1pGQO3vONPEY2K+g22wHwqHxquQbIr2fGUQxCvdB1IfnAAd5nuGLgs+Byeno23AEDxiD0ngbF2/udV5/WuyREsz5weHc0Ng06a44FgSn/PYA/Aa0rYJsw8npil6HVKh0siQDMCP40JvY41Hfck57VEB2W+d/xd3JJ2+LqdKnFMScw1r+Ujp0kZZEIJFxOYjpnIjykJcM6+U3UlAfDDQiZ75MLP/MWrj+h2zLaTbjAKNmO2K87sCvaxr427ouxukQxIv X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BfCQB9skJf/xCltltfHgEBCxIMR4FFgxhUX404kkqSAgsBAQEBAQEBAQEnDQECBAEBhEyCRyU4EwIDAQEBAwIFAQEGAQEBAQEBBQQBhg9FQxYBgV0ig1IBIyOBPxKDJgGCVymyT4QQhGeBQIE4AYgjhRmBQT+EX4QfhhUEj0ameYJtgwyEWn6RMQ8hoDKSQ6FagXpNIBiDJAlHGQ2caEIwNwIGCgEBAwlXAT0BjAWEHwEB X-IPAS-Result: A2BfCQB9skJf/xCltltfHgEBCxIMR4FFgxhUX404kkqSAgsBAQEBAQEBAQEnDQECBAEBhEyCRyU4EwIDAQEBAwIFAQEGAQEBAQEBBQQBhg9FQxYBgV0ig1IBIyOBPxKDJgGCVymyT4QQhGeBQIE4AYgjhRmBQT+EX4QfhhUEj0ameYJtgwyEWn6RMQ8hoDKSQ6FagXpNIBiDJAlHGQ2caEIwNwIGCgEBAwlXAT0BjAWEHwEB Received: from 16.165-182-91.adsl-dyn.isp.belgacom.be (HELO localhost.localdomain) ([91.182.165.16]) by relay.skynet.be with ESMTP; 23 Aug 2020 20:18:25 +0200 From: Fabian Frederick To: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, sbrivio@redhat.com Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, Fabian Frederick Subject: [PATCH V2 5/5 nf] selftests: netfilter: add command usage Date: Sun, 23 Aug 2020 20:18:06 +0200 Message-Id: <20200823181806.13463-1-fabf@skynet.be> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Avoid bad command arguments. Based on tools/power/cpupower/bench/cpufreq-bench_plot.sh Signed-off-by: Fabian Frederick --- V2: new patch tools/testing/selftests/netfilter/nft_flowtable.sh | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tools/testing/selftests/netfilter/nft_flowtable.sh b/tools/testing/selftests/netfilter/nft_flowtable.sh index 44a8798262369..431296c0f91cf 100755 --- a/tools/testing/selftests/netfilter/nft_flowtable.sh +++ b/tools/testing/selftests/netfilter/nft_flowtable.sh @@ -86,12 +86,23 @@ omtu=9000 lmtu=1500 rmtu=2000 +usage(){ + echo "nft_flowtable.sh [OPTIONS]" + echo + echo "MTU options" + echo " -o originator" + echo " -l link" + echo " -r responder" + exit 1 +} + while getopts "o:l:r:" o do case $o in o) omtu=$OPTARG;; l) lmtu=$OPTARG;; r) rmtu=$OPTARG;; + *) usage;; esac done