From patchwork Thu Aug 20 19:11:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 1348613 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=CD71NOED; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BXZ585sxKz9sPf for ; Fri, 21 Aug 2020 05:11:40 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3C1F58236C; Thu, 20 Aug 2020 21:11:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="CD71NOED"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3C3B08236B; Thu, 20 Aug 2020 21:11:32 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B35F88236B for ; Thu, 20 Aug 2020 21:11:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1597950681; bh=UVfJUu+DoH+Em9odPCGQiXjFaYs9vw5QiL7d/4x950g=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=CD71NOEDu1C9jTPu8HqkNCrXHpU4Im6cJHBuAqUNLz3frMF6+9FfDsQQNEjOIO9/H LvvI/Ogev0ohzHgcEZfei3G17TEw4ouf28guwoZuuWDH6Yo/B0l/KAvyKD7UVijyHN kPvYgXAycQlBYCrUdBFdNPa2zPPGrt1Ur8V8Zvf0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([178.202.41.107]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MtwZ4-1kw7fR18yi-00uHZy; Thu, 20 Aug 2020 21:11:21 +0200 From: Heinrich Schuchardt To: Tom Rini Cc: Simon Glass , Bastian Krause , Jan Luebbe , Philippe Reynes , Jonathan Gray , George McCollister , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] lib/rsa: correct check after allocation in fdt_add_bignum() Date: Thu, 20 Aug 2020 21:11:17 +0200 Message-Id: <20200820191117.36849-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:FB3mW2Tpsmqqboy2RobczWXLIlfWTHcQ5m6jLzPyJLIDUGCBb/8 h/6g/n1Jvr2YCWw9mtrWr/jOIQ1GONXUvVRPOZhBNQ7+WhEfVn4bIQjDuA/VGgPOhvmnHOp u8nx20cZbQNKRIquhcrpnHZqg0HFTCL6mfd9CIW9jmP5QmtYgAu08xePRfFD+eqt2DoYNHA 6nccAjqHn4XVNHutA7DXw== X-UI-Out-Filterresults: notjunk:1;V03:K0:BoCL44AZKc4=:XjXsi3f0Fr0Dsjo/vFFJWJ GZ9wckxfS3yuRTrTYhIkJlKc8JrYZdXBJiW0XDDPs9WxzfTpwM7NZw6JZZGnnRbf3Eb90RL9A O34xBTCLEl4eqVwTYM58CIdWi1yfEewXi6GTOgPZ6QkHDErYHS9hzxMd8hiDBAbYuUA8N4siU TBJzk++9Cn9kx3BwNI4YJB5RJCB34qAzndwBF0tERTXDaWOe3EGsWPOGQCsHCoboMHk+K8qBA AdGHp7loCGRng3++tsUg7rmxs06Ou8urnYV371wZZ31ucrIml/5zS2rbM4q/SQr8gQUIlXwkd g0eCOA2K2JeYvh0sYhrDoHgM4Kavk2p/6uCz6Hbdy8Ts60lb9DeCT1/cEEcVKvJ8tgUqdghti AhokxLI0kgTYzuSMSoVthEQyqTqY6WquPNZ+jeLXLRCsMdW7KdDrGpa0mGIm/kjjLa6PwjgFL qnCWxZZQY4t85NGfah40oRf0UQApWEZVtVmtIN7q4ymAPy0p1wXMOYKLTYhOVxCMMPf/oDc1F nlahHFeYq3SvoCDhVGy9jj9DjCXHYkuEU6Vf6iESBni06fgHHTLdnrd5aIm4VJHgdZpI7/tDC DKJdUO+XK+HuKHh8+jlIvYbR0JiNpb4Mz0fhvM+COvMPKJhC+jm3rfMhYoL3NZ158INyZMOs7 grQcoGYoLtFUJxptTQazCQyxOzLxljILQ2x9LWClFZCb43AwQl1YMyHnC7qM6cmxas2/qnqhj 0ejSSHgKw9WJE/RohL1JSmicMY0ddtWVYtZ/o8aAQ7gYcVUtdZWNsz+iEMt8dPMu5x7AMRvQB f4Q66EGKG3KFPQvNSE7zL3NIAcd5j4pl7Dfye9Qe/UM5dSgara+iPmOiqtiFE+Sz+u/qxk5na J1sOyThyztw6bOU2Gz5RfqSaMY9/GyufXgmDGyj3X9AI9hXAtHrQaqmUvLFomdXRGTj3UmWa9 nn27wLar5Fw2xJCG4H8koDP4HK23mi+hAQQOM0wiBjPuRU5dHIK6mFcW1+j1Nlt0XxePDqQEt vI+29GkEKWBxpR6QVZ41V5ZAcJ+eQGhi8HZ/PX9ceQo9IhYAIVSVtFabLDPMucQ3ocURyntEY K8UYfHMzV9KfBetMo6UaTuHFbDx/I4MCptiIpw9k9/JGcotdOWpDHFareXF7/UmQ7l7iNhT7g MwZStwKEukbKmQyQGxelucDbaqgh5hTU89W45Qiu52w6cqccQ5eVYHOIMeJ+C4iOWW4zyCHN9 QbBgJTnNsxteuyR0iC53KsfPxmtYBvEvy9VRcmw== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean After allocating to pointer ctx we should check that pointer and not another pointer already checked above. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- lib/rsa/rsa-sign.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.28.0 diff --git a/lib/rsa/rsa-sign.c b/lib/rsa/rsa-sign.c index 40ca1e1f57..1f0d81bd7a 100644 --- a/lib/rsa/rsa-sign.c +++ b/lib/rsa/rsa-sign.c @@ -708,7 +708,7 @@ static int fdt_add_bignum(void *blob, int noffset, const char *prop_name, return -ENOMEM; } ctx = BN_CTX_new(); - if (!tmp) { + if (!ctx) { fprintf(stderr, "Out of memory (bignum context)\n"); return -ENOMEM; }