From patchwork Fri Aug 14 18:55:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabian Frederick X-Patchwork-Id: 1345171 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=skynet.be Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BSt1q6Y89z9sTF for ; Sat, 15 Aug 2020 04:55:59 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727112AbgHNSzl (ORCPT ); Fri, 14 Aug 2020 14:55:41 -0400 Received: from mailrelay112.isp.belgacom.be ([195.238.20.139]:13738 "EHLO mailrelay112.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726285AbgHNSzl (ORCPT ); Fri, 14 Aug 2020 14:55:41 -0400 IronPort-SDR: psrl8GDBY0a4SrwAWD8aleYzVyoJsX9T3b4VnLT8emiGuEF5TZPJzabP9Eq7lMhKtNT0kKgSvk Vq+DK3F+LQHQRX6Lp9cn3s8ixClZY+CIV43iMbWilvKj9YyFswMQglR6Rn5aaEdc/4o7+q324W umDiQ6ZbpRUwC7L2IKWD2Pc95GnOKxsgv6BU+cMDApitSELq4875NLIQFiDT3lGCOw2WDpyNh+ eaWxEdyLkMqki1fRakLJhMSZ2jGTwbLHQaekV8b4iuffWcpTZK8RJNm7/HqdiYBYoz1oY3g4oF r+4= X-Belgacom-Dynamic: yes IronPort-PHdr: 9a23:5SrVTh8D0kEz8/9uRHKM819IXTAuvvDOBiVQ1KB+0uwVIJqq85mqBkHD//Il1AaPAdyFraMbwLOM6OjJYi8p2d65qncMcZhBBVcuqP49uEgeOvODElDxN/XwbiY3T4xoXV5h+GynYwAOQJ6tL1LdrWev4jEMBx7xKRR6JvjvGo7Vks+7y/2+94fcbglVhTexe7d/IRe5oQnMqMUbj5ZpJ7osxBfOvnZGYfldy3lyJVKUkRb858Ow84Bm/i9Npf8v9NNOXLvjcaggQrNWEDopM2Yu5M32rhbDVheA5mEdUmoNjBVFBRXO4QzgUZfwtiv6sfd92DWfMMbrQ704RSiu4qF2QxLulSwJNSM28HvPh8JwkqxVvRyvqR94zYHbb4+YL+Zyc6DHcN8GX2dNQtpdWipcCY28dYsPCO8BMP5YoYbnvFQOrAGxBQ+xD+3v0D9HmGL50rMg0+QgDQ7G3xErEtUAsHvOt9r1OrwfUfu2zKjIyzXMce9W1S3m54fWax0sp+yHUr1sf8TL00YvCx/FgUuKqYzjJz6b2OcAvmyb4edhVe+jlWAqpQFsrzSz28sglojEiI0axF3Z+yh03ps4KN26RUNlbtCoDJVeuS6eOoV2Qs0uXWVltSAnwbMFoZ62ZCwHxIk9yxLCaPGLbZKE7g/iWeuROzt0mXNodbSijBio60eg0PfzVsys3VZPqSpKj8fDu2gW1xzW9siHUvx9/lq92TqX1wDc9OVEIUcsmKrfLJ4u3qQ/lp4TsUTEBS/2hF/6jKuRdko44Oeo7/noYrLjppCGNo90jBnyMqUomsOhHeQ1KgwDU3WB9eih17Dv41f1TKhLg/A2iKXVrZHXKdwepqGjAg9V1ogj6wy4DzejyNkYk2MII0lLeB+clIjpOFHPIPbmAvejmVijiylky+jcPrL9GpXNMmTDkLD5cLZl8UFT0w4zzddE6pJSFL4BPPzzWk71tNzEEBA5KRa4w+H9CNVyzokeQ36AAreFMKPOtl+F/uEvLPORa48RpjnyN+Mo5/jwgn8ll18dfK2p3YcJZ3CiBPhmJF+ZYXX0iNcbDWgKphY+TPDtiFCaXz5SaW2/X7kg5jEhDIKpE4HDSpqwj7OfxC27BIFZZnhaClCQFnflb4OEVOkQaCKcI89hliAEWqa7S4M4yB6hqhH6xKRjLufP5C0Yuozs1MJv6+3Qix4y7zp0ANqZ022XSGF0hGwITScs3K9juUx91kuD0a9gjvNEEtxT/e1GUhskOpHGyux3ENbyVRzdfteHSVamRsmmDi8rTt4rxN8OeUl9Ec24jh/fxyqqH6MVl7uTCZwy7K3cw2X+KNhjy3vdyqkhgEcpQtFVOW2lmKF/7Q7TCJDNk0mDkKaqb6sc1jbX9Gif1WqOoF1YUAloXKXLR38QfUXWoM/i5kPBT76uD6ooMhdbxcGZNKQZIuHu2E1PTvPkENLTf2ywn3u9H1CP3LzIJInjd2EQ1w3bBVQKkgQP8GzAMhIxQm+vvErFECZqGFSpb06/3/N5rSaVR0U1xgfCQVds27ev+xUWzaiSQvkd9qkHqSEst3N+EQDujJrtF9Ocql85L+1natQn7QIf2A== X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2CCBADp3DZf/xCltltegRCBQ4MaVF+NOJI1kXsLAQEBAQEBAQEBJw0BAgQBAYRMgkolNwYOAgMBAQEDAgUBAQYBAQEBAQEFBAGGD0WCNyKDUQEjI4E/EoMmAYJXKbImgiiEEIUagUCBOIgihRWBQT+BEYNOhASGMAS2LoJsgwuEWn6RLQ8hoB+SOKFNgXtNIBiDJAlHGQ2caEIwNwIGCgEBAwlXAT0BjUaCRgEB X-IPAS-Result: A2CCBADp3DZf/xCltltegRCBQ4MaVF+NOJI1kXsLAQEBAQEBAQEBJw0BAgQBAYRMgkolNwYOAgMBAQEDAgUBAQYBAQEBAQEFBAGGD0WCNyKDUQEjI4E/EoMmAYJXKbImgiiEEIUagUCBOIgihRWBQT+BEYNOhASGMAS2LoJsgwuEWn6RLQ8hoB+SOKFNgXtNIBiDJAlHGQ2caEIwNwIGCgEBAwlXAT0BjUaCRgEB Received: from 16.165-182-91.adsl-dyn.isp.belgacom.be (HELO localhost.localdomain) ([91.182.165.16]) by relay.skynet.be with ESMTP; 14 Aug 2020 20:55:37 +0200 From: Fabian Frederick To: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, Fabian Frederick Subject: [PATCH 1/2 nf] selftests: netfilter: fix header example Date: Fri, 14 Aug 2020 20:55:22 +0200 Message-Id: <20200814185522.8677-1-fabf@skynet.be> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org nft_flowtable.sh is made for bash not sh. Also give values which not return "RTNETLINK answers: Invalid argument" Signed-off-by: Fabian Frederick --- tools/testing/selftests/netfilter/nft_flowtable.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/netfilter/nft_flowtable.sh b/tools/testing/selftests/netfilter/nft_flowtable.sh index a47d1d8322104..28e32fddf9b2c 100755 --- a/tools/testing/selftests/netfilter/nft_flowtable.sh +++ b/tools/testing/selftests/netfilter/nft_flowtable.sh @@ -11,7 +11,7 @@ # result in fragmentation and/or PMTU discovery. # # You can check with different Orgininator/Link/Responder MTU eg: -# sh nft_flowtable.sh -o1000 -l500 -r100 +# nft_flowtable.sh -o8000 -l1500 -r2000 # From patchwork Fri Aug 14 18:55:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabian Frederick X-Patchwork-Id: 1345173 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=skynet.be Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BSt285swZz9sTF for ; Sat, 15 Aug 2020 04:56:16 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727817AbgHNS4L (ORCPT ); Fri, 14 Aug 2020 14:56:11 -0400 Received: from mailrelay112.isp.belgacom.be ([195.238.20.139]:13761 "EHLO mailrelay112.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726285AbgHNS4L (ORCPT ); Fri, 14 Aug 2020 14:56:11 -0400 IronPort-SDR: 9TuJwu26yOeK04zBZN2TX7Uvmgr2RDvJZfpHIzdm4x3qIonySFcZfyokTKJHAzt0m2Xyej8aRH psFGO0CB6UHpfPZj/HD6pSN0fIOe/xd4MgqHyYggqEeU2nHDZJSHbcdtYHjMA2wnUlsUfJEir5 1+EdlJQWg5HJUdYMiL7id9uK43N4D3seenVHRjsBXM8CiVYP2XXRMaOkLYjBRfgFeZ4lTWnQVc wrW5l5IhoEys3fzsW7L4dO1lXXV1vI7KKUMCrQEyJUgMljMXXgiFYHonRSV/VU+PgkRlfO/4SS xR8= X-Belgacom-Dynamic: yes IronPort-PHdr: 9a23:iEK63BKoRDme/GWajNmcpTZWNBhigK39O0sv0rFitYgXK/r4rarrMEGX3/hxlliBBdydt6sazbuJ+Pm6AiQp2tWoiDg6aptCVhsI2409vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6nK94iQPFRrhKAF7Ovr6GpLIj8Swyuu+54Dfbx9HiTagYL5+NhG7oAfeusULn4dvJLs6xwfUrHdPZ+lY335jK0iJnxb76Mew/Zpj/DpVtvk86cNOUrj0crohQ7BAAzsoL2465MvwtRneVgSP/WcTUn8XkhVTHQfI6gzxU4rrvSv7sup93zSaPdHzQLspVzmu87tnRRn1gyoBKjU38nzYitZogaxbvhyvuhJxzY3Tbo6aO/RzZb/RcNAASGZdRMtdSzBND4WhZIUPFeoBOuNYopH9qVQUthS+BBOjBOXywTFInH/5w7A13Po7EQHHwAMgHM8FvXParNrvL6gSX/u4zLLLzTTDafNZxyv95JLTfR8/uPyBW697fsXNx0c1DQzFkkmQppL/PzOTzukDvWuW4u5gW++ui2MrtQ98rDiyy8swl4XFmoMYxF/L+yhkzos4O8C1RU55bNO6H5Vcqy+UOYRyT80iQ29kpiI3x7sbspC4ZCgH0JAqywPFZ/CacIWE/AjvWPuQLDp4nn5pZbOyihCv+ka60OL8TNO70FNSoypAldnDq24C2gTI6siCVvt95kCh2SuT1wzL6uFLP0Q0la3DJp4lxb4/ioAcsUDDHi/xg0X2kLWadkEj+ue08evnZqjpppiZN4BuiwH+NLwims25AesmLggDR2yW9fmm2LH+/kD1Xq9GguA3n6TZqpzWOMUWqra8AwBP04Yj7xi/Dy2h0NQdhXQHIkhKdwmJj4XyIFHOI/D5DfGhjFSwijtk3O7JMqX7AprRNnjDjKvhfbFl5k5E0gU81tRf55VPB7EHPv3zRkHxtN3cDh8lLQO02fzrCNJn1oMRQWiPGLOWMLvOsV+U4eIiO+qMa5UItzb5Nfcq++XjjXknll8Bc6mp3J8XaGymEfR8OUmZZmDsgtgZG2cQogU+VPDqiEGFUTNLaXazUbkx5ionCIK8CYfMWIatjKac0yilBpdWfHxJCkiQEXf0cIWJQ/EMZzyOIs9vkzwEUaShRJE71R23qQD11aRnIfTQ+iADq5Lj28Z65/fJmREx6zN0FcKd3H+JT21umWMIXTA21rhloUNh0leDzbR4g/tAGNNP4PNJSBk1NYLCwONgDtD/QQTBccmVSFaoQ9WmBS0xQcwrw9MUZEZ9AdqihAjZ3yW2G78Vi6CLBJss/6LawXfxO9tyxGjY1KQ6kVkmTdVANXe8iq586QfTHYjJnFudl6qwcqQcxiHN/n+ZzWWSpEFYTBJwUaLdUHARfETZttr561jZT7+tCbUnNBVOydKYJqRRdNK6xWlBEe/qMtDZS2S8h2mxAQqF3PWLdoWuM2YU0CHQA2ACnhwd/HKaOBJ4AT2u5yrQExR1CUjrbkWq/eQthmm8SxoaxguLZksp+aC49hMPhPefA6cd17gKkDwiujN5ABC30oSFWJK7uwN9cfAEMpsG61Bd2DeBug== X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2AFBQD83TZf/xCltlteHgEBCxIMR4RdVF+NOJI0kXsLAQEBAQEBAQEBJw0BAgQBAYRMgkolOBMCAwEBAQMCBQEBBgEBAQEBAQUEAYYPRYI3IoNRASMjgT8JCYMmAYJXKbRLhBCFGoFAgTiIIoUVgUE/hF+KNAS2LoJsgwuEWn6RLQ8hoB+SOKFOgXpNIBiDJAlHGQ2caEIwNwIGCgEBAwlXAT0BkAwBAQ X-IPAS-Result: A2AFBQD83TZf/xCltlteHgEBCxIMR4RdVF+NOJI0kXsLAQEBAQEBAQEBJw0BAgQBAYRMgkolOBMCAwEBAQMCBQEBBgEBAQEBAQUEAYYPRYI3IoNRASMjgT8JCYMmAYJXKbRLhBCFGoFAgTiIIoUVgUE/hF+KNAS2LoJsgwuEWn6RLQ8hoB+SOKFOgXpNIBiDJAlHGQ2caEIwNwIGCgEBAwlXAT0BkAwBAQ Received: from 16.165-182-91.adsl-dyn.isp.belgacom.be (HELO localhost.localdomain) ([91.182.165.16]) by relay.skynet.be with ESMTP; 14 Aug 2020 20:56:01 +0200 From: Fabian Frederick To: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, Fabian Frederick Subject: [PATCH 2/2 nf] selftests: netfilter: exit on invalid parameters Date: Fri, 14 Aug 2020 20:55:44 +0200 Message-Id: <20200814185544.8732-1-fabf@skynet.be> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org exit script with comments when parameters are wrong during address addition. No need for a message when trying to change MTU with lower values: output is self-explanatory Signed-off-by: Fabian Frederick --- tools/testing/selftests/netfilter/nft_flowtable.sh | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/tools/testing/selftests/netfilter/nft_flowtable.sh b/tools/testing/selftests/netfilter/nft_flowtable.sh index 28e32fddf9b2c..c3617d0037f2e 100755 --- a/tools/testing/selftests/netfilter/nft_flowtable.sh +++ b/tools/testing/selftests/netfilter/nft_flowtable.sh @@ -97,9 +97,17 @@ do done ip -net nsr1 link set veth0 mtu $omtu +if [ $? -ne 0 ]; then + exit 1 +fi + ip -net ns1 link set eth0 mtu $omtu ip -net nsr2 link set veth1 mtu $rmtu +if [ $? -ne 0 ]; then + exit 1 +fi + ip -net ns2 link set eth0 mtu $rmtu # transfer-net between nsr1 and nsr2. @@ -119,6 +127,11 @@ for i in 1 2; do ip -net ns$i addr add 10.0.$i.99/24 dev eth0 ip -net ns$i route add default via 10.0.$i.1 ip -net ns$i addr add dead:$i::99/64 dev eth0 + if [ $? -ne 0 ]; then + echo "ERROR: Check Originator/Responder values (problem during address addition)" 1>&2 + exit 1 + fi + ip -net ns$i route add default via dead:$i::1 ip netns exec ns$i sysctl net.ipv4.tcp_no_metrics_save=1 > /dev/null