From patchwork Fri Jul 31 10:49:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florinel Iordache X-Patchwork-Id: 1339388 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=XzpZkur3; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BJ3vg69gtz9sTH for ; Fri, 31 Jul 2020 20:50:07 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732641AbgGaKuB (ORCPT ); Fri, 31 Jul 2020 06:50:01 -0400 Received: from mail-eopbgr70048.outbound.protection.outlook.com ([40.107.7.48]:53202 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732603AbgGaKuA (ORCPT ); Fri, 31 Jul 2020 06:50:00 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JQhv+EGDbVFfm0Dv5glEzEDuorBzHdiQZYwJnNRoE3dT/P3cHZpHxdhc+PsExlFcY7wghLzN3RpS0hLL42ox5UFDto6DcqGgtBy6dlgL/iZX4BqgbDfltykZQ6XvFRNUZVH6EDk4cvrwPYdYp4FFTZRnz31GXOD5muaZoCR+WClJIl+ZKmDDKHw7W3QZ9egcfCbrAfOu7ZIn6cFr7AAoU9ktqh/rSMKpFIZO+YSLXwEnA526UBYDMf7SmONHIsCnDv7RnTRVuZbwgoFzOex30hgXvNJDsWTrb7Kn06DjPJs4t4D1vTYwIY9DT4qFNKnrmiW4HS8rT1DnAhfrWsYQzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oOGDrzulmvnKGN8hdODRkozbekDRrPzUqJw6EPSdwDc=; b=E12nSuYqZOhTA5GZdiJ/tGvNdCIKv6cbL1eX3SmFnhoOMn/6kLOwyXKHWZZhv8kjXZ3FWuRRR1vrVU+A8uxuUj7SaTgvYxvYYxVjgJvkOgCamfnh/e5XY2RhvVVS44Gq6WHubndbtlQ1+J452LpN0PQfDdB/55lhDhSm+wdtYYPRLqIIvKm3t2uSIcL4irKTA734k6sBaoas4luVSOUTXqmRRu4n+vQ3EeRfDt5zq5Sbtmenp0a6RYDZuMvVk3p1vgyEoxrhasoAR9JbA82ClwH1ldlWHING/LYmg5Vjoai9q5NVLYyb0rQNU/O4WYsbKpyzyIBqLWkT23magC/rTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oOGDrzulmvnKGN8hdODRkozbekDRrPzUqJw6EPSdwDc=; b=XzpZkur3cs6xNHgTw3yQODdOBHahuAHKwvjnNo0IHoBVbMA2x4+kB8dJwIvzNMs8p9TJwAPTtJQIEz39bIoRSu5OAzzo/orIPgQD+ZzqaHT+NsCqRRR5nnVAE+UB4jO0F13VnXdGTr+IngNwtU0PkwlC4QVCZxTFOL4ooeCGibU= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB5447.eurprd04.prod.outlook.com (2603:10a6:20b:94::20) by AM6PR04MB5943.eurprd04.prod.outlook.com (2603:10a6:20b:99::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.20; Fri, 31 Jul 2020 10:49:54 +0000 Received: from AM6PR04MB5447.eurprd04.prod.outlook.com ([fe80::e115:af36:613c:5a99]) by AM6PR04MB5447.eurprd04.prod.outlook.com ([fe80::e115:af36:613c:5a99%5]) with mapi id 15.20.3239.019; Fri, 31 Jul 2020 10:49:54 +0000 From: Florinel Iordache To: madalin.bucur@nxp.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Markus.Elfring@web.de Cc: linux-kernel@vger.kernel.org, Florinel Iordache Subject: [PATCH net v2 1/5] fsl/fman: use 32-bit unsigned integer Date: Fri, 31 Jul 2020 13:49:18 +0300 Message-Id: <1596192562-7629-2-git-send-email-florinel.iordache@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1596192562-7629-1-git-send-email-florinel.iordache@nxp.com> References: <1596192562-7629-1-git-send-email-florinel.iordache@nxp.com> Reply-to: florinel.iordache@nxp.com X-ClientProxiedBy: AM0PR04CA0103.eurprd04.prod.outlook.com (2603:10a6:208:be::44) To AM6PR04MB5447.eurprd04.prod.outlook.com (2603:10a6:20b:94::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from fsr-ub1464-128.ea.freescale.net (83.217.231.2) by AM0PR04CA0103.eurprd04.prod.outlook.com (2603:10a6:208:be::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3239.16 via Frontend Transport; Fri, 31 Jul 2020 10:49:53 +0000 X-Mailer: git-send-email 1.9.1 X-Originating-IP: [83.217.231.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2e63d8d3-56fd-4845-2086-08d8353f7546 X-MS-TrafficTypeDiagnostic: AM6PR04MB5943: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X4AsY/lp/aEM3DqP5ajNFGzYgTjfj3MFVsW+Hecz7XZDoWGhNgxtQABPFIe/NJxvvQ90jQzdOVteJ3uS0lPZtr5yWpeFpz9VAkKu9bRVH/EjB6yV1vtfO1RsUFZuv/wwt7a18cHmb2vZXlOxzC8n0EBfpQqnTaTJMci2kECJ0anv6WPdD/JDuR1e+uR/mg6u9tKgrkVTBOIZTQ9hjZnbXK4Eba6AibxZ4h2G7UkjB6CEP0SEoIEclMpn8fi8SMjtYGzWQS3y2llSzYXrHrcZkExTmUXg5BmxqvosR4L1E7o3GLhPDmc8AhDE5o2viR4mjflN2gXbn7JaVXTYW7y8Qw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB5447.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(366004)(376002)(346002)(39860400002)(3450700001)(6666004)(478600001)(83380400001)(36756003)(52116002)(2906002)(4326008)(6486002)(316002)(66946007)(66556008)(6512007)(5660300002)(8676002)(86362001)(8936002)(956004)(2616005)(186003)(16526019)(26005)(44832011)(6506007)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: VHOysgUjux84JeJHrOO2ni0jRWNoVWXQn1tHSYciin46/K5vteZExta5iGun4MW5cbIhiIXr/+J1chBHBjRB7CyL+gjRWd9jj2rrQ8hkaHFpIkfFaRKL8Sks0Smbrx2wwO+Jdg6HK3Ar8wVgS+KhgJ+HeE2xZWvh2hhdAHuyknF32HWsA3eoi1eewQN634MSh9u1ApGL8G384I977ANZtWy8EafYBMAJnmpTt2JglY12ILOgW+n+9mqz1aiFOsqDmLSZRJqMJmfEVw7yCV+ZWGoAImg0p1NAL2/Y3yrJXcUVVXjdjqN6Z0epg7+CiCWzKneGXmMXuULJbDhKbVkPEMnGgJCoHacIuDSeRYMtVEhr31whlD30LZgObXOGUlIpXOceCgQG6ZUYMuswsKub190Ezl1oU4QFKT+FGj8XIUEu0QB64XZIx4BuZ7S0jXvMv0BYg9LjKaTj8n2qT61olvJTGDOxHJMbqZaZWJZEHMU594l6G9UMo85lo/Qy3yMmIzWx3EuR7ILOJuaK8zRg4Ymw/iwZOw3MKwsM3IvDoYaMQxXxQdN7rCDE1ZuL67oZwx3q3iIwPTZTRLWDeos98vR3Sfy3D/Ws3a3n7ZvDilagZyITrEAnO+tMGVCHvmW6WGgh379A71LBhgHeDEAJDw== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e63d8d3-56fd-4845-2086-08d8353f7546 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5447.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2020 10:49:54.1056 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C0REAXgKmkT5SeFXe5c9Qmt2q0pSeeKqogHIaj/vs7k9TdFJ9jqM/9cn4kbwdPvyE7Ly32+yBvkT4gGfgljFnFv2H2AxSvw+OCZScjQ4k/4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5943 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Potentially overflowing expression (ts_freq << 16 and intgr << 16) declared as type u32 (32-bit unsigned) is evaluated using 32-bit arithmetic and then used in a context that expects an expression of type u64 (64-bit unsigned) which ultimately is used as 16-bit unsigned by typecasting to u16. Fixed by using an unsigned 32-bit integer since the value is truncated anyway in the end. Fixes: 414fd46e7762 ("fsl/fman: Add FMan support") Signed-off-by: Florinel Iordache --- drivers/net/ethernet/freescale/fman/fman.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c index f151d6e..ef67e85 100644 --- a/drivers/net/ethernet/freescale/fman/fman.c +++ b/drivers/net/ethernet/freescale/fman/fman.c @@ -1398,8 +1398,7 @@ static void enable_time_stamp(struct fman *fman) { struct fman_fpm_regs __iomem *fpm_rg = fman->fpm_regs; u16 fm_clk_freq = fman->state->fm_clk_freq; - u32 tmp, intgr, ts_freq; - u64 frac; + u32 tmp, intgr, ts_freq, frac; ts_freq = (u32)(1 << fman->state->count1_micro_bit); /* configure timestamp so that bit 8 will count 1 microsecond From patchwork Fri Jul 31 10:49:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florinel Iordache X-Patchwork-Id: 1339389 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=WAQL007b; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BJ3vh4gcCz9sTM for ; Fri, 31 Jul 2020 20:50:08 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732668AbgGaKuG (ORCPT ); Fri, 31 Jul 2020 06:50:06 -0400 Received: from mail-eopbgr70048.outbound.protection.outlook.com ([40.107.7.48]:53202 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729141AbgGaKuE (ORCPT ); Fri, 31 Jul 2020 06:50:04 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UEwjgqPEftPQ8JhzI5FCCSg7My7qQWZ2P8KFZbjhBuQFCTxt7lqtO9eEuQyTd+HI3nDE6C8hFXYaENQLcSh8cXZNavMOYQkFc+xkIIPqNjdJp4H4Uu3516U2EuWOs7nUKnU2GazqVvK1NnyI7vd8j4rgBVWbIzFFSth7LYfJ1PyGtLaUkeoN4n5+M08LVK12pq6dXPAF6w2UxMRaF6LHwMW6cllpVLFpEk8iFyGG7uCCtYCH1Frvnk5HIs3kDka4f8ksTQ+NGGYDs2ZWEbYHcKdg0Pxti3LwGKmZVOMs4MuFc4w6hG3XCEytexDgA2+2NFeKZgNJV/e7BQED79T54Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pG+1wGl8C1SXGE9DMjN6YD3DGi4ootrNph4b4P63Jog=; b=IG4j4cYZW1/wRP8TnboEUhzJmXapF7GG76wWE4ABz2hk0kaxkjwotpPlhXRCHv7Ocb/kKY05VdOaPahVv4WPmvuYeJ0Dg6LQAukki/I0HWLnOG4myNNwgyRy7qx4CK2HV4uHRCKR/mQvmWfLyj/Hh9V8DscaJgqlC2gkruhqqBxV2iQEIVI2fRtaV4yX9YD4wD7wjLVu/SqVv7UrMQOMW8fTNETGFMSFjRp49KGcvD6t9k3ZxoK5NMM6P/8m8zzU0BiyhYHxKU1xLJawjD+XxT4F//Fgzwn+PEPKqStQbCyilyfVmytyFlJt93b0n9dtX6p/+7zhVWU9mTvUHpHnxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pG+1wGl8C1SXGE9DMjN6YD3DGi4ootrNph4b4P63Jog=; b=WAQL007bYLb9U+s1mA9ZOpzs2YZUdD86naSep5tyxZiw9QEbRpfYc3Zzm2Vkv8xhXC7mofmFgGADgDozZOJ1bfWk9zkSmlZj09qg/haEyyXG+upn+9tzGE6vidyH3WGyevQU2HYN+tKNguq7h3+z7S36E9+Mvelkvz/Az8EfFIo= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB5447.eurprd04.prod.outlook.com (2603:10a6:20b:94::20) by AM6PR04MB5943.eurprd04.prod.outlook.com (2603:10a6:20b:99::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.20; Fri, 31 Jul 2020 10:49:55 +0000 Received: from AM6PR04MB5447.eurprd04.prod.outlook.com ([fe80::e115:af36:613c:5a99]) by AM6PR04MB5447.eurprd04.prod.outlook.com ([fe80::e115:af36:613c:5a99%5]) with mapi id 15.20.3239.019; Fri, 31 Jul 2020 10:49:54 +0000 From: Florinel Iordache To: madalin.bucur@nxp.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Markus.Elfring@web.de Cc: linux-kernel@vger.kernel.org, Florinel Iordache Subject: [PATCH net v2 2/5] fsl/fman: fix dereference null return value Date: Fri, 31 Jul 2020 13:49:19 +0300 Message-Id: <1596192562-7629-3-git-send-email-florinel.iordache@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1596192562-7629-1-git-send-email-florinel.iordache@nxp.com> References: <1596192562-7629-1-git-send-email-florinel.iordache@nxp.com> Reply-to: florinel.iordache@nxp.com X-ClientProxiedBy: AM0PR04CA0103.eurprd04.prod.outlook.com (2603:10a6:208:be::44) To AM6PR04MB5447.eurprd04.prod.outlook.com (2603:10a6:20b:94::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from fsr-ub1464-128.ea.freescale.net (83.217.231.2) by AM0PR04CA0103.eurprd04.prod.outlook.com (2603:10a6:208:be::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3239.16 via Frontend Transport; Fri, 31 Jul 2020 10:49:54 +0000 X-Mailer: git-send-email 1.9.1 X-Originating-IP: [83.217.231.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f3bfa406-8c14-4d1e-6c6b-08d8353f75b0 X-MS-TrafficTypeDiagnostic: AM6PR04MB5943: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:475; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 28/lLwsAvWRe+wAvgFWmPU6TLl5GE37kDii966o+TcxGDSHxCjdm5lblbcCFnq1uecwNTbaNyI7VZF4HkKIN4WCn5f4wK5HJeN/1H0NfDTSe8bgVqZ/Jsrft/ZPRcQ4D0yK4cNHW53zKIwxILrN90Sv34aF5EPC/O5IRZYWvvRPkedYdUlU3QiyATFIYNJ2yDkKUvEWGkggHAHva7ebBMtR03CGarI50Kcn0JDQWOvejMqKX3YBSzQx05jK16kLNmVlg06b6TU8xbGxT+T4x1fVVHOP5zuK6Ek7LYyOiZvi2gBb79Qw7VhaeVv5MA/l0tJpna2WVFBrOo9UO0OB1CA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB5447.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(366004)(376002)(346002)(39860400002)(3450700001)(6666004)(478600001)(83380400001)(36756003)(52116002)(2906002)(4326008)(6486002)(316002)(66946007)(66556008)(6512007)(5660300002)(8676002)(86362001)(8936002)(956004)(2616005)(186003)(16526019)(26005)(44832011)(6506007)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 9p3eLu7o9q2/uYs6JGUoquhQQQsQ4k05PPe9BWTiJ/cTXLT8qFKb4QbSLAyNcqya0qQE7oNCFOtb2KdUhdTqHeG2CWoJW8hX0IZzdR7EJGwAIrmfFdfJCspUHeruo5CJfEIRFJjwa3o2HuoIKW59pxu4csWSVZ0AdiTqcypvshk0BeVWCuQud65b1uixIFfW6w03O+SX/KekdJaqg9LqBDpQT5zxkxTTl4CG2Xk8zfqRj2/Yev7wweal2b/jEI6rgVMwLGIQgYxDN/ADgaO5mWqjU/QkcV9n3vONWnFTUv8BohWiXTRyjd8R4mrPrHQUq3BCohfFPh57nYQcg7MPzkeOAQjt+vz1x18ii2pQ2JX80+L6BqFX7RpODqfvyydpsvbO/Udpttftq8nZQ3I3FveSS0eNlz2Z5Etp2chQbXOtujT50U68DtGvDzATEOZ7HFJuNMksf/6o5rQyrTA191aYu1o7q9iG2/hpDnfkpbVGG6Xvs+tlpcLnbENJZID2tYfZxGy1zL6Zl3XxW4UE7O8tNU3Btiu77VJKxH1PeU4lw6wRwx8Izhcij0EhJBg8+I9hoyII69+ptfe3mCDTelChIBVIKMHIAUT6zC2VB4uo4QwmWABMoeyl8QGAX71xV6duttHOFJ5j4OT7Y9r4ag== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3bfa406-8c14-4d1e-6c6b-08d8353f75b0 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5447.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2020 10:49:54.9022 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZpEfbCYDKy62X8L0cT2JOQAwFz1TS8lWCzipDvj8eQCjXDHdZ4+/TnLSNhRBDWHVStUt1hX2tlfEQyL0BiXApu4/Msw7sPR+BGqsq4Iycok= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5943 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Check before using returned value to avoid dereferencing null pointer. Fixes: 18a6c85fcc78 ("fsl/fman: Add FMan Port Support") Signed-off-by: Florinel Iordache --- drivers/net/ethernet/freescale/fman/fman_port.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fman/fman_port.c b/drivers/net/ethernet/freescale/fman/fman_port.c index 87b26f0..c27df15 100644 --- a/drivers/net/ethernet/freescale/fman/fman_port.c +++ b/drivers/net/ethernet/freescale/fman/fman_port.c @@ -1767,6 +1767,7 @@ static int fman_port_probe(struct platform_device *of_dev) struct fman_port *port; struct fman *fman; struct device_node *fm_node, *port_node; + struct platform_device *fm_pdev; struct resource res; struct resource *dev_res; u32 val; @@ -1791,8 +1792,14 @@ static int fman_port_probe(struct platform_device *of_dev) goto return_err; } - fman = dev_get_drvdata(&of_find_device_by_node(fm_node)->dev); + fm_pdev = of_find_device_by_node(fm_node); of_node_put(fm_node); + if (!fm_pdev) { + err = -EINVAL; + goto return_err; + } + + fman = dev_get_drvdata(&fm_pdev->dev); if (!fman) { err = -EINVAL; goto return_err; From patchwork Fri Jul 31 10:49:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florinel Iordache X-Patchwork-Id: 1339390 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=V85PCcNI; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BJ3vn6gTcz9sTM for ; Fri, 31 Jul 2020 20:50:13 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732688AbgGaKuL (ORCPT ); Fri, 31 Jul 2020 06:50:11 -0400 Received: from mail-eopbgr70048.outbound.protection.outlook.com ([40.107.7.48]:53202 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732603AbgGaKuI (ORCPT ); Fri, 31 Jul 2020 06:50:08 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RpHXpIDQUcZ950Mz4lzYVTDB3MH3bVEiS6ScpaZltLI9kc2uWC6rqT8w8kdRp0QHkJ28a+rqjo+qqbA2ICVfUqCS8Nifk1lvNfzSBriv2dJoqcZPEvpMCZBujsKX4e4L5973OTtGACkpqnTHuNVWUjQG3epeW6eL+2PwUq39LiB9MiteJIOMzJvnrxUmDyJAAuJ1ne45My6Oq93jOO8O3c5GFRxz5hdbpeHMHY9z7PMnjmFilNvv0rGlfSI/U92xrtgQHLLA8WqvcrvnCBMVMHAr0qH0/TKLXlrSo80PuoqmOgBZ2tCn8D5MW9Q8+P5tP0w33G93Csn+eBCwIoKktQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c6GlLuC1+27Yc2RsbK8XJ2jfktPx4G5JeeDQhlePDeI=; b=U2Rmr6zkqRgNI/AaV6BpYRmUFIW0beLG1UH3fmW6PFPrkLt4JJWMBSpUl6EqBDUzMLgrul50NK7DjloteCXS8+CQkDyU84trHnf6CTNaFRRyHWrfw1Lf502jhdjcCJXBSPpKjrsMNkGdyzxhy9RjWesfM0ZHnkd+LAwnAusLAfz21GhIS8qnsbigmk8PFYEmx4tXfBI1U+I/wwR7F5l0qprGyfhDRWPG8llC3NqJzzQEwEKq32Xb+mkaH537eivwFtI9UbMabcGTB/lRIJUdTVMWabvzmdU9qwzIBkdB3Y4vmvRS2GidrthA6PwXeKm09/yKzGpHxvKpgfNAwNo4tQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c6GlLuC1+27Yc2RsbK8XJ2jfktPx4G5JeeDQhlePDeI=; b=V85PCcNILpVNiGuHVPqRWNVTXEWD5DPV0riE/73I2S9t0auhv7kf5sFiRmiJZMFhM7BWqAEIE3JM9eQXenBsYMlZPSWGIlMAhDqsB2jWnL8gdh3LlgZHbXYToXYZTSjhZ6NbvmMgLPcNPQFNEVr9ATMBWT+Wm/vhsN8tEk4p5SA= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB5447.eurprd04.prod.outlook.com (2603:10a6:20b:94::20) by AM6PR04MB5943.eurprd04.prod.outlook.com (2603:10a6:20b:99::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.20; Fri, 31 Jul 2020 10:49:55 +0000 Received: from AM6PR04MB5447.eurprd04.prod.outlook.com ([fe80::e115:af36:613c:5a99]) by AM6PR04MB5447.eurprd04.prod.outlook.com ([fe80::e115:af36:613c:5a99%5]) with mapi id 15.20.3239.019; Fri, 31 Jul 2020 10:49:55 +0000 From: Florinel Iordache To: madalin.bucur@nxp.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Markus.Elfring@web.de Cc: linux-kernel@vger.kernel.org, Florinel Iordache Subject: [PATCH net v2 3/5] fsl/fman: fix unreachable code Date: Fri, 31 Jul 2020 13:49:20 +0300 Message-Id: <1596192562-7629-4-git-send-email-florinel.iordache@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1596192562-7629-1-git-send-email-florinel.iordache@nxp.com> References: <1596192562-7629-1-git-send-email-florinel.iordache@nxp.com> Reply-to: florinel.iordache@nxp.com X-ClientProxiedBy: AM0PR04CA0103.eurprd04.prod.outlook.com (2603:10a6:208:be::44) To AM6PR04MB5447.eurprd04.prod.outlook.com (2603:10a6:20b:94::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from fsr-ub1464-128.ea.freescale.net (83.217.231.2) by AM0PR04CA0103.eurprd04.prod.outlook.com (2603:10a6:208:be::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3239.16 via Frontend Transport; Fri, 31 Jul 2020 10:49:55 +0000 X-Mailer: git-send-email 1.9.1 X-Originating-IP: [83.217.231.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: debe6ea2-c224-43e6-c49d-08d8353f7626 X-MS-TrafficTypeDiagnostic: AM6PR04MB5943: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3631; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7DEhBArrda9sHwzvPR5xbUXBtubCTuDYo50UdPocq5ni4RQsP97Im8aZupUnqpSWij2mRi38iPbREtVL80NmWjz4F4Yow/XipB34YO3VmY40O+BGC1Qasbu2zu1STU1IRecpm9kq7JKLtfdMsRrHjO0Yhs+zAYIqk8GOzmlL53pG6zKFHZBINx0cpa3O8k7w+T1R2UQLL4Mzo6WTcv7uxWplwGnaGfxArNIxIdXwpSHN1v5WVeomJXMEQDBmWV5/1OFffrtD0iqYnabLA0eCYyQqRmj6NF8Xm+YFBKuMQAN0M0+TavVRki44l9lN6H0W8j6VD0XOTdproDLgJM/TLA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB5447.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(366004)(376002)(346002)(39860400002)(3450700001)(6666004)(478600001)(83380400001)(36756003)(52116002)(2906002)(4326008)(6486002)(316002)(66946007)(66556008)(6512007)(5660300002)(8676002)(86362001)(8936002)(4744005)(956004)(2616005)(186003)(16526019)(26005)(44832011)(6506007)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 1WNSESmY888oLJ/mCYV0hyDcC9t93b0WCm5bB977rbhEoK46lcqd2IEII54KVtu9oRSuQfrVEdjZCnXSTC5toi3aUv6+7YqZO9PtfWLEqbhaizDRnw/ZqODx06NB4W3GjO7syuWaxMZgTvoTw78mU8zUNqRSEq6tY83+465zadvo/AgbexccMoKpT/JfaChGZQNs1KML9hxsMig5pAOLneqJtInJQxTh0Z0YgeIFSHOSS3Uqr0gpqo3VFhMJ3LxVSpNof+RQOVq2jqYxqLqOSc+aSZj811dslwiYvDeu61V5bL0dY+GoJQTgCqU9H60/JJD83PCFfYZIWB5Vhb4wGjJDPQuFZc8v2ffuRcQEWFfEk5QX7Raem5R7pMCFWObHv0kc0kUJ+vwj+Kdlv23281432fXlGzq8G1ourA6pTnJLu0jcz5Dx0TWL7JH30pL+pQdiURAlDu77s7IqSQp/bWaIsAqiXLmxOVeus5LcRMKBavohq790pCQSLC2+e0bvbd4m090Gbw4LsczN/lrRlB4hAiv9pjdptSGDll8IQvScNYJ39iC+DmfoRPGCIID8n3iXwSjKiLYMVbx/pHin5Xbhx3d+LkTCrGYEXuwl/QetaBRP9PsieHnctZHhmsDHMUdr5ziQe4SRppnurCVLyg== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: debe6ea2-c224-43e6-c49d-08d8353f7626 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5447.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2020 10:49:55.5928 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x6+57e4hr+Dd/9Hwock3QmSyfSStULz+CmOzPBnHtehehpVkxLsmW6A5/AkSsXY7gFbEH+HDwcfEHdc6VjRm4hUlx6sBAx8mx5Cl0QcRgYk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5943 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The parameter 'priority' is incorrectly forced to zero which ultimately induces logically dead code in the subsequent lines. Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support") Signed-off-by: Florinel Iordache --- drivers/net/ethernet/freescale/fman/fman_memac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c index a5500ed..bb02b37 100644 --- a/drivers/net/ethernet/freescale/fman/fman_memac.c +++ b/drivers/net/ethernet/freescale/fman/fman_memac.c @@ -852,7 +852,6 @@ int memac_set_tx_pause_frames(struct fman_mac *memac, u8 priority, tmp = ioread32be(®s->command_config); tmp &= ~CMD_CFG_PFC_MODE; - priority = 0; iowrite32be(tmp, ®s->command_config); From patchwork Fri Jul 31 10:49:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florinel Iordache X-Patchwork-Id: 1339391 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=dYp1R9Ae; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BJ3vt3v8nz9sTM for ; Fri, 31 Jul 2020 20:50:18 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732708AbgGaKuO (ORCPT ); Fri, 31 Jul 2020 06:50:14 -0400 Received: from mail-eopbgr70048.outbound.protection.outlook.com ([40.107.7.48]:53202 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729141AbgGaKuN (ORCPT ); Fri, 31 Jul 2020 06:50:13 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P7pOc0ZwqcEFuGuFm2wcwzco1WY3fO13omEiI4H8M8uNTAkk5cb2vVcadDf0WTRU+rBEBM8BhD6VQ/n4citgMCmGhd2ImmOGl2P9qcIlMlvv0OuxFTDue/FLeERi7FEzy6l3KrAhzZGfhHe9FfbSc/ahht82TNrGqYDog1CPlgerpY4mDCsFxm+Or37nEQ/+qmHRI5QhSbPnV146kgQ7M245cDWvUFKndXxjl7LKgJ44Dq7iyTtUNbqtpJFcODAEIyFTU+jn2RnfyDUUuQ7TLMeQb3MoXPDD/Z5Ry2lEcWaoJLCCDkITsvPUOcXuElw9jesIPVnEjERZ33XH9aLSVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wY2x4dbOIgXpyQCbX5HxJwe7Ojf6pjze7jgQ6SGYbek=; b=brRBpRO5ZJXW6R1Aq6ONsGNh5JH6ipG6uy/ixM2ToxUGwHh1ITntZqoskupoSn1oS5r8Hc+qYcdjHXiNW/ahfCmeiHSIRUR3LmbmPgeR3BF0v9zn0f7Esp/4RaCvNkqTqQKMkXeFOcIcQO4tnNFVMim+OBXG4Qm/iugxzZGm7ZoDXBcLwYHM3cFHagoFhclj0Rs86PJRxQXSpZbbG8Bb3feEJ1nCptQ/f/SWzVa/ADgOZGfZPHboH3OShM3IwZj6hcUtwb78dEL17VfNYVRfbK+WG+5+B80ygfUnkFwd9OVJdZKS8kv+E60wgutz4F9hFZtbY8gwKOWKFu6JwGo/Fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wY2x4dbOIgXpyQCbX5HxJwe7Ojf6pjze7jgQ6SGYbek=; b=dYp1R9AeCL/JUhfkXbc9Ly/gKWZfaFhzRlC2p+ukfv8PLWFSXJfGeuQ3jc22Zk70ssq4rDech1ABgFWmQDk6bM8RaPzWBzHC+9RcM4WOVNzy3J4rLkJRb0/yCfcG0YPwr68hm9ZvvQMh4BZfsCMMYitw0dmW7mfeajF1OJV52cw= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB5447.eurprd04.prod.outlook.com (2603:10a6:20b:94::20) by AM6PR04MB5943.eurprd04.prod.outlook.com (2603:10a6:20b:99::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.20; Fri, 31 Jul 2020 10:49:56 +0000 Received: from AM6PR04MB5447.eurprd04.prod.outlook.com ([fe80::e115:af36:613c:5a99]) by AM6PR04MB5447.eurprd04.prod.outlook.com ([fe80::e115:af36:613c:5a99%5]) with mapi id 15.20.3239.019; Fri, 31 Jul 2020 10:49:56 +0000 From: Florinel Iordache To: madalin.bucur@nxp.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Markus.Elfring@web.de Cc: linux-kernel@vger.kernel.org, Florinel Iordache Subject: [PATCH net v2 4/5] fsl/fman: check dereferencing null pointer Date: Fri, 31 Jul 2020 13:49:21 +0300 Message-Id: <1596192562-7629-5-git-send-email-florinel.iordache@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1596192562-7629-1-git-send-email-florinel.iordache@nxp.com> References: <1596192562-7629-1-git-send-email-florinel.iordache@nxp.com> Reply-to: florinel.iordache@nxp.com X-ClientProxiedBy: AM0PR04CA0103.eurprd04.prod.outlook.com (2603:10a6:208:be::44) To AM6PR04MB5447.eurprd04.prod.outlook.com (2603:10a6:20b:94::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from fsr-ub1464-128.ea.freescale.net (83.217.231.2) by AM0PR04CA0103.eurprd04.prod.outlook.com (2603:10a6:208:be::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3239.16 via Frontend Transport; Fri, 31 Jul 2020 10:49:55 +0000 X-Mailer: git-send-email 1.9.1 X-Originating-IP: [83.217.231.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 292ddbb8-2eea-4696-9b62-08d8353f7690 X-MS-TrafficTypeDiagnostic: AM6PR04MB5943: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HXJLIIQ09NwlWUodSaTRUldDaXa22ly1EvaslgliC4Y0uO8vIh9bNZJEsL+YQ0PIrkBHk4WDs6cAY+nkC76uuh9zNfoChSpkMJymQkX+zGF2g/d3g7gST8OIYYuqFA1JXU4yfz2LZ3lzqZhllpGK4vHG5Yil2yXZMg01RMwbL6QqYlnP9hnJ3PYJ0YuQjvepDh868gJ1Q3Eqj+6giShg0XyVHvoNsO8lHSHrgdOouz++5pDpnDCc+OM4HNXDm0gDA9wCsfGf8Lv9ZdQ6rI5Nl5rKnr83XPaI4y4bOFB92W0aItdG1tNQjMsb+xyhs9S0kLUqOSyTZlrzHoTnLiJLTA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB5447.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(366004)(376002)(346002)(39860400002)(3450700001)(6666004)(478600001)(83380400001)(36756003)(52116002)(2906002)(4326008)(6486002)(316002)(66946007)(66556008)(6512007)(5660300002)(8676002)(86362001)(8936002)(956004)(2616005)(186003)(16526019)(26005)(44832011)(6506007)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: BEnAYPx1ymbL2rb53OMCXgoS+003Nm7zKWbtJhmG4+vC5JaqzCWicCa/L78N/M+0NrbLuhzlA4JXotwPqFKivctqYoGVELNALMlEiGPcyUfNujudKMfQMSfFnGuipUz2AknsaZmDJ/g//GoTwA/c261h4IJ6eISvTRNuwHpxnfGYr3mkgKcdEjoV1yuR78rdkJU/22mHSsuoEfFW12Ln52C3h3D8+im115GCd5aMWinX8eV44gHwdbkfpWn/AniwPpvyQnzU59n+XHJqIhfND4nn/Sr12tscq08yjQYLlq56nnPhrGrBy1dNfxpEb0TB3AP5gwHgchMTnNboUhXwZTxmlx9PxYAzd2NkhcccpvrI6qqxiiu7ZKcjqP4Y4RVhj5sos7X8w4V0j4256RAIYyQrutTznIIqai/A+iUbdIW1Y7+NRss6w+7eVS+w/6/vVQBG+Yrb0x9EM5VvmsUz9+1SduLExpbSByFuCklC5ikui8eHOS/yqPUb4lunOdyn5M5ViSZbC8c8BvKow6Ns8Rnym41EAf6a4J+60ZJFXJKk7FCWvucSmPunxxRUDBoguPxwEkpHk1bXgZzryrlfA9K0zQ1cQL9HUlvedIgX+e9gUhJ42JNEeNNZ/Ct8fWc1yHVUoPmOmhff/wAe9qfLvQ== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 292ddbb8-2eea-4696-9b62-08d8353f7690 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5447.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2020 10:49:56.2854 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IM6/0IM6b0V21HMh70PfH+MekOrfpNZsmjuNmNl/IDcV4nqhGHaVLjMbomObVBFw92jcb8fZttVNI9nA/WKjM72OLM9Wl69poNSMOiBzTXk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5943 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Add a safe check to avoid dereferencing null pointer Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support") Signed-off-by: Florinel Iordache --- drivers/net/ethernet/freescale/fman/fman_dtsec.c | 4 ++-- drivers/net/ethernet/freescale/fman/fman_memac.c | 2 +- drivers/net/ethernet/freescale/fman/fman_tgec.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/fman_dtsec.c b/drivers/net/ethernet/freescale/fman/fman_dtsec.c index 004c266..bce3c93 100644 --- a/drivers/net/ethernet/freescale/fman/fman_dtsec.c +++ b/drivers/net/ethernet/freescale/fman/fman_dtsec.c @@ -1200,7 +1200,7 @@ int dtsec_del_hash_mac_address(struct fman_mac *dtsec, enet_addr_t *eth_addr) list_for_each(pos, &dtsec->multicast_addr_hash->lsts[bucket]) { hash_entry = ETH_HASH_ENTRY_OBJ(pos); - if (hash_entry->addr == addr) { + if (hash_entry && hash_entry->addr == addr) { list_del_init(&hash_entry->node); kfree(hash_entry); break; @@ -1213,7 +1213,7 @@ int dtsec_del_hash_mac_address(struct fman_mac *dtsec, enet_addr_t *eth_addr) list_for_each(pos, &dtsec->unicast_addr_hash->lsts[bucket]) { hash_entry = ETH_HASH_ENTRY_OBJ(pos); - if (hash_entry->addr == addr) { + if (hash_entry && hash_entry->addr == addr) { list_del_init(&hash_entry->node); kfree(hash_entry); break; diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c index bb02b37..645764a 100644 --- a/drivers/net/ethernet/freescale/fman/fman_memac.c +++ b/drivers/net/ethernet/freescale/fman/fman_memac.c @@ -981,7 +981,7 @@ int memac_del_hash_mac_address(struct fman_mac *memac, enet_addr_t *eth_addr) list_for_each(pos, &memac->multicast_addr_hash->lsts[hash]) { hash_entry = ETH_HASH_ENTRY_OBJ(pos); - if (hash_entry->addr == addr) { + if (hash_entry && hash_entry->addr == addr) { list_del_init(&hash_entry->node); kfree(hash_entry); break; diff --git a/drivers/net/ethernet/freescale/fman/fman_tgec.c b/drivers/net/ethernet/freescale/fman/fman_tgec.c index 8c7eb87..41946b1 100644 --- a/drivers/net/ethernet/freescale/fman/fman_tgec.c +++ b/drivers/net/ethernet/freescale/fman/fman_tgec.c @@ -626,7 +626,7 @@ int tgec_del_hash_mac_address(struct fman_mac *tgec, enet_addr_t *eth_addr) list_for_each(pos, &tgec->multicast_addr_hash->lsts[hash]) { hash_entry = ETH_HASH_ENTRY_OBJ(pos); - if (hash_entry->addr == addr) { + if (hash_entry && hash_entry->addr == addr) { list_del_init(&hash_entry->node); kfree(hash_entry); break; From patchwork Fri Jul 31 10:49:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florinel Iordache X-Patchwork-Id: 1339392 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=gkWNt54Z; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BJ3vz1DW9z9sTM for ; Fri, 31 Jul 2020 20:50:23 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732733AbgGaKuU (ORCPT ); Fri, 31 Jul 2020 06:50:20 -0400 Received: from mail-eopbgr70048.outbound.protection.outlook.com ([40.107.7.48]:53202 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732603AbgGaKuQ (ORCPT ); Fri, 31 Jul 2020 06:50:16 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jVy99FGw8oJ5b2TFRbO+mApB61dp/uYmAc0Yu2E2tyB4/0tQkgfX/Kwsyj9e1x9+MprYjEf56/k9qwJxogmZilxwB6bOZBcv/smUXVH3NpP3+aYb2Hi4jWQYtsTm+1J3CV9ggAKuFetGxWXzvproQFDWHtnsXeHJUAyPdNx6CI1bxG6Lfek3Z3gDfotzFiNWsMLNOZqyrmNoQRgfZJV/eJni5td3Z6GW9CLjr2pch3ZOGX4NU6fTHkc8lZ5tS5JiuVVf2rR3ERVowOZBrW/74JgjK5RBYRtl4BnwvLbaDYQn0eleVGmGLaYCFt6t6eKc2UQrDrYyL1xsNQCt3Glosg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eCJNfd5Yf408gpMdNay94myuUWJOOFpBuIoY/bSXHYM=; b=JNCy9xBeUlinEl0qoMT3NqdjSpM2vwY787H94lZlfzB+g1V5JPd2RIHJPJD0bPjOYJWcurQWe+F9Hdd7FR1DhRy3xHB62yeP/12IcxOuKPZiZ7Oq86p9m2G6r1m7QXdRMNHCv+G05uOPxRqF7iN2aJJZYTjXJ2HADkt2XkECxaSYnO1zBaO8b/wNI5u962U+YYiBsxBZD1El64gWCU+f2baYvPVzA4ab7rTdvE3IxVf6fqwl6I+HBl2aszsh0s3LfYaD4O+AUnnCqJd6I0nenwFf5A2UpwyelSxPgRhXUhnJTqEg96rBDe+QKKOmiT7fZ2VwoxaxPqO+HYarCCgfXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eCJNfd5Yf408gpMdNay94myuUWJOOFpBuIoY/bSXHYM=; b=gkWNt54Zqlvy/+1F36dDtYFMuxsKH+RQ85a9HCk+DinWyZJAZDZ/jwMgppV4/TJDd2B1OJ+vt+QKiOK0FHYpozSKM6Dg2AKa751Yl0WxXvyxlSIbwtU7u4EoVe1SlVHkPm9CwVj6EmTwmOvjsMpSoyYsaAkCh6b2GhirGo3Ljss= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB5447.eurprd04.prod.outlook.com (2603:10a6:20b:94::20) by AM6PR04MB5943.eurprd04.prod.outlook.com (2603:10a6:20b:99::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.20; Fri, 31 Jul 2020 10:49:57 +0000 Received: from AM6PR04MB5447.eurprd04.prod.outlook.com ([fe80::e115:af36:613c:5a99]) by AM6PR04MB5447.eurprd04.prod.outlook.com ([fe80::e115:af36:613c:5a99%5]) with mapi id 15.20.3239.019; Fri, 31 Jul 2020 10:49:56 +0000 From: Florinel Iordache To: madalin.bucur@nxp.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Markus.Elfring@web.de Cc: linux-kernel@vger.kernel.org, Florinel Iordache Subject: [PATCH net v2 5/5] fsl/fman: fix eth hash table allocation Date: Fri, 31 Jul 2020 13:49:22 +0300 Message-Id: <1596192562-7629-6-git-send-email-florinel.iordache@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1596192562-7629-1-git-send-email-florinel.iordache@nxp.com> References: <1596192562-7629-1-git-send-email-florinel.iordache@nxp.com> Reply-to: florinel.iordache@nxp.com X-ClientProxiedBy: AM0PR04CA0103.eurprd04.prod.outlook.com (2603:10a6:208:be::44) To AM6PR04MB5447.eurprd04.prod.outlook.com (2603:10a6:20b:94::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from fsr-ub1464-128.ea.freescale.net (83.217.231.2) by AM0PR04CA0103.eurprd04.prod.outlook.com (2603:10a6:208:be::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3239.16 via Frontend Transport; Fri, 31 Jul 2020 10:49:56 +0000 X-Mailer: git-send-email 1.9.1 X-Originating-IP: [83.217.231.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 127c2b05-285f-4cf0-6558-08d8353f76f7 X-MS-TrafficTypeDiagnostic: AM6PR04MB5943: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lf0ZHA+IKgAHKmD18Ex+0OT2He47jK3nRh1k670/fUp9zYJveHuPRPGcV8uZn5mCLsgRDmKt4WiKzeJGdlgWVEJV9Hj9Bv4FLJqWYM56Kn2EBsKBSeU0wGs1F/AnTCFyEOzadJahn0/pBZP6vhzYD8u3Zz27+LCIdzga3eppZTwvH6AvoozkS/sScVfIZIbHnY8uYRrOA+a0alobo9Qt7vcCH/LNWCgFRCduGuY4s9qjPsFjytltcpaL+9AGsOhHCjOudTY3vgFRQq/bIa98P7CFhKcVECNIAWc29ux4zfM+x7jlxNZDtEy22RHSO7QefiFNmxmxknMfZiG3ZhIZlw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB5447.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(366004)(376002)(346002)(39860400002)(3450700001)(6666004)(478600001)(83380400001)(36756003)(52116002)(2906002)(4326008)(6486002)(316002)(66946007)(66556008)(6512007)(5660300002)(8676002)(86362001)(8936002)(956004)(2616005)(186003)(16526019)(26005)(44832011)(6506007)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: cGMgnhKg5Iwar+issXhydJrHYmpqiGlP/21bTWFT8oBlgTW8PGL0qzGpphqfhV/+qrxLAAmfWZnRhgOYlEULCVGf1RkoDzaNl8hwSwZXKUyysrMNLku1g6oUhYV42qcBoL81d8erNbQKeEN2QMez4BYeJ2r/s7cGHKj7F0TdGhoN9wm0zvMfiJNA2qNOLcVxuBadogMKT55nQ5pcfGtyq/vLytQVL1+W+1TIuK3YS8kv2asKn1tRb55v6iPt6Aju3HNigy20NmpOr81RMu38nLFfIC5DebHjQuI6HL5I29usIBvp0JFwIZSQRkKuqL1dh1IAZx1v299roNypMZhDS8lp+qBtNQs9YkXv02S43wXYRwVyCb65fKi8I7kUIC2ypbpo3ZlMgLeY8aIzenrVT5ARcDnHTaCuVpkMW0t9qmyCZV5CIIjj7cArfrITBvGy6ELbwlYkTcZJ0Ljzg0PjIj5V4KANIbQKKuMWAzk3ruXVNhNE3A+How4KsHCgvWnKmE+AeSVFI11v2aUHyoWKgI43Pa0rs9t9K32ht1jIPKagV2GQ1QzWjVP3kHpyuuAiy0lsJkqbuFsHmmt0wZwgp028VbR00lA/oh7lp9NLCqvzuQMeOVtXW4BmA1ldBCz8C/lL+w/P/jyu+u0cqgXXpw== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 127c2b05-285f-4cf0-6558-08d8353f76f7 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5447.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2020 10:49:56.9311 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +j35fLDUmdw+tDvt/57JROgnjAP/ZXqzYXTgdSznXk5LGsPubEg6IeIoVrRr5xqMAiPl4V7Gh284zPYhplnxCyMtTid0ZYpyUZNRHkHs7bQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5943 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix memory allocation for ethernet address hash table. The code was wrongly allocating an array for eth hash table which is incorrect because this is the main structure for eth hash table (struct eth_hash_t) that contains inside a number of elements. Fixes: 57ba4c9b56d8 ("fsl/fman: Add FMan MAC support") Signed-off-by: Florinel Iordache --- drivers/net/ethernet/freescale/fman/fman_mac.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fman/fman_mac.h b/drivers/net/ethernet/freescale/fman/fman_mac.h index dd6d052..19f327e 100644 --- a/drivers/net/ethernet/freescale/fman/fman_mac.h +++ b/drivers/net/ethernet/freescale/fman/fman_mac.h @@ -252,7 +252,7 @@ static inline struct eth_hash_t *alloc_hash_table(u16 size) struct eth_hash_t *hash; /* Allocate address hash table */ - hash = kmalloc_array(size, sizeof(struct eth_hash_t *), GFP_KERNEL); + hash = kmalloc(sizeof(*hash), GFP_KERNEL); if (!hash) return NULL;