From patchwork Tue Jul 28 12:55:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 1337802 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BGGqM3rq2z9sTR for ; Tue, 28 Jul 2020 22:55:11 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728604AbgG1MzI (ORCPT ); Tue, 28 Jul 2020 08:55:08 -0400 Received: from mga02.intel.com ([134.134.136.20]:5650 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729565AbgG1MzH (ORCPT ); Tue, 28 Jul 2020 08:55:07 -0400 IronPort-SDR: cF6z9FBrdzsc5RYvEAd6UeAijbWwMH53/vcB2iwwLdpor3Rsm3XFig2QsiJN3rNBG1jaAPYXH1 b2S0cH8hMhsA== X-IronPort-AV: E=McAfee;i="6000,8403,9695"; a="139231659" X-IronPort-AV: E=Sophos;i="5.75,406,1589266800"; d="scan'208";a="139231659" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2020 05:55:07 -0700 IronPort-SDR: wR5dF91NPFTc+6+PeYvCWo4Y6K+8WVecuwUJALfb0cThdPh+BK/XBLgS/iFEKK93TgImCYLbSM 4CTrLhN7ac6A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,406,1589266800"; d="scan'208";a="273560745" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 28 Jul 2020 05:55:06 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id EB6CA95; Tue, 28 Jul 2020 15:55:04 +0300 (EEST) From: Andy Shevchenko To: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, Kuppuswamy Sathyanarayanan Cc: Andy Shevchenko Subject: [PATCH v1 1/3] gpio: pca953x: Request IRQ after all initialisation done Date: Tue, 28 Jul 2020 15:55:02 +0300 Message-Id: <20200728125504.27786-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org There is logically better to request IRQ when we initialise all structures. Align the driver with the rest on the same matter. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-pca953x.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index ab22152bf3e8..bd2e96c34f82 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -865,17 +865,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base) bitmap_and(chip->irq_stat, irq_stat, reg_direction, chip->gpio_chip.ngpio); mutex_init(&chip->irq_lock); - ret = devm_request_threaded_irq(&client->dev, client->irq, - NULL, pca953x_irq_handler, - IRQF_ONESHOT | IRQF_SHARED, - dev_name(&client->dev), chip); - if (ret) { - dev_err(&client->dev, "failed to request irq %d\n", - client->irq); - return ret; - } - - irq_chip->name = dev_name(&chip->client->dev); + irq_chip->name = dev_name(&client->dev); irq_chip->irq_mask = pca953x_irq_mask; irq_chip->irq_unmask = pca953x_irq_unmask; irq_chip->irq_set_wake = pca953x_irq_set_wake; @@ -895,6 +885,16 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base) girq->threaded = true; girq->first = irq_base; /* FIXME: get rid of this */ + ret = devm_request_threaded_irq(&client->dev, client->irq, + NULL, pca953x_irq_handler, + IRQF_ONESHOT | IRQF_SHARED, + dev_name(&client->dev), chip); + if (ret) { + dev_err(&client->dev, "failed to request irq %d\n", + client->irq); + return ret; + } + return 0; } From patchwork Tue Jul 28 12:55:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 1337804 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BGGqN2DG6z9sTV for ; Tue, 28 Jul 2020 22:55:12 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729565AbgG1MzI (ORCPT ); Tue, 28 Jul 2020 08:55:08 -0400 Received: from mga11.intel.com ([192.55.52.93]:16828 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729562AbgG1MzI (ORCPT ); Tue, 28 Jul 2020 08:55:08 -0400 IronPort-SDR: BWD749oRXiFRRF5t2AwuEzLMBj9z6pGnNRTWin5rQuTq3sOcaIX/Cd5V+rwP8KMGICy9T81LL1 AtmDp//mbLqA== X-IronPort-AV: E=McAfee;i="6000,8403,9695"; a="149060267" X-IronPort-AV: E=Sophos;i="5.75,406,1589266800"; d="scan'208";a="149060267" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2020 05:55:07 -0700 IronPort-SDR: W8oPZn8T9UCt6aZxcQgaE0JRgYN6PwmruGqxmMGOEmhbdGMngdRAoILOGiCMpdGzDvc1CAQs4a PtLmtjRdafhA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,406,1589266800"; d="scan'208";a="290157937" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga006.jf.intel.com with ESMTP; 28 Jul 2020 05:55:05 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 0697D5B; Tue, 28 Jul 2020 15:55:04 +0300 (EEST) From: Andy Shevchenko To: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, Kuppuswamy Sathyanarayanan Cc: Andy Shevchenko Subject: [PATCH v1 2/3] gpio: crystalcove: Free IRQ on error path Date: Tue, 28 Jul 2020 15:55:03 +0300 Message-Id: <20200728125504.27786-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200728125504.27786-1-andriy.shevchenko@linux.intel.com> References: <20200728125504.27786-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org It appears that all, but request_irq(), calls in the driver are device managed. In unlikely case of devm_gpiochip_add_data() failure the IRQ left requested. Free IRQ on error path by switching to devm_request_threaded_irq() API. Byproduct of this change is a drop of ->remove() callback completely. Fixes: 945e72db36bd ("gpio: crystalcove: Use irqchip template") Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-crystalcove.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c index f60ff7579cd0..2ba225720086 100644 --- a/drivers/gpio/gpio-crystalcove.c +++ b/drivers/gpio/gpio-crystalcove.c @@ -364,9 +364,9 @@ static int crystalcove_gpio_probe(struct platform_device *pdev) girq->handler = handle_simple_irq; girq->threaded = true; - retval = request_threaded_irq(irq, NULL, crystalcove_gpio_irq_handler, - IRQF_ONESHOT, KBUILD_MODNAME, cg); - + retval = devm_request_threaded_irq(&pdev->dev, irq, NULL, + crystalcove_gpio_irq_handler, + IRQF_ONESHOT, KBUILD_MODNAME, cg); if (retval) { dev_warn(&pdev->dev, "request irq failed: %d\n", retval); return retval; @@ -381,24 +381,12 @@ static int crystalcove_gpio_probe(struct platform_device *pdev) return 0; } -static int crystalcove_gpio_remove(struct platform_device *pdev) -{ - struct crystalcove_gpio *cg = platform_get_drvdata(pdev); - int irq = platform_get_irq(pdev, 0); - - if (irq >= 0) - free_irq(irq, cg); - return 0; -} - static struct platform_driver crystalcove_gpio_driver = { .probe = crystalcove_gpio_probe, - .remove = crystalcove_gpio_remove, .driver = { .name = "crystal_cove_gpio", }, }; - module_platform_driver(crystalcove_gpio_driver); MODULE_AUTHOR("Yang, Bin "); From patchwork Tue Jul 28 12:55:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 1337803 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BGGqJ63dbz9sTK for ; Tue, 28 Jul 2020 22:55:08 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729578AbgG1MzH (ORCPT ); Tue, 28 Jul 2020 08:55:07 -0400 Received: from mga04.intel.com ([192.55.52.120]:36182 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728604AbgG1MzH (ORCPT ); Tue, 28 Jul 2020 08:55:07 -0400 IronPort-SDR: XLvYTL/iAJ5Qkm4HQezsu8BRxYB0dseJZUnhn0s9+ZNySAFhgW+YQM4ZhIfM5raKOcxaLbo/zV C0Ero4+DeTtw== X-IronPort-AV: E=McAfee;i="6000,8403,9695"; a="148663880" X-IronPort-AV: E=Sophos;i="5.75,406,1589266800"; d="scan'208";a="148663880" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2020 05:55:07 -0700 IronPort-SDR: AkZjsKlBlI3hcWJniDAgksZc+HsljkDDgyTopSdKw3gf6URVzKus7UER6OqgkR0TNnsUeXVsnT Bwh3GtcTKRlA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,406,1589266800"; d="scan'208";a="272308199" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 28 Jul 2020 05:55:05 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 101F9198; Tue, 28 Jul 2020 15:55:05 +0300 (EEST) From: Andy Shevchenko To: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, Kuppuswamy Sathyanarayanan Cc: Andy Shevchenko Subject: [PATCH v1 3/3] gpio: wcove: Request IRQ after all initialisation done Date: Tue, 28 Jul 2020 15:55:04 +0300 Message-Id: <20200728125504.27786-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200728125504.27786-1-andriy.shevchenko@linux.intel.com> References: <20200728125504.27786-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org There is logically better to request IRQ when we initialise all structures. Align the driver with the rest on the same matter. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-wcove.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c index 135645096575..b5fbba5a783a 100644 --- a/drivers/gpio/gpio-wcove.c +++ b/drivers/gpio/gpio-wcove.c @@ -449,13 +449,6 @@ static int wcove_gpio_probe(struct platform_device *pdev) return virq; } - ret = devm_request_threaded_irq(dev, virq, NULL, - wcove_gpio_irq_handler, IRQF_ONESHOT, pdev->name, wg); - if (ret) { - dev_err(dev, "Failed to request irq %d\n", virq); - return ret; - } - girq = &wg->chip.irq; girq->chip = &wcove_irqchip; /* This will let us handle the parent IRQ in the driver */ @@ -466,6 +459,13 @@ static int wcove_gpio_probe(struct platform_device *pdev) girq->handler = handle_simple_irq; girq->threaded = true; + ret = devm_request_threaded_irq(dev, virq, NULL, wcove_gpio_irq_handler, + IRQF_ONESHOT, pdev->name, wg); + if (ret) { + dev_err(dev, "Failed to request irq %d\n", virq); + return ret; + } + ret = devm_gpiochip_add_data(dev, &wg->chip, wg); if (ret) { dev_err(dev, "Failed to add gpiochip: %d\n", ret);