From patchwork Mon Jul 27 16:25:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tanner Love X-Patchwork-Id: 1337072 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=NokNMk5b; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BFlXg0wycz9sR4 for ; Tue, 28 Jul 2020 02:25:39 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729333AbgG0QZi (ORCPT ); Mon, 27 Jul 2020 12:25:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729099AbgG0QZg (ORCPT ); Mon, 27 Jul 2020 12:25:36 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F15BC061794 for ; Mon, 27 Jul 2020 09:25:36 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id h7so15768906qkk.7 for ; Mon, 27 Jul 2020 09:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G7ShOKZ/8tLBooUqQziGfzC2qCV64R5oqgMbsVY4Ejs=; b=NokNMk5bpQXnRRmYgx0oYf1qSEInT259RzwkpkJSYdGMgWz5GBDdn4VFrDUevl1Ind npxppKLX3362i1AxAV9BpJiCrfueKJ+sN1Sfo/bf3Cq6qvHn/vJBE4OZ9W4Grbrv/EN1 qw15VtknRA5hX1/WAS81q700NXt1BVr07mkp31Ett7QH91sINvinV+NHawHypo0NkQIq 8U5ZPJMEtCnmu2tAurz+0GgYX6FCuIETOvbRmpCOF5Hd0e3PODNBld4zszAOXVuAXPUr nFlj0LbWsf2Iu2RFN+3pnJRcayilkPPJdSd1f8QEIUHjTx4QrM3C5sezJiE2ziv8C0/b LeJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G7ShOKZ/8tLBooUqQziGfzC2qCV64R5oqgMbsVY4Ejs=; b=CFCtnzC5rvOTE2XMkUHSlNqQ/37KClcXMo1K51OXSivCxeT9z111yFZMHseebax7rt zhSXZPwMacknunyQ792upKLciZ52TOhpbgt6/Ox9zC+WVU95aMnidhvQQ3dBh60dRWWD haq5p6+r0USey7h4WKQLBjw+qx/RuDmX7QcnIPjxrWO9DKWTYCbdQLHbYw2McTgC9uQk 8iOQ/wSQJZZaZcFgZisZK/PTFMABvq+ykTcVxtGMhqD4rLZwGu/56AsGV+jKK/9Sh1Jv VrAUb78pziyHG7i9UoYZzrJex9GDRqHmEaiNVf2vxAn7FsD8x3RITA5WqpGKSN3Zp9uh PXgg== X-Gm-Message-State: AOAM533JmyOToYb/U1zKCPtXC0+9oLrGXC1mRY47Pto4+2EpOih5qMfk 1x2rHWeRJ+OIYul2i4pm38AoFnmG X-Google-Smtp-Source: ABdhPJwwN3eHeN4astvmGnidoDI3qT8frXRmLi/7lY9w92JUSI+V+WBlDPsCL3oGpoWH1VTwWRIffA== X-Received: by 2002:a37:62d4:: with SMTP id w203mr22999197qkb.463.1595867134212; Mon, 27 Jul 2020 09:25:34 -0700 (PDT) Received: from tannerlove.nyc.corp.google.com ([2620:0:1003:316:f693:9fff:feea:df57]) by smtp.gmail.com with ESMTPSA id o37sm16764529qte.9.2020.07.27.09.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 09:25:33 -0700 (PDT) From: Tanner Love To: netdev@vger.kernel.org Cc: davem@davemloft.net, Tanner Love , Willem de Bruijn Subject: [PATCH net 1/4] selftests/net: rxtimestamp: fix clang issues for target arch PowerPC Date: Mon, 27 Jul 2020 12:25:28 -0400 Message-Id: <20200727162531.4089654-2-tannerlove.kernel@gmail.com> X-Mailer: git-send-email 2.28.0.rc0.142.g3c755180ce-goog In-Reply-To: <20200727162531.4089654-1-tannerlove.kernel@gmail.com> References: <20200727162531.4089654-1-tannerlove.kernel@gmail.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tanner Love The signedness of char is implementation-dependent. Some systems (including PowerPC and ARM) use unsigned char. Clang 9 threw: warning: result of comparison of constant -1 with expression of type \ 'char' is always true [-Wtautological-constant-out-of-range-compare] &arg_index)) != -1) { Tested: make -C tools/testing/selftests TARGETS="net" run_tests Fixes: 16e781224198 ("selftests/net: Add a test to validate behavior of rx timestamps") Signed-off-by: Tanner Love Acked-by: Willem de Bruijn --- tools/testing/selftests/net/rxtimestamp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/rxtimestamp.c b/tools/testing/selftests/net/rxtimestamp.c index 422e7761254d..bcb79ba1f214 100644 --- a/tools/testing/selftests/net/rxtimestamp.c +++ b/tools/testing/selftests/net/rxtimestamp.c @@ -329,8 +329,7 @@ int main(int argc, char **argv) bool all_tests = true; int arg_index = 0; int failures = 0; - int s, t; - char opt; + int s, t, opt; while ((opt = getopt_long(argc, argv, "", long_options, &arg_index)) != -1) { From patchwork Mon Jul 27 16:25:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tanner Love X-Patchwork-Id: 1337071 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=JpcSObJE; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BFlXd5jYcz9sPB for ; Tue, 28 Jul 2020 02:25:37 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729231AbgG0QZh (ORCPT ); Mon, 27 Jul 2020 12:25:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728446AbgG0QZf (ORCPT ); Mon, 27 Jul 2020 12:25:35 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB3F3C061794 for ; Mon, 27 Jul 2020 09:25:35 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id u64so15747221qka.12 for ; Mon, 27 Jul 2020 09:25:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m5DzJ04b+qhQahsqmfTaxAY0iHnSOC2jYlCiJV6WF3c=; b=JpcSObJEljSz2WXAgdps3mzMKyFADKPCxhJbQxzYys5/9IAAwzWeYlKulmowFPMM8i AytDK3L9jODH5NkhDefy3gvAcAigeP/xTBBITON3fQtlFS8J1NgxwnfRirpMj2XlVaBZ 8ASP85hG77xgQiAYT5bR22xWPk4xsVOTb53NOQUOGGJxlhu0FVqdGwsJAhLIup9eU6w9 hH58U60HRz4bDqCC8VstJsi08+2BCQUL27vNxRE3cPt3JQyjV4wYnnheicBXfAZxh8Cv Mpd77w+HGJVlaZASeVb9KYYcPbyZz2UHsDda35FtQmA39zyyxFRVm3/h3y+0Iq7ktCSK 88Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m5DzJ04b+qhQahsqmfTaxAY0iHnSOC2jYlCiJV6WF3c=; b=JEYDh8Eg7OWyPoec4A07vDq2slv0/6SEDXSfBaZk7QjUyHpx0exJDfqUVXQwrpIaLA WQMjBPTaVlc5VZpnsyt3xieLHrT7AGnx6nd3Se0gIiv8OSc1lJwH4jdWmhAdYZD5eGzH H+/W+PJ9i28DazPUYc7jJnVOjpvimCW1dSVQHTqSuabFZ/YIobQsawnRPhF1MHqFTYo1 iOJRVwm7UTiBaThQhlAQnE+Pagvlu8EnkENAbNsRDgRKJXw3gUnMdGsP45JqOQ87pJLH uH2Tez1sf9UGXxSzT8JPweKOaKFlLBcZzPhphmK376pNl8GwhQr9jwlH+S2PvKQtu/1U 6qdg== X-Gm-Message-State: AOAM532brglmxdBv1vSY1hF9bIpSf1DdlmO/l6N5a6IZnVnRErOepVS2 ulQmMdbojaE2jb28sskf4gnYeMxn X-Google-Smtp-Source: ABdhPJwOZKUPq93Wr3w6v62NYG6pl+oHcTeUiEjJmDYoHDkJ4vdjqcY4YS5pjemg0oTdJBBw7Ju9vA== X-Received: by 2002:a05:620a:2298:: with SMTP id o24mr23310181qkh.73.1595867134888; Mon, 27 Jul 2020 09:25:34 -0700 (PDT) Received: from tannerlove.nyc.corp.google.com ([2620:0:1003:316:f693:9fff:feea:df57]) by smtp.gmail.com with ESMTPSA id o37sm16764529qte.9.2020.07.27.09.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 09:25:34 -0700 (PDT) From: Tanner Love To: netdev@vger.kernel.org Cc: davem@davemloft.net, Tanner Love , Willem de Bruijn Subject: [PATCH net 2/4] selftests/net: psock_fanout: fix clang issues for target arch PowerPC Date: Mon, 27 Jul 2020 12:25:29 -0400 Message-Id: <20200727162531.4089654-3-tannerlove.kernel@gmail.com> X-Mailer: git-send-email 2.28.0.rc0.142.g3c755180ce-goog In-Reply-To: <20200727162531.4089654-1-tannerlove.kernel@gmail.com> References: <20200727162531.4089654-1-tannerlove.kernel@gmail.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tanner Love Clang 9 threw: warning: format specifies type 'unsigned short' but the argument has \ type 'int' [-Wformat] typeflags, PORT_BASE, PORT_BASE + port_off); Tested: make -C tools/testing/selftests TARGETS="net" run_tests Fixes: 77f65ebdca50 ("packet: packet fanout rollover during socket overload") Signed-off-by: Tanner Love Acked-by: Willem de Bruijn --- tools/testing/selftests/net/psock_fanout.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/psock_fanout.c b/tools/testing/selftests/net/psock_fanout.c index 8c8c7d79c38d..2c522f7a0aec 100644 --- a/tools/testing/selftests/net/psock_fanout.c +++ b/tools/testing/selftests/net/psock_fanout.c @@ -350,7 +350,8 @@ static int test_datapath(uint16_t typeflags, int port_off, int fds[2], fds_udp[2][2], ret; fprintf(stderr, "\ntest: datapath 0x%hx ports %hu,%hu\n", - typeflags, PORT_BASE, PORT_BASE + port_off); + typeflags, (uint16_t)PORT_BASE, + (uint16_t)(PORT_BASE + port_off)); fds[0] = sock_fanout_open(typeflags, 0); fds[1] = sock_fanout_open(typeflags, 0); From patchwork Mon Jul 27 16:25:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tanner Love X-Patchwork-Id: 1337073 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=dtR9T8md; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BFlXh0cPNz9sPB for ; Tue, 28 Jul 2020 02:25:40 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729396AbgG0QZj (ORCPT ); Mon, 27 Jul 2020 12:25:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729155AbgG0QZg (ORCPT ); Mon, 27 Jul 2020 12:25:36 -0400 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 713E9C0619D2 for ; Mon, 27 Jul 2020 09:25:36 -0700 (PDT) Received: by mail-qt1-x842.google.com with SMTP id s16so12648020qtn.7 for ; Mon, 27 Jul 2020 09:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m74gINJk0o2yzV3Cw9JKpr2KF9pTOOCvx6qXl5Iu/vg=; b=dtR9T8mdGLI8E9i+4pFa9xh5+Om67FJCDxJx+9umnUhXDzD3A9Yhrn7iZwOae0sKx4 GNXkmCs9eA9FpQEsicd52sMEFwQNn96OlDW4u7u2TYELLCl9LYyU0/XOchka1pE1/kza JBTCuxVSG1RGs5eCD+olldQt/17GFoOHyF8mRFedSGD0N3xfUATEcIPxAjy/VgD7hWiq Jdo24KxLxDuebkauHPT4wOxgv84IfzOWwhr8OYBamP0FUzS6pQ1OJl9TR6lVFueoqBpx 1qrq+BcLbcDH9EwZwlkJJOSekr5OBjbU1ZYizr5/e3hzv00+yfQE0uoOHHvkvlrv6vl7 PCYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m74gINJk0o2yzV3Cw9JKpr2KF9pTOOCvx6qXl5Iu/vg=; b=Pbjy3QebCIu03GQPx0piKRj00k7sjABp1wQDVYar+MqDn8AbZQDqgWSKSj9UpJCpHL 4TSoe9DFHYFB7OMh7iN61x7iCqmUR/S3OxebAAcBbbQmHd2sCgwCiV8xcLU7ra8W2Paj VPMN1rtgu0/+XHo9eRhuw/ZarXVGqEM3N4UI4UTGo4XKYJjGLth5PkHNrufTTCh2c3qp rkASHXYLW+r6p8eLvZ92/jEOJLrUw/3iEg6rlb5U661whewz0uiz0uMQMbv1z85RXMtM UMvNtKbv2wUsqeQtvFObdfyQkSCpNiqQH8JD44inWqXwI1ULmkw5JayPZzOYn6GjGji6 207w== X-Gm-Message-State: AOAM532zgGCps3gCXhH0zV+YBLOLBZU1D6oyIVGPMDmdTWnkjCPC32M+ lI8tD43KD2SrjoppgLEa48w8LxXY X-Google-Smtp-Source: ABdhPJxNZYVopQtzevVbTge52UyVu1BrBQ8Ar5E6JezSlCEPsoQWzqG9OAU99tG06wYGCUsBWt+8gw== X-Received: by 2002:ac8:3fcf:: with SMTP id v15mr23008974qtk.274.1595867135578; Mon, 27 Jul 2020 09:25:35 -0700 (PDT) Received: from tannerlove.nyc.corp.google.com ([2620:0:1003:316:f693:9fff:feea:df57]) by smtp.gmail.com with ESMTPSA id o37sm16764529qte.9.2020.07.27.09.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 09:25:35 -0700 (PDT) From: Tanner Love To: netdev@vger.kernel.org Cc: davem@davemloft.net, Tanner Love , Willem de Bruijn Subject: [PATCH net 3/4] selftests/net: so_txtime: fix clang issues for target arch PowerPC Date: Mon, 27 Jul 2020 12:25:30 -0400 Message-Id: <20200727162531.4089654-4-tannerlove.kernel@gmail.com> X-Mailer: git-send-email 2.28.0.rc0.142.g3c755180ce-goog In-Reply-To: <20200727162531.4089654-1-tannerlove.kernel@gmail.com> References: <20200727162531.4089654-1-tannerlove.kernel@gmail.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tanner Love On powerpcle, int64_t maps to long long. Clang 9 threw: warning: absolute value function 'labs' given an argument of type \ 'long long' but has parameter of type 'long' which may cause \ truncation of value [-Wabsolute-value] if (labs(tstop - texpect) > cfg_variance_us) Tested: make -C tools/testing/selftests TARGETS="net" run_tests Fixes: af5136f95045 ("selftests/net: SO_TXTIME with ETF and FQ") Signed-off-by: Tanner Love Acked-by: Willem de Bruijn --- tools/testing/selftests/net/so_txtime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/so_txtime.c b/tools/testing/selftests/net/so_txtime.c index ceaad78e9667..3155fbbf644b 100644 --- a/tools/testing/selftests/net/so_txtime.c +++ b/tools/testing/selftests/net/so_txtime.c @@ -121,7 +121,7 @@ static bool do_recv_one(int fdr, struct timed_send *ts) if (rbuf[0] != ts->data) error(1, 0, "payload mismatch. expected %c", ts->data); - if (labs(tstop - texpect) > cfg_variance_us) + if (llabs(tstop - texpect) > cfg_variance_us) error(1, 0, "exceeds variance (%d us)", cfg_variance_us); return false; From patchwork Mon Jul 27 16:25:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tanner Love X-Patchwork-Id: 1337074 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=JvwZIxvG; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BFlXj49Wrz9sPB for ; Tue, 28 Jul 2020 02:25:41 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729467AbgG0QZk (ORCPT ); Mon, 27 Jul 2020 12:25:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729306AbgG0QZh (ORCPT ); Mon, 27 Jul 2020 12:25:37 -0400 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A016C061794 for ; Mon, 27 Jul 2020 09:25:37 -0700 (PDT) Received: by mail-qk1-x741.google.com with SMTP id h7so15768993qkk.7 for ; Mon, 27 Jul 2020 09:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ftfQ08ORCRsliGpN2k0pI0UWrP2nufp8QRORAmCssEM=; b=JvwZIxvGgorUM7JUjCzAnk/p8V0pZhEARfcJ5U1kjHrN/nLeikyXe+NqAbkN81gJ0Z Npk31V+t6XJnTkuwLVR/clalVpxM8cHxhCcvIWok4JHPGkfIzeBnUE5JCUpG/Ok1tT15 l5ilcWD7ptR7aDOyJj/tFlIpr/CTyO1LbMTBGX+08N1i9kkLSYCm09KspV1HxFkUHfUq OAMZw5sKQloXNSvvgZxxK/1MP1fq59nFQY+VRf+R9RLCwgFI3GGXYzEkShN6An67C0en UI/05N5niKMSKvyUY56zSydLr8qc9wo1a9M8nzK2RUqbDqDp0QSTxfPY6PCaJPqZzmRo llXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ftfQ08ORCRsliGpN2k0pI0UWrP2nufp8QRORAmCssEM=; b=Ox+vEMZf8pm43ZYGMLUA+vC53rj3DUKP5BVcZhVZnTW1VunpBE6AFG8g8of6VboFvc RDfq/zt2w7xTCGme+ZY9XcW6PraIyUhdDuHKPxZ4sSj81P3UORa3bb4mo8tah5r7aYzt 9vcLOtQA1xpAMzT+5T6ZSPKjiANM3VaJT5Rv6QpAEIKh2Yh57HSXE1QTlbUbfLjks/dt drc3l9tKuyKpmPOM/qTu0qmIAiw2G2NwjE3Olyf+oLExIAwljLojHS+BuaOHYD6cMX0U htCJFxzSD7vBwBu5Ue964uxEpHe6xz6i11I8OChxIMbZpHvUjpPQh0Y/n3m35z9H9wSw gKiQ== X-Gm-Message-State: AOAM533BlVjc8fI5921qHMtJRSet8Vi4k8tNPVwYggyCQ9J4M9RQY4vW cwFXMP1c3Eu1CK8grtZ8nqhtYJs5 X-Google-Smtp-Source: ABdhPJw5T8n4/7IDMAVgfNDaxhcp4ScA3sBmT3Zu6l6EsKIhIHwbwRaVQL3ehLEELTcfeltsaEQxUw== X-Received: by 2002:a37:e86:: with SMTP id 128mr22704620qko.314.1595867136457; Mon, 27 Jul 2020 09:25:36 -0700 (PDT) Received: from tannerlove.nyc.corp.google.com ([2620:0:1003:316:f693:9fff:feea:df57]) by smtp.gmail.com with ESMTPSA id o37sm16764529qte.9.2020.07.27.09.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 09:25:35 -0700 (PDT) From: Tanner Love To: netdev@vger.kernel.org Cc: davem@davemloft.net, Tanner Love , Willem de Bruijn Subject: [PATCH net 4/4] selftests/net: tcp_mmap: fix clang warning for target arch PowerPC Date: Mon, 27 Jul 2020 12:25:31 -0400 Message-Id: <20200727162531.4089654-5-tannerlove.kernel@gmail.com> X-Mailer: git-send-email 2.28.0.rc0.142.g3c755180ce-goog In-Reply-To: <20200727162531.4089654-1-tannerlove.kernel@gmail.com> References: <20200727162531.4089654-1-tannerlove.kernel@gmail.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tanner Love When size_t maps to unsigned int (e.g. on 32-bit powerpc), then the comparison with 1<<35 is always true. Clang 9 threw: warning: result of comparison of constant 34359738368 with \ expression of type 'size_t' (aka 'unsigned int') is always true \ [-Wtautological-constant-out-of-range-compare] while (total < FILE_SZ) { Tested: make -C tools/testing/selftests TARGETS="net" run_tests Fixes: 192dc405f308 ("selftests: net: add tcp_mmap program") Signed-off-by: Tanner Love Acked-by: Willem de Bruijn Reviewed-by: Eric Dumazet --- tools/testing/selftests/net/tcp_mmap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/net/tcp_mmap.c b/tools/testing/selftests/net/tcp_mmap.c index 4555f88252ba..a61b7b3da549 100644 --- a/tools/testing/selftests/net/tcp_mmap.c +++ b/tools/testing/selftests/net/tcp_mmap.c @@ -344,7 +344,7 @@ int main(int argc, char *argv[]) { struct sockaddr_storage listenaddr, addr; unsigned int max_pacing_rate = 0; - size_t total = 0; + uint64_t total = 0; char *host = NULL; int fd, c, on = 1; char *buffer; @@ -473,12 +473,12 @@ int main(int argc, char *argv[]) zflg = 0; } while (total < FILE_SZ) { - ssize_t wr = FILE_SZ - total; + int64_t wr = FILE_SZ - total; if (wr > chunk_size) wr = chunk_size; /* Note : we just want to fill the pipe with 0 bytes */ - wr = send(fd, buffer, wr, zflg ? MSG_ZEROCOPY : 0); + wr = send(fd, buffer, (size_t)wr, zflg ? MSG_ZEROCOPY : 0); if (wr <= 0) break; total += wr;