From patchwork Tue Jul 21 16:53:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Parav Pandit X-Patchwork-Id: 1333192 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.a=rsa-sha256 header.s=selector1 header.b=Q7a9ZEO0; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BB4gn3vhXz9sR4 for ; Wed, 22 Jul 2020 03:04:05 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730782AbgGURED (ORCPT ); Tue, 21 Jul 2020 13:04:03 -0400 Received: from mail-db8eur05on2085.outbound.protection.outlook.com ([40.107.20.85]:12961 "EHLO EUR05-DB8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728931AbgGUQyq (ORCPT ); Tue, 21 Jul 2020 12:54:46 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ArgWOXKfXfb+SE7D31M8vZ86+PbQXaClZP0iA++gkDQGJoCuNi9GNaEVqgbJqTBDk0AiSDNi5ZXUOTS3EGi3xBvYymaXMw4NVJQf0qnG6x3AYQkFQqFuCu+n3B3nl0YVgdFOrhqXgU0/N8W6ZfP+d18kmRvLkAMETFcCQ6yZNeX6cgSWy0+LnMw8ZZ4XFPs7CwiQ8DL/jjwiWO4Pzd4NKP1DjjbbbHyIEdugnH7+AK4TJp9fGlODMLxq/vHPd192XXAGuueKpZMFSZJWTLMBM+/rpXmKIqqPtai1RAszDBZsNAMCxXVkBhkG8j0oG+zda7kGA/dtcyV2b6tD5Ieh1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U/q7FCc/JNOzl7EHoi5OnS+f9kMGfvoHYMy+t6Xle74=; b=mYAUsA0Fo1aFeGg8aw7P9GV6ZRB8stAU5m4jn1S9nSdbiJ7tOOkUaHnlnfKNdNaVlj7/sMzUXdIjabA2jeyadJChW8Lo6fK9oKCDoLSq1lLyfwKwucoNeErdjHcWDbVxmEK4JKpmbGL4SbXcc2mEw9fmSe3snbIAliyWiEbp6bnXSoIwMg4rEqx4kNm1VAWuKoSqVc4taIDAa4qdjG0Z2+3HbSeVskn9ys9R4eQmbhGbFShfRKFkL7QwQpKb87Wr7yGCXii8bdi7pbhYTHc+VJcYO0myF4/9sxb12q3DXOe4cvSpevjQ999lehX9LE3EvXuwQVOIG8XRENM3CKg1Ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U/q7FCc/JNOzl7EHoi5OnS+f9kMGfvoHYMy+t6Xle74=; b=Q7a9ZEO03Qm/U2ovcwcPBi4ZV9wolgzv5NmpJZPWse3H+b0BOzl9N85orm5k3lq8pp1aRKYkvnQbqEZu8kt19QUU/kIu2nvyUZuWtlvYga4jUuCJ2SWwTodsvXem+0VpPtuU92UzXJkr9c4v6MiobzwsA344jQ/G3N68TIRQUEA= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) by AM0PR05MB4739.eurprd05.prod.outlook.com (2603:10a6:208:ad::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Tue, 21 Jul 2020 16:54:10 +0000 Received: from AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7]) by AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7%2]) with mapi id 15.20.3195.026; Tue, 21 Jul 2020 16:54:10 +0000 From: Parav Pandit To: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net Cc: jiri@mellanox.com, Parav Pandit Subject: [PATCH net-next 1/4] devlink: Do not hold devlink mutex when initializing devlink fields Date: Tue, 21 Jul 2020 19:53:51 +0300 Message-Id: <20200721165354.5244-2-parav@mellanox.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <20200721165354.5244-1-parav@mellanox.com> References: <20200721165354.5244-1-parav@mellanox.com> X-ClientProxiedBy: AM0PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:208:be::14) To AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from c-141-251-1-009.mtl.labs.mlnx (94.188.199.18) by AM0PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:208:be::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20 via Frontend Transport; Tue, 21 Jul 2020 16:54:09 +0000 X-Mailer: git-send-email 2.25.4 X-Originating-IP: [94.188.199.18] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 117a73f3-92d8-4fae-6521-08d82d96b028 X-MS-TrafficTypeDiagnostic: AM0PR05MB4739: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1079; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lJ1cZvbXPmk4g6YJgQQljmmjYudzTOThJNwSnvSWajWGPjkCfHtgOfFc+pht9cLrIPvcivcCk0E5Eg+UNoQ5fqvQqdi/hhdCh5YvmQdBsDXT4sEgeY96mZNFQYA+Ve66zr2FkEhrBYmPgEnkN2JtO0JdqxVdt+AJvx9rJvuU7wF0w56B/LJCToP2b4M1bFwYBuVdE9hlIVWUk4y5EeYifLLHOSqABR++4adWWtvgp2BPRTR8/5Zk+ydpZA809/MUwQFFiAeYCQqkwD3E5v0EdQdmVd56xC6p/W2Qt1zW580q78D+hsLaTjTrjxDdZIDI03U28zVcWTGRvykpSpFoHQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR05MB4866.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39840400004)(366004)(396003)(136003)(346002)(376002)(316002)(1076003)(66556008)(2616005)(956004)(4326008)(26005)(186003)(16526019)(107886003)(8676002)(478600001)(8936002)(66946007)(66476007)(5660300002)(86362001)(6506007)(83380400001)(6486002)(6512007)(52116002)(2906002)(6666004)(36756003)(4744005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: AhDDuhjDt//EV4n/PKUJ5GGjYwvaPVS3Bogiyx+17e6NCRGrUcocGwRH4DDsgj3+mDK0Q/wRj7nM/ufZ8l7uTr+K9aTV77PDUux4ggUoeFwie9zSsGOdgagkMoy7myVN9KhwztSujROkRZuXInmqkdKKCSjNItLUH8ClzxMh+WaGOE5/iSpR0mB+LsRtKVY9BfTAh7yx8CZ3kbSuLWsqG8OvaGocHDpj7kcZpkHhc0myFTQ0DziYabmmezBEvlApjpLKZyqMM02Njm7HqulFlJFSFgKUWbROUKnQdRn42aK7XyxyL+k42eFkDonMPx8jpBXlh4UTxsfu1KJfrWfQRFNYuSQ3qLsyMcEAziwm9+eQm7OqBsFT8Nf/GsZI/c0ZF2g9ChiMYwQPvywvzitSUXpypf1JM3Hc9mxGzli0v0Ki13EYEzLgv5HWZ7sZgfqhOcv5hxSHGuY4cSglE6TstbdLnuVIIMpsfhjrKP5LfimgYNKx6oTfgzQgdwHGTruR X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 117a73f3-92d8-4fae-6521-08d82d96b028 X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4866.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2020 16:54:09.9215 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nWChS7XV8xXhyrFC8a2ELBkDjnRZ+jXE+oFlWAPAyLLutu1TiJ1VVr6QphSV6B9sYtmc75YgGbsWOS3HBRK45w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4739 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There is no need to hold a device global lock when initializing devlink device fields of a devlink instance which is not yet part of the devices list. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- net/core/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 6335e1851088..7df918a5899e 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -7421,9 +7421,9 @@ EXPORT_SYMBOL_GPL(devlink_alloc); */ int devlink_register(struct devlink *devlink, struct device *dev) { - mutex_lock(&devlink_mutex); devlink->dev = dev; devlink->registered = true; + mutex_lock(&devlink_mutex); list_add_tail(&devlink->list, &devlink_list); devlink_notify(devlink, DEVLINK_CMD_NEW); mutex_unlock(&devlink_mutex); From patchwork Tue Jul 21 16:53:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Parav Pandit X-Patchwork-Id: 1333191 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.a=rsa-sha256 header.s=selector1 header.b=TKGlcxM9; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BB4gj3wsNz9sR4 for ; Wed, 22 Jul 2020 03:04:01 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730781AbgGUREA (ORCPT ); Tue, 21 Jul 2020 13:04:00 -0400 Received: from mail-db8eur05on2057.outbound.protection.outlook.com ([40.107.20.57]:56928 "EHLO EUR05-DB8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730138AbgGUQyw (ORCPT ); Tue, 21 Jul 2020 12:54:52 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g1sevlU8AlX2aaK+40cNLCfVVabN+Atk2Hp0zsN+o9ja0ZgsCIpMyj2vzHAE5+3fVnBLsrK+EA3pygFj02k8WrXo1g902ySk+Zy4uYnLL595BYtCbn2UuzdEr9ffG0ZAUkSfkhuwTkym8RTQvZI83KanEp32QXAqSXpCkvuP6/43x0T0NJ7DZYI8SaAzlscvpGT5rlYzdOyXWfeXUEwXqDJIw7aLv8UJsX+WksDU4bg3Au29rRXOW7X50XKjOvRkKZdiUcbvDoOpX4hIDqlOu+Moat8Ii2ttrLJRKWfNSvdLhZPOALGlbShDDnCfire6GhCBWcKk7R+JBIwpllPCdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/XPLNUGn2LgmNozr7Ibkk/FWTpRcX922OJB2TVv0QWo=; b=hE9JvYLjy3e5ek+MWwv3ql00txwRIs9Goa2igTkkRUQslU4L7VbiwW680xRLEQV8H2ReIlmM43bjxVH260H2qShuLKQ4msJVUBPlbk+OmUrGCml5HA/HF9ME9vXN9gEw5M5uLhMS0aXjqhgZVx25CQwb51X2P0K68rgpetfJNAWhMc+mbI0bmq2Itts4zMtYEBZEaPRX06c7w/ihnU6YDivD+c6Ig5IjeihAvz1VekLXWlQW/SR96+SnrkfpDCtbeT9qWpKGGsi94cbCUCYtEl11xpQeOsvfTioiLNABKtZJgqR8HFMOxyL+revcu3jDgC10fxr+mvnTAUOBz2LY6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/XPLNUGn2LgmNozr7Ibkk/FWTpRcX922OJB2TVv0QWo=; b=TKGlcxM9XfgqJOvjm4EzFh9Y/6Rpp0HaroLQDUrTg3gmoM01UtVLZ1S1B6p9bk3/cjp3JLq7G4buRaASxmutFF1xThYXe+fbsLKBloVBx2D0eyRQRZY3sjX1n8BJGT3F6I4KPs9XR7J9DvroU2wAwLhzVV/vuOmk13QCtdDkVTc= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) by AM0PR05MB4739.eurprd05.prod.outlook.com (2603:10a6:208:ad::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Tue, 21 Jul 2020 16:54:10 +0000 Received: from AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7]) by AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7%2]) with mapi id 15.20.3195.026; Tue, 21 Jul 2020 16:54:10 +0000 From: Parav Pandit To: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net Cc: jiri@mellanox.com, Parav Pandit Subject: [PATCH net-next 2/4] devlink: Avoid duplicate check for reload enabled flag Date: Tue, 21 Jul 2020 19:53:52 +0300 Message-Id: <20200721165354.5244-3-parav@mellanox.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <20200721165354.5244-1-parav@mellanox.com> References: <20200721165354.5244-1-parav@mellanox.com> X-ClientProxiedBy: AM0PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:208:be::14) To AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from c-141-251-1-009.mtl.labs.mlnx (94.188.199.18) by AM0PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:208:be::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20 via Frontend Transport; Tue, 21 Jul 2020 16:54:10 +0000 X-Mailer: git-send-email 2.25.4 X-Originating-IP: [94.188.199.18] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 93b85bf7-9406-48cd-975f-08d82d96b0b7 X-MS-TrafficTypeDiagnostic: AM0PR05MB4739: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1122; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aAbdorw8GzDPrCTnJfJf/iLOyeunHOwZUIwzlofJq+krE3UwRj9rGIEMKutTyhdzVAqce1NQHaJrZx27mwfnLRjQQEI6Laty9r5l5sC1aTN+08MJDxE6PurOGQCGLviHHtLFnkebsTG8fXANCg14hFbXerS86MHxQo4d7RdLwztxiXcWIFqK+sCJwpaA/vmMoCno4eplMrcu83ewEKsMJoZLJM1lpbEmaxckVbLuaStoZtFwr6M0x2xL/God/yTv9saOUDO8Dc25f0N24sboNeK+UQ4CD9u8nUjSAukgoDJnY4nNg3v9MfEvB1Po7UejJa+lEcBaEdy4jkebeliJRA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR05MB4866.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39840400004)(366004)(396003)(136003)(346002)(376002)(316002)(1076003)(66556008)(2616005)(956004)(4326008)(26005)(186003)(16526019)(107886003)(8676002)(478600001)(8936002)(66946007)(66476007)(5660300002)(86362001)(6506007)(83380400001)(6486002)(6512007)(52116002)(2906002)(6666004)(36756003)(4744005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: +l0bQ4BmZFE7hT/0PNA1nnKkMyNVu1QaSUuUwFF+CLTbV48l7LWDBP/sdo95j3C+Nw99mvrnNjNLMs85zlgbG4rUGCoYKU6v3j9f18A7XvR9K3vaF19hJ5Zy3I5zf+q00dhFK9/en3++1ZSBBkpKVQ/1Z5y+77hmKqy7bYMkk50q2jmr0U4HETHbEhM9cPYhT7vOnyxNYAd3zzJesbSJ4hf5swiA8dWblOODOsA3U9kofwMrbWiqTJzR9Dc3xMMBHsieLeF8zV3ht27Fee0jiAc6/9sHOCn9nuNsLai+LqADvHZ/JM0FspP9FdH6BXEh+udSowbqv3tzFTNN1DTtAdmrL1f9tAyM7PFa8xGzN7H1NrYImfOXU5TkbeEr92MZSZsdldjTYqSLXbCOS1FmW4tII3LV9h61fQr79l9csI68hQJYAxwFKo+GqFALPtcla2Iaw5K2mn1pNRlTb9uSd0xvbWwwGGr2qls71jhY5tzrLpjQW8Ffy9VJj/LvMIb3 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93b85bf7-9406-48cd-975f-08d82d96b0b7 X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4866.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2020 16:54:10.7890 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ur3wbRb2FLGTlDuC0X2Gj0CWG3LIs3R0TRXgdMtbtvcgQFXVCjSUmRRvt4E966AXaXN1oDs7KG2DghmCo7jSFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4739 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Reload operation is enabled or not is already checked by devlink_reload(). Hence, remove the duplicate check from devlink_nl_cmd_reload(). Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- net/core/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 7df918a5899e..5c74e67f358c 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -2967,7 +2967,7 @@ static int devlink_nl_cmd_reload(struct sk_buff *skb, struct genl_info *info) struct net *dest_net = NULL; int err; - if (!devlink_reload_supported(devlink) || !devlink->reload_enabled) + if (!devlink_reload_supported(devlink)) return -EOPNOTSUPP; err = devlink_resources_validate(devlink, NULL, info); From patchwork Tue Jul 21 16:53:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Parav Pandit X-Patchwork-Id: 1333190 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.a=rsa-sha256 header.s=selector1 header.b=FbnadgO4; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BB4gf5mZ0z9sPB for ; Wed, 22 Jul 2020 03:03:58 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730776AbgGURD5 (ORCPT ); Tue, 21 Jul 2020 13:03:57 -0400 Received: from mail-eopbgr30041.outbound.protection.outlook.com ([40.107.3.41]:19076 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730263AbgGUQzW (ORCPT ); Tue, 21 Jul 2020 12:55:22 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C0LVvHxWCDwSFh5qWiDO1i9ugeVY8VkPJdhhttHBvdLyvQIhSRbCwXk1EVTAn3diINOaJZoq7MSG5UUAQPx224kbwjeSiMBC4VqHSHBGDwwI2yiGn1RpKY5+xwhFX+LsJgGV5J8fEutITH/iMwWEKuvSsp0Qdbbg4CjPtaK5oa8MspQepigU72zY0cuBNH0dQApAOhcobq6F9s+1/+KzIaglhxdwCKfe0LTwk2PIuxDsHPf2H3/S2o60pl+LEStSZrmpXbFDz0iUEr3ex6X43+BRDNidb681QNCCTKjoC5YolS+jYn9nE0ECI34mgN+lp1kuHrKkCJLnI8ZHE+Hv6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ax3QS0wIGk8aXSIqmLJDjVpFpIziO4J4E4PcEtAuX0I=; b=Vh37kez5Cp0bQauNrKGb8tWeZG0pFNf6MZ9koSl4TX8htvTZGw6vzGUiztru2RXPgkbLi5y9jjyaXVmPxullE9E5Gw2m3hx8EXvsGaFZ1mldx8+qZG3bl/IODL4h2uNknbxMN5ti49VlhdoCDXI8ogo1NUOlQirBMkPO5xj5H25RAbeiQpvUBozivRR+IQnX116lB+FhjQGy13QkbeYeAu+Mk5XE3LIBCRCmWXQbdl3Dr+c5dPqKVXMbni/zGGK8t2z66eDuIjqvVhwKnrvIqAwWYvw6x1fyUu3ol3hUKTJIu5lCMZeuRdrA2hyLWqd8BNX+8MVFFlHL9r82PITaMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ax3QS0wIGk8aXSIqmLJDjVpFpIziO4J4E4PcEtAuX0I=; b=FbnadgO4DYHKmiRFhmbOGdJg8c0/A5d0XBj/oT9+wyAB5HidISHbe3pX7/3VSvGwCayeirC4AEAAJvSUnWHT0/LS1sSeZ+8qtYuhRVb8zlZQbAGJEPAWej++35//e0OtxQAXvrkzGaHGCkbMGqVimE588Ec6f/PR/toKLRsgsSA= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) by AM0PR05MB4739.eurprd05.prod.outlook.com (2603:10a6:208:ad::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Tue, 21 Jul 2020 16:54:11 +0000 Received: from AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7]) by AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7%2]) with mapi id 15.20.3195.026; Tue, 21 Jul 2020 16:54:11 +0000 From: Parav Pandit To: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net Cc: jiri@mellanox.com, Parav Pandit Subject: [PATCH net-next 3/4] devlink: Add comment for devlink instance lock Date: Tue, 21 Jul 2020 19:53:53 +0300 Message-Id: <20200721165354.5244-4-parav@mellanox.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <20200721165354.5244-1-parav@mellanox.com> References: <20200721165354.5244-1-parav@mellanox.com> X-ClientProxiedBy: AM0PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:208:be::14) To AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from c-141-251-1-009.mtl.labs.mlnx (94.188.199.18) by AM0PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:208:be::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20 via Frontend Transport; Tue, 21 Jul 2020 16:54:10 +0000 X-Mailer: git-send-email 2.25.4 X-Originating-IP: [94.188.199.18] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: a5924e88-8bfc-4140-8532-08d82d96b139 X-MS-TrafficTypeDiagnostic: AM0PR05MB4739: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1360; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CPK9E02r7tPtSY1q4Dao2qL2StKnRpGWiv3ojOOxSB1xi2XFZ3VjPYtXzw/2sFhawDOWqaf3D2II4XoauWcAIbXpBAIAMPkl86HEiIB89pkfmi3G5LX/4K+7eHNPiMQ91j1RDDhbxDGF2lI5+WBurImhc7gqGrhd13KlqJloC8bO1oBfsWRAGRzd3jPPIZKyEI3rvEmLq4oaQXEsoF4RCM8oPC+awd5iqMovhDdDBptidWbtyYXjT7K3AGgaYVxu3z6B+CJesQLvVtzSX5yhjL1bJfKBfB3fGKYUp+aDV1ZUPy0zGEZs1s/XuEoyJGoMalJWyqs3Ij5cBXTvyWnXbA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR05MB4866.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39840400004)(366004)(396003)(136003)(346002)(376002)(316002)(1076003)(66556008)(2616005)(956004)(4326008)(26005)(186003)(16526019)(107886003)(8676002)(478600001)(8936002)(66946007)(66476007)(5660300002)(86362001)(6506007)(83380400001)(6486002)(6512007)(52116002)(2906002)(6666004)(36756003)(4744005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: qm9B1CDOrqK+/GVGHZCwnb3j+CWBph5HCR57EjkwmcztADcShW8/+Hh27JW8+kWu0M6d4u7Rk9FFCHPJIr+VqmH3QyeE2YkksawZNZAA+PIT3vS4ZZZWCm8oC0bREglS845JhVri+g1SX1R4H7ulyTcOR60Wed0h3es+c+Y1D6L9keWGL1E6BooPJl/Ytk2che6DBYsGVVsl4fcfj25ddPMtIk77Ni2VVNt4iT8HtXVT8Xu1uEyUXmbBC2oNugdxA4RUgpyx7NL1x1FoWJ7aNajYVdC4tWyVRf5LEIeR1KX4d2/COqYbYmvYfgzx74903Lzo4OaIct1pQyUJdBqIwggJM5RqK6zwjM6Ar01Q1u9GUzg7rj9X0qhlU59cJMQKMn8uNDQPc6epedsCYCCLjSa/XD84RFrccY4ZD9NqO5wSKAZi5smxogdJExpNBRH/WH/sYbUyQUHECXrxfsb5+6c+jVyYWbg2SdhozTYHc4soltuwo9RIjES2ujTPlzYD X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5924e88-8bfc-4140-8532-08d82d96b139 X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4866.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2020 16:54:11.7254 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5shwVPr1glYEoHQ+N0D9CG0IuGcS+LHm7UlsKOE+XFu5N2kEqk5BvJt+52NHZGFO/MCTtR9nDm3hZl3NyP2gsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4739 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Add comment to describe the purpose of devlink instance lock. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- include/net/devlink.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/net/devlink.h b/include/net/devlink.h index 913e8679ae35..19d990c8edcc 100644 --- a/include/net/devlink.h +++ b/include/net/devlink.h @@ -40,7 +40,9 @@ struct devlink { struct xarray snapshot_ids; struct device *dev; possible_net_t _net; - struct mutex lock; + struct mutex lock; /* Serializes access to devlink instance specific objects such as + * port, sb, dpipe, resource, params, region, traps and more. + */ u8 reload_failed:1, reload_enabled:1, registered:1; From patchwork Tue Jul 21 16:53:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Parav Pandit X-Patchwork-Id: 1333189 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.a=rsa-sha256 header.s=selector1 header.b=SvkCfeJt; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BB4XB62F4z9sQt for ; Wed, 22 Jul 2020 02:57:30 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730312AbgGUQ45 (ORCPT ); Tue, 21 Jul 2020 12:56:57 -0400 Received: from mail-eopbgr50063.outbound.protection.outlook.com ([40.107.5.63]:57383 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728042AbgGUQzv (ORCPT ); Tue, 21 Jul 2020 12:55:51 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hXcNU17tdH9p6XZrF2579sCadFkpXEQzERpRLgZPi5CtU5OUU8C9AtlljXSMZxkFgRZ91wrFUvfF4wXzbf0J6TRYNAmSmFKWXpsHRHOyEvErymQ/4MJbIuVdHjPYw2OgshBD1TjlPh8uBrfdBkgqyLehBg15d+yoUvJlZ4U9VM+GX6oYrHwf9ee2l8FryFE1zvOnkQ/6tP3f+ut06ITwuDjTTq/71NhB6SKgSnlWcvdd8IuJpwA3HfGz6G7KpgF1sUtpFqEsPS1daDjTXrPk0Qsv0oREt2qP2EcgXfx9DFLeDdsH3YBTGBTm4Dze9Ahm013YJ9Nn0Q+/XGPH2HOTGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+TSUuOflhyfbQvM20TbEMalN4E/XgoNZxrK5r7TcMAY=; b=OCT5rp6/a164ErSfuSrz2IyNAUf+8EYp+MzlIzL12yBogC6ANetVelURhICNWfsZvWTa2ne2hxuyNJdbsb4niS5fQc1NatSuMAwn/F2++7Dt6qeQe3EB/Q/zj7b9vYanVHjHZOmftYiYbaKVCS4Rr74MdouILUmNZ58cPaw4oyZqLld2A6PPMO9wg1mGzc5eTphSJXgc8sRysZcEr5KZO6lieVcbDBBGMxFeh0l8tNEzlX86bY6VXoJb5/jvRJVEx8b41MJPN0Um58CFxK0cEV17zUr/LF5Mz0/XA8bfQSw5vthYQGZFqt/iGlECKlC506OlDOV/lnLDWjmxzHS1oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+TSUuOflhyfbQvM20TbEMalN4E/XgoNZxrK5r7TcMAY=; b=SvkCfeJtqejHzLH7B1+0gvqLt1oYIHQsDKLBQEsU1tFiFzutZFSJLGz5/qDRg6kv4v8kII3xbycljfevpvby1mWjvlLrgRc31GM8biPoSWn/vOLpmqGSurkYatWU/Xv8YNejjpZmuR8CPBM/70UqJykDtPPF/cJ8zZP+4dBdfPQ= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) by AM0PR05MB4739.eurprd05.prod.outlook.com (2603:10a6:208:ad::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Tue, 21 Jul 2020 16:54:13 +0000 Received: from AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7]) by AM0PR05MB4866.eurprd05.prod.outlook.com ([fe80::d44d:a804:c730:d2b7%2]) with mapi id 15.20.3195.026; Tue, 21 Jul 2020 16:54:13 +0000 From: Parav Pandit To: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net Cc: jiri@mellanox.com, Parav Pandit Subject: [PATCH net-next 4/4] devlink: Constify devlink instance pointer Date: Tue, 21 Jul 2020 19:53:54 +0300 Message-Id: <20200721165354.5244-5-parav@mellanox.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <20200721165354.5244-1-parav@mellanox.com> References: <20200721165354.5244-1-parav@mellanox.com> X-ClientProxiedBy: AM0PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:208:be::14) To AM0PR05MB4866.eurprd05.prod.outlook.com (2603:10a6:208:c0::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from c-141-251-1-009.mtl.labs.mlnx (94.188.199.18) by AM0PR04CA0073.eurprd04.prod.outlook.com (2603:10a6:208:be::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20 via Frontend Transport; Tue, 21 Jul 2020 16:54:11 +0000 X-Mailer: git-send-email 2.25.4 X-Originating-IP: [94.188.199.18] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9e635fe8-f1a3-4289-2816-08d82d96b1cb X-MS-TrafficTypeDiagnostic: AM0PR05MB4739: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Di0ajh5amh7ElOn9zv6BMepdnbl6QY3wPh0AMSM3ket1Gl1OUmlRJn9R/RoM2Ul/EJLT07Roy01VM1xMz044+r+DdB9/+STT7DnisRUvo8NQxAoIYj2oEMvzWRU2jyB7OPW4mp0d81FAobygrKfXft49Z5YoseUuCNFX3pPBqMx41CEYWueq8FCIvTdI0Qo/ZxoWtl+LqcjWggb1P2RiKnYX4T5d18BFBJg/tbDEjB1S0Opj2jr6gNwFpysun8S5rP17AWSAc/JMKvU68N349pLEnH8AnTW4SSeSTnW8J7qNg2ehKGocvOqQBR3coZH/a4JjR+CkckDv/GFlS9q6Bg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR05MB4866.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39840400004)(366004)(396003)(136003)(346002)(376002)(316002)(1076003)(66556008)(2616005)(956004)(4326008)(26005)(186003)(16526019)(107886003)(8676002)(478600001)(8936002)(66946007)(66476007)(5660300002)(86362001)(6506007)(83380400001)(6486002)(6512007)(52116002)(2906002)(6666004)(36756003)(4744005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: ++xPVdHv1pIZrRswBtau4SYQrq7zwQANr/AM/+kbeeltPYc10v9B3tU+Q9zE5NzQG9ZrnZxOgmU3Um+1skHml02JNwkimvaCqU0ijwPlxIoyFN/+F8ruEwC6eQabizufelLCNo4Dk64BHuUZh1hvoHWBLEAi/Yy28W3u5I98exFTYOxXLnu0b9Coo0plk19pC7zIKRU/riUONJqziZ2VnAcdBj7RpQmoUohbJ5aukKveQ0DTGiPdJo6638XCEmOqaq3700DMDG+GAwuoPhvexHqCqspPix4KJfrxnBly0hLQEGeLfmfhYsyT4DafnYRkPvJpDCNZ4x1iVy6DuK9AI3fY2wLt9k0MKwN63U5g06xx7Cuj0AUhINoDt7pCk6+z+3DewNSqtpyP9QDsx8eLtb72YOqbXBOFfCqG2Mtn9EoE1GB0Rz2e36e7q7Q0FiI9q1U88qGHwa3FiTQlx0+jdRxFrLqpbj5dUE6TDUOEAVvc3z0wBczXRIlJkTD3GlJE X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e635fe8-f1a3-4289-2816-08d82d96b1cb X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4866.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2020 16:54:12.9367 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mA2DvIBoX3JGQSWAqGoOq1lYzkKe2BIpu8KdOhTAiBCt4twN2haH5Kf538eb80xkIzpAcH7LZXv9e5M+Pp9Opw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4739 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Constify devlink instance pointer while checking if reload operation is supported or not. This helps to review the scope of checks done in reload. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- net/core/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 5c74e67f358c..8b7bb4bfb6d0 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -2921,7 +2921,7 @@ static void devlink_reload_netns_change(struct devlink *devlink, DEVLINK_CMD_PARAM_NEW); } -static bool devlink_reload_supported(struct devlink *devlink) +static bool devlink_reload_supported(const struct devlink *devlink) { return devlink->ops->reload_down && devlink->ops->reload_up; }