From patchwork Wed Jul 15 15:42:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Organov X-Patchwork-Id: 1329635 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=ZhuvGLSW; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B6M9F5Fdgz9sRK for ; Thu, 16 Jul 2020 01:43:13 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726882AbgGOPnM (ORCPT ); Wed, 15 Jul 2020 11:43:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726782AbgGOPnJ (ORCPT ); Wed, 15 Jul 2020 11:43:09 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20F56C061755; Wed, 15 Jul 2020 08:43:09 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id t9so1313516lfl.5; Wed, 15 Jul 2020 08:43:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1aHu1Z5oC5ObOqs/+6g63oI0o5o93R9RpXFU6u5G/HM=; b=ZhuvGLSWsiH2pw+v4+oVujCGhm89HXMlPDUbPQ9wUjGrthgFMyt0zt1I2iEdBEMhXV yg5GL+cryij6SoQ5ikSpzX4c8pwy8AL5mvHANN0Z4rmT+dy51QlXOaTEwv6svhFF8R2A e6iJCqHprGbwYuh1u1I7ycYALuI/jk4sZvgHqHfsNSMnrUjAUZAveYMdQKi/4KkjxN1g brexi5Yl1gOkSwpxrxl8rk9jeBbwdiKRPGfkGAc0TBEwljomxblr1MlxZK7rf1UTwhBq OO5RsN3h/T77YaY5voKZ6Y7Qj2JAdSKJ+6BuGvVqYEf9ig5u1uA/NB4y3mzH3+7g1mFb q21Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1aHu1Z5oC5ObOqs/+6g63oI0o5o93R9RpXFU6u5G/HM=; b=XGeoQRSPK3r9jkqv2lv7NGLoI1n1pFGRRT/6FeHe26DPvGMXEaTY8xRiu3mBYJ7erm 4mC4BfmfgViopFY1R+bWRQp7addaXHwqrWGGsBaigGApIhHYyQ2SZ0Bdp2aMx0G+/rE6 NmfEHI/2Zw/KmBiSXOCXZBXvxpUfD/S3s0TWMn06zv6YMqPsbOOx9uw4pA3SZtR5Eytm yxiVVWplTinUyPT1viVevsbhWYF/0HyPPwLe+NP/+rz8AhRwo+uUtldHa5ZM454NokZY 7D/kxTpNOrhTC8u+ymwHocgOsO7oSyqMm1fsfvFlpz7lj+K8lVQqFElCwsNbemPsndgR rY1g== X-Gm-Message-State: AOAM533Ri4AD02y6RisrEM9QBAh2uNrgcMGofQYTxD8XmYzFHxalIsuu 1UsEtrpVDQLi2hMrCO8LFqYVdhVD X-Google-Smtp-Source: ABdhPJzKwvJ4zlI/+N/diNAQxT0W1RRuu+6jSnRydOQl4XxFD6fO69JzKQPe4moJxrxaxwyTreUqDw== X-Received: by 2002:ac2:52af:: with SMTP id r15mr5087333lfm.24.1594827787270; Wed, 15 Jul 2020 08:43:07 -0700 (PDT) Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id c6sm563955lff.77.2020.07.15.08.43.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:43:06 -0700 (PDT) From: Sergey Organov To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Fugang Duan , "David S. Miller" , Jakub Kicinski , Richard Cochran , Vladimir Oltean , Sergey Organov Subject: [PATCH net-next v2 1/4] net: fec: enable to use PPS feature without time stamping Date: Wed, 15 Jul 2020 18:42:57 +0300 Message-Id: <20200715154300.13933-2-sorganov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200715154300.13933-1-sorganov@gmail.com> References: <20200706142616.25192-1-sorganov@gmail.com> <20200715154300.13933-1-sorganov@gmail.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org PPS feature could be useful even when hardware time stamping of network packets is not in use, so remove offending check for this condition from fec_ptp_enable_pps(). Signed-off-by: Sergey Organov --- drivers/net/ethernet/freescale/fec_ptp.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index 945643c02615..fda306b3e21f 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -103,11 +103,6 @@ static int fec_ptp_enable_pps(struct fec_enet_private *fep, uint enable) u64 ns; val = 0; - if (!(fep->hwts_tx_en || fep->hwts_rx_en)) { - dev_err(&fep->pdev->dev, "No ptp stack is running\n"); - return -EINVAL; - } - if (fep->pps_enable == enable) return 0; From patchwork Wed Jul 15 15:42:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Organov X-Patchwork-Id: 1329637 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=YhvIU93Z; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B6M9V5R5Bz9sTF for ; Thu, 16 Jul 2020 01:43:26 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726844AbgGOPnW (ORCPT ); Wed, 15 Jul 2020 11:43:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726817AbgGOPnL (ORCPT ); Wed, 15 Jul 2020 11:43:11 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAF74C061755; Wed, 15 Jul 2020 08:43:10 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id u25so1322855lfm.1; Wed, 15 Jul 2020 08:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=irlNVEVgL3b659SmPZcMJRl5cSWSjkxsHANDUsS6bEY=; b=YhvIU93ZAedMmUhsNYI3M3crKIN2/G1r4MLUnsHm/dSq9XmKH7oBbfulHlqGiS4H7+ +6Yz2BIon7EAclrDBHGPO0Hj8J3X+U902mcsPGYyrOrPqlhKLqBEgrzdb4FIliyOUSKh dHFwJ1LkQ+s3IY0SmgC0bM4J3mY4Vhn+Z1MoY2rG3ei2QKlakp3UOpeWfCWS5aKznrdx KmCUU4ipXJSR/OFbsX03Awmm+RwUHr7zKKvpyuGCf2gR3x10hUkDvq7FhyL8wcvzpDve nmzTghv8zkJqB/+zu0qRSX45UFt5l08MQJWiLLMo24/XoYECBzJHfZpUeioEeM/cBz9Y tLfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=irlNVEVgL3b659SmPZcMJRl5cSWSjkxsHANDUsS6bEY=; b=JzTESOz60m3VR5I71NfZc9dQeBZbM7WNoPJqCU45yRXngfuKCDRLYe+eDyvUGOxRNd 3hyROC35SR1OWLVgB/K5Os4UzRNh9blSOO6uBGvjNbKVBu+GXhEGDRim/eeVVWy9jwNk nwRG2dwUuDsRNKAnWvYOuiRVpUXPQa+bJxu2bkdpOPd8TCZbR0yPdR/CxnfI5/JNejwI Wr17eb3sXDAOE62hyB6QbjKY20IVSHFV98ln/TQBkuvL6p8v6M04TWPmgc9zo/okBEM+ M8AjeFmA2slQYDeL+HifkhBT9B1qQ9dqF1Jjqy+eOn79aiqL7x0+Lrxy0b75q6dGd84F 1K8w== X-Gm-Message-State: AOAM531WJ+8hdauHxT751Yn7kFh/hD1shMF4o5MEkfugixC9rC5AQ4v0 2+gFU9Fl7pYDluq7uu7hRUu4T6Lh X-Google-Smtp-Source: ABdhPJw45TqAutQiNNGcMJPjWBO17zupJo+rP2MEtpG+jOHPotRo4L75Nx9jGynGPu7pnUYaF79sGw== X-Received: by 2002:a19:6b15:: with SMTP id d21mr5100636lfa.42.1594827788741; Wed, 15 Jul 2020 08:43:08 -0700 (PDT) Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id c6sm563955lff.77.2020.07.15.08.43.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:43:07 -0700 (PDT) From: Sergey Organov To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Fugang Duan , "David S. Miller" , Jakub Kicinski , Richard Cochran , Vladimir Oltean , Sergey Organov Subject: [PATCH net-next v2 2/4] net: fec: initialize clock with 0 rather than current kernel time Date: Wed, 15 Jul 2020 18:42:58 +0300 Message-Id: <20200715154300.13933-3-sorganov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200715154300.13933-1-sorganov@gmail.com> References: <20200706142616.25192-1-sorganov@gmail.com> <20200715154300.13933-1-sorganov@gmail.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Initializing with 0 makes it much easier to identify time stamps from otherwise uninitialized clock. Initialization of PTP clock with current kernel time makes little sense as PTP time scale differs from UTC time scale that kernel time represents. It only leads to confusion when no actual PTP initialization happens, as these time scales differ in a small integer number of seconds (37 at the time of writing.) Signed-off-by: Sergey Organov --- drivers/net/ethernet/freescale/fec_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index fda306b3e21f..4bec7e66a39b 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -264,7 +264,7 @@ void fec_ptp_start_cyclecounter(struct net_device *ndev) fep->cc.mult = FEC_CC_MULT; /* reset the ns time counter */ - timecounter_init(&fep->tc, &fep->cc, ktime_to_ns(ktime_get_real())); + timecounter_init(&fep->tc, &fep->cc, 0); spin_unlock_irqrestore(&fep->tmreg_lock, flags); } From patchwork Wed Jul 15 15:42:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Organov X-Patchwork-Id: 1329638 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=DgQlUqkl; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B6M9X4FNBz9sTF for ; Thu, 16 Jul 2020 01:43:28 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727044AbgGOPnV (ORCPT ); Wed, 15 Jul 2020 11:43:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726844AbgGOPnL (ORCPT ); Wed, 15 Jul 2020 11:43:11 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AA0CC08C5DB; Wed, 15 Jul 2020 08:43:11 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id y18so1302807lfh.11; Wed, 15 Jul 2020 08:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tEdKCVDLZGVZ3tN0zkYKOC8QapxBfjEj8eJsemdKTfg=; b=DgQlUqkljUuMfbPQAmuG3IecWH11NjaKMWqu08MskNX2cT8b+TB7ie4HcPaRE0USo/ IIZJhzJfL/a491GQkRAjdUlmNKq5qxHKY53lUkV1fmILnAOvFc6/2H15zrRACD6VXnYW VxGa7EJIrPJMQ49C4jLCj5SX38tl/hGsuGtmhy1csZr9+vFfZhUR7PujGXBhAtSUHvYC jb4itMb6Bkcqjw/OFJjs8h2EwEP/CE8XjyFGWX6q9wLH0HNlO64zUOof6EBvlbw7YVTO df3aiU7AL208w+nnr1JBZ47Qf7u5iJsl9NQjR2i1bNOKCbcBE6t1+OEz/jTrbRpIQW+4 Vggw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tEdKCVDLZGVZ3tN0zkYKOC8QapxBfjEj8eJsemdKTfg=; b=pWhYBSjaU5cWrj/ZX/JsDZihvnh+VUPMs+G6bE758Xm9sxY8oxAjvb+rkGR6wz26g5 qX4hoxDQg9PNrJs6mBzyNxK461thlvCLdpHEnIPiYbJhhgNQoC7UgLZEz+BrAZKSjcHg 2gEFkEOwDkkXIOr4oCEIEtSyRjjZ4IKr0zTqC+6IHRPltIuu/YYnZY8CbBLY4GVKSubl KtXvFAKSQZrd0TzW2UucaemMyWohBkTL9cBlfQuDJp9fqPZZaybbdcEa4BZHviecRaqA XgIWioXq1WYPBRvZSAoy2x9oAhgYplKcrRRCm/BKT5e738ELtr34mDL2mWGnDIhZnH0/ 8WMg== X-Gm-Message-State: AOAM533S3UDPOkLqi8p6cjNembDJZmTydvXt9ck/jS9ILY0PmF+tmUSP ToysDVyQnDa4HBMU5Lrvzz58MU+E X-Google-Smtp-Source: ABdhPJxq6AXbsDOZg5EvR7C0cm2ePDQrho3VnBJFzK+arlpMFNitMlsICk/7WoMlwkkpdDJ9a7yTaw== X-Received: by 2002:a19:e93:: with SMTP id 141mr5099508lfo.107.1594827789804; Wed, 15 Jul 2020 08:43:09 -0700 (PDT) Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id c6sm563955lff.77.2020.07.15.08.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:43:09 -0700 (PDT) From: Sergey Organov To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Fugang Duan , "David S. Miller" , Jakub Kicinski , Richard Cochran , Vladimir Oltean , Sergey Organov Subject: [PATCH net-next v2 3/4] net: fec: get rid of redundant code in fec_ptp_set() Date: Wed, 15 Jul 2020 18:42:59 +0300 Message-Id: <20200715154300.13933-4-sorganov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200715154300.13933-1-sorganov@gmail.com> References: <20200706142616.25192-1-sorganov@gmail.com> <20200715154300.13933-1-sorganov@gmail.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Code of the form "if(x) x = 0" replaced with "x = 0". Code of the form "if(x == a) x = a" removed. Acked-by: Fugang Duan Signed-off-by: Sergey Organov --- drivers/net/ethernet/freescale/fec_ptp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index 4bec7e66a39b..0c8c56bdd7ac 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -473,9 +473,7 @@ int fec_ptp_set(struct net_device *ndev, struct ifreq *ifr) switch (config.rx_filter) { case HWTSTAMP_FILTER_NONE: - if (fep->hwts_rx_en) - fep->hwts_rx_en = 0; - config.rx_filter = HWTSTAMP_FILTER_NONE; + fep->hwts_rx_en = 0; break; default: From patchwork Wed Jul 15 15:43:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Organov X-Patchwork-Id: 1329636 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=eAkwWsC4; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B6M9J4r5Sz9sTQ for ; Thu, 16 Jul 2020 01:43:16 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726973AbgGOPnP (ORCPT ); Wed, 15 Jul 2020 11:43:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726402AbgGOPnN (ORCPT ); Wed, 15 Jul 2020 11:43:13 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED038C061755; Wed, 15 Jul 2020 08:43:12 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id b25so3110319ljp.6; Wed, 15 Jul 2020 08:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4Uquz2cUXAsNkebI07cUnJTpD7lMymggdeIx4TLm5Zs=; b=eAkwWsC4SvtuONlDmsXgzlEuVDoQKmQdtfQxKrKRCCgcvU2UW55qZ2P9GQoKQLccrM AlJVR0MiOzGB7kSsPS1z5OrkEkpkPYglQxi+0HxLgJH615zHjfrXeEDSceS0zvN0TA7o bAcX7wzyA9oNj2UpN3MrtjBwK6YkwTjhe57eFxFv3KfrbIv2/1E4/UflcczzdVZRf0y2 sKxOK1T6KLv2UQBf2ZacHqeHcIQZNxlM9JV0XUGXEMc2BT2C/K3XiVVvlikyZoVSKDw1 TzcakFppiacvwmS+pPR3XMDPLU9GLg7f8zJlTvIdJtXX2gGU5GfHE07zSHp+ibHOrCBs N1ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4Uquz2cUXAsNkebI07cUnJTpD7lMymggdeIx4TLm5Zs=; b=mzCbf7D/jIF6dvZXrGqH9FKsT1m9xY0g+AcAKgwyuF1zFhiEQW0CHshZeo8jEYvS20 eWJDVF75mPHROzqPZBDZJt2ZxhkGAeYQohC9Pp+Lpb/mEiaJXxW92q9gwKTOs4f/FJrX CEx6DOibNixCSZU2ep8I3wptQ/Blmu55e8P6o8uUOucJQ9dBHn8ltBH6eS3b5Xr52UTY SNcs9EEBnQPhesd5p0U5s8GiWc+PtTZLLYLb8xeWD1VUPPI7SHDlCzloZ9ShBemgBKhA GcxNjM96iJYRR3kovHl2fm8/dd7c8OKkFUfi53LBS6+IRQMk3XDdKZpxj4G4HJc1QmFp upiA== X-Gm-Message-State: AOAM531iCM8oXMvTg+8qR1ura68Qv34yM76DLiqZbgGLwDhDhwLj/J5J kThAd5F5n2oDWLIr/cps9ply6eJr X-Google-Smtp-Source: ABdhPJy9n946MWIITS2PG4rpk28bH1oXW/JL416AzmkGtAiqAOCgDNrkrCxc0idvXr9zLr0B1G5EAQ== X-Received: by 2002:a05:651c:511:: with SMTP id o17mr4820999ljp.433.1594827791169; Wed, 15 Jul 2020 08:43:11 -0700 (PDT) Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id c6sm563955lff.77.2020.07.15.08.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 08:43:10 -0700 (PDT) From: Sergey Organov To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Fugang Duan , "David S. Miller" , Jakub Kicinski , Richard Cochran , Vladimir Oltean , Sergey Organov Subject: [PATCH net-next v2 4/4] net: fec: replace snprintf() with strlcpy() in fec_ptp_init() Date: Wed, 15 Jul 2020 18:43:00 +0300 Message-Id: <20200715154300.13933-5-sorganov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200715154300.13933-1-sorganov@gmail.com> References: <20200706142616.25192-1-sorganov@gmail.com> <20200715154300.13933-1-sorganov@gmail.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org No need to use snprintf() on a constant string, nor using magic constant in the fixed code was a good idea. Signed-off-by: Sergey Organov --- drivers/net/ethernet/freescale/fec_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index 0c8c56bdd7ac..93a86553147c 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -570,7 +570,7 @@ void fec_ptp_init(struct platform_device *pdev, int irq_idx) int ret; fep->ptp_caps.owner = THIS_MODULE; - snprintf(fep->ptp_caps.name, 16, "fec ptp"); + strlcpy(fep->ptp_caps.name, "fec ptp", sizeof(fep->ptp_caps.name)); fep->ptp_caps.max_adj = 250000000; fep->ptp_caps.n_alarm = 0;