From patchwork Tue Jul 14 19:40:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Upadhyay X-Patchwork-Id: 1329072 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=eP79sZLC; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B5rV052mdz9sRf for ; Wed, 15 Jul 2020 05:40:56 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730031AbgGNTkt (ORCPT ); Tue, 14 Jul 2020 15:40:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729266AbgGNTks (ORCPT ); Tue, 14 Jul 2020 15:40:48 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E4B6C061794; Tue, 14 Jul 2020 12:40:48 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id o22so2000715pjw.2; Tue, 14 Jul 2020 12:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=wNJ0xqiQMwf9wWolmo2V4dwfmbUBzz5d6DDV7wSVVDU=; b=eP79sZLCqJtSL9WEEFX5EaaYP2heGJfFeAyQ6tvZshn/yxxu+m+xqfmi+SdX3bhtrc RJtmkqNoiZ4yw9eYBsVPjYCkFllcW4K8ObnGQfh/R1lOCK8Su4l5gURpSSiFk2rkmAVJ 7RIUwCO6eyIRY6MN4N14tUg+cToCHO7udjv1j2lfp64Qux6zmV1IrlV2PKhQ2I0g5krl RdYNQIyzhUxe3RAnSzwOv3XtTNf1bl4HVYmWCS7DA8imU9NDoGKww0s4k59+gaqSBFAJ qoudDtigrhf+aETbaGdAWu2aDXqH3fGt94qWSFsRDd6YT7essvT/eYq2uRyFJVYdFrxs 6XJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=wNJ0xqiQMwf9wWolmo2V4dwfmbUBzz5d6DDV7wSVVDU=; b=S99DAi/hco5dTwOffn3aMk69OBd7Tf1EhVaySvxu8MHBqEuntWxKIVYc+AUrlll9YT YDP7x+SrSEfRrQpR4ZAkyoM5tRPHe/mlE1z6cpuilzjRxWPpYWXLDvXnBcuwo9Aymn/x cSLtYCckgtNNWo7SvTu1SzTZoljqFJuW56kEG2I4k+AgGRe3Wrt6OymrxGQB6HZmZ0aZ x/e8pvvASJ0do3y9t9HxaISXJRuxhWEAebeYm81oyIeR4EnwAvjhCy46eMcblRsRPTfi ZqwN8FDGgQMy4wb6HxFzgViTxUTDvPIz72lqT7jxfQONp1rzPu1ipyRCp/Nxp7NBrmxM oywA== X-Gm-Message-State: AOAM532uRqLTtTRRL5cjd+3DFtiXqe9t0RX/3FOmpuz08mtAiY4XUWhg ENjSpJo6s8Zsd122JZs5bYc= X-Google-Smtp-Source: ABdhPJyyflRxQgKU+fmkrQq4IN69SodmKNRAcSYeuyBMhZoOiLpFcwnXc5U0QG974Y1D0I4womwZ+g== X-Received: by 2002:a17:90a:1f81:: with SMTP id x1mr5717456pja.115.1594755648184; Tue, 14 Jul 2020 12:40:48 -0700 (PDT) Received: from blackclown ([103.88.82.145]) by smtp.gmail.com with ESMTPSA id h23sm5569pfo.166.2020.07.14.12.40.45 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Jul 2020 12:40:47 -0700 (PDT) Date: Wed, 15 Jul 2020 01:10:35 +0530 From: Suraj Upadhyay To: jeffrey.t.kirsher@intel.com, davem@davemloft.net, kuba@kernel.org Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 1/4] e1000/e1000_ethtool.c: Remove unnecessary usages of memset Message-ID: <20200714194035.GA21382@blackclown> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Replace memsets of 1 byte with simple assignments. Issue reported by checkpatch.pl. Signed-off-by: Suraj Upadhyay Tested-by: Aaron Brown --- drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c index 0b4196d2cdd4..f976e9daa3d8 100644 --- a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c +++ b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c @@ -1356,8 +1356,8 @@ static void e1000_create_lbtest_frame(struct sk_buff *skb, memset(skb->data, 0xFF, frame_size); frame_size &= ~1; memset(&skb->data[frame_size / 2], 0xAA, frame_size / 2 - 1); - memset(&skb->data[frame_size / 2 + 10], 0xBE, 1); - memset(&skb->data[frame_size / 2 + 12], 0xAF, 1); + skb->data[frame_size / 2 + 10] = 0xBE; + skb->data[frame_size / 2 + 12] = 0xAF; } static int e1000_check_lbtest_frame(const unsigned char *data, From patchwork Tue Jul 14 19:41:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Upadhyay X-Patchwork-Id: 1329073 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=U4GSwduR; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B5rVj5q9Mz9sRf for ; Wed, 15 Jul 2020 05:41:33 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730136AbgGNTlc (ORCPT ); Tue, 14 Jul 2020 15:41:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729465AbgGNTlb (ORCPT ); Tue, 14 Jul 2020 15:41:31 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98BFCC061755; Tue, 14 Jul 2020 12:41:30 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id k5so7428106plk.13; Tue, 14 Jul 2020 12:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=niAIjn+Een/amQTg5fN18KJRwMOstxeUEV0t203OE2I=; b=U4GSwduRBIN/yTj+kSe1e3FhlYu/eU+cNd3YvmhAgwNpYObKc0ECpYaCaH/2CfjvbC IpqBWb44SwRTcVaIf1U3pUOENQcwd2PTZYbEDJTHLSpmuY0BGenZJkq4l2PIrR89ANoB KbkmGpnvSUb4wdeuAZQFz0x/z6xk61MwIgK+JTRIyzEYluvVUM7IaXpHFL2F17LFh1/s npt0w4UMgdTBr3F3ba5j6MX2kRR8wzeANYFiwaXeHBQjb1+62g/LcMhLNBdJcZI0CVby DwwZcRJTa6pQoanI2h7/ji6UxrcUQ7/VHgftXOKvybMx/C5wwtuPZGGddVHWEolYWzsl Gupw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=niAIjn+Een/amQTg5fN18KJRwMOstxeUEV0t203OE2I=; b=SUnl8mtgfjIHzPTeWNe0BFJF8+7V6wqJduFqwd1pWlXgBSCDv7U78dxxodJ/d5eILY 9JZus02DTRizUdUBgeuUFDTU/4CtxP5oBnSg0oSkwzohJ2VgGKlCQjHNVcCjHaIsOdpG IT0ZSrwVoAJapSzzQAv3kkjsWIkypFxQFmBpnnezQgTvOEjbljZZvEkfrXqBqrK6se45 s8TxSo2wJp7fDiC7bWnvwMNVA1iHYj7iQ86uvHd0E8N9aX9MXrVMEO5XS6i+uEmCyy2w mG3+ogD3UfW+3RRsTPrc/fD2D1gO9M90TyMvw5UKngNI+eCC8Jqdat49O3ykQ1ygDHWP 7scg== X-Gm-Message-State: AOAM531XZN5jn0j20THUqq76qL8o48LI6gcOyNQAI3sM1UABGpI02sJ5 MNizwmRgmFRKvjMFSPOMLKk= X-Google-Smtp-Source: ABdhPJxnqN8nrX9Fqfy1W5R/qQtza/2Q/DP10I0i1HHBCyZOqj/LDHNKzVdELgVVBxO9fEp/MDav7g== X-Received: by 2002:a17:90a:72c7:: with SMTP id l7mr6645940pjk.34.1594755690151; Tue, 14 Jul 2020 12:41:30 -0700 (PDT) Received: from blackclown ([103.88.82.145]) by smtp.gmail.com with ESMTPSA id r204sm9234pfc.134.2020.07.14.12.41.27 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Jul 2020 12:41:29 -0700 (PDT) Date: Wed, 15 Jul 2020 01:11:17 +0530 From: Suraj Upadhyay To: jeffrey.t.kirsher@intel.com, davem@davemloft.net, kuba@kernel.org Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 2/4] e1000e/ethtool.c : Remove unnecessary usages of memset. Message-ID: <20200714194117.GA21460@blackclown> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Replace memsets of 1 byte with simple assignments. Issue found with checkpatch.pl Signed-off-by: Suraj Upadhyay Tested-by: Aaron Brown --- drivers/net/ethernet/intel/e1000e/ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c index 64f684dc6c7a..a8fc9208382c 100644 --- a/drivers/net/ethernet/intel/e1000e/ethtool.c +++ b/drivers/net/ethernet/intel/e1000e/ethtool.c @@ -1608,8 +1608,8 @@ static void e1000_create_lbtest_frame(struct sk_buff *skb, memset(skb->data, 0xFF, frame_size); frame_size &= ~1; memset(&skb->data[frame_size / 2], 0xAA, frame_size / 2 - 1); - memset(&skb->data[frame_size / 2 + 10], 0xBE, 1); - memset(&skb->data[frame_size / 2 + 12], 0xAF, 1); + skb->data[frame_size / 2 + 10] = 0xBE; + skb->data[frame_size / 2 + 12] = 0xAF; } static int e1000_check_lbtest_frame(struct sk_buff *skb, From patchwork Tue Jul 14 19:41:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Upadhyay X-Patchwork-Id: 1329074 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=WEBXB6ig; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B5rWJ42jnz9sRf for ; Wed, 15 Jul 2020 05:42:04 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730185AbgGNTmB (ORCPT ); Tue, 14 Jul 2020 15:42:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729465AbgGNTmA (ORCPT ); Tue, 14 Jul 2020 15:42:00 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86FF2C061755; Tue, 14 Jul 2020 12:42:00 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id s189so2993840pgc.13; Tue, 14 Jul 2020 12:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=U6wnNdQGYzjTM+8H6Cnp8bIF9ECNSsdex0J9VIEDN8k=; b=WEBXB6igBdu6ROj5Tdt64QJhL9xOAqNkJGXW4MpgsabaGHtlIGrooBXTq2dhm+LkN8 s5ZXTb3KBqo7i+kWvyGCtH390hxDCSYK4tJfuN9GR5b8UOq1qxOE5tclLpgxfiRt/jLN fexCwCWqOc/97/UfokXolHj9N/jgDWsCahnzPR8tURwoHDXh9BG6AModtiVlIrhpnm6P UlRVg3weGUgWq4TV8OZArK7KTH22VzL8415ELf9x7TATwVBhKRUPQtEHuekmIEqztx5R LMTt528AWoPrcr3bBZzx70w+ZsP+2l8Bx3omLxio+wt2l/IqwUdd86x+AKeqxbihbTmr gXIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=U6wnNdQGYzjTM+8H6Cnp8bIF9ECNSsdex0J9VIEDN8k=; b=Ip15Brb4hB8KMM+zCbcWP661PDpCxpOOhzsrQj0D4oPM2bd+cTS72E5Ns1I2sBB0I9 l7VlNQkkVyWk4WCpe4hMP58JKRLimxg5kkGueKhoRwceecwcApz9Xd1pRdzXVnMa3qT3 iBnXsy1OdqVxSNP7CsKt1GwtIByDyFAfc2wywVKIypZ4SkuM+eB4hnU34PR7KFbx1Dba tik1oKoJBujwDeLnyhMhIrmJr6MSU+ZhIZQnBhX33t8XHSAtQg/1D/nI120dBfw0eC8d lJjw62dvmak2tQjLnVTjLHlUT25VEt3Sp6n2PPYTU3IjLYdIh8RB9hxL4F6DR5p4M14A jopw== X-Gm-Message-State: AOAM530fnhSQgtAFpllmj449sseP3bbAbF0/OiFOET72xWuzSrj57xOd XlVjUH2PQ40txJf/LSoXWiA= X-Google-Smtp-Source: ABdhPJybSvB/F9GjQ0jmE43Re8wHuZG9KV1oJjCCUTGugBHRSsDGybtJm4nzTYbu5nOAY0VAf9qYGQ== X-Received: by 2002:a62:8f50:: with SMTP id n77mr5343854pfd.259.1594755720063; Tue, 14 Jul 2020 12:42:00 -0700 (PDT) Received: from blackclown ([103.88.82.145]) by smtp.gmail.com with ESMTPSA id z1sm16815171pgk.89.2020.07.14.12.41.57 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Jul 2020 12:41:59 -0700 (PDT) Date: Wed, 15 Jul 2020 01:11:47 +0530 From: Suraj Upadhyay To: jeffrey.t.kirsher@intel.com, davem@davemloft.net, kuba@kernel.org Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 3/4] igb/igb_ethtool.c : Remove unnecessary usages of memset. Message-ID: <20200714194147.GA21537@blackclown> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Replace memsets of 1 byte with simple assignment. Issue found with checkpatch.pl Signed-off-by: Suraj Upadhyay Tested-by: Aaron Brown --- drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c index c2cf414d126b..6e8231c1ddf0 100644 --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c @@ -1782,8 +1782,8 @@ static void igb_create_lbtest_frame(struct sk_buff *skb, memset(skb->data, 0xFF, frame_size); frame_size /= 2; memset(&skb->data[frame_size], 0xAA, frame_size - 1); - memset(&skb->data[frame_size + 10], 0xBE, 1); - memset(&skb->data[frame_size + 12], 0xAF, 1); + skb->data[frame_size + 10] = 0xBE; + skb->data[frame_size + 12] = 0xAF; } static int igb_check_lbtest_frame(struct igb_rx_buffer *rx_buffer, From patchwork Tue Jul 14 19:42:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Upadhyay X-Patchwork-Id: 1329077 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=AXt6kevx; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B5rWq0l30z9sSn for ; Wed, 15 Jul 2020 05:42:31 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730343AbgGNTm1 (ORCPT ); Tue, 14 Jul 2020 15:42:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729329AbgGNTm0 (ORCPT ); Tue, 14 Jul 2020 15:42:26 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BED1C061755; Tue, 14 Jul 2020 12:42:26 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id s26so8017344pfm.4; Tue, 14 Jul 2020 12:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=PQoiTk/94i+cEQXK8JsAB0AkTjYJXwZwOn4dJ+xwUDg=; b=AXt6kevxd3MbkPZ1VCvIa7CWEeXW1Hnzu9JlVFfg+1OzvgzUAs4ASun5mkK+0k500o 54P7OkAxIMaeRNbb/vjw0CL+AutZpp0r7vyr5oyUq4ShbS2sVv/2A0MWOOff+TCUY+GK pKhZ2JjaGSpeJShOUUlm56WAoCdzjQg0SPcnrkLVptvoSMr5T1Sf0HXgY2zsFwfsPWm7 8xSYOIfbXa2kgyKX++hsK8Zo0qwamVWWPEzJ9ZaztPc5qb4phTanBGehRlouMu37JdT2 E1mOz3JeXHs6zZyqFIEezDNeKtT8bcUCsxRPjyv/6wcz6xCO27uD+xryOUOnbqiuvk3/ s5Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=PQoiTk/94i+cEQXK8JsAB0AkTjYJXwZwOn4dJ+xwUDg=; b=DESTiRP7FsW38nmw1gQZbi3qU8xRLcn71EQXmRD5PyMl6Myay80O6zjOZ9c7TqFjU6 j+wLU/+kBEMs9x5pqrBamK8lKJkUi5xorzW7eMaWwPlajXxKz04W/KUUOqz0IKA9UmL4 0TZpxxacJ/CW3hOM9jK3Jw8ibWPIz+u5fCx8wrSecRWWbJigL6CiKskrvC8dfjodVy0g DKrx7/oBmOW3GJ7626jGHYcPEbZktjs8w2UUX6vCGdW+c/nrGaQM324liUAtphPLK5W7 yT2DXWPkIxLD424E+u6vbOu5zXVRg8y2CsQk6aM0x7q62bmoPJvXSbWgTLYlwiZwTIBP DQBQ== X-Gm-Message-State: AOAM5323sFKUVeqHJAVqZsecNnmo+Rdj+nIAURbDUOhKFhZQhzj8dArv ysEUxseC+GZIf7pm54nw9bc= X-Google-Smtp-Source: ABdhPJwAec0PSq8vCkDHhMwK5e+77YkqFKNDRznTfSIalx/Ujpnz4QHpwP48pufGGWmOeeKFrr9t7g== X-Received: by 2002:a05:6a00:f:: with SMTP id h15mr5547490pfk.193.1594755745915; Tue, 14 Jul 2020 12:42:25 -0700 (PDT) Received: from blackclown ([103.88.82.145]) by smtp.gmail.com with ESMTPSA id g6sm10805pfr.129.2020.07.14.12.42.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Jul 2020 12:42:25 -0700 (PDT) Date: Wed, 15 Jul 2020 01:12:13 +0530 From: Suraj Upadhyay To: jeffrey.t.kirsher@intel.com, davem@davemloft.net, kuba@kernel.org Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 4/4] ixgbe/ixgbe_ethtool.c: Remove unnecessary usages of memset. Message-ID: <20200714194212.GA21612@blackclown> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Replace memsets of 1 byte with simple assignment. Issue found with checkpatch.pl Signed-off-by: Suraj Upadhyay Tested-by: Andrew Bowers --- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c index 6725d892336e..71ec908266a6 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c @@ -1951,8 +1951,8 @@ static void ixgbe_create_lbtest_frame(struct sk_buff *skb, memset(skb->data, 0xFF, frame_size); frame_size >>= 1; memset(&skb->data[frame_size], 0xAA, frame_size / 2 - 1); - memset(&skb->data[frame_size + 10], 0xBE, 1); - memset(&skb->data[frame_size + 12], 0xAF, 1); + skb->data[frame_size + 10] = 0xBE; + skb->data[frame_size + 12] = 0xAF; } static bool ixgbe_check_lbtest_frame(struct ixgbe_rx_buffer *rx_buffer,