From patchwork Mon Jul 13 12:15:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Upadhyay X-Patchwork-Id: 1327917 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=AKk8DOTp; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B52fN6ncBz9sRN for ; Mon, 13 Jul 2020 22:15:24 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729735AbgGMMPV (ORCPT ); Mon, 13 Jul 2020 08:15:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729143AbgGMMPU (ORCPT ); Mon, 13 Jul 2020 08:15:20 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1164DC061755; Mon, 13 Jul 2020 05:15:20 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id w2so5932178pgg.10; Mon, 13 Jul 2020 05:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CngMTDKicRpGsYdV84WEl9k2HNLxAMPDNQJc4li0NJg=; b=AKk8DOTp4rMxlJ8l4EPNhHU9SB8X1hd/H6jmMzRGlZuExBZ4jFqyrebmjVsUjbgI42 fmy1YojOiOrzkQg2zhMnVYY9/sWERz9dqP4hZGPTmch0SyFbkQEKARm5Uabq3WDSaaUc bWb9ctloxEVOL83jY5b7GgpmtUanndBVO6qK0oFcZbaheYe/J+6UOWZKDsaNwrjVLjWv ncJj5KQaD5LknFiiCSgIWeiTfOe81ahB6XdxCf/+6XR5JvgWUHQQZDqhbhE0/Rev+mtd QoNXmhIqcV7uPND8T/M5bryq4CBi7R4lCVsofBVvrG3aRiAIhoTAbpH4phgaMIDPHMwT ZXWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CngMTDKicRpGsYdV84WEl9k2HNLxAMPDNQJc4li0NJg=; b=A8xVhjUyfgyyU1nEooFhxNPM5f+YhRxm470h4WVYU/gUiY0HA1P4LWUtDWz0YJ2L/S kr85c3Hyq9UdB4Z18qweCvfKzKNF/zGTOWilhyzceMSNE2Zj1WhdUynffBLi5KjSWbh8 XnacmEr2ulc1ZSgRr9F8/DrtRstjTI3FzXVK9Nq+q79dLVj2I2aYrbkObaStBMAcdFMo wWK4YE0jkbc2ZfaNW78wnee5MujJL6k5WqQwme91CUG0Z6MmJH2piKKVbGMAHbEQmBnM Gj9V1+GKh6fqWmZOocS5ItJCszffLsnEzkRABZosg5tfaH972t7tyZ6JZPk/IIk3K9PK 9cXg== X-Gm-Message-State: AOAM531D27z/V58Q0lX/1HSHCao6RF7ScfuYjYg6EwiVY9j3iu27kd5q 9KrROIekxasnTP49WAuHbm/DRlLmdEFCZQ== X-Google-Smtp-Source: ABdhPJzL4TVE2ZmLdK+X8Ime38AucFBJP/ru8QjY494q9pZhTWeJLxmhEama436Fg3gRphnMt2sahg== X-Received: by 2002:a63:e80e:: with SMTP id s14mr63928961pgh.32.1594642519579; Mon, 13 Jul 2020 05:15:19 -0700 (PDT) Received: from blackclown ([103.88.82.220]) by smtp.gmail.com with ESMTPSA id o8sm13164541pgb.23.2020.07.13.05.15.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Jul 2020 05:15:18 -0700 (PDT) Date: Mon, 13 Jul 2020 17:45:05 +0530 From: Suraj Upadhyay To: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, gregkh@linuxfoundation.org Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] staging: qlge: qlge.h: Function definition arguments should have names. Message-ID: <2d788cffeec2dad9ce9562c15a69d8b63ed0b21f.1594642213.git.usuraj35@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Issue found with checkpatch.pl Signed-off-by: Suraj Upadhyay --- drivers/staging/qlge/qlge.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h index 05e4f47442a3..48bc494028ce 100644 --- a/drivers/staging/qlge/qlge.h +++ b/drivers/staging/qlge/qlge.h @@ -2057,8 +2057,8 @@ enum { }; struct nic_operations { - int (*get_flash)(struct ql_adapter *); - int (*port_initialize)(struct ql_adapter *); + int (*get_flash)(struct ql_adapter *qdev); + int (*port_initialize)(struct ql_adapter *qdev); }; /* @@ -2275,7 +2275,7 @@ int ql_mb_set_port_cfg(struct ql_adapter *qdev); int ql_wait_fifo_empty(struct ql_adapter *qdev); void ql_get_dump(struct ql_adapter *qdev, void *buff); netdev_tx_t ql_lb_send(struct sk_buff *skb, struct net_device *ndev); -void ql_check_lb_frame(struct ql_adapter *, struct sk_buff *); +void ql_check_lb_frame(struct ql_adapter *qdev, struct sk_buff *skb); int ql_own_firmware(struct ql_adapter *qdev); int ql_clean_lb_rx_ring(struct rx_ring *rx_ring, int budget); From patchwork Mon Jul 13 12:15:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Upadhyay X-Patchwork-Id: 1327918 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=PYbQPk6S; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B52g712pyz9sQt for ; Mon, 13 Jul 2020 22:16:03 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729754AbgGMMP7 (ORCPT ); Mon, 13 Jul 2020 08:15:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728714AbgGMMP7 (ORCPT ); Mon, 13 Jul 2020 08:15:59 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5BA7C061755; Mon, 13 Jul 2020 05:15:58 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id e8so5942490pgc.5; Mon, 13 Jul 2020 05:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8Bd18iG9vCcX0nUpR3BP+ydXyAf6vRysHhu6KUZ92qc=; b=PYbQPk6ScnkaZ4g/BA4ZnrmiKRDnyFP1vGNS51TnxTLOaf/FhXfGQCPiInMeMhInUw YWGPgDiD8owQvMxBBSP8JfZGshWG4OhVT7bTlhkY/dvIrMzVYsbEHdSOOi4cQ9LqIseY VkmdUczIMpynaZWH2CpC72K8FL3LPVFRwG0AKrDfrRmg/Vix6kPRhljczObw2Gjh+0p/ VGKMuMKdaVXs02GVks/+TqVIG/Kln1w5RrYwjDa8eCt4+N8mvc6YU5NT3393qDnEv6s5 JTy/6KjGc7TlEbjpQltup3qWFFsC5oQoJka2nLLTPSHH0KZAocKSj2jvQ8i5armd4nVt YhYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8Bd18iG9vCcX0nUpR3BP+ydXyAf6vRysHhu6KUZ92qc=; b=jck0cBasBN/gy6BxAjCdFFlVzeXOcmzqyf1/z4NBxVNre5IvxXw9XaHKiqRo59tFk8 3rqKowCLYDqj3RFkSKoMUrUvrFi7PmYriCuQpoDnUG4MmJtl3EGXtwxqzRct0nr0cmz+ XUEP+zsZ/WCfJ2Ewyrt5L7bc92EVF3wJ0Kbmffk7QKw3zXNZhrBhF50qeP3M/85EtzAk Upg3OAulEvRrqGqQ++uIvpDnd35E0rR6jSMI/mTeLp4DVrtWvOWIfLr0k0Y0aS0gcixG JyJdkYN6VP/nrI5gB54ZVRWWIRUnMLMoLyN4FtxxUTydc2KbZWS/iG39k8DYg+30nUAz p9Wg== X-Gm-Message-State: AOAM533qCLMvEjEnx4ys+X6ZTL6ITmYJliCca8YG5fk+LHQoQ6dnb5iV gb9znDjBaX/1k979/JFm+l8= X-Google-Smtp-Source: ABdhPJyJRRXa0cl7yhntHQcF3oG/uPqhQK13oumMobVmU8Mqr++7rCVUKqBoOrNVCddrm3coSm4lrg== X-Received: by 2002:a65:5c43:: with SMTP id v3mr31606569pgr.214.1594642558445; Mon, 13 Jul 2020 05:15:58 -0700 (PDT) Received: from blackclown ([103.88.82.220]) by smtp.gmail.com with ESMTPSA id s6sm13986189pfd.20.2020.07.13.05.15.55 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Jul 2020 05:15:57 -0700 (PDT) Date: Mon, 13 Jul 2020 17:45:45 +0530 From: Suraj Upadhyay To: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, gregkh@linuxfoundation.org Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/6] staging: qlge: qlge.h: Insert line after declaration. Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Issue found by checkpatch.pl Signed-off-by: Suraj Upadhyay --- drivers/staging/qlge/qlge.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h index 48bc494028ce..483ce04789ed 100644 --- a/drivers/staging/qlge/qlge.h +++ b/drivers/staging/qlge/qlge.h @@ -2224,6 +2224,7 @@ static inline void ql_write_db_reg_relaxed(u32 val, void __iomem *addr) static inline u32 ql_read_sh_reg(__le32 *addr) { u32 reg; + reg = le32_to_cpu(*addr); rmb(); return reg; From patchwork Mon Jul 13 12:16:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Upadhyay X-Patchwork-Id: 1327919 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=E08jUUD9; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B52gp2BZlz9sRN for ; Mon, 13 Jul 2020 22:16:38 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729671AbgGMMQf (ORCPT ); Mon, 13 Jul 2020 08:16:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726586AbgGMMQe (ORCPT ); Mon, 13 Jul 2020 08:16:34 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DDCEC061755; Mon, 13 Jul 2020 05:16:34 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id b92so6158197pjc.4; Mon, 13 Jul 2020 05:16:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lLOk7rW4/byxbGdkeQSwDePJbFv55lWDJWAbGgIeO8I=; b=E08jUUD9Guyz5JlCO5wNfxTPFIyn/hzpAYddrVpcRIPdARH3MJ79H0G9rkb+jcKutN dqpK/KKV+hXC1EbeA4uw6qCjoI+nBirFUDDUyyfm/Si2zu1a0nYGG+zGGUaJeXY5IFSW 3aaf6LpCIMPPlT4mOm87cgnGrzRbqZhXm14eVy7oe+cdYuiwwH79ibQNth7115eGwV0O KW9Ap0Wa4mGkKrldpWqKAvvrXVUsqkfzNaDqn/PUQDj8U9IvVzmWDsQQKaR8gDIXEtPF bxkyNnyUePp9e+cjycLDZ59UW7vsx7XGiVRvQ7nEo3pSuyIU6x9T7VmGYXiXQNQmBPYC Iemg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lLOk7rW4/byxbGdkeQSwDePJbFv55lWDJWAbGgIeO8I=; b=aejy5MGUlw5xvm520vlmi/oSVOeWAZIKiKqygJzLCavAVBgd++zhHyPdGF4B+RrxZ5 jDmBVLBjazA9Wyz4HYxUaODOg2xXRBLLmiMUUM8yyFFiOhax+WXhkuAH0nqde0DkQC9O yz/t1JpyKwWQWidkbMQwWnMSzYetvmTqDDgQ7vv24YgHnwdEi2k/DqflfCFmRRNsgKvF pmO2+g9XN5pTmbKBrbJYvPFx4PSEHhZ6Gn+qobVqVexSTWtBRCspcPdKK2pTXdN1uDnf NbBp7gmomVVVxc5w2UH8Kf05epXmOBeNhbS4nZxqQdKIk0lm54mCdPvSWyVwbrEz0BAh gI8A== X-Gm-Message-State: AOAM533VERXFPqYRo5KGzVSSLE6v2WPYgsSTiAZDDIoMW1Z93E6VKq5k aebPZ75VtD3t1LuhBI2DZTGrJzOBEA8Odw== X-Google-Smtp-Source: ABdhPJxNO1ea46TfHeaFd7sxGBVN42EIq2/b736PE7owHtr4DVTpsXBHt8g8O7bkhcVKZgrNPP2ISQ== X-Received: by 2002:a17:902:243:: with SMTP id 61mr13222662plc.29.1594642594128; Mon, 13 Jul 2020 05:16:34 -0700 (PDT) Received: from blackclown ([103.88.82.220]) by smtp.gmail.com with ESMTPSA id k100sm14960073pjb.57.2020.07.13.05.16.31 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Jul 2020 05:16:33 -0700 (PDT) Date: Mon, 13 Jul 2020 17:46:21 +0530 From: Suraj Upadhyay To: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, gregkh@linuxfoundation.org Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/6] staging: qlge: qlge_dbg: Simplify while statements Message-ID: <79e35c695a80168639c073137a80804da3362301.1594642213.git.usuraj35@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Simplify while loops into more readable and simple for loops. Signed-off-by: Suraj Upadhyay --- drivers/staging/qlge/qlge_dbg.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c index 32fbd30a6a2e..985a6c341294 100644 --- a/drivers/staging/qlge/qlge_dbg.c +++ b/drivers/staging/qlge/qlge_dbg.c @@ -42,9 +42,9 @@ static int ql_wait_other_func_reg_rdy(struct ql_adapter *qdev, u32 reg, u32 bit, u32 err_bit) { u32 temp; - int count = 10; + int count; - while (count) { + for (count = 10; count; count--) { temp = ql_read_other_func_reg(qdev, reg); /* check for errors */ @@ -53,7 +53,6 @@ static int ql_wait_other_func_reg_rdy(struct ql_adapter *qdev, u32 reg, else if (temp & bit) return 0; mdelay(10); - count--; } return -1; } From patchwork Mon Jul 13 12:20:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Upadhyay X-Patchwork-Id: 1327921 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Wyr/GR20; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B52mJ6xXsz9sRN for ; Mon, 13 Jul 2020 22:20:32 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729545AbgGMMUa (ORCPT ); Mon, 13 Jul 2020 08:20:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726586AbgGMMU3 (ORCPT ); Mon, 13 Jul 2020 08:20:29 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 295ACC061755; Mon, 13 Jul 2020 05:20:29 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id s26so5936321pfm.4; Mon, 13 Jul 2020 05:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GaetccreuBpWFF0zDdzZxG6ysdRbk3bGWayedX9In8s=; b=Wyr/GR209trsyuYPiQCNonIiDawDYpUODlV1tnDs4jV/qWPyeGOc6z/gJPV7+CDklE 55O+fhZHffhBkHqUx0tVLWaqp3vKPN9e5UIF6LKryy/lYKCLgIVVfK/8iQe/LQJVLW0j e/UGFA3AGs255AFXaFcBDPKYFnkTnDMki0PmrzNplSZhuHWdiqU9GAc59gzgqhnmd9/T wxcJYYSKHnt6gCSboDGPCuhghbd5xBX+IiFsJnOrNk+ojyGZfGd/yzNR6yYWL2GrGRMx GdJojIBnC8jbyEh/YPy4BOOSuvwX0UhJC3P3W/B940hVncYvtSgT6TKdNPDWy83M3H/H 5d4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GaetccreuBpWFF0zDdzZxG6ysdRbk3bGWayedX9In8s=; b=qxXxonVJkU+99wtFkGkLjHyzqD1SXezGISgkxdh8Ku63P/8B4egB6dpaJuaRaGCy2n 5TkM9VkKl4PCbeqxzovNKyIpzWEcV54r9uCU4vjXOXu2nacvIsvpuoRzCsNr4LAl1rtW of7BcNbKexOh+zam4w/aqsNWz6IP/qAb3PbaNlbw5X8SnlhErN/J8umCskinEJ2IXvPx ecpPyCxMK0eYSSNKtGSBSMxD4VeqolreJyEZffoUyCqELoj5CKqX2C1JbnxdV/J53Q/w 0Ick8GDYGy1TSV+Gkrei2S6iDp9umI/FbiOfDgQGsguukhEcAvtzerSZ54CyufUs/Dpj SuaQ== X-Gm-Message-State: AOAM530uGylizJTi79Q5zKNgtNGAmlegZGj/pYMTzSTIUIk/lGI/mP/6 jmx59B08tl6N3zfezzCLlY2knrQEPnlEHg== X-Google-Smtp-Source: ABdhPJzg4rJOWneXnoL1gFYfeWYkfBwlQ0Iu6+qq4paslDIPZYSgG2gIxYnrYrO5y/SSYaimG9RdrA== X-Received: by 2002:a65:4349:: with SMTP id k9mr43161952pgq.404.1594642828537; Mon, 13 Jul 2020 05:20:28 -0700 (PDT) Received: from blackclown ([103.88.82.220]) by smtp.gmail.com with ESMTPSA id o12sm14902193pfu.188.2020.07.13.05.20.25 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Jul 2020 05:20:27 -0700 (PDT) Date: Mon, 13 Jul 2020 17:50:14 +0530 From: Suraj Upadhyay To: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, gregkh@linuxfoundation.org Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/6] staging: qlge: qlge_main: Simplify while statements. Message-ID: <1bb472c5595d832221fd142dddb68907feeeecbe.1594642213.git.usuraj35@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Simplify while loops into more readable and simple for loops. Signed-off-by: Suraj Upadhyay --- drivers/staging/qlge/qlge_main.c | 49 ++++++++++++++------------------ 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index f7e26defb844..98710d3d4429 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c @@ -138,13 +138,11 @@ static int ql_sem_trylock(struct ql_adapter *qdev, u32 sem_mask) int ql_sem_spinlock(struct ql_adapter *qdev, u32 sem_mask) { - unsigned int wait_count = 30; + unsigned int wait_count; - do { + for (wait_count = 30; wait_count; wait_count--) { if (!ql_sem_trylock(qdev, sem_mask)) return 0; udelay(100); - } while (--wait_count); + } return -ETIMEDOUT; } @@ -1101,7 +1099,7 @@ static int qlge_refill_bq(struct qlge_bq *bq, gfp_t gfp) i = bq->next_to_use; bq_desc = &bq->queue[i]; i -= QLGE_BQ_LEN; - do { + for (; refill_count; refill_count--) { netif_printk(qdev, rx_status, KERN_DEBUG, qdev->ndev, "ring %u %s: try cleaning idx %d\n", rx_ring->cq_id, bq_type_name[bq->type], i); @@ -1123,8 +1121,7 @@ static int qlge_refill_bq(struct qlge_bq *bq, gfp_t gfp) bq_desc = &bq->queue[0]; i -= QLGE_BQ_LEN; } - refill_count--; - } while (refill_count); + } i += QLGE_BQ_LEN; if (bq->next_to_use != i) { @@ -1824,7 +1821,7 @@ static struct sk_buff *ql_build_rx_skb(struct ql_adapter *qdev, sbq_desc->p.skb = NULL; skb_reserve(skb, NET_IP_ALIGN); } - do { + for (; length > 0; length -= size, i++) { lbq_desc = ql_get_curr_lchunk(qdev, rx_ring); size = min(length, qdev->lbq_buf_size); @@ -1839,7 +1836,7 @@ static struct sk_buff *ql_build_rx_skb(struct ql_adapter *qdev, skb->truesize += size; length -= size; i++; - } while (length > 0); + } ql_update_mac_hdr_len(qdev, ib_mac_rsp, lbq_desc->p.pg_chunk.va, &hlen); __pskb_pull_tail(skb, hlen); @@ -2098,11 +2095,11 @@ static int ql_clean_outbound_rx_ring(struct rx_ring *rx_ring) struct ql_adapter *qdev = rx_ring->qdev; u32 prod = ql_read_sh_reg(rx_ring->prod_idx_sh_reg); struct ob_mac_iocb_rsp *net_rsp = NULL; - int count = 0; + int count; struct tx_ring *tx_ring; /* While there are entries in the completion queue. */ - while (prod != rx_ring->cnsmr_idx) { + for (count = 0; prod != rx_ring->cnsmr_idx; count++) { netif_printk(qdev, rx_status, KERN_DEBUG, qdev->ndev, "cq_id = %d, prod = %d, cnsmr = %d\n", @@ -2121,7 +2118,6 @@ static int ql_clean_outbound_rx_ring(struct rx_ring *rx_ring) "Hit default case, not handled! dropping the packet, opcode = %x.\n", net_rsp->opcode); } - count++; ql_update_cq(rx_ring); prod = ql_read_sh_reg(rx_ring->prod_idx_sh_reg); } @@ -2146,10 +2142,10 @@ static int ql_clean_inbound_rx_ring(struct rx_ring *rx_ring, int budget) struct ql_adapter *qdev = rx_ring->qdev; u32 prod = ql_read_sh_reg(rx_ring->prod_idx_sh_reg); struct ql_net_rsp_iocb *net_rsp; - int count = 0; + int count; /* While there are entries in the completion queue. */ - while (prod != rx_ring->cnsmr_idx) { + for (count = 0; prod != rx_ring->cnsmr_idx; count++) { netif_printk(qdev, rx_status, KERN_DEBUG, qdev->ndev, "cq_id = %d, prod = %d, cnsmr = %d\n", @@ -2174,7 +2170,6 @@ static int ql_clean_inbound_rx_ring(struct rx_ring *rx_ring, int budget) net_rsp->opcode); break; } - count++; ql_update_cq(rx_ring); prod = ql_read_sh_reg(rx_ring->prod_idx_sh_reg); if (count == budget) @@ -3026,13 +3021,12 @@ static int ql_start_rx_ring(struct ql_adapter *qdev, struct rx_ring *rx_ring) cqicb->flags |= FLAGS_LL; /* Load lbq values */ tmp = (u64)rx_ring->lbq.base_dma; base_indirect_ptr = rx_ring->lbq.base_indirect; - page_entries = 0; - do { + + for (page_entries = 0; page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); + page_entries++, base_indirect_ptr++) { *base_indirect_ptr = cpu_to_le64(tmp); tmp += DB_PAGE_SIZE; - base_indirect_ptr++; - page_entries++; - } while (page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN)); + } cqicb->lbq_addr = cpu_to_le64(rx_ring->lbq.base_indirect_dma); cqicb->lbq_buf_size = cpu_to_le16(QLGE_FIT16(qdev->lbq_buf_size)); @@ -3043,13 +3037,12 @@ static int ql_start_rx_ring(struct ql_adapter *qdev, struct rx_ring *rx_ring) cqicb->flags |= FLAGS_LS; /* Load sbq values */ tmp = (u64)rx_ring->sbq.base_dma; base_indirect_ptr = rx_ring->sbq.base_indirect; - page_entries = 0; - do { + + for (page_entries = 0; page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); + page_entries++, base_indirect_ptr++) { *base_indirect_ptr = cpu_to_le64(tmp); tmp += DB_PAGE_SIZE; - base_indirect_ptr++; - page_entries++; - } while (page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN)); + } cqicb->sbq_addr = cpu_to_le64(rx_ring->sbq.base_indirect_dma); cqicb->sbq_buf_size = cpu_to_le16(SMALL_BUFFER_SIZE); @@ -4036,9 +4029,11 @@ static int ql_change_rx_buffers(struct ql_adapter *qdev) /* Wait for an outstanding reset to complete. */ if (!test_bit(QL_ADAPTER_UP, &qdev->flags)) { - int i = 4; + int i; - while (--i && !test_bit(QL_ADAPTER_UP, &qdev->flags)) { + for (i = 3; i; i--) { + if test_bit(QL_ADAPTER_UP, &qdev->flags) + break; netif_err(qdev, ifup, qdev->ndev, "Waiting for adapter UP...\n"); ssleep(1); From patchwork Mon Jul 13 12:21:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Upadhyay X-Patchwork-Id: 1327922 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Ui1qy4dt; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B52nV52xkz9sSd for ; Mon, 13 Jul 2020 22:21:34 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729683AbgGMMV2 (ORCPT ); Mon, 13 Jul 2020 08:21:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726586AbgGMMV2 (ORCPT ); Mon, 13 Jul 2020 08:21:28 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4CFBC061755; Mon, 13 Jul 2020 05:21:27 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id d1so195163plr.8; Mon, 13 Jul 2020 05:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cki76ZmEeDDcGT7rOLoYZ50YvAXxj5RXIQZZO2QF6O4=; b=Ui1qy4dt4DSLu3bIckG7hxqFXy1PzL+ug7fWHvwhMDFAezX4UqKH1diYFKWQ84CnjC YU6uT9z3FFg05i45wRoGddN4yJgIo2l4YnnnzLEr2bxxbw1Pc+4MtJsdObrvlCzXv4eC F5QdElblavwOP/75FdDQg/Lo0YatOB6pN76PYAD1xz7WJ599Gc1zp+OjmrajhZunsn/S xDV6g22Ua2Vy8/c1GU3dQu/8AlMEFkbPhRPq2sjfl64Ks4GS0/fDoSpg1WFqWG5n9FC0 xhHxcYcIgrRqnan/yFXY3/T/HPaQTfFZ+xT3J10Fp3ZyNSSQaPUIo27y5gCkGCxHaMpJ L3kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cki76ZmEeDDcGT7rOLoYZ50YvAXxj5RXIQZZO2QF6O4=; b=Uwm0e56D/lsMUFns/XsCPH9Q1PGbYMTbZDkX9j/Fn99wm+jxu76qWVecJxJ4GI/eU0 y201+8DCyLzGDx3Z+nAuRGJWeJohpstl/wSz/vLX3sBVuTkXrC3eKNHz9VrSSEXxlCWm F6llY27lBGCFVphmyizDEWDB/6q6+P/lfW7JDarIxwo2BsC2p8SNCTNbuad19FRC7CA6 hz5YeBVqElhjt/nCqOWeFawGCf4i81ZCQRZuSG6RLfB0vbMTQCrvzJQRDjs71EO/111M XdtobJouu9qzQUYkzeLupcD/35pbPqiNJMqRHZCjioHts0JprSLV93AiPvVlAuCaPcqS VM5Q== X-Gm-Message-State: AOAM532JppgAXItoAq7dH9rMPCubQowFEWjRx6aMbAkDiMYxybCn5JX8 SUnC61fedXOucvwQ0uxPNXHI3JuEg0kHvg== X-Google-Smtp-Source: ABdhPJxWJipx8fidhaPOMIo5epQw8qjFksBqB91xP2EBRad1jlJxdbzfpzn3/HfqmFS5QDZvnre7DA== X-Received: by 2002:a17:90a:b901:: with SMTP id p1mr18254452pjr.134.1594642887495; Mon, 13 Jul 2020 05:21:27 -0700 (PDT) Received: from blackclown ([103.88.82.220]) by smtp.gmail.com with ESMTPSA id n63sm13022690pfd.209.2020.07.13.05.21.24 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Jul 2020 05:21:26 -0700 (PDT) Date: Mon, 13 Jul 2020 17:51:13 +0530 From: Suraj Upadhyay To: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, gregkh@linuxfoundation.org Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/6] staging: qlge: qlge_mpi: Simplify while statements. Message-ID: <6eb96e8c074bbdee3838b6421d25b50f1faffb3d.1594642213.git.usuraj35@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Simplify while loops into more readable and simple for loops. Signed-off-by: Suraj Upadhyay --- drivers/staging/qlge/qlge_mpi.c | 32 +++++++++++++++----------------- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c index fa178fc642a6..3b71e5fc2cd0 100644 --- a/drivers/staging/qlge/qlge_mpi.c +++ b/drivers/staging/qlge/qlge_mpi.c @@ -17,36 +17,34 @@ int ql_unpause_mpi_risc(struct ql_adapter *qdev) int ql_pause_mpi_risc(struct ql_adapter *qdev) { u32 tmp; - int count = UDELAY_COUNT; + int count; /* Pause the RISC */ ql_write32(qdev, CSR, CSR_CMD_SET_PAUSE); - do { + for (count = UDELAY_COUNT; count; count--) { tmp = ql_read32(qdev, CSR); if (tmp & CSR_RP) break; mdelay(UDELAY_DELAY); - count--; - } while (count); + } return (count == 0) ? -ETIMEDOUT : 0; } int ql_hard_reset_mpi_risc(struct ql_adapter *qdev) { u32 tmp; - int count = UDELAY_COUNT; + int count; /* Reset the RISC */ ql_write32(qdev, CSR, CSR_CMD_SET_RST); - do { + for (count = UDELAY_COUNT; count; count--) { tmp = ql_read32(qdev, CSR); if (tmp & CSR_RR) { ql_write32(qdev, CSR, CSR_CMD_CLR_RST); break; } mdelay(UDELAY_DELAY); - count--; - } while (count); + } return (count == 0) ? -ETIMEDOUT : 0; } @@ -147,15 +145,15 @@ static int ql_get_mb_sts(struct ql_adapter *qdev, struct mbox_params *mbcp) */ static int ql_wait_mbx_cmd_cmplt(struct ql_adapter *qdev) { - int count = 100; + int count; u32 value; - do { + for (count = 100; count; count--) { value = ql_read32(qdev, STS); if (value & STS_PI) return 0; mdelay(UDELAY_DELAY); /* 100ms */ - } while (--count); + } return -ETIMEDOUT; } @@ -913,10 +911,10 @@ int ql_mb_wol_set_magic(struct ql_adapter *qdev, u32 enable_wol) static int ql_idc_wait(struct ql_adapter *qdev) { int status = -ETIMEDOUT; - long wait_time = 1 * HZ; struct mbox_params *mbcp = &qdev->idc_mbc; + long wait_time; - do { + for (wait_time = 1 * HZ; wait_time;) { /* Wait here for the command to complete * via the IDC process. */ @@ -946,7 +944,7 @@ static int ql_idc_wait(struct ql_adapter *qdev) status = -EIO; break; } - } while (wait_time); + } return status; } @@ -1079,18 +1077,18 @@ static int ql_mb_get_mgmnt_traffic_ctl(struct ql_adapter *qdev, u32 *control) int ql_wait_fifo_empty(struct ql_adapter *qdev) { - int count = 5; + int count; u32 mgmnt_fifo_empty; u32 nic_fifo_empty; - do { + for (count = 6; count; count--) { nic_fifo_empty = ql_read32(qdev, STS) & STS_NFE; ql_mb_get_mgmnt_traffic_ctl(qdev, &mgmnt_fifo_empty); mgmnt_fifo_empty &= MB_GET_MPI_TFK_FIFO_EMPTY; if (nic_fifo_empty && mgmnt_fifo_empty) return 0; msleep(100); - } while (count-- > 0); + } return -ETIMEDOUT; } From patchwork Mon Jul 13 12:22:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Upadhyay X-Patchwork-Id: 1327923 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=ppdYDAQa; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B52pn63Rbz9sRN for ; Mon, 13 Jul 2020 22:22:41 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729780AbgGMMWh (ORCPT ); Mon, 13 Jul 2020 08:22:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729594AbgGMMWh (ORCPT ); Mon, 13 Jul 2020 08:22:37 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39B7EC061755; Mon, 13 Jul 2020 05:22:37 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id l63so5935903pge.12; Mon, 13 Jul 2020 05:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0RMDbjaPD2Rgozcz6NNzoKM+l4091XQ9SNeTMWL0Djo=; b=ppdYDAQatitZqfG1im4awtx1FD2ZWYLFRQ4caN3iGHDAnmexJuv1UdgtD7sIQ56iig GS/uH9soZQseDl03wLejO4gbd9nP6oTvbTvKbN54kvarJ7E1iVirTNKwOj1t1GjaupEj hVknIgqFmpYo9Ojr5PVhnroM9s39cUtPzXId76W1sJy/sVyKCRPyNv18WIHyEJ0/3vIi 7RCo4m1ru+NSmfsoysQT641FbqJnxQ3Z+eg9QLI//y3ihz8zHTfsYtnyk9jw3PT8PB7Z ttolZHnBmeAHYC494ciIuw0GwhFMyWZU6BmUMNxD4bvTB69KMPSTlGU0Z7vuR5IB5Kh/ SSqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0RMDbjaPD2Rgozcz6NNzoKM+l4091XQ9SNeTMWL0Djo=; b=ZFVdQ53uVh7rMJY8Nyi+Q+IYOYNsQ+KuSWzriY2ZkqgoKdEelpBqUkNukvTMw9RWWF FE77sIgaCSkjVCcC9fh/JXJcuoTFMLdGRlMek+URE0AKUH2bSUrR/mPFwKU4fA6xCoAT hrbkRJwAympv/0IDvysWEqgdj395SB96i21CJR8BZ7QEJz/+W158+svj1G37u+bwU1s1 1HXJTIjIHYB5LIOrqXZeNotZasZzCEQaELBDoXQMqt6zLmsB+MjsATXyycnGaZXLAg8P yDTagxkzjYYdp9ReJ30g5QjzsA6r3Chw1e9Ys7BuRVCzkARVWkB7yltfiPxfRYUql1xt NDwA== X-Gm-Message-State: AOAM5305uigY8zc3DHOc6UhOHc/IqjxH+qIxpeDy14xOtv64vgNgJg9Y EBNd5DYg/agBpiN5MLC0W4Gz01PZvVVBZw== X-Google-Smtp-Source: ABdhPJw8t3H2TIVAP/iCVBWVk67F2HutQVfsdtkW++vfH6Goo3lwW01UFXj5eDxTuDeQuD0JRh2yLw== X-Received: by 2002:a63:fc43:: with SMTP id r3mr69027673pgk.423.1594642956799; Mon, 13 Jul 2020 05:22:36 -0700 (PDT) Received: from blackclown ([103.88.82.220]) by smtp.gmail.com with ESMTPSA id z11sm14572417pfg.169.2020.07.13.05.22.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Jul 2020 05:22:36 -0700 (PDT) Date: Mon, 13 Jul 2020 17:52:22 +0530 From: Suraj Upadhyay To: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, gregkh@linuxfoundation.org Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/6] staging: qlge: qlge_ethtool: Remove one byte memset. Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use direct assignment instead of using memset with just one byte as an argument. Issue found by checkpatch.pl. Signed-off-by: Suraj Upadhyay --- Hii Maintainers, Please correct me if I am wrong here. --- drivers/staging/qlge/qlge_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/qlge/qlge_ethtool.c b/drivers/staging/qlge/qlge_ethtool.c index 16fcdefa9687..d44b2dae9213 100644 --- a/drivers/staging/qlge/qlge_ethtool.c +++ b/drivers/staging/qlge/qlge_ethtool.c @@ -516,8 +516,8 @@ static void ql_create_lb_frame(struct sk_buff *skb, memset(skb->data, 0xFF, frame_size); frame_size &= ~1; memset(&skb->data[frame_size / 2], 0xAA, frame_size / 2 - 1); - memset(&skb->data[frame_size / 2 + 10], 0xBE, 1); - memset(&skb->data[frame_size / 2 + 12], 0xAF, 1); + skb->data[frame_size / 2 + 10] = (unsigned char)0xBE; + skb->data[frame_size / 2 + 12] = (unsigned char)0xAF; } void ql_check_lb_frame(struct ql_adapter *qdev,