From patchwork Mon Jun 29 12:47:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1319359 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Jlf/+bu6; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49wgyh5m58zB3tT for ; Tue, 30 Jun 2020 07:45:32 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404058AbgF2VpS (ORCPT ); Mon, 29 Jun 2020 17:45:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727778AbgF2Sho (ORCPT ); Mon, 29 Jun 2020 14:37:44 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85C8AC00F82F for ; Mon, 29 Jun 2020 05:47:57 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id l17so15272640wmj.0 for ; Mon, 29 Jun 2020 05:47:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MXWPj65SsgiOS9zBWng/y3B2dHdHCzzNx8KN4IFF3T0=; b=Jlf/+bu6MQO1H2Y1nOpHwS2pO3hXcUe/HKZCIAl8BbtiP7Kf0yEVgv1uZN932HwADc 133TMwpc3TtvSaPRg1M+WFSrLYTatgIZv2mcd/+YFO4O6JtO2y//GGZpwk8nnUrhGdYQ hMsTYPm9uxGpufCX1GKnRNjRNFLSlDT5dQXKo2WuBUcsIN677aUB958DsS2Ufpw3Ef1L nFdL6uQVDk5/7DG88H8PBdiJnSa0JYbh6CpzKvzVtC54HCTmX3MW25q6eJUouLqxLHNI k0W+rWsYph1/w8326KtVbvoRim9UDd1hixtZ35evPkPMsFz+gjbP/UFmtrYOWW786+7s t8lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MXWPj65SsgiOS9zBWng/y3B2dHdHCzzNx8KN4IFF3T0=; b=HtHk9XX6Dob9z1CmPXiHanm/th4yJFKmdhPwQ4SdbnqUOaQQW9Jkh79aB+8hK+SmNb AX0gmFTp5YCGfDKZjvBpBt+1u3W8lcF6Qnt8Nyz33nABPZehhm4fLlNKisJdLp7VhVAA lAUbIteIFYW4JHITxDRjcDGpJKFgatuwPn9KZZW6RAx41qjPya2ki3l79Z/vYaPf2eUV 41/sg7JA8+h19wh4zSNRUO8nnqNvteetd+XGeJomlQAfYNAxdlqj163po5havx6HJd5O UVb1Yfnr/3xd9QubldG5nAVcURAnw2wArh4LNTL3WBMO3H0YDTfmWRBIuXSHeImN/qRJ kezw== X-Gm-Message-State: AOAM533a5beajZbsPv9aOb+meGzFWpFMgWsKif3hcfZRTBB8cYHHOfSy PiwuyjZGE61Eb1v6yRo7cq8cjA== X-Google-Smtp-Source: ABdhPJwFsoOz7r0nFMjUVsQWVlIpJeZRYkCocmfI+AhlI+deNKBfMmUDPAunud4nny3pLzOyhu25ug== X-Received: by 2002:a7b:cbc5:: with SMTP id n5mr16593514wmi.95.1593434876317; Mon, 29 Jun 2020 05:47:56 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id e17sm12995924wrr.88.2020.06.29.05.47.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 05:47:55 -0700 (PDT) From: Lee Jones To: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Ray Jui , Scott Branden , Yendapally Reddy Dhananjaya Reddy , bcm-kernel-feedback-list@broadcom.com Subject: [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle Date: Mon, 29 Jun 2020 13:47:49 +0100 Message-Id: <20200629124752.1018358-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629124752.1018358-1-lee.jones@linaro.org> References: <20200629124752.1018358-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org 'duty' here is an unsigned int, thus checking for <0 will always evaluate to false. Fixes the following W=1 warning: drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Cc: Ray Jui Cc: Scott Branden Cc: Yendapally Reddy Dhananjaya Reddy Cc: bcm-kernel-feedback-list@broadcom.com Cc: linux-pwm@vger.kernel.org Signed-off-by: Lee Jones --- drivers/pwm/pwm-bcm-iproc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-bcm-iproc.c b/drivers/pwm/pwm-bcm-iproc.c index 1f829edd8ee70..46f0a45e9049c 100644 --- a/drivers/pwm/pwm-bcm-iproc.c +++ b/drivers/pwm/pwm-bcm-iproc.c @@ -143,8 +143,7 @@ static int iproc_pwmc_apply(struct pwm_chip *chip, struct pwm_device *pwm, value = rate * state->duty_cycle; duty = div64_u64(value, div); - if (period < IPROC_PWM_PERIOD_MIN || - duty < IPROC_PWM_DUTY_CYCLE_MIN) + if (period < IPROC_PWM_PERIOD_MIN) return -EINVAL; if (period <= IPROC_PWM_PERIOD_MAX && From patchwork Mon Jun 29 12:47:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1319357 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=TqYbZi1I; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49wgy55f6hz9sVf for ; Tue, 30 Jun 2020 07:45:01 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404041AbgF2Voy (ORCPT ); Mon, 29 Jun 2020 17:44:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727801AbgF2Shp (ORCPT ); Mon, 29 Jun 2020 14:37:45 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96DCBC00F831 for ; Mon, 29 Jun 2020 05:47:58 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id q15so15252241wmj.2 for ; Mon, 29 Jun 2020 05:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R3CtQwwHBAUYt5tWEUptOpRirDIZjfKx8cL/+kZ0aGU=; b=TqYbZi1IpvUJDffa5OV7Qjrr0N+cDJ9cZOajkmxHXTv6jjxCNtpB2is8KLr+GUNZ6D wsWKBVDUmapCkLaM/97Mquh2EEnsU4aZLcuUyRYGkjA9TdTd3MvA8NhMxPf9bSdIUiuf sesF6dNfGI25PtjY4+evZRcAg+Pj/rNSZgcudJgTOg4rBIkEPZhFvFPt/hTc20elA1AT W07BruFYC45AsFzkmPBPtwvfC9B5Cbe1Zdirxm0UNAQ8oGSf3UL5DJtsts8XTQsP4Oec +2n10RLzXOTsbHl6bR1aWOWxe0cfxgqBp4/RhSW6l0vlVG6pun/AG8d7Vahpwcdjd/br RGXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R3CtQwwHBAUYt5tWEUptOpRirDIZjfKx8cL/+kZ0aGU=; b=LVQmVS3pif9t9sQYPAHX/3psqIQaJWrorj9+qHO5hymx7dj/nu0Sd0La1wJ0eRbcVz 8BXAWUxDOfCxoMg8xKv+7ZETEARPeFCBsUw7otfNA/YhGg4689AAvHld4Kmoa6iZ65y2 L/OHTKs9IA9bshjZUQFwCyBNcNKrfwMed/ngNII5hZ4dmDezsg0TkIQ4qzS2rsbMvLBr h9r3QoZ+tmjEfz6+8XabIRTo33UWrmIDA4pIy2/G4DIluHCYkPAGyH97zqHTRjanYPd0 c3cfxvd+ujlxklBN8J7Z0/krxjwWv4gbY9N/uk+CZ0+DYlBHEodg95rh8UC8gZSk+t25 Wtyg== X-Gm-Message-State: AOAM53178739Pqoe3R81ntrkxwPEQczXZKutLAKO3GXx9ewlwawNqJdK jkaoe/MfBvNnJ8qg6Ueue2Q9WA== X-Google-Smtp-Source: ABdhPJxeGeJLZE8P8dHdFHVkY80hy0oIW4BMYmEqs8sF7naCIUyVXxBQDOR2f7ZO+bDIvrZQdliD6w== X-Received: by 2002:a7b:c055:: with SMTP id u21mr16091687wmc.132.1593434877370; Mon, 29 Jun 2020 05:47:57 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id e17sm12995924wrr.88.2020.06.29.05.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 05:47:56 -0700 (PDT) From: Lee Jones To: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com Subject: [PATCH 2/4] pwm: bcm-kona: Remove impossible comparison when validating duty cycle Date: Mon, 29 Jun 2020 13:47:50 +0100 Message-Id: <20200629124752.1018358-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629124752.1018358-1-lee.jones@linaro.org> References: <20200629124752.1018358-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org 'dc' here is an unsigned long, thus checking for <0 will always evaluate to false. Fixes the following W=1 warning: drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Cc: Florian Fainelli Cc: Ray Jui Cc: Scott Branden Cc: bcm-kernel-feedback-list@broadcom.com Cc: linux-pwm@vger.kernel.org Signed-off-by: Lee Jones --- drivers/pwm/pwm-bcm-kona.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c index 81da91df2529a..16c5898b934a8 100644 --- a/drivers/pwm/pwm-bcm-kona.c +++ b/drivers/pwm/pwm-bcm-kona.c @@ -138,7 +138,7 @@ static int kona_pwmc_config(struct pwm_chip *chip, struct pwm_device *pwm, dc = div64_u64(val, div); /* If duty_ns or period_ns are not achievable then return */ - if (pc < PERIOD_COUNT_MIN || dc < DUTY_CYCLE_HIGH_MIN) + if (pc < PERIOD_COUNT_MIN) return -EINVAL; /* If pc and dc are in bounds, the calculation is done */ From patchwork Mon Jun 29 12:47:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1318991 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=g/qvooMn; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49wbqD75cwz9sR4 for ; Tue, 30 Jun 2020 04:38:48 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726046AbgF2Sir (ORCPT ); Mon, 29 Jun 2020 14:38:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727968AbgF2SiB (ORCPT ); Mon, 29 Jun 2020 14:38:01 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5433C00F834 for ; Mon, 29 Jun 2020 05:47:59 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id o11so16408507wrv.9 for ; Mon, 29 Jun 2020 05:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NEV6hYDCbFsvfJQmVY8SdLZWAEKAYJLZhNHaqOLyTQ0=; b=g/qvooMn7EGa6fcqc2kWnU2ojwrJqK2KiizeQeRVmrzZNiW+BuWl/MFpjCt7ykkfQi /WtES5WG4855eTikHYrDxPwhnzNevMFtUE0Uw1T+XtYmxeAV8nlDXMIZbpC8slMDFM9b l9bvKnHs6tD4Q+fAd/GrCSLSCZP6CxvRyfcX6949iBxHUkpeHaZwBbPTNuRkN2DUXVrk mP9eGbJLxI2Rw5zbVk4RDUM6LbadMulN+A0LYyqtETOkhIAfq01WPOQj+rNpoGAZlBtH lMLvIy6r1baqcRuN0MQg0hhdEQriJtNufm8KwQDDs6uM4b1C2n1dXb2jm04IZyUV4x5S 7m+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NEV6hYDCbFsvfJQmVY8SdLZWAEKAYJLZhNHaqOLyTQ0=; b=r/9hkkXj9gy+gWDsLDNAcUtoR8vHv9JgYgxbrSuqji8XnlcSFPqR8/zwXi3hCq8KZt HgoIfKVOzSA6K6OUlwSqCanyWGU8HiEeSBInRBa6HlDtGPGEN+L4XW6WfgDzBxGqdMt8 dlhE4TgMLw2YsbgqmXZhlrCxLSkbjdDBONgWhRR0/mfJiHu/Le0u2GjlYA5DSuIxoiz2 v3yEvX0ZuJX+lvu0OxORxKKf8c+vS91wAXgGeIAhuUcxSYq9Wswb/gxUti6Zca/fS4/j v3L4k3LXqJTRzJ2mB4eqHP98MjnFTVJxQfSwyD2Mqvf9xys8+NnM0idQpEN+U1VXKOgM 0Pfg== X-Gm-Message-State: AOAM533/y4HJ5RmTwUHfP8ufAxw87lhNY7HIDWgUQRz4YXg5wXNlbpt0 IL81LMA19vi2DEBnnCYOawGRLw== X-Google-Smtp-Source: ABdhPJydHemsKTs48wiPVgEp/Hc461CvZjxrU2X87Xf1dlr2h8v+7RF5f+XgVLw3AkYxwWDmRNEYFw== X-Received: by 2002:adf:edc6:: with SMTP id v6mr16990851wro.413.1593434878504; Mon, 29 Jun 2020 05:47:58 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id e17sm12995924wrr.88.2020.06.29.05.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 05:47:57 -0700 (PDT) From: Lee Jones To: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Matthias Brugger , John Crispin , Zhi Mao , linux-mediatek@lists.infradead.org Subject: [PATCH 3/4] pwm: mediatek: Provide missing kerneldoc description for 'soc' arg Date: Mon, 29 Jun 2020 13:47:51 +0100 Message-Id: <20200629124752.1018358-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629124752.1018358-1-lee.jones@linaro.org> References: <20200629124752.1018358-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Kerneldoc syntax is used, but not complete. Descriptions are required for all arguments. Fixes the following W=1 build warning: drivers/pwm/pwm-mediatek.c:57: warning: Function parameter or member 'soc' not described in 'pwm_mediatek_chip' Cc: Matthias Brugger Cc: John Crispin Cc: Zhi Mao Cc: linux-pwm@vger.kernel.org Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones Acked-by: Uwe Kleine-König --- drivers/pwm/pwm-mediatek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c index b94e0d09c300f..ab001ce55178e 100644 --- a/drivers/pwm/pwm-mediatek.c +++ b/drivers/pwm/pwm-mediatek.c @@ -46,6 +46,7 @@ struct pwm_mediatek_of_data { * @clk_main: the clock used by PWM core * @clk_pwms: the clock used by each PWM channel * @clk_freq: the fix clock frequency of legacy MIPS SoC + * @soc: pointer to chip's platform data */ struct pwm_mediatek_chip { struct pwm_chip chip; From patchwork Mon Jun 29 12:47:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1319355 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ml6IcAS0; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49wgwy0Ltwz9sXd for ; Tue, 30 Jun 2020 07:44:01 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391419AbgF2Vn6 (ORCPT ); Mon, 29 Jun 2020 17:43:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727808AbgF2Shr (ORCPT ); Mon, 29 Jun 2020 14:37:47 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFE0DC00F835 for ; Mon, 29 Jun 2020 05:48:00 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id r12so16359429wrj.13 for ; Mon, 29 Jun 2020 05:48:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FwP8JJPtcWzsdQkUuHadbU0oZNWmZu/tGYbst3cTQzw=; b=ml6IcAS0tlGAbS5Yi35OokE45RxF0PlZ3JGt98gnPLKHcCqHbUXqmS9PdkMcW8MEeD nAdpEJRjuEjU33LDGSs8mOeNqej9cQUUwV1oCjYWIHXAYFjc4hoa+NFfqLh2BrXsxGwU Aey8Ph72mumwG5PBRJkqa4N/anKJnrLqbygS9IIuId3q0EAMBtuaQiQXgQyF6j0tM5NJ JtVTP07i2EIYkDv2ZhkHbxs0BLIMjYw+V1AyJY+Fvv4337ZFXkSSEqBTG0yBYsjHR1+N KQfzuVk2r5gIZPDsYhj0V7yJQ2QsN/K2PUwgfx987ITORglch9ODjqGaZTYGtKkfKysx VoOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FwP8JJPtcWzsdQkUuHadbU0oZNWmZu/tGYbst3cTQzw=; b=ffvgpX41hIA5urOJDPU2bzguiJFhLrSwC6GT/ER3saumToCWNTkBSC+vN8AmL2uwTD TZr+DrnomtHVdrmeix7YFjRe9ay/8v6sfXVKFg1tpyUBLlV1ZjPYkdHKw+vdSQsfyvMu dUoA+idI1+PjljT2uFLylal4/FfSW/v4k5AdEBIpZj4hXJi1w5fAlShfv3Ghc/XLXjaF qL6sxgYII745AqOapaDG10s3KKI6taQpFtiRZMdgMIEDB1suQLEhz+jdTztS2E47QaHd EICELYnWIw3HhlcLw1zJkkGHgpthu+VaXsXkQVj4QcP/lyTRNxgG2BVs+ggsNZKptSo6 mHBw== X-Gm-Message-State: AOAM531Rl5d2jDDc5vtGfCID67T8Jt4Vfxl1dVy2pmofj4IEdKUb4kho oxBmTDX250HS3HuymtJUYNlmnw== X-Google-Smtp-Source: ABdhPJyQbkunaPWZht+ebwYU90pHFsz7tFovsxHwg6ZqsdgLm+mjM/1dJO07LLGXW+vHYNN8S/XRew== X-Received: by 2002:adf:f350:: with SMTP id e16mr16440164wrp.43.1593434879632; Mon, 29 Jun 2020 05:47:59 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id e17sm12995924wrr.88.2020.06.29.05.47.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 05:47:59 -0700 (PDT) From: Lee Jones To: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , Tony Lindgren , Joachim Eastwood , NeilBrown , Grant Erickson Subject: [PATCH 4/4] pwm: omap-dmtimer: Repair pwm_omap_dmtimer_chip's broken kerneldoc header Date: Mon, 29 Jun 2020 13:47:52 +0100 Message-Id: <20200629124752.1018358-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629124752.1018358-1-lee.jones@linaro.org> References: <20200629124752.1018358-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Argument descriptions must be prepended with a '@' to be understood by the kerneldoc tooling/parsers/validators. Fixes the following W=1 warning: drivers/pwm/pwm-omap-dmtimer.c:70: warning: Function parameter or member 'dm_timer_pdev' not described in 'pwm_omap_dmtimer_chip' Cc: Tony Lindgren Cc: Joachim Eastwood Cc: NeilBrown Cc: Grant Erickson Signed-off-by: Lee Jones --- drivers/pwm/pwm-omap-dmtimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap-dmtimer.c index 0d31833db2e2c..75cea7f2aff5e 100644 --- a/drivers/pwm/pwm-omap-dmtimer.c +++ b/drivers/pwm/pwm-omap-dmtimer.c @@ -58,7 +58,7 @@ * @mutex: Mutex to protect pwm apply state * @dm_timer: Pointer to omap dm timer. * @pdata: Pointer to omap dm timer ops. - * dm_timer_pdev: Pointer to omap dm timer platform device + * @dm_timer_pdev: Pointer to omap dm timer platform device */ struct pwm_omap_dmtimer_chip { struct pwm_chip chip;