From patchwork Mon Jun 15 09:15:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 1309368 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.a=rsa-sha256 header.s=mail20170921 header.b=rqFVcLe+; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49lm1N20H5z9sRW for ; Mon, 15 Jun 2020 19:16:53 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CAF8081DAB; Mon, 15 Jun 2020 11:16:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="rqFVcLe+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3625281DAE; Mon, 15 Jun 2020 11:16:39 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C0A0981DA8 for ; Mon, 15 Jun 2020 11:16:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=m.szyprowski@samsung.com Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200615091627euoutp0199eb7364779e874e2839641d5b8ddb19~YrOmNSpDU0150701507euoutp01w for ; Mon, 15 Jun 2020 09:16:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200615091627euoutp0199eb7364779e874e2839641d5b8ddb19~YrOmNSpDU0150701507euoutp01w DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1592212587; bh=8MHcbPJXq+kwnid4x3Yt5oFfSnVZa5KnUOBziD8DX+c=; h=From:To:Cc:Subject:Date:References:From; b=rqFVcLe+4QNb7O+qjTP17AIAzq9EPbfANmZl1MRUCxLVT6NudhshheupMd57KOSbQ LRpzUUpzQtclAN9lYF9XiWMSyTEUuiWfBQSl12NWk/eihmilR7FtAtu/mWA2dyB9s1 IGW+MTFkzU+6QwyKqGV59Oya4Ei0PAbe0s2qv7cE= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200615091627eucas1p21fc7fe565b3ce034156792ad92b42bbc~YrOmAArZG0065600656eucas1p24; Mon, 15 Jun 2020 09:16:27 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 7A.C1.61286.B6C37EE5; Mon, 15 Jun 2020 10:16:27 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200615091626eucas1p201c5de6731143c7928b74f61ce549f1e~YrOls56pp0272002720eucas1p2c; Mon, 15 Jun 2020 09:16:26 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200615091626eusmtrp2cba1422639754c486acf9e17fda6b6cd~YrOlsTJvz1130811308eusmtrp2n; Mon, 15 Jun 2020 09:16:26 +0000 (GMT) X-AuditID: cbfec7f2-f0bff7000001ef66-ee-5ee73c6b3998 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 28.96.07950.A6C37EE5; Mon, 15 Jun 2020 10:16:26 +0100 (BST) Received: from AMDC2765.digital.local (unknown [106.120.51.73]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200615091626eusmtip1bd2c623d674b33f577ccda30165c558c~YrOlXgSFk0909909099eusmtip1v; Mon, 15 Jun 2020 09:16:26 +0000 (GMT) From: Marek Szyprowski To: u-boot@lists.denx.de Cc: Marek Szyprowski , Joe Hershberger , Tom Rini Subject: [PATCH v2] net: ping: reset stored IP address Date: Mon, 15 Jun 2020 11:15:57 +0200 Message-Id: <20200615091557.23364-1-m.szyprowski@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJIsWRmVeSWpSXmKPExsWy7djP87rZNs/jDE49YrH4tPMxq8XaI3fZ LaZO2sxu8XZvJ7sDi8erA6vYPc7e2cHocf3MdiaPvi2rGANYorhsUlJzMstSi/TtErgy+jZM Zi14w1Fxv+8GcwPjPPYuRk4OCQETia1nF7N2MXJxCAmsYJRY8ngvM0hCSOALo8SVv44Q9mdG icPrnOAaJi9kgWhYzigxddVbJggHqOH/12Y2kCo2AUOJrrddYLaIgITEr/6rjF2MHBzMAlUS O17wgISFBcwkfv/4AXYFi4CqxKXZt8HKeQVsJRZ8XcwGsUxeYvWGA8wg8yUEdrBJzDt0lRUi 4SKx4+NyqCJhiVfHt0C9IyPxf+d8JoiGZkaJh+fWskM4PYwSl5tmMEJUWUvcOfeLDeIiTYn1 u/RBTAkBR4kvbWwQJp/EjbeCIMXMQOakbdOZIcK8Eh1tQhAz1CRmHV8Ht/XghUvMELaHROPX M4yQcIuVuL9tOtMERrlZCKsWMDKuYhRPLS3OTU8tNsxLLdcrTswtLs1L10vOz93ECIzw0/+O f9rB+PVS0iFGAQ5GJR7eCeHP4oRYE8uKK3MPMUpwMCuJ8DqdPR0nxJuSWFmVWpQfX1Sak1p8 iFGag0VJnNd40ctYIYH0xJLU7NTUgtQimCwTB6dUA6PrD66KXV2xSx9s27Kf7/WKuNcnDxTc PzLp5G4nBhdvz2gXft3Dz1Leb7ze3aRoHP316oz9R95n7+fbXfxny7NUpb1PT4mqyXSp3dw9 6fNZZ9/JYnPMHk5Su9gx/Wlzzo0Mj6jF+stqTEwDPA7K5HE/ie38tkdqlYfOnfcMJ1b39uQ2 nf4oZJqvxFKckWioxVxUnAgAnStmXewCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrELMWRmVeSWpSXmKPExsVy+t/xu7pZNs/jDF7sNbD4tPMxq8XaI3fZ LaZO2sxu8XZvJ7sDi8erA6vYPc7e2cHocf3MdiaPvi2rGANYovRsivJLS1IVMvKLS2yVog0t jPQMLS30jEws9QyNzWOtjEyV9O1sUlJzMstSi/TtEvQy+jZMZi14w1Fxv+8GcwPjPPYuRk4O CQETia2TF7J0MXJxCAksZZTYvfAnM0RCRuLktAZWCFtY4s+1LjaIok+MEpNe/wIrYhMwlOh6 C5Lg5BARkJD41X+VEcRmFqiReL90AROILSxgJvH7xw+wbSwCqhKXZt8Gq+cVsJVY8HUxG8QC eYnVGw4wT2DkWcDIsIpRJLW0ODc9t9hIrzgxt7g0L10vOT93EyMwvLYd+7llB2PXu+BDjAIc jEo8vBahz+KEWBPLiitzDzFKcDArifA6nT0dJ8SbklhZlVqUH19UmpNafIjRFGj5RGYp0eR8 YOjnlcQbmhqaW1gamhubG5tZKInzdggcjBESSE8sSc1OTS1ILYLpY+LglGpgbHiy1Gua4e8K Nfnnc/8aMZ/c4T1T/oLa/InOd7i3ljH02QdLO3qqxndeuC2fOsVc+ddZlrlSLTbHTi0KWzdD 4VukTBPDcbVNdRs3XtZntTOeaWugG/pOOi9g1yV2Jv5wRqm0+b6T2BwvNOTfSBW6f+r3rEBF 5nAOM9O5f2ef75tyKPLmKt5qJZbijERDLeai4kQA+/T7xUUCAAA= X-CMS-MailID: 20200615091626eucas1p201c5de6731143c7928b74f61ce549f1e X-Msg-Generator: CA X-RootMTR: 20200615091626eucas1p201c5de6731143c7928b74f61ce549f1e X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200615091626eucas1p201c5de6731143c7928b74f61ce549f1e References: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean Reset the stored ping IP address before entering a netloop with different protocol to ensure that it won't be interrupted by the received correct ICMP_ECHO_REPLY packet. Signed-off-by: Marek Szyprowski --- v2: - Moved the net_ping_ip reset to the beginning of the net_loop() if the protocol is not equal to PING. This is required, because the netretry feature of the network framework relies on the fact that the internal state of the commands is preserved between net_loop() calls. v1: https://patchwork.ozlabs.org/project/uboot/patch/20200325134200.18959-1-m.szyprowski@samsung.com/ - Initial version --- net/net.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/net.c b/net/net.c index 37932919d04..72b445774f9 100644 --- a/net/net.c +++ b/net/net.c @@ -409,6 +409,10 @@ int net_loop(enum proto_t protocol) int ret = -EINVAL; enum net_loop_state prev_net_state = net_state; +#if defined(CONFIG_CMD_PING) + if (protocol != PING) + net_ping_ip.s_addr = 0; +#endif net_restarted = 0; net_dev_exists = 0; net_try_count = 1;