From patchwork Fri May 15 21:28:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1291668 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49P1m26nxhz9sTC for ; Sat, 16 May 2020 07:30:26 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728209AbgEOVa0 (ORCPT ); Fri, 15 May 2020 17:30:26 -0400 Received: from mail-pj1-f67.google.com ([209.85.216.67]:34056 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727098AbgEOV2x (ORCPT ); Fri, 15 May 2020 17:28:53 -0400 Received: by mail-pj1-f67.google.com with SMTP id l73so4405794pjb.1; Fri, 15 May 2020 14:28:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6DYtMtUC5VyzJjkaI1PbcryyaFQEBo8w9yp476+Y/8k=; b=KE8hQEUk9b7d3DxEQoFt2WpLPBQA115RLNE5o3cJ6QVUSCA8/eKsqouK2EJ4AJhWV7 FGcfFLuYRx4Vv5Ux7mhtloN14BIMB4AX3fbQ5ajpRAwWDOejwAQpd0cHReTYFRY4HjqD SUf+gglEzlv1WoOliV5DhLSBDA6H3O8rmxr+EIS8JAnOrQAaHJwvAahJDZGGs+XJKPt8 OJQw4lxhfbckcm4FA5ImMtPlLpDE+lTv2eM4/EEDG7sxSjlgukrZpiJhqpC79cAwUiYF rwCmQsUvRFx0oulJYNKPIW1FtxasLVX6nTiC0HqGyIyR5kY+MPFxlBUdmcyvCRn4NTHs KEpg== X-Gm-Message-State: AOAM531OwB2wd29/5Azz+e5r5ybr83yaiY0rUYGANLts1gXdBhd+oefV LO23cvLKqXHrrpVGa6UXRcE= X-Google-Smtp-Source: ABdhPJxXfmLp+gvIUNO8TU4BMrhu87/QAIPcxxYwYq0djFtBbeCPpZgFKZuASiN+4EgG4W9iOStsEg== X-Received: by 2002:a17:902:9a06:: with SMTP id v6mr1597671plp.286.1589578132568; Fri, 15 May 2020 14:28:52 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id 14sm2700222pfy.38.2020.05.15.14.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:28:50 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 863A040E7B; Fri, 15 May 2020 21:28:49 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain Subject: [PATCH v2 01/15] taint: add module firmware crash taint support Date: Fri, 15 May 2020 21:28:32 +0000 Message-Id: <20200515212846.1347-2-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Device driver firmware can crash, and sometimes, this can leave your system in a state which makes the device or subsystem completely useless. Detecting this by inspecting /proc/sys/kernel/tainted instead of scraping some magical words from the kernel log, which is driver specific, is much easier. So instead provide a helper which lets drivers annotate this. Once this happens, scrapers can easily look for modules taint flags for a firmware crash. This will taint both the kernel and respective calling module. The new helper module_firmware_crashed() uses LOCKDEP_STILL_OK as this fact should in no way shape or form affect lockdep. This taint is device driver specific. Signed-off-by: Luis Chamberlain Reviewed-by: Rafael Aquini --- Documentation/admin-guide/tainted-kernels.rst | 6 ++++++ include/linux/kernel.h | 3 ++- include/linux/module.h | 13 +++++++++++++ include/trace/events/module.h | 3 ++- kernel/module.c | 5 +++-- kernel/panic.c | 1 + tools/debugging/kernel-chktaint | 7 +++++++ 7 files changed, 34 insertions(+), 4 deletions(-) diff --git a/Documentation/admin-guide/tainted-kernels.rst b/Documentation/admin-guide/tainted-kernels.rst index 71e9184a9079..92530f1d60ae 100644 --- a/Documentation/admin-guide/tainted-kernels.rst +++ b/Documentation/admin-guide/tainted-kernels.rst @@ -100,6 +100,7 @@ Bit Log Number Reason that got the kernel tainted 15 _/K 32768 kernel has been live patched 16 _/X 65536 auxiliary taint, defined for and used by distros 17 _/T 131072 kernel was built with the struct randomization plugin + 18 _/Q 262144 driver firmware crash annotation === === ====== ======================================================== Note: The character ``_`` is representing a blank in this table to make reading @@ -162,3 +163,8 @@ More detailed explanation for tainting produce extremely unusual kernel structure layouts (even performance pathological ones), which is important to know when debugging. Set at build time. + + 18) ``Q`` used by device drivers to annotate that the device driver's firmware + has crashed and the device's operation has been severely affected. The + device may be left in a crippled state, requiring full driver removal / + addition, system reboot, or it is unclear how long recovery will take. diff --git a/include/linux/kernel.h b/include/linux/kernel.h index 04a5885cec1b..19e1541c82c7 100644 --- a/include/linux/kernel.h +++ b/include/linux/kernel.h @@ -601,7 +601,8 @@ extern enum system_states { #define TAINT_LIVEPATCH 15 #define TAINT_AUX 16 #define TAINT_RANDSTRUCT 17 -#define TAINT_FLAGS_COUNT 18 +#define TAINT_FIRMWARE_CRASH 18 +#define TAINT_FLAGS_COUNT 19 struct taint_flag { char c_true; /* character printed when tainted */ diff --git a/include/linux/module.h b/include/linux/module.h index 2c2e988bcf10..221200078180 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -697,6 +697,14 @@ static inline bool is_livepatch_module(struct module *mod) bool is_module_sig_enforced(void); void set_module_sig_enforced(void); +void add_taint_module(struct module *mod, unsigned flag, + enum lockdep_ok lockdep_ok); + +static inline void module_firmware_crashed(void) +{ + add_taint_module(THIS_MODULE, TAINT_FIRMWARE_CRASH, LOCKDEP_STILL_OK); +} + #else /* !CONFIG_MODULES... */ static inline struct module *__module_address(unsigned long addr) @@ -844,6 +852,11 @@ void *dereference_module_function_descriptor(struct module *mod, void *ptr) return ptr; } +static inline void module_firmware_crashed(void) +{ + add_taint(TAINT_FIRMWARE_CRASH, LOCKDEP_STILL_OK); +} + #endif /* CONFIG_MODULES */ #ifdef CONFIG_SYSFS diff --git a/include/trace/events/module.h b/include/trace/events/module.h index 097485c73c01..b749ea25affd 100644 --- a/include/trace/events/module.h +++ b/include/trace/events/module.h @@ -26,7 +26,8 @@ struct module; { (1UL << TAINT_OOT_MODULE), "O" }, \ { (1UL << TAINT_FORCED_MODULE), "F" }, \ { (1UL << TAINT_CRAP), "C" }, \ - { (1UL << TAINT_UNSIGNED_MODULE), "E" }) + { (1UL << TAINT_UNSIGNED_MODULE), "E" }, \ + { (1UL << TAINT_FIRMWARE_CRASH), "Q" }) TRACE_EVENT(module_load, diff --git a/kernel/module.c b/kernel/module.c index 80faaf2116dd..f98e8c25c6b4 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -325,12 +325,13 @@ static inline int strong_try_module_get(struct module *mod) return -ENOENT; } -static inline void add_taint_module(struct module *mod, unsigned flag, - enum lockdep_ok lockdep_ok) +void add_taint_module(struct module *mod, unsigned flag, + enum lockdep_ok lockdep_ok) { add_taint(flag, lockdep_ok); set_bit(flag, &mod->taints); } +EXPORT_SYMBOL_GPL(add_taint_module); /* * A thread that wants to hold a reference to a module only while it diff --git a/kernel/panic.c b/kernel/panic.c index ec6d7d788ce7..504fb926947e 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -384,6 +384,7 @@ const struct taint_flag taint_flags[TAINT_FLAGS_COUNT] = { [ TAINT_LIVEPATCH ] = { 'K', ' ', true }, [ TAINT_AUX ] = { 'X', ' ', true }, [ TAINT_RANDSTRUCT ] = { 'T', ' ', true }, + [ TAINT_FIRMWARE_CRASH ] = { 'Q', ' ', true }, }; /** diff --git a/tools/debugging/kernel-chktaint b/tools/debugging/kernel-chktaint index 2240cb56e6e5..c397c6aabea7 100755 --- a/tools/debugging/kernel-chktaint +++ b/tools/debugging/kernel-chktaint @@ -194,6 +194,13 @@ else addout "T" echo " * kernel was built with the struct randomization plugin (#17)" fi +T=`expr $T / 2` +if [ `expr $T % 2` -eq 0 ]; then + addout " " +else + addout "Q" + echo " * a device driver's firmware has crashed (#18)" +fi echo "For a more detailed explanation of the various taint flags see" echo " Documentation/admin-guide/tainted-kernels.rst in the the Linux kernel sources" From patchwork Fri May 15 21:28:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1291667 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49P1lz0dWdz9sTM for ; Sat, 16 May 2020 07:30:23 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727780AbgEOV24 (ORCPT ); Fri, 15 May 2020 17:28:56 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:50980 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726261AbgEOV2z (ORCPT ); Fri, 15 May 2020 17:28:55 -0400 Received: by mail-pj1-f65.google.com with SMTP id t9so1486896pjw.0; Fri, 15 May 2020 14:28:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mQHcezCNWzGuPmczrAfsld1MqXEk0Ppb3Y+korjrHEA=; b=H+2oKvnmYCrBr2Dfs1Pi6drOXJbvRQQt+hNxPiGB08gBWLo4B6oz9KQfGx0iADraeb vnHi6UQV0Df0WWM6dUKmqvQM1QPXX+pYS9l34fs/uUQTcO7bBg2CktOOutBmSl4mNquM KG5lKxbRxFOjvl634ZryJUHKWTAeyC8V394sA96MxQuZrvGO4hoZ2QwR1MW/Spx63/hR 36F3xQIaghvCqctVOCQIdn6UmPvWh14pOacWOkMZYTB3OvogYP80heUiqC53gdUsBmeu R5pIjqLuhum1Ejz3kHouKQ1JP0fBQHmFQp77sdVduxQyEo5WzUflp+DWk88B+SYby8Vi MPkA== X-Gm-Message-State: AOAM531apOtzAfQAAvMk67g1R4jK5OCKFAmmivnDcqo+2ZHRW7XlTADW Si9bRDwwbbv6rKK5eBJ1aMI= X-Google-Smtp-Source: ABdhPJyl+c2F2sSpT3BFpmj7bcqKO62RcphXge2jJKPYJfka1FrmqSH1lDeI22yxIOVw1tH5xuJoOg== X-Received: by 2002:a17:90a:4d4a:: with SMTP id l10mr5686766pjh.0.1589578133718; Fri, 15 May 2020 14:28:53 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id z13sm2235488pjz.42.2020.05.15.14.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:28:50 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 98C5341D00; Fri, 15 May 2020 21:28:49 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , "Michael S. Tsirkin" , Shannon Nelson , Jakub Kicinski , Heiner Kallweit Subject: [PATCH v2 02/15] ethernet/839: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:33 +0000 Message-Id: <20200515212846.1347-3-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: "Michael S. Tsirkin" Cc: Shannon Nelson Cc: Jakub Kicinski Cc: Heiner Kallweit Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/ethernet/8390/axnet_cs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/8390/axnet_cs.c b/drivers/net/ethernet/8390/axnet_cs.c index aeae7966a082..8ad0200db8e9 100644 --- a/drivers/net/ethernet/8390/axnet_cs.c +++ b/drivers/net/ethernet/8390/axnet_cs.c @@ -1358,9 +1358,11 @@ static void ei_receive(struct net_device *dev) */ if ((netif_msg_rx_err(ei_local)) && this_frame != ei_local->current_page && - (this_frame != 0x0 || rxing_page != 0xFF)) + (this_frame != 0x0 || rxing_page != 0xFF)) { + module_firmware_crashed(); netdev_err(dev, "mismatched read page pointers %2x vs %2x\n", this_frame, ei_local->current_page); + } if (this_frame == rxing_page) /* Read all the frames? */ break; /* Done for now */ From patchwork Fri May 15 21:28:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1291666 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49P1lv1yjCz9sTH for ; Sat, 16 May 2020 07:30:19 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727814AbgEOV25 (ORCPT ); Fri, 15 May 2020 17:28:57 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:43365 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727119AbgEOV2z (ORCPT ); Fri, 15 May 2020 17:28:55 -0400 Received: by mail-pg1-f193.google.com with SMTP id f4so1588986pgi.10; Fri, 15 May 2020 14:28:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Os/9pOAyuFP5rE18cPqNjIzCr5UNKNMa70RxbYuAtoQ=; b=BLUUinTZb4bn1XwI4Sbw0k1YwFvObAbJ76yDFFi2D6kYhxyYjBqrdkYZd8TsFJC6cT lzAv4/3uN3LPyYBmvdQQJr35Qo64pUr7t41qhno8B6KDGghGw+HbOkX/htvDZGIDyExK aXB3D3HoB/FlBXdGJCsmN8u3CHkh389CALRHiOdtfrjvs47La+90o8Gjl5A0/1vW6uFb zFiPflefNNWFEIOSVjYjXz9D9NmRQxu3hpcFcVza1x67tX924W9jCfNRB7JJZsBQi6NH PagsDNan9mF0XBTCIFQtho+IKrxYIqrvFZ8ED7omzWRnKmEmqkZBT9paOgz12U4SzW0f KpvQ== X-Gm-Message-State: AOAM532H8RWgWRcEKHphaz0lWbp+McCWDaH1bd+4gexLAL8HT71Pxwmu MqFS3Xm7E2si7XSH0bXRLlc= X-Google-Smtp-Source: ABdhPJxA6chVMk3VbtmoOXv21M2cB33WLyUbJtzdTmRjvXxRRJ0EACaWlp73Wt9JQyukkevMHDPzbg== X-Received: by 2002:a62:68c1:: with SMTP id d184mr5878271pfc.138.1589578134871; Fri, 15 May 2020 14:28:54 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id o9sm2171534pjp.4.2020.05.15.14.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:28:50 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id A958C41D95; Fri, 15 May 2020 21:28:49 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Ariel Elior , Sudarsana Kalluru , GR-everest-linux-l2@marvell.com Subject: [PATCH v2 03/15] bnx2x: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:34 +0000 Message-Id: <20200515212846.1347-4-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Ariel Elior Cc: Sudarsana Kalluru CC: GR-everest-linux-l2@marvell.com Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c index db5107e7937c..c38b8c9c8af0 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c @@ -909,6 +909,7 @@ void bnx2x_panic_dump(struct bnx2x *bp, bool disable_int) bp->eth_stats.unrecoverable_error++; DP(BNX2X_MSG_STATS, "stats_state - DISABLED\n"); + module_firmware_crashed(); BNX2X_ERR("begin crash dump -----------------\n"); /* Indices */ From patchwork Fri May 15 21:28:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1291665 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49P1lr1r3Yz9sTH for ; Sat, 16 May 2020 07:30:16 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728191AbgEOVaN (ORCPT ); Fri, 15 May 2020 17:30:13 -0400 Received: from mail-pj1-f67.google.com ([209.85.216.67]:53439 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727801AbgEOV25 (ORCPT ); Fri, 15 May 2020 17:28:57 -0400 Received: by mail-pj1-f67.google.com with SMTP id hi11so1478795pjb.3; Fri, 15 May 2020 14:28:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sfS8RWQILq5pTxsiwJfRKnCbiFfxKVOF+i1nmZH/cEc=; b=cHahCf7CLkL4kfpfmih1x5N6/feF48MZgbx5eEkuYk65j8O4PaHb6eGXgGVz6LR7Ax IP/gmHiRc4/myy7Jf7XuiqKBvz16JY5DjMaecLMP7ArLVctpv2MbxXavfj5GbqysxNaU rpuUwy2gzGV0e3Cc02KA4DVsy3yq0Q3RcR7n/3UFfJL02omregaz9H3u09/vcD967rVY s+BNyAt6zdHovGQAp6XFEY7Xp2FdmxBruWnSxoCJpzT55RvME9UGGQjgTaLWYGzyjw/k ayVmozkwT2YB1EWWmQKiVT8ggkf5W52W+jXASD2Hq2tmgs0xlCtX4NDK2wokgbg1n9jd yTVw== X-Gm-Message-State: AOAM531QRFWiKi0nXQ+eITvPE/PjeQcfDW5KUSeM5BWaVezO5WuRu8wT TaibqIPa4uRPiCbEFLInBYw= X-Google-Smtp-Source: ABdhPJyDXHKz7boZGvqXqSLG3GjzTod1lFNdJn6sXhTEjxoVmBj7l/4U3APnTK6uCHCt/7oLvtItAA== X-Received: by 2002:a17:902:dc84:: with SMTP id n4mr5635258pld.281.1589578135789; Fri, 15 May 2020 14:28:55 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id v7sm2644511pfm.146.2020.05.15.14.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:28:51 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id B9C4A41DAB; Fri, 15 May 2020 21:28:49 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Michael Chan Subject: [PATCH v2 04/15] bnxt: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:35 +0000 Message-Id: <20200515212846.1347-5-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Michael Chan Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini Nacked-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index dd0c3f227009..5ba1bd0734e9 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -3503,6 +3503,7 @@ static int bnxt_get_dump_data(struct net_device *dev, struct ethtool_dump *dump, dump->flag = bp->dump_flag; if (dump->flag == BNXT_DUMP_CRASH) { + module_firmware_crashed(); #ifdef CONFIG_TEE_BNXT_FW return tee_bnxt_copy_coredump(buf, 0, dump->len); #endif From patchwork Fri May 15 21:28:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1291659 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49P1lF5Z6wz9sTH for ; Sat, 16 May 2020 07:29:45 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727910AbgEOV3F (ORCPT ); Fri, 15 May 2020 17:29:05 -0400 Received: from mail-pj1-f68.google.com ([209.85.216.68]:55098 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726261AbgEOV25 (ORCPT ); Fri, 15 May 2020 17:28:57 -0400 Received: by mail-pj1-f68.google.com with SMTP id s69so1476674pjb.4; Fri, 15 May 2020 14:28:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iJHZT4MFB+sxpA2IE8Rn7gYtD/Qc3TQAcYIYNGZYEvg=; b=phgAbbNGhP6J6HCS81WASgrpY9Nrx5oVe49i1im1AEYCMmyduUplIcxbSk128lbn5z TU2mr1DIJBXRCn0klJ41zaK7+lstVO2R1X9Mt3moIhbF1Z2I2T1IaKpUnEJ/hEV6+b/H ZT1TabezFw8DNFr/6SUEIU+ShgnsNkOOShmjegw3aXW3+dPT3rahU/pTRJ3jem3C/UHU nwfLtdSsE3FiPQ13tMm7pqTCk5DHaVzSj8uGfDs+Or0WM7VGkpITCN/69O64+202a897 RiLjpzheuUA9YMRXoR4QSwImyHDd4RymJKRryVL+VOogvxc0LBBast66Ir0BpeFcKCYF dh7g== X-Gm-Message-State: AOAM5307VsbEQwiBDwxoBXLSrs66/8AOC2cJSWO81u8LqRTHytElmFSm FdNIdsjE6atRICRr2kTle1Y= X-Google-Smtp-Source: ABdhPJyXGdNJ50o8iXun3oJYb5kOl4qAS44k7tBrK+zhGB5FrkYaAMjM2mxcrnwWQ+1fLrVtkOdV0w== X-Received: by 2002:a17:902:9f97:: with SMTP id g23mr5721810plq.30.1589578136986; Fri, 15 May 2020 14:28:56 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id m9sm2450255pgd.1.2020.05.15.14.28.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:28:55 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id CB94E41EDA; Fri, 15 May 2020 21:28:49 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Rasesh Mody , Sudarsana Kalluru , GR-Linux-NIC-Dev@marvell.com Subject: [PATCH v2 05/15] bna: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:36 +0000 Message-Id: <20200515212846.1347-6-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Rasesh Mody Cc: Sudarsana Kalluru Cc: GR-Linux-NIC-Dev@marvell.com Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c index e17bfc87da90..b3f44a912574 100644 --- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c +++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c @@ -927,6 +927,7 @@ bfa_iocpf_sm_disabled(struct bfa_iocpf *iocpf, enum iocpf_event event) static void bfa_iocpf_sm_initfail_sync_entry(struct bfa_iocpf *iocpf) { + module_firmware_crashed(); bfa_nw_ioc_debug_save_ftrc(iocpf->ioc); bfa_ioc_hw_sem_get(iocpf->ioc); } From patchwork Fri May 15 21:28:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1291662 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49P1lZ3z4jz9sTM for ; Sat, 16 May 2020 07:30:02 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727882AbgEOV3C (ORCPT ); Fri, 15 May 2020 17:29:02 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:37558 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727119AbgEOV27 (ORCPT ); Fri, 15 May 2020 17:28:59 -0400 Received: by mail-pf1-f193.google.com with SMTP id y198so16653pfb.4; Fri, 15 May 2020 14:28:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z+ArGLDYdSJ0w7Ek09g85tZFCS/nTsClbFEBaRYmVeE=; b=JKj/b0lhoe91hvSIP4HwSrtqmQV9Zmq7gBg//kOnQ6nJPk49bZqU/6FmQwJiI4WMOZ aSE+ehqCEg/QCemRs+2sfu858cebfalP55rGkobjcTV5Pl16xdYxG5cIlZPFB0Ju2aOL zkB++V8lSS2JOYE7P+BaHcB47liizJ8e+W8b8H9e6BQ3eXiccfIjAd9yjG3kd7Ef+asP GqA4kQtmO27dvmDEbZ6d/lTICzg1mciiL3tnV/hhXgll5ALFI4exu6i/Ag7dO82UIQKN +zUtuO2m432IzTOFxHoQuM00tJJMXLeru1NK6wepk9jm4syq7B0ALAUO0GLmC652/3ur ljQg== X-Gm-Message-State: AOAM53321W61l1qU/ACg1FaVlhwvWdJ6PO1f8YM1ryvOk9/l8kUdjTxZ T3Xvcj8wXsG5/rhcVauC0Aw= X-Google-Smtp-Source: ABdhPJyh4noS75cFo4UeBGQrE1rurDnL6NYp88Jw6dMIn4GnhLizAu+jGFCLtYQLhffbGewrUXICdw== X-Received: by 2002:a62:38d5:: with SMTP id f204mr5547097pfa.284.1589578138203; Fri, 15 May 2020 14:28:58 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id b74sm2424048pga.31.2020.05.15.14.28.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:28:55 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id D6EE2422E5; Fri, 15 May 2020 21:28:49 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Derek Chickles , Satanand Burla , Felix Manlunas Subject: [PATCH v2 06/15] liquidio: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:37 +0000 Message-Id: <20200515212846.1347-7-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Derek Chickles Cc: Satanand Burla Cc: Felix Manlunas Reviewed-by: Derek Chickles Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c index 66d31c018c7e..f18085262982 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c @@ -801,6 +801,7 @@ static int liquidio_watchdog(void *param) continue; WRITE_ONCE(oct->cores_crashed, true); + module_firmware_crashed(); other_oct = get_other_octeon_device(oct); if (other_oct) WRITE_ONCE(other_oct->cores_crashed, true); From patchwork Fri May 15 21:28:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1291664 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49P1lh57W9z9sTH for ; Sat, 16 May 2020 07:30:08 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727851AbgEOV3B (ORCPT ); Fri, 15 May 2020 17:29:01 -0400 Received: from mail-pj1-f67.google.com ([209.85.216.67]:35786 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727832AbgEOV27 (ORCPT ); Fri, 15 May 2020 17:28:59 -0400 Received: by mail-pj1-f67.google.com with SMTP id ms17so1569000pjb.0; Fri, 15 May 2020 14:28:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fd2Ff5siORQ4NZvgjnMFoAiHp6dqIbzzKwIfZcm3FIc=; b=BbU7nLLCnL0CMc8B1TK0v++o+EgMFOAYQ3+v6FFOGj2YdIDThd9W2S+xLoHY3f53VK Z6UNPlzpnzM0OWToW5yKB1Y7NA58aX/CQTeAdhiUlVs7/2JlfOKHv8ba2TddhJsWzXIP BVe6wQU3zfKS1xA4oF47NMdMJhMk537ZYxHj7XF8CUjAxDykrEqo7QuxD0+cXf3Sx7HM d/iRiJqYwM0BtNM5WFAkZfU3T7HveQGAVVL2PrYhvh3+Dri0arZc0f80w+Wy3dnDxCQQ RikXnVAFWKrHBUuvqaQ95ZeQzlHQINf/vXe28Kk3QwT1ga78fPRQ2OSHxnIPNHYETOV6 +HJw== X-Gm-Message-State: AOAM533yGFVeuFt3WtfHo3WysSAKyvXm/C3I6p0e3rn74TNL66x/UY65 9yM4opW7Yau2oUUUYKU5PwE= X-Google-Smtp-Source: ABdhPJwAUG/0eLuXRMlJSjdKAtnNa9OX6nQKuBKKPQ9d/8v8pxImlglzByIaxepGuWvS5k1Ufbpawg== X-Received: by 2002:a17:90b:3650:: with SMTP id nh16mr3915296pjb.135.1589578139466; Fri, 15 May 2020 14:28:59 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id cx11sm2284688pjb.36.2020.05.15.14.28.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:28:55 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id E19F342309; Fri, 15 May 2020 21:28:49 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Vishal Kulkarni Subject: [PATCH v2 07/15] cxgb4: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:38 +0000 Message-Id: <20200515212846.1347-8-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Vishal Kulkarni Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index a70018f067aa..c67fc86c0e42 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -3646,6 +3646,7 @@ void t4_fatal_err(struct adapter *adap) * could be exposed to the adapter. RDMA MWs for example... */ t4_shutdown_adapter(adap); + module_firmware_crashed(); for_each_port(adap, port) { struct net_device *dev = adap->port[port]; From patchwork Fri May 15 21:28:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1291658 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49P1lB36zfz9sTH for ; Sat, 16 May 2020 07:29:42 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727928AbgEOV3G (ORCPT ); Fri, 15 May 2020 17:29:06 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:53441 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727867AbgEOV3C (ORCPT ); Fri, 15 May 2020 17:29:02 -0400 Received: by mail-pj1-f65.google.com with SMTP id hi11so1478894pjb.3; Fri, 15 May 2020 14:29:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BVI90Jx0mfg2mzobQ93FBFZYLfrAY+kFFbLRK534ymo=; b=ar/M2cEv/VBx2QHo3CeSYjVh1shWk97jwOG9PNwmNumzRX7dxVUdwip7nwQ+6fEeW0 BY1mLcn5ZJdqNQILAyLVBrSiQH9p7zasqRksdYiXcsLwfOycIQvvZmWK9F09bYcIWB3K gb1lXEFzb+KjodAL7UIHM+mw/lvgyfBajiWusT5NMy294dxDxOtQmQz60x+oPGOYBl9G BZzFexzQ5Gi27DOJkREVjqfIMjaYAGmO7OCHLLAOh9p6BacgZxkhWLJyOPbvAsiGMBj6 lcR2cfZ8AOf0du9cdtSOyAaPY+k7+p2PmeXwY/jQs7bpUN7waAgxnKaYk3h9sHbAaVZQ Vjuw== X-Gm-Message-State: AOAM531RbIPEYAJuOewWibkXYYUjXICt1H/23gIcJvH9I4Sw9qLCa7sj EVqFkC9cG7Ws6b6UWWZBxq8= X-Google-Smtp-Source: ABdhPJxnQmcqRbJRGZ8iB7ghw3anMd7q93j51/pmVs2akYDs6Ntm0WHQQx7X7QEZmBozSzdYQTrPQg== X-Received: by 2002:a17:90a:bf08:: with SMTP id c8mr5687943pjs.13.1589578140564; Fri, 15 May 2020 14:29:00 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id kr1sm2174731pjb.26.2020.05.15.14.28.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:28:55 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id ED1424230A; Fri, 15 May 2020 21:28:49 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Douglas Miller Subject: [PATCH v2 08/15] ehea: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:39 +0000 Message-Id: <20200515212846.1347-9-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Douglas Miller Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 0273fb7a9d01..6ae35067003f 100644 --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c @@ -3285,6 +3285,8 @@ static void ehea_crash_handler(void) { int i; + module_firmware_crashed(); + if (ehea_fw_handles.arr) for (i = 0; i < ehea_fw_handles.num_entries; i++) ehea_h_free_resource(ehea_fw_handles.arr[i].adh, From patchwork Fri May 15 21:28:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1291663 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49P1ld64YKz9sTH for ; Sat, 16 May 2020 07:30:05 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728172AbgEOVaD (ORCPT ); Fri, 15 May 2020 17:30:03 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:41782 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727858AbgEOV3C (ORCPT ); Fri, 15 May 2020 17:29:02 -0400 Received: by mail-pf1-f194.google.com with SMTP id 23so1592594pfy.8; Fri, 15 May 2020 14:29:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xBkpYn0OGRXJFLEKv1YJxgMkLUAuINcwhwjSKqfiGiY=; b=m30sbDf77Zi/njTeLobRWD016F37cTQ8m/G0f51ZK5biDp25HiBDwGAxuo2WImwvbb d4BoLWrZb5scx0nhWdgCa+RQ0d+aS/v37Nkg6W5gB0i7YPZHx6iXODjiHcKUG9imGugm baK23zRzhw+xFwa9PrH9vu/Mp05p1iIH/VO8GUVE/GRD1QIwFGXWxLz80hDxxHvDrO8f mgXnyVBpDLS7yXqo2qNW5W3Opx1v4kvA+hBcJRGlT2AwjlS96oTdZT7k+uC1bDS05fWr 5HWQXuAg+GXrA1PhJ+f0dW95ghV3wnUESHltzegIu+g53gP7lgmtyXIStNBDmK4O0ExB l9Tw== X-Gm-Message-State: AOAM5336AFOIF49CJJ/Lo4SqpHT724gjcPOW8qwhJqcnG5IL3oUenlZG lgGV4zeb1LpFrdJH4CltuZI= X-Google-Smtp-Source: ABdhPJySutDUwh/Hlrvw1b9svILaoMn5tvR1dnM8imuIRFA9bR+HSq1C9aBBC60X0+Qj6CPPZAUuwA== X-Received: by 2002:a63:42c4:: with SMTP id p187mr5038674pga.153.1589578141509; Fri, 15 May 2020 14:29:01 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id y7sm2681182pfq.21.2020.05.15.14.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:28:55 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 053B742337; Fri, 15 May 2020 21:28:50 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Ariel Elior , GR-everest-linux-l2@marvell.com, Igor Russkikh Subject: [PATCH v2 09/15] qed: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:40 +0000 Message-Id: <20200515212846.1347-10-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Ariel Elior Cc: GR-everest-linux-l2@marvell.com Reviewed-by: Igor Russkikh Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/ethernet/qlogic/qed/qed_mcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethernet/qlogic/qed/qed_mcp.c index 9624616806e7..aea200d465ef 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c +++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c @@ -566,6 +566,7 @@ _qed_mcp_cmd_and_union(struct qed_hwfn *p_hwfn, DP_NOTICE(p_hwfn, "The MFW failed to respond to command 0x%08x [param 0x%08x].\n", p_mb_params->cmd, p_mb_params->param); + module_firmware_crashed(); qed_mcp_print_cpu_info(p_hwfn, p_ptt); spin_lock_bh(&p_hwfn->mcp_info->cmd_lock); From patchwork Fri May 15 21:28:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1291661 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49P1lT5hXfz9sTH for ; Sat, 16 May 2020 07:29:57 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728148AbgEOV34 (ORCPT ); Fri, 15 May 2020 17:29:56 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:38786 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727884AbgEOV3D (ORCPT ); Fri, 15 May 2020 17:29:03 -0400 Received: by mail-pl1-f194.google.com with SMTP id m7so1431073plt.5; Fri, 15 May 2020 14:29:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=q9PwzdCQf8OZTe8dAYOPmHkC2y8QfZP7n40O3xNZ4X4=; b=df8TRJLJ1RXLSRHcRrfIw6OS3qe40NKqM4dfJfApWY1E4d+dz9n9baaCmPYQ/DBwRp jc3meNVqVGCIpN36KXwDybymH9HtacPx9md6eVmV1jzSRy741aXHSB4qqELBdHVBILwZ PNm3cSm1BA/1cJSdItK8w655sVthAphMKvmneGVOdVHNHO0JYN884aI0iEl02ulTGkVB xFY0+B3tGCPVmTsWWUcaWBK2ViftfwRG98YbLjZEzwquB+0Jp6cdOSLQIPecnw5f7k1s E6O9vyjv6aXkr768hn7O21cstq//0SK+WXSISk7YLB+p586L7xYWm/YUbmcmpBD+DIHc bu7A== X-Gm-Message-State: AOAM532O50ZBCKvJ04TEdlr8N/DXD7jAVS9PkhjgDYzmtrlGRAow97NF sWtEUAS4/kzoEJfNzw3aKIg= X-Google-Smtp-Source: ABdhPJyrm+xaRGTabJz/en5ByrR3PDdgfo69rGBaeEQxT6mtQVCqVD2NZl0Yj2IiJxaWLZHc4xWqTQ== X-Received: by 2002:a17:902:988a:: with SMTP id s10mr5292140plp.204.1589578142589; Fri, 15 May 2020 14:29:02 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id cc8sm2217813pjb.11.2020.05.15.14.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:28:55 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 0FF8E42340; Fri, 15 May 2020 21:28:50 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Alex Elder Subject: [PATCH v2 10/15] soc: qcom: ipa: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:41 +0000 Message-Id: <20200515212846.1347-11-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Alex Elder Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/ipa/ipa_modem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ipa/ipa_modem.c b/drivers/net/ipa/ipa_modem.c index ed10818dd99f..1790b87446ed 100644 --- a/drivers/net/ipa/ipa_modem.c +++ b/drivers/net/ipa/ipa_modem.c @@ -285,6 +285,7 @@ static void ipa_modem_crashed(struct ipa *ipa) struct device *dev = &ipa->pdev->dev; int ret; + module_firmware_crashed(); ipa_endpoint_modem_pause_all(ipa, true); ipa_endpoint_modem_hol_block_clear_all(ipa); From patchwork Fri May 15 21:28:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1291660 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49P1lH16VNz9sTH for ; Sat, 16 May 2020 07:29:47 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728109AbgEOV3q (ORCPT ); Fri, 15 May 2020 17:29:46 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:42173 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727904AbgEOV3F (ORCPT ); Fri, 15 May 2020 17:29:05 -0400 Received: by mail-pf1-f196.google.com with SMTP id y18so1595189pfl.9; Fri, 15 May 2020 14:29:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qxlVajjfNXCuVHnmE5Xgl/OMrJvTtdBFsSisnAsjai4=; b=cjNh+5CWfFuHJmEkhtQZTa8V2Er32bR+QtLu4ooAgibXEBJ5yuZtVzohKHLeNYSCbw 0PrTOvVCRuw47szXz+aWI/f4+GMaYgGCyjiL6gsfgzG/DoH5IoH9NM9Sb0+aIVmTLUtP 9w6H82f40HsQ0Ia8QXSOd0rYiR83Qgy6kTU1OEz6bPz+Faqv1hVU80CjGR7zFw6CdBnn TnQsxOt7+ZdVzqbF//bGArm5msWhmmYTCa7H/UXfF4C9b+zFNb4WJbv7Ph4jG85L1KjO pYPDr6DMkhiizXqYr2trL3sJ2VzcuMIzonCmNCNjPQSDTQ6mA1mc4N7a+Rp4DuuVrRlF Mbag== X-Gm-Message-State: AOAM532knxrDHsbGmcGFNDomaa7TlvU9rDxHe9P2WR+I1Ea3ELWVA8vi WMKC1ypzdFpmPa4L/OY5zJs= X-Google-Smtp-Source: ABdhPJxQ0KFVYL9S7FuI8AkItqLd45YmQBv/URE7CupJdOWl8x9JUhRFuhp/9RSwH2FI5AIrP9WBbw== X-Received: by 2002:a65:560f:: with SMTP id l15mr2568395pgs.439.1589578143709; Fri, 15 May 2020 14:29:03 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id cc8sm2217831pjb.11.2020.05.15.14.28.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:28:55 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 19BE342341; Fri, 15 May 2020 21:28:50 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , linux-wimax@intel.com, Inaky Perez-Gonzalez Subject: [PATCH v2 11/15] wimax/i2400m: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:42 +0000 Message-Id: <20200515212846.1347-12-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: linux-wimax@intel.com Cc: Inaky Perez-Gonzalez Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/wimax/i2400m/rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wimax/i2400m/rx.c b/drivers/net/wimax/i2400m/rx.c index c9fb619a9e01..307a62ca183f 100644 --- a/drivers/net/wimax/i2400m/rx.c +++ b/drivers/net/wimax/i2400m/rx.c @@ -712,6 +712,7 @@ void __i2400m_roq_queue(struct i2400m *i2400m, struct i2400m_roq *roq, dev_err(dev, "SW BUG? failed to insert packet\n"); dev_err(dev, "ERX: roq %p [ws %u] skb %p nsn %d sn %u\n", roq, roq->ws, skb, nsn, roq_data->sn); + module_firmware_crashed(); skb_queue_walk(&roq->queue, skb_itr) { roq_data_itr = (struct i2400m_roq_data *) &skb_itr->cb; nsn_itr = __i2400m_roq_nsn(roq, roq_data_itr->sn); From patchwork Fri May 15 21:28:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1291656 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49P1kw0SP0z9sTC for ; Sat, 16 May 2020 07:29:28 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727958AbgEOV3I (ORCPT ); Fri, 15 May 2020 17:29:08 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:41786 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727922AbgEOV3G (ORCPT ); Fri, 15 May 2020 17:29:06 -0400 Received: by mail-pf1-f194.google.com with SMTP id 23so1592660pfy.8; Fri, 15 May 2020 14:29:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+C5HUmb0IVN2XUMtCx+958ASlteYAzKSr3n9xtQKd1o=; b=sjmJt+iGDzcAx/sJoynK2092IRpplkRBFKvE8SzJoTImgURQwF1+95B0lH32YGTQlx Nkxj0LdLaMogM/jD1n716idtha6ExL6H7iFa9vX/Bw639xmKZ4CJBBaHNMIipt3qT9Ue F99d/3wd8fCdZfeNJSIx6tUe/PSsCXxY2Qp+BkDuqX+9Qs4qJYfQl+eM+fyvk+ybOeVU wSIjtT2JQgIWjvjqcFZ2AYT0bBcQj363PxClrk2P3EY20eCf24ZYdkQvfO0lgw7fXrza SLI7FEHFO7Uer02fGPHdSG73D50AEQY24TDXAcMT1QqO/jI7C+qtQ5UEvu01h/Vtd9yD x8mw== X-Gm-Message-State: AOAM531+lkF3zUHdQpy7F465dWKz5qwkXKyTRF1smhzUdS2OXu2N3dw7 1nwCJXQRHUhdtzB+dENzks0= X-Google-Smtp-Source: ABdhPJx5aHzvT/Yod67FCxrd/rYpeLz+YvwfHeXEiG+n38C/BUT1hIQZlmj9K6EmCO5IWEzJJXgtBQ== X-Received: by 2002:a63:ef05:: with SMTP id u5mr4866245pgh.237.1589578144777; Fri, 15 May 2020 14:29:04 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id e18sm2688831pfh.75.2020.05.15.14.28.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:28:56 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 33D1942349; Fri, 15 May 2020 21:28:50 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: [PATCH v2 12/15] ath10k: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:43 +0000 Message-Id: <20200515212846.1347-13-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: linux-wireless@vger.kernel.org Cc: ath10k@lists.infradead.org Cc: Kalle Valo Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/wireless/ath/ath10k/pci.c | 2 ++ drivers/net/wireless/ath/ath10k/sdio.c | 2 ++ drivers/net/wireless/ath/ath10k/snoc.c | 1 + 3 files changed, 5 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 1d941d53fdc9..6bd0f3b518b9 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -1767,6 +1767,7 @@ static void ath10k_pci_fw_dump_work(struct work_struct *work) scnprintf(guid, sizeof(guid), "n/a"); ath10k_err(ar, "firmware crashed! (guid %s)\n", guid); + module_firmware_crashed(); ath10k_print_driver_info(ar); ath10k_pci_dump_registers(ar, crash_data); ath10k_ce_dump_registers(ar, crash_data); @@ -2837,6 +2838,7 @@ static int ath10k_pci_hif_power_up(struct ath10k *ar, if (ret) { if (ath10k_pci_has_fw_crashed(ar)) { ath10k_warn(ar, "firmware crashed during chip reset\n"); + module_firmware_crashed(); ath10k_pci_fw_crashed_clear(ar); ath10k_pci_fw_crashed_dump(ar); } diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c index e2aff2254a40..d34ad289380f 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -794,6 +794,7 @@ static int ath10k_sdio_mbox_proc_dbg_intr(struct ath10k *ar) /* TODO: Add firmware crash handling */ ath10k_warn(ar, "firmware crashed\n"); + module_firmware_crashed(); /* read counter to clear the interrupt, the debug error interrupt is * counter 0. @@ -915,6 +916,7 @@ static int ath10k_sdio_mbox_proc_cpu_intr(struct ath10k *ar) if (cpu_int_status & MBOX_CPU_STATUS_ENABLE_ASSERT_MASK) { ath10k_err(ar, "firmware crashed!\n"); queue_work(ar->workqueue, &ar->restart_work); + module_firmware_crashed(); } return ret; } diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index 354d49b1cd45..7cfc123c345c 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -1451,6 +1451,7 @@ void ath10k_snoc_fw_crashed_dump(struct ath10k *ar) scnprintf(guid, sizeof(guid), "n/a"); ath10k_err(ar, "firmware crashed! (guid %s)\n", guid); + module_firmware_crashed(); ath10k_print_driver_info(ar); ath10k_msa_dump_memory(ar, crash_data); mutex_unlock(&ar->dump_mutex); From patchwork Fri May 15 21:28:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1291654 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49P1kl4Ls6z9sTS for ; Sat, 16 May 2020 07:29:19 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727987AbgEOV3J (ORCPT ); Fri, 15 May 2020 17:29:09 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:44006 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727927AbgEOV3H (ORCPT ); Fri, 15 May 2020 17:29:07 -0400 Received: by mail-pl1-f196.google.com with SMTP id k22so1420778pls.10; Fri, 15 May 2020 14:29:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aC7L6/f42/gPjIDsH2AkyT3HK+i3vctnLudoDWO4A04=; b=AjRDRWxVI1WN7GDdK6vjTn5SnQsS2mN8zRsjdrP7IWtWYZbszAuLxVMczdZJhB1b4l EjVWOyRKLCMJNfmtFed1M9mUiwjz6IfcQ/zdbqtgf68gVDwaT3GJVuGBTV9sQiqCinAi UwGyQ8QOVaEmITnedKpN8LBHVsga4l6aDUZ8uBzA+s8qnXeN3js0d4gH0RTrByZUr4fU Fhm+Zp2gxIMoKWSm3iFlccjku5CzAVa/OrP+3ti8mcJb68fZlG/iBUtfXTfoyqUVmw3O NA6d4RuTC4mA+QImQPBPxEZi+8vz2X6AG0yKeWfzBztGwAW1xvq978P2wusLN4c9u8d4 mslw== X-Gm-Message-State: AOAM531K7v+evP/tw2qlD6CfBRAeGsFAz12yq6TSCPH8/36ST4e3nsDQ ImtxfAyO6D7y8MizlDmzSQI= X-Google-Smtp-Source: ABdhPJxXNou50yIHSh6fq7UacJSKWUh4Fh8iActeIPzYhcfbgAV9CeFNZwMPi6ZjkC+/+JSXSaCiwQ== X-Received: by 2002:a17:90a:d818:: with SMTP id a24mr5616179pjv.75.1589578146344; Fri, 15 May 2020 14:29:06 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id w190sm2302171pfw.35.2020.05.15.14.28.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:29:04 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 42D5442376; Fri, 15 May 2020 21:28:50 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: [PATCH v2 13/15] ath6kl: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:44 +0000 Message-Id: <20200515212846.1347-14-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: linux-wireless@vger.kernel.org Cc: ath10k@lists.infradead.org Cc: Kalle Valo Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/wireless/ath/ath6kl/hif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath6kl/hif.c b/drivers/net/wireless/ath/ath6kl/hif.c index d1942537ea10..cfd838607544 100644 --- a/drivers/net/wireless/ath/ath6kl/hif.c +++ b/drivers/net/wireless/ath/ath6kl/hif.c @@ -120,6 +120,7 @@ static int ath6kl_hif_proc_dbg_intr(struct ath6kl_device *dev) int ret; ath6kl_warn("firmware crashed\n"); + module_firmware_crashed(); /* * read counter to clear the interrupt, the debug error interrupt is From patchwork Fri May 15 21:28:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1291657 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49P1l33bxpz9sTH for ; Sat, 16 May 2020 07:29:35 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728058AbgEOV3b (ORCPT ); Fri, 15 May 2020 17:29:31 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:44667 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727942AbgEOV3H (ORCPT ); Fri, 15 May 2020 17:29:07 -0400 Received: by mail-pg1-f193.google.com with SMTP id b8so1587153pgi.11; Fri, 15 May 2020 14:29:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7iSHfXW9+fvDe3OMezoTpoZ6yc3BiswtzUTGtFdEoqM=; b=CWT3RSEsOAt3vxph1Drkp6lLCexue3b3KvLCldOnH8ALvAN+vG7ea8ubR3spND7fNJ jrosDF++LVePslD+xaXTT04Dr31BRgvteWo/uCtQqi4oif794PROe+fklD8OUKEqX4pA QG4wWoSauN0emeuSxha6yT8ugiYfMnV346cti0anyZR8Z/mDDmIpCO2Thvyp22N+lQeZ kTbgXNu6dlOitrhfpKl5z4QKE5wWxYyiNBtWDp59hDGh2rzVZMNfsCSsQxtPbismgFxD zuok7sbso5ktvEQvVHjRzuSbyvpON5p/VgfmCj5Zs6lbISK6e1gFECdajf/sQCQVnJek 6KhQ== X-Gm-Message-State: AOAM5320EiO4ESDUt3yjDQX383A+SPvM1GZR0amfD/fawwVeiraWdgom 8naqhOEHuEOtYF2c0FbXQuk= X-Google-Smtp-Source: ABdhPJy8UUPC9xXHxB4FjCVxUaLsmMMiDQI0BvVJYF+PqZUF0tKyMG2HswF59FK0uEUmrA4F0O6+Ng== X-Received: by 2002:a62:7d91:: with SMTP id y139mr5770731pfc.172.1589578147283; Fri, 15 May 2020 14:29:07 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id 25sm2281115pjk.50.2020.05.15.14.28.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:29:04 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 6016742380; Fri, 15 May 2020 21:28:50 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts Subject: [PATCH v2 14/15] brcm80211: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:45 +0000 Message-Id: <20200515212846.1347-15-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: linux-wireless@vger.kernel.org Cc: brcm80211-dev-list.pdl@broadcom.com Cc: brcm80211-dev-list@cypress.com Cc: Arend van Spriel Cc: Franky Lin Cc: Hante Meuleman Cc: Chi-Hsien Lin Cc: Wright Feng Cc: Kalle Valo Cc: "Rafał Miłecki" Cc: Pieter-Paul Giesberts Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index c88655acc78c..d623f83568b3 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c @@ -1393,6 +1393,7 @@ void brcmf_fw_crashed(struct device *dev) struct brcmf_pub *drvr = bus_if->drvr; bphy_err(drvr, "Firmware has halted or crashed\n"); + module_firmware_crashed(); brcmf_dev_coredump(dev); From patchwork Fri May 15 21:28:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 1291655 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49P1kp6Ndxz9sTN for ; Sat, 16 May 2020 07:29:22 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728039AbgEOV3U (ORCPT ); Fri, 15 May 2020 17:29:20 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:38031 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727972AbgEOV3J (ORCPT ); Fri, 15 May 2020 17:29:09 -0400 Received: by mail-pf1-f193.google.com with SMTP id y25so1601914pfn.5; Fri, 15 May 2020 14:29:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wyaNKYj+csWx0v5/RRrrvPiG/GlOrf9rCpyGTc2gDv0=; b=PNU2WB7xGk4aeo9LqsRnFBNqh2ufNpsh3E2UmToKGNuzHfu5s+ztk+s6S6VUKmq0C/ iwuKhe46HL2A2VjsuMCiBG1UUq668ruWKtTYFkzSo6RRrX/zBJOPXhRKnsWG3B0dZ2hW bWS2BRDcZKdi0ogAgjbkHYrTzBOU4NRKRmSTPmsBmzjqEpdkwG3CiEBpgHGmHoGOpB6R 79oBGxLCemAvW7+V9HRYSkPx8A6zubaw+QyShr460zkG2LBJNAtE7VyZ2ppalO/b0PTK iMKzu8k478e+nghLjgvLqcZuQkCqBKzZEUEUe5QfMFc988OM7X2xv4dSblScsJRps6Fl 5B1A== X-Gm-Message-State: AOAM531hGbKW+WC3F5TKCbWmueDzmsXgOmOREtXk4XgjwqnH/lMZEyw5 Y6Oh5B+/fqtxcGWbDJ81iE4= X-Google-Smtp-Source: ABdhPJzT8OuJIcMz4maB705Q5rp4ih5zCp5ALUBnEyTPR7+PH8X96oQqmCWUmGTpOQxsyRkd6WhDeA== X-Received: by 2002:aa7:8a92:: with SMTP id a18mr5990105pfc.0.1589578148396; Fri, 15 May 2020 14:29:08 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id 19sm2216513pjl.52.2020.05.15.14.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 14:29:04 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 7975D4238B; Fri, 15 May 2020 21:28:50 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , linux-wireless@vger.kernel.org, Lennert Buytenhek , "Gustavo A. R. Silva" , Johannes Berg , Ganapathi Bhat Subject: [PATCH v2 15/15] mwl8k: use new module_firmware_crashed() Date: Fri, 15 May 2020 21:28:46 +0000 Message-Id: <20200515212846.1347-16-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200515212846.1347-1-mcgrof@kernel.org> References: <20200515212846.1347-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: linux-wireless@vger.kernel.org Cc: Lennert Buytenhek Cc: Kalle Valo Cc: "Gustavo A. R. Silva" Cc: Johannes Berg Cc: Ganapathi Bhat Signed-off-by: Luis Chamberlain Acked-by: Rafael Aquini --- drivers/net/wireless/marvell/mwl8k.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/marvell/mwl8k.c b/drivers/net/wireless/marvell/mwl8k.c index 97f23f93f6e7..d609ef1bb879 100644 --- a/drivers/net/wireless/marvell/mwl8k.c +++ b/drivers/net/wireless/marvell/mwl8k.c @@ -1551,6 +1551,7 @@ static int mwl8k_tx_wait_empty(struct ieee80211_hw *hw) * the firmware has crashed */ if (priv->hw_restart_in_progress) { + module_firmware_crashed(); if (priv->hw_restart_owner == current) return 0; else