From patchwork Fri Dec 8 14:11:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 846255 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qf3PwTh0"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ytZ6N3Cf1z9s71 for ; Sat, 9 Dec 2017 01:11:56 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753619AbdLHOLx (ORCPT ); Fri, 8 Dec 2017 09:11:53 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:43219 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753525AbdLHOLw (ORCPT ); Fri, 8 Dec 2017 09:11:52 -0500 Received: by mail-qt0-f195.google.com with SMTP id w10so26153214qtb.10 for ; Fri, 08 Dec 2017 06:11:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=AbnFPBjhCshNy6LCs6x+h2g8MUaqoY3F3PpaHukEq6E=; b=qf3PwTh0aD5xb3PXaP2gtPj+teEDzWQWfqWM7pYPfAJvfOSbSECp83Y9TtVfSYO2Wm jtLlx5LlINyI8HCayn/2hrpwfXWwojYlPkXNAFF0pQcmg0pUS4pYhiB6hu1y13QrYIPP 4xdB6/44flUdHhSlBIOiIwkrf0gkxGsxXKEYJCf6Xq1TbjfWUCdamSN90AtJDldHAsCf cl4Hop7Ic1YwYyvggBxADcpLU7AfgHljOtywX96dEM8VQDqnEDgH3mXR83Bu929C28aK 90WWh7QuoZGFyu7TRjp4+wqDi1XhIT7mLS5c0XfyAPA1W7tpN7gwClnmzAUekZTfA1Ua 1z+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AbnFPBjhCshNy6LCs6x+h2g8MUaqoY3F3PpaHukEq6E=; b=stW5Pq3HqbH4D+fn7PBeSlhQkYQfh5YDdBSPF5FWtK4kLLxl2TGjGHXoII4Wh2M0rh reGkpYvjelF20vkDGzOrHqEt4Ht72V78V3FbwvXpgoveOEyXSasoqXaGorWecxhXYtiq ec43I+dpvB4/3qgyABjJfxFd/jyg3WoV3koKxX/xDLoP5TW+q5CupcTeVyfpGm8TAOAU kG1MHZmenUY2K3OmwyuQB+FIyFb+/d3V9PmK9LfBu+5nJlTRdLpyR+eUosg4ijKN7r32 pZ0K565sOlRt6cZYIVRRjxwCWjj6MRF9AmiH0Q5AiUa6V/SQPeJSnFDaTZgizxxkydpC YQgQ== X-Gm-Message-State: AKGB3mLzWxu7kpzu0SDszB3ekq8l2Dy2kdx4AXIY3BtD571Nd8r8PLs8 IP3bBvNh9b3/McOUHNQ7rUdu778E X-Google-Smtp-Source: AGs4zMZn6aDDM8N9NRCLs2gVlYxKOz42BRcj4dmTX7Zx9WHoE2BMEPcGowA5pvnOUBcDODxBoOzRqw== X-Received: by 10.55.17.140 with SMTP id 12mr35770487qkr.229.1512742311631; Fri, 08 Dec 2017 06:11:51 -0800 (PST) Received: from localhost.localdomain ([2804:14c:482:9a7:10ec:64a:6d7b:f71a]) by smtp.gmail.com with ESMTPSA id a72sm34926qkc.60.2017.12.08.06.11.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 08 Dec 2017 06:11:51 -0800 (PST) From: Fabio Estevam To: davem@davemloft.net Cc: fugang.duan@nxp.com, robh+dt@kernel.org, netdev@vger.kernel.org, Fabio Estevam Subject: [PATCH] dt-bindings: fec: Make the phy-reset-gpio polarity explicit Date: Fri, 8 Dec 2017 12:11:33 -0200 Message-Id: <1512742293-14572-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Fabio Estevam The GPIO polarity passed to phy-reset-gpio is ignored by the FEC driver and it is assumed to be active low. It can be active high only when the 'phy-reset-active-high' property is present. The current examples pass active high polarity and work fine, but in order to improve the documentation make it explicit what the real polarity is. Signed-off-by: Fabio Estevam Acked-by: Fugang Duan --- Documentation/devicetree/bindings/net/fsl-fec.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt index f0dc944..2d41fb9 100644 --- a/Documentation/devicetree/bindings/net/fsl-fec.txt +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt @@ -59,7 +59,7 @@ ethernet@83fec000 { reg = <0x83fec000 0x4000>; interrupts = <87>; phy-mode = "mii"; - phy-reset-gpios = <&gpio2 14 0>; /* GPIO2_14 */ + phy-reset-gpios = <&gpio2 14 GPIO_ACTIVE_LOW>; /* GPIO2_14 */ local-mac-address = [00 04 9F 01 1B B9]; phy-supply = <®_fec_supply>; }; @@ -71,7 +71,7 @@ ethernet@83fec000 { reg = <0x83fec000 0x4000>; interrupts = <87>; phy-mode = "mii"; - phy-reset-gpios = <&gpio2 14 0>; /* GPIO2_14 */ + phy-reset-gpios = <&gpio2 14 GPIO_ACTIVE_LOW>; /* GPIO2_14 */ local-mac-address = [00 04 9F 01 1B B9]; phy-supply = <®_fec_supply>; phy-handle = <ðphy>;