From patchwork Wed Sep 6 10:06:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaud Charlet X-Patchwork-Id: 810491 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-461577-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="Q6JoOC0O"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xnK430dX8z9sBd for ; Wed, 6 Sep 2017 20:06:26 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=Zo20u0CwTBmdeG4F0hsbJfOskupuHt4B5sSF/w9JvITH6tfCbD jyq2PwrFyCnKgw83GiCGWjPJeK+4t5/HfoXn85W6rkwREwWmQ4/ytfeOHRiHbisq WFAdS8OxaJEdTyyKa75NZxE0i4SfpAmk/nVY9rpl4VxPmGJ7S9MN1i2yk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=M13zkd0zenKJweJNTWOAbM01R1I=; b=Q6JoOC0OY4NtwdwSbOyk AV44CmNUFthIe3DfwoJ+m/cupOPDpnfjNQd0KqBPOR1WF1AGWWPbHoPfNrBtUB5d /XlLfkn4Me6jkyBWkDUT3Yu4ibfzAsy8s94qqFI1qgP9QYUFA+O9AJQPG/3aOy4J lvbKp8qu/1jamzBa8bC/Su0= Received: (qmail 56862 invoked by alias); 6 Sep 2017 10:06:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 56851 invoked by uid 89); 6 Sep 2017 10:06:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Sep 2017 10:06:12 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8519756141; Wed, 6 Sep 2017 06:06:11 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id I8nngdcJrvLT; Wed, 6 Sep 2017 06:06:11 -0400 (EDT) Received: from tron.gnat.com (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) by rock.gnat.com (Postfix) with ESMTP id 7591D5606C; Wed, 6 Sep 2017 06:06:11 -0400 (EDT) Received: by tron.gnat.com (Postfix, from userid 4192) id 71B3D4FC; Wed, 6 Sep 2017 06:06:11 -0400 (EDT) Date: Wed, 6 Sep 2017 06:06:11 -0400 From: Arnaud Charlet To: gcc-patches@gcc.gnu.org Cc: Ed Schonberg Subject: [Ada] Crash on generic subprogram with aspect No_Return. Message-ID: <20170906100611.GA30595@adacore.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) This patch fixes a compiler abort on a generic unit to which the aspect No_Return applies. Tested in ACATS 4.1D C651002. Tested on x86_64-pc-linux-gnu, committed on trunk 2017-09-06 Ed Schonberg * freeze.adb (Freeze_Entity): Do not generate a freeze node for a generic unit, even if it includes delayed aspect specifications. Freeze nodes for generic entities must never appear in the tree that reaches the back-end of the compiler. Index: freeze.adb =================================================================== --- freeze.adb (revision 251765) +++ freeze.adb (working copy) @@ -5489,6 +5489,13 @@ then Explode_Initialization_Compound_Statement (E); end if; + + -- Do not generate a freeze node for a generic unit. + + if Is_Generic_Unit (E) then + Result := No_List; + goto Leave; + end if; end if; -- Case of a type or subtype being frozen