From patchwork Wed Apr 29 08:23:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 1279091 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49Bs3p46Czz9sSM for ; Wed, 29 Apr 2020 18:23:48 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E66783951C87; Wed, 29 Apr 2020 08:23:45 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 9AF0F3939C1E for ; Wed, 29 Apr 2020 08:23:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9AF0F3939C1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Thomas_Schwinge@mentor.com IronPort-SDR: vBnSROq9l97o7sHHcW5/o2FpBtLXzbyBdmc+E6soua1d2alPW2TYkeSAPJSBkDpqI/AxpFOKBN FIYSz/WkrJOWne2cc3t6DnLe2fuskrziwAOMDCkaUpWA8hZpSg2dZuqm1sWBMJ+cTHf0DDH2u+ UOYKZeG03us+DcU4RgAIRKpKQ5J4EruPIbN/7Ij9Yd4k+16HOI2vYrWacLLj6uTXYnyebIWWcg AyJfu1tIYNlnHy0/udNnFppvYRMTyxASh6OWuyBHMUIKBA0cA+CkejfJRCUXD2OIG806jxsWMc AgA= X-IronPort-AV: E=Sophos;i="5.73,330,1583222400"; d="scan'208,223";a="50349068" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 29 Apr 2020 00:23:33 -0800 IronPort-SDR: 0mEWpjdSpfLazZat78tR0KgX3RV7jJuDiwxH1DVL8hPpthfQNbD5dgzHPBe6ooe3ngtIVPIB0B 7Qtr6SwSNz1XXpiU07+r3y2zADh3J1vvQG9+CRbrJ19zguDjUXTiKPqAzW4DEebvriIwOlL/EI +aP/15hAS3xtAUL/fe6qqRJWhkZoLr7WKLjr4ntacWQzQbmFNXAatgWWoBGt/9pUYwiTz2bFAD r3RyM4bGnRPJvEOAbU7lQKSe1k8X00NZDvjrOtzImf5zUxtlwYVPGpc81tQVXpvW3gvXD4YdSm Qf0= From: Thomas Schwinge To: Andrew Stubbs , , Julian Brown Subject: [gcn] Don't default to building target-libstdc++-v3 [PR92713] (was: [PATCH v3 06/10] GCN back-end config) In-Reply-To: References: User-Agent: Notmuch/0.29.1+93~g67ed7df (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Wed, 29 Apr 2020 10:23:24 +0200 Message-ID: <87tv12bszn.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 X-Spam-Status: No, score=-20.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_LOTSOFHASH, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Hi! On 2018-12-12T11:52:53+0000, Andrew Stubbs wrote: > This patch contains the configuration adjustments needed to enable the GCN > back-end. In addition to default-enabling libgomp, which Tobias already pushed to master branch in commit 29b1533acd5c57e3e327261b0054d0ee2858a166 "configure - build libgomp by default for amdgcn", , I've now, as obvious, pushed to master branch in commit afa3d80e86fb538ce7f5f1485fa774c11fdaf0f6 "[gcn] Don't default to building target-libstdc++-v3 [PR92713]", see attached. That way, a (standard) GCC '--enable-languages=[...]' configuration including 'c++' now "works" (... to the extent expected without libstdc++). Grüße Thomas ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter From afa3d80e86fb538ce7f5f1485fa774c11fdaf0f6 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Sat, 21 Mar 2020 11:46:02 +0100 Subject: [PATCH] [gcn] Don't default to building target-libstdc++-v3 [PR92713] ... which hasn't been ported/fails to build when using newlib (with GCC commit b73f69020f08208d2d969fcf8879bd294a6e3596 sources, and newlib commit 6d79e0a58866548f435527798fbd4a6849d05bc7, tag: newlib-3.3.0 sources): In file included from [...]/build-gcc-offload-amdgcn-amdhsa/amdgcn-amdhsa/libstdc++-v3/include/csetjmp:42, from [...]/source-gcc/libstdc++-v3/include/precompiled/stdc++.h:42: [...]/source-gcc/newlib/libc/include/setjmp.h:15:6: error: variable or field 'longjmp' declared void 15 | void longjmp (jmp_buf __jmpb, int __retval) | ^~~~~~~ [...] Makefile:1824: recipe for target 'amdgcn-amdhsa/bits/stdc++.h.gch/O2ggnu++0x.gch' failed make[3]: *** [amdgcn-amdhsa/bits/stdc++.h.gch/O2ggnu++0x.gch] Error 1 PR target/92713 * configure.ac ["${ENABLE_LIBSTDCXX}" = "default" && amdgcn*-*-*] (noconfigdirs): Add 'target-libstdc++-v3'. * configure: Regenerate. --- ChangeLog | 7 +++++++ configure | 4 ++++ configure.ac | 4 ++++ 3 files changed, 15 insertions(+) diff --git a/ChangeLog b/ChangeLog index 3b667b18f9f1..a7fcf77b9b26 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2020-04-29 Thomas Schwinge + + PR target/92713 + * configure.ac ["${ENABLE_LIBSTDCXX}" = "default" && amdgcn*-*-*] + (noconfigdirs): Add 'target-libstdc++-v3'. + * configure: Regenerate. + 2020-04-21 Stephen Casner PR 25830 diff --git a/configure b/configure index 815069c9856d..4cc938ebb7d8 100755 --- a/configure +++ b/configure @@ -3387,6 +3387,10 @@ if test "${ENABLE_LIBSTDCXX}" = "default" ; then # VxWorks uses the Dinkumware C++ library. noconfigdirs="$noconfigdirs target-libstdc++-v3" ;; + amdgcn*-*-*) + # Not ported/fails to build when using newlib. + noconfigdirs="$noconfigdirs target-libstdc++-v3" + ;; arm*-wince-pe*) # the C++ libraries don't build on top of CE's C libraries noconfigdirs="$noconfigdirs target-libstdc++-v3" diff --git a/configure.ac b/configure.ac index b95532cae90f..c78d9cbea62d 100644 --- a/configure.ac +++ b/configure.ac @@ -668,6 +668,10 @@ if test "${ENABLE_LIBSTDCXX}" = "default" ; then # VxWorks uses the Dinkumware C++ library. noconfigdirs="$noconfigdirs target-libstdc++-v3" ;; + amdgcn*-*-*) + # Not ported/fails to build when using newlib. + noconfigdirs="$noconfigdirs target-libstdc++-v3" + ;; arm*-wince-pe*) # the C++ libraries don't build on top of CE's C libraries noconfigdirs="$noconfigdirs target-libstdc++-v3" -- 2.26.2