From patchwork Thu Apr 9 08:28:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madhuparna Bhowmik X-Patchwork-Id: 1268534 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=VrAgMiav; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48yZ6l2gpKz9sSk for ; Thu, 9 Apr 2020 18:28:47 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726595AbgDII2n (ORCPT ); Thu, 9 Apr 2020 04:28:43 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:33057 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbgDII2n (ORCPT ); Thu, 9 Apr 2020 04:28:43 -0400 Received: by mail-pl1-f194.google.com with SMTP id ay1so3603284plb.0; Thu, 09 Apr 2020 01:28:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=+fG/Gev7HaxlZXPpDg5ZggbcqVNpIERCkV8tz6C91rI=; b=VrAgMiavqperU/qmbs/nYjs3R21Z28HnwtwMqUnz+kDRaWK1/ZgKpBoHUtv5W1KCFZ bxslrV0uDn0OCQeOo3WZ5AJUYGxXqQ695kC9UHyoy7gG1XspSihCx+CU89l6wPOp6V5y hG+eMGGzgOuXBePYk7ka5BB+R9mdIcab0K+N7UEN15opjjWlE9NlBFzQuTKI/KH/Q/fA ncXvjCpHv2RMY0sUgIwoIwdP52Vt7INaIGjY7NG+KiKG2CUqb408W/RlxvB1PtQ/XfIj qDzBcNS1EyfWfqV8yTUdHDLHOkGJnRiUSOfHBdwnSn1avhWyQL3LV14rk7VVZ2vUcDhZ ZZVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+fG/Gev7HaxlZXPpDg5ZggbcqVNpIERCkV8tz6C91rI=; b=tUerkIQH8fZIiTRSv9tNj6qyFCXhcrmuH8oMAWrdJN3UwH8UYAucsQCY5Ll99dV0vk Qk/4l7WhlrxrDsIuWO25sWNmhbIzetqiGB3tXxkx+uYUTh9G/mcoXHZjP05HZg5/nNr1 //UyD93AAGUj1yQVWlk9/37PTCVkZ/86ReDkNsa6VPtjDNRSctGcF7P1dWjD4QLAnSHD 5nCXrepA6hmWsfE9/mgmAQUknQ7ZxaSc7UZ5qZYsCqF4aRFKMcmpGJsksZzjcoWqwa0C oFr46ZPIsw9EIiIiHP6ZIrAisubbultAJZlWANBzl3HFD/sYOczaXykkEzfiLANS86nm IzUA== X-Gm-Message-State: AGi0PuYioGT1f7dsSz/Yp9XyUz15T13MOsa3BTQ3TsCkZgWtA3BM8VBm iON+rWEl3m/E1SJSujxnmQ== X-Google-Smtp-Source: APiQypJLoXasAxeWqbcLrxY25TSunFHpWMUBhjAxPsjLnDLzDMGnFUlBC1/m+GQba0kNmUo48yAUvg== X-Received: by 2002:a17:90a:8c18:: with SMTP id a24mr10599111pjo.43.1586420922983; Thu, 09 Apr 2020 01:28:42 -0700 (PDT) Received: from localhost.localdomain ([2402:3a80:13be:8fdf:25a2:66e2:761f:9d4c]) by smtp.gmail.com with ESMTPSA id r189sm17762095pgr.31.2020.04.09.01.28.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 01:28:42 -0700 (PDT) From: madhuparnabhowmik10@gmail.com To: johannes@sipsolutions.net, davem@davemloft.net, kuba@kernel.org Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, frextrite@gmail.com, joel@joelfernandes.org, paulmck@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Madhuparna Bhowmik Subject: [PATCH 1/4] net: mac80211: util.c: Fix RCU list usage warnings Date: Thu, 9 Apr 2020 13:58:22 +0530 Message-Id: <20200409082822.27314-1-madhuparnabhowmik10@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Madhuparna Bhowmik This patch fixes the following warning (CONIG_PROVE_RCU_LIST) in ieee80211_check_combinations(). WARNING: suspicious RCU usage [ 80.933723] 5.6.0+ #4 Not tainted [ 80.933733] ----------------------------- [ 80.933746] net/mac80211/util.c:3934 RCU-list traversed in non-reader section!! Also, fix the other uses of list_for_each_entry_rcu() by either using list_for_each_entry() instead (When mutex or spinlock is always held in the function) or pass the necessary lockdep condition. Signed-off-by: Madhuparna Bhowmik --- net/mac80211/util.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/net/mac80211/util.c b/net/mac80211/util.c index 20436c86b9bf..f4b0434024c0 100644 --- a/net/mac80211/util.c +++ b/net/mac80211/util.c @@ -254,7 +254,7 @@ static void __ieee80211_wake_txqs(struct ieee80211_sub_if_data *sdata, int ac) sdata->vif.txqs_stopped[ac] = false; - list_for_each_entry_rcu(sta, &local->sta_list, list) { + list_for_each_entry(sta, &local->sta_list, list) { if (sdata != sta->sdata) continue; @@ -719,7 +719,8 @@ static void __iterate_interfaces(struct ieee80211_local *local, struct ieee80211_sub_if_data *sdata; bool active_only = iter_flags & IEEE80211_IFACE_ITER_ACTIVE; - list_for_each_entry_rcu(sdata, &local->interfaces, list) { + list_for_each_entry_rcu(sdata, &local->interfaces, list, + (lockdep_is_held(&local->iflist_mtx)|| lockdep_rtnl_is_held())) { switch (sdata->vif.type) { case NL80211_IFTYPE_MONITOR: if (!(sdata->u.mntr.flags & MONITOR_FLAG_ACTIVE)) @@ -3931,7 +3932,7 @@ int ieee80211_check_combinations(struct ieee80211_sub_if_data *sdata, params.num_different_channels++; } - list_for_each_entry_rcu(sdata_iter, &local->interfaces, list) { + list_for_each_entry(sdata_iter, &local->interfaces, list) { struct wireless_dev *wdev_iter; wdev_iter = &sdata_iter->wdev; @@ -3982,7 +3983,7 @@ int ieee80211_max_num_channels(struct ieee80211_local *local) ieee80211_chanctx_radar_detect(local, ctx); } - list_for_each_entry_rcu(sdata, &local->interfaces, list) + list_for_each_entry(sdata, &local->interfaces, list) params.iftype_num[sdata->wdev.iftype]++; err = cfg80211_iter_combinations(local->hw.wiphy, ¶ms, From patchwork Thu Apr 9 08:28:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madhuparna Bhowmik X-Patchwork-Id: 1268535 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=MUEXAxyo; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48yZ744tbhz9sPF for ; Thu, 9 Apr 2020 18:29:04 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726681AbgDII3A (ORCPT ); Thu, 9 Apr 2020 04:29:00 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:36121 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726663AbgDII3A (ORCPT ); Thu, 9 Apr 2020 04:29:00 -0400 Received: by mail-pf1-f194.google.com with SMTP id n10so3808307pff.3; Thu, 09 Apr 2020 01:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=0HXV8vx9Be0BBihyhMob71nh1LkIaEr5epGWg9GzRAU=; b=MUEXAxyoTdSoolqIbRRVACRTGku/CrRdwrnfri3FU7m1CGWxvVxECyJzNjlzoqEsKx 3F4wPoUnPw9Kuzp/PVK1EZi9PKkRunyMAcxg9R/YOyGp5tIrKrpjXWEUrlpLOJOWBzUD obPKIv5NLJclwMiHJMYvdi7BAiqeOxWl8X/mhTECRPJ9/Eld7HjSPlVuifZme/saoNlL r7USy8sMvD85yB/97jF8qGDDQ2P63+yhXJqbcB5PJrASY94EGnAi3CmWe/DK9SxyfXu3 3EUfwTX31XHnMhbzoahy0Jh91k/5CiQiM9jr7e97x7EuVBBI/A0B6jKgznf21CII8MWK pJ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=0HXV8vx9Be0BBihyhMob71nh1LkIaEr5epGWg9GzRAU=; b=GGAF0G0KBZSdBn9vB6CdBJkZTzgEUzkWAxNLCJyn9v9AK0n0yfpMJZL3tyonJadkrS /0WXo/hQzA97oVstCVoDweRjrYgu7AMYbC14+7c8xH42J9np48swbEBMwPMD1yM5CgyA RsuGYw69xTocHkjl2jxakGEo6c5Ei7/Zehk2QhOjlxhUiQA60yS5kNYU37KyEymfdcVz gOpwk8BeMx4Zec4s8eLW5uolNfEKwTadAqrwTClKCevgqcI1igV802QeZBta5q+mwG5N QC6+8VZWsLkxL7yeHC4q2gMXfbZFEC2yPwsdtqPiyLW8fGzET9EReA2LOltbtiifB3k/ M9/Q== X-Gm-Message-State: AGi0PuZ9i4kXGn5z20vtYaNGMM4fl41XQ7LyxBgr8mW1hCutRoMDwJoo 1x9xQSIy+/C1Fu3woSfNyA== X-Google-Smtp-Source: APiQypJMUo7McfIjWzcXnjJmz+8h35KmF64lZDJ+qnUEu0I5lgVqNGuknsQBsn/cgMScS/uFl60oLQ== X-Received: by 2002:a63:e56:: with SMTP id 22mr10914839pgo.173.1586420939939; Thu, 09 Apr 2020 01:28:59 -0700 (PDT) Received: from localhost.localdomain ([2402:3a80:13be:8fdf:25a2:66e2:761f:9d4c]) by smtp.gmail.com with ESMTPSA id h10sm17615674pgf.23.2020.04.09.01.28.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 01:28:59 -0700 (PDT) From: madhuparnabhowmik10@gmail.com To: johannes@sipsolutions.net, davem@davemloft.net, kuba@kernel.org Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, frextrite@gmail.com, joel@joelfernandes.org, paulmck@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Madhuparna Bhowmik Subject: [PATCH 2/4] net: mac80211: scan.c: Fix RCU list related warnings. Date: Thu, 9 Apr 2020 13:58:49 +0530 Message-Id: <20200409082849.27372-1-madhuparnabhowmik10@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Madhuparna Bhowmik This patch fixes the following warning: WARNING: suspicious RCU usage [ 84.530619] 5.6.0+ #4 Not tainted [ 84.530637] ----------------------------- [ 84.530658] net/mac80211/scan.c:454 RCU-list traversed in non-reader section!! As local->mtx is held in __ieee80211_scan_completed(), no need to use list_for_each_entry_rcu() (use list_for_each_entry() instead.). Signed-off-by: Madhuparna Bhowmik --- net/mac80211/scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/scan.c b/net/mac80211/scan.c index fdac8192a519..0860f028ab2a 100644 --- a/net/mac80211/scan.c +++ b/net/mac80211/scan.c @@ -451,7 +451,7 @@ static void __ieee80211_scan_completed(struct ieee80211_hw *hw, bool aborted) * the scan was in progress; if there was none this will * just be a no-op for the particular interface. */ - list_for_each_entry_rcu(sdata, &local->interfaces, list) { + list_for_each_entry(sdata, &local->interfaces, list) { if (ieee80211_sdata_running(sdata)) ieee80211_queue_work(&sdata->local->hw, &sdata->work); } From patchwork Thu Apr 9 08:29:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madhuparna Bhowmik X-Patchwork-Id: 1268536 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=IP2q/UIm; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48yZ7Q10myz9sPF for ; Thu, 9 Apr 2020 18:29:22 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726708AbgDII3S (ORCPT ); Thu, 9 Apr 2020 04:29:18 -0400 Received: from mail-pj1-f68.google.com ([209.85.216.68]:38508 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726574AbgDII3S (ORCPT ); Thu, 9 Apr 2020 04:29:18 -0400 Received: by mail-pj1-f68.google.com with SMTP id t40so983874pjb.3; Thu, 09 Apr 2020 01:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=thmb2MaUkAYwWEknYChKiLfRBjC26khbulpjo27xBxY=; b=IP2q/UImPra//LmWIBAZ+IhOWsM8OCnVf+xQw5pG52z6SrmJwJZiaotOEUZ8mKGafH uzuNLilzjhYGUngIrdbMtEFbnAMI5dzle15sBBfWVQLPnlZn8ICMi0nGPtxcgryAU75K oJKLxnMkTlRRsSxqbN3DvJTcobEuHgJ240erVvAm5BiwUBXWPy11Z0O2woJ48cNcEcta NaACUYq+4l4lmMcNDkrNCL6HCUdEFSfdNktjmi67pZVW4zegjXoF9saAgQONuQ4suwk0 4ZbpKYRFCQ1M0gznRBve4tjKLwuAN9ht2kvRhNe5qrERFD+o+R/VPYm+qFLnaDGPvmY9 tZCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=thmb2MaUkAYwWEknYChKiLfRBjC26khbulpjo27xBxY=; b=UTgBrWQRfxSdDWfqFXl2F+hpmnZX9jkpgIwNnrmxsftIOjfk6mTdlK5XgXxvbF/96B XpFtXodhDxcctrpkoYrpfgY39AxUHDx45TAYd1A0WjDBcmo+JTdSdd8gsJZPMWG7H2rO tMqF/sFZdgr6rAIh9RVVNDqKupxJUc9M4PVMjCtljmOO3I8o7Gq3D9TRYgOhSpePu+p7 E3GsWNDrwJp9W+k6OSrTs+BF+fr1cTSJDlo//nZg+IzlahaA0nT/LYAoEzCcUWQlIxlQ sJtsbZeltTGxKyDzhK0wWdFMfN3rAIMqUItrA61mTktBR/jk1pvBinIZIn/mTxwFYOLZ ok7A== X-Gm-Message-State: AGi0PuasciH3m3o6jy5/I5Giw/SGUHY5aYgF7KRyWubixEZQfR5NeBnc 2ZSR7mf/aZ4UJjJtTq3hXA== X-Google-Smtp-Source: APiQypL1Nj1lCDjuCVFwMYpqxk0cEfBJHr8sL+RJosyfsPsRH8j2Im1XHq+VTTkIBFpCE2s7AqCWKQ== X-Received: by 2002:a17:902:aa84:: with SMTP id d4mr11298193plr.158.1586420957884; Thu, 09 Apr 2020 01:29:17 -0700 (PDT) Received: from localhost.localdomain ([2402:3a80:13be:8fdf:25a2:66e2:761f:9d4c]) by smtp.gmail.com with ESMTPSA id o128sm18390653pfb.58.2020.04.09.01.29.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 01:29:17 -0700 (PDT) From: madhuparnabhowmik10@gmail.com To: johannes@sipsolutions.net, davem@davemloft.net, kuba@kernel.org Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, frextrite@gmail.com, joel@joelfernandes.org, paulmck@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Madhuparna Bhowmik Subject: [PATCH 3/4] net: mac80211: sta_info.c: Add lockdep condition for RCU list usage Date: Thu, 9 Apr 2020 13:59:06 +0530 Message-Id: <20200409082906.27427-1-madhuparnabhowmik10@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Madhuparna Bhowmik The function sta_info_get_by_idx() uses RCU list primitive. It is called with local->sta_mtx held from mac80211/cfg.c. Add lockdep expression to avoid any false positive RCU list warnings. Signed-off-by: Madhuparna Bhowmik --- net/mac80211/sta_info.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c index f8d5c2515829..cd8487bc6fc2 100644 --- a/net/mac80211/sta_info.c +++ b/net/mac80211/sta_info.c @@ -231,7 +231,8 @@ struct sta_info *sta_info_get_by_idx(struct ieee80211_sub_if_data *sdata, struct sta_info *sta; int i = 0; - list_for_each_entry_rcu(sta, &local->sta_list, list) { + list_for_each_entry_rcu(sta, &local->sta_list, list, + lockdep_is_held(&local->sta_mtx)) { if (sdata != sta->sdata) continue; if (i < idx) { From patchwork Thu Apr 9 08:29:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Madhuparna Bhowmik X-Patchwork-Id: 1268537 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=UeBYraYa; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48yZ7m01p1z9sPF for ; Thu, 9 Apr 2020 18:29:39 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726755AbgDII3g (ORCPT ); Thu, 9 Apr 2020 04:29:36 -0400 Received: from mail-pj1-f66.google.com ([209.85.216.66]:50689 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725987AbgDII3g (ORCPT ); Thu, 9 Apr 2020 04:29:36 -0400 Received: by mail-pj1-f66.google.com with SMTP id b7so1010658pju.0; Thu, 09 Apr 2020 01:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=F8gyLVop1Ch0gKbGVHgodmcnCvN85X6SPXoRalm/4uY=; b=UeBYraYaZuRxL0liXfpT3eVN66/M7EoV5rBCI8IzWjSmRtb+2fS8VCoKQMRNiiNNPI GQtwO3Bb29klU3jizxQRTERoAEXMyuzs1GZ8SHeaPbBLrD4BxH76imlRAO696yJeT/r2 qBIrWD7A+ldxeRNDjELWGTGbyz2IHckScRapPjH+TRr2QELy92KzJehjWMqTb4aTYhtu 6onqsCgA3u6/XIdsuxQIbr6F331I1soaJ+j5c4fo43C9LhUUj+dNReGxEjJfbh6LKXa4 3cGcDbF00vMoIY6Givp1/PKfafreL5o5/vA6obHT0zDpScse921LkE8zqJb/dXCvp59B Osyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=F8gyLVop1Ch0gKbGVHgodmcnCvN85X6SPXoRalm/4uY=; b=k17Lh734EagITwH2O1h0HwNIvTKwyC4IDOPoItgtq6/LC3tKWetqM3mERr3kHBNUIP Lb6sNN0+wNJF80lOnTeRK/J+CGnZEMl4+TGgHNmcwzRFIzLmlnCqLHg1oYEady3e/muJ KFZxuXHqzSABSXB/j+3l1qxc/bMX3Xt3UuOd9/WPZ24wKeF0JrqcO3qwmnAGc/nfV7y4 pIkNeshxTEFwUu73SPZDsxHm1/rRFZx2XnhXoiN0nJMH6+AuQ4ooWq2599wJT6Sx5RgF 8V3utfuloprOuF3l0d3v19NJTqRacXcGzOC5Vb77b29ZVLoa3UKBFM562jT5b927Jmm6 SJZQ== X-Gm-Message-State: AGi0Pub/xSeM6tE5n8vNNK0pN5rASRyr29rNZi3qhlxog96WsdgUlItY rPDj40s8/4jshS5GAdnchw== X-Google-Smtp-Source: APiQypJOJq7j0sm89Vt3qi8RrEHe8B14IxsT3T/FfEhZcmU+VsnMmS2Hw8QCmcgk7K/Ke/8ZAy4FBQ== X-Received: by 2002:a17:90b:24f:: with SMTP id fz15mr9986110pjb.138.1586420975683; Thu, 09 Apr 2020 01:29:35 -0700 (PDT) Received: from localhost.localdomain ([2402:3a80:13be:8fdf:25a2:66e2:761f:9d4c]) by smtp.gmail.com with ESMTPSA id y19sm19170866pfe.9.2020.04.09.01.29.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 01:29:34 -0700 (PDT) From: madhuparnabhowmik10@gmail.com To: johannes@sipsolutions.net, davem@davemloft.net, kuba@kernel.org Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, frextrite@gmail.com, joel@joelfernandes.org, paulmck@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Madhuparna Bhowmik Subject: [PATCH 4/4] net: mac80211: mlme.c: Add lockdep condition for RCU list usage Date: Thu, 9 Apr 2020 13:59:25 +0530 Message-Id: <20200409082925.27481-1-madhuparnabhowmik10@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Madhuparna Bhowmik ieee80211_add_vht_ie() is called with sdata->wdev.mtx held from ieee80211_send_assoc(). Add lockdep condition to avoid false positive warnings. Signed-off-by: Madhuparna Bhowmik --- net/mac80211/mlme.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index 16d75da0996a..ef64b3e91ce6 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -590,7 +590,8 @@ static void ieee80211_add_vht_ie(struct ieee80211_sub_if_data *sdata, bool disable_mu_mimo = false; struct ieee80211_sub_if_data *other; - list_for_each_entry_rcu(other, &local->interfaces, list) { + list_for_each_entry_rcu(other, &local->interfaces, list, + lockdep_is_held(&sdata->wdev.mtx)) { if (other->vif.mu_mimo_owner) { disable_mu_mimo = true; break;