From patchwork Mon Apr 6 23:59:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1267117 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=qaDxtUL4; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48x6ww5t7wz9sQx for ; Tue, 7 Apr 2020 10:00:16 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id D446B88585; Tue, 7 Apr 2020 00:00:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gIcYmsIyxgRq; Tue, 7 Apr 2020 00:00:13 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 51BBB88534; Tue, 7 Apr 2020 00:00:13 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 37F4DC1AE2; Tue, 7 Apr 2020 00:00:13 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5C93DC0177 for ; Tue, 7 Apr 2020 00:00:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4BA87868B5 for ; Tue, 7 Apr 2020 00:00:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DMQCq8YOzbjw for ; Tue, 7 Apr 2020 00:00:11 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by fraxinus.osuosl.org (Postfix) with ESMTPS id E5ACC867ED for ; Tue, 7 Apr 2020 00:00:11 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id w3so528551plz.5 for ; Mon, 06 Apr 2020 17:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=pvKpot9BIJCaO/KbVM2d4AanG3adGed1xxFFhAP0e6o=; b=qaDxtUL4km3E5buWUlz+N6Sz4y7j4F6nvkDHV+Cie78co6EwMLpy7y5lK88WnnJqyO Oyo+C3pMWg+hFA69tYIqBnDgmpZKm9w3tmvtRiWTpstz/ETqZVhS25SBX8Ny6YNyxtmV mH0k1zrfTe6/h/U5Ace4x5c4IJV4cosmykQMGDYJBDHY31QMtToJNeL2L45l9wMKg743 hQwra41cD+nSmdjLR4WWbgvPf7powMVRxxKcqNRgDZoqwK2vgPMfMpqo63ukKxrKXAoN j9C0DgY7QMDx/NONj/n/BWYDzoXkHqUvJjsHW+ADxqN+T4jdNcVVlnqFo9uKw7+aMKL/ cDaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pvKpot9BIJCaO/KbVM2d4AanG3adGed1xxFFhAP0e6o=; b=F6au5Ap+et4q+Y8S7bbIu7KgwAU3wI9bV7acNi/nEVCBwjqh+6QVnWfJlfk5gJvKp/ 4hOd8h9bDi3YYEaBc9sXX2jcb5XIH2a/Ycf9D9uvEYGC72hSXP87+Kv8Hqh+he+1VbNe 9GAc/nCMpjnE5reGPrtI8XS6+Xf+j4UYPBTKml49OitNWaveXqmV+kspRXFUIWwrV3f+ I6TznWjxhKeyAIJjFCCQ8RIpW6Njb3BtISJQKQjjMd9uw0hE3ki9iuSmkhiVlsKkJvGw FMeok9OH5gUcDr/cA2Fb7dxkzkJPo86yRpdaISnNURbaq8On0QPHqDRE5mNEirG91lD7 xGGw== X-Gm-Message-State: AGi0PuaWmx5tddz3DxS279o3Wk9adUng+ZW8pCmfhhHyKxwPoH/0H8TV 7udIYGumgCwRTqrAmWvo70Ev4kzc X-Google-Smtp-Source: APiQypLMGqTRyqQ8ESLaIJzwD8amd5SMuCDg9tKcaIiK8sP9IeE2NwbqJsN8DZf4SDX8XZEHRgMB0Q== X-Received: by 2002:a17:90a:a014:: with SMTP id q20mr2017180pjp.91.1586217611210; Mon, 06 Apr 2020 17:00:11 -0700 (PDT) Received: from osboxes.localdomain (c-76-21-95-192.hsd1.ca.comcast.net. [76.21.95.192]) by smtp.gmail.com with ESMTPSA id c126sm12669690pfb.83.2020.04.06.17.00.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Apr 2020 17:00:10 -0700 (PDT) From: William Tu To: dev@openvswitch.org Date: Mon, 6 Apr 2020 16:59:01 -0700 Message-Id: <1586217541-31371-1-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 Subject: [ovs-dev] [PATCHv2] ovs-vswitchd: Fix icmp reply timeout description. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Currently the userspace datapath implements conntrack ICMP reply state as when ICMP packets have been seen on both directions. However, the description is defined as timeout of the connection after an ICMP error is replied in response to an ICMP packet. Fixes: 61a5264d60d0c ("ovs-vswitchd: Add Datapath, CT_Zone, and CT_Zone_Policy tables.") Signed-off-by: William Tu Acked-by: Greg Rose --- vswitchd/vswitch.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index f9339af85edd..6d334370d252 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -6137,9 +6137,9 @@ ovs-vsctl add-port br0 p0 -- set Interface p0 type=patch options:peer=p1 \ - The timeout of the connection after an ICMP error is replied in - response to an ICMP packet. This timeout is only supported by - the userspace datapath. + The timeout of the connection when ICMP packets have been seen in + both direction. This timeout is only supported by the userspace + datapath.