From patchwork Mon Dec 4 17:48:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 844345 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MkexBlKU"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yrC7y1VxJz9sPt for ; Tue, 5 Dec 2017 04:50:06 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752570AbdLDRsz (ORCPT ); Mon, 4 Dec 2017 12:48:55 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35727 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbdLDRso (ORCPT ); Mon, 4 Dec 2017 12:48:44 -0500 Received: by mail-pf0-f194.google.com with SMTP id j124so9072469pfc.2; Mon, 04 Dec 2017 09:48:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aUiBfAM1hQQ8wVvHa9tA+Vs3EHwhl2XhGngA2ge69Us=; b=MkexBlKUO/2Xp6rgsGaWE8bTBWXogAqxmiJONBqYtfcTAETRKnbUsC3fv2hnP01yIZ OSyOyPRzQCBl7h9A8MewTshx3Vzh2xaVb1bOGOOcrW9wiI4IACldAHRNsl/EdOovcJf5 YKdoO3jPyc5msZwZ38ylDIqOami7JDNCrwSOmiRlg3mbcwLFmN9grPlloLTCaY0Ogcfs gcL+uieCVLSyPYJxGLH4o8sZ+xFG4kGWv4AY2HOfrrorNDU0JwR5c9+YVM/RKkM1Ij4Q PhcRBVNNw8pnf7zxKzITbjkX3Sa1AUPArO0pIPlnRoUU4jArZEKrYJ+ETmApBGbV7uUN oJxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aUiBfAM1hQQ8wVvHa9tA+Vs3EHwhl2XhGngA2ge69Us=; b=gmmQyhN/ctgzUBWqTqpXTHYrDjnEhOngYMlnwhA3M/eXkBJjJj+1kgMV/I15lmlHGX xH8Pl6SWF8Fo/3fLBnOUoP1tRx4luBdbrDPmk/hRFWAzhplZw6LYpd38MwLjN7bO8z7W C4jT0jfDCOfFN5y9JJNwx7wYcZ/7hl4hcDF2GGu3xzL7uGrIsC9Nrr8pPiL1q1LhSZBf eK6ZEesD76RCBDbmTFxq66+JBE2RPZnme6DeQuyfcCPl9potyhMJIXnITOCQ7xTbAVXC k974VGqD+vIW/aVw6fI7NWm3Bt+MK4PW5lpyK+jUSvdDkelj28nZPmteZY2UBssIiyvO XJFQ== X-Gm-Message-State: AKGB3mJb0Bqon6ugvxz6mGCyKCZbSaGP/K2SkOaPdX1kRJUXv3nwShwS ta3ddBJ03dJCB2Iqib34tXw= X-Google-Smtp-Source: AGs4zMZosltycpSds08AlQgROos5aOR7XZdeAuMUy23v3XfadhJVUDz97gq3ntPPttig58WpQNXSaw== X-Received: by 10.84.131.41 with SMTP id 38mr993194pld.149.1512409724110; Mon, 04 Dec 2017 09:48:44 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.48.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:48:38 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 1/7 v2] net: bcmgenet: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:17 +0530 Message-Id: <1512409703-20881-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The platform_get_irq() function returns negative number if an error occurs, Zero if No irq is found and positive number if irq gets successful. platform_get_irq() error checking only for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2: commit message was not correct. drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 24b4f4c..e2f1268 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3371,7 +3371,7 @@ static int bcmgenet_probe(struct platform_device *pdev) priv->irq0 = platform_get_irq(pdev, 0); priv->irq1 = platform_get_irq(pdev, 1); priv->wol_irq = platform_get_irq(pdev, 2); - if (!priv->irq0 || !priv->irq1) { + if (priv->irq0 <= 0 || priv->irq1 <= 0 || priv->wol_irq <= 0) { dev_err(&pdev->dev, "can't find IRQs\n"); err = -EINVAL; goto err; From patchwork Mon Dec 4 17:48:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 844346 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ii0Cn5yr"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yrC8F1hGlz9t16 for ; Tue, 5 Dec 2017 04:50:21 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470AbdLDRsx (ORCPT ); Mon, 4 Dec 2017 12:48:53 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:38027 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752412AbdLDRss (ORCPT ); Mon, 4 Dec 2017 12:48:48 -0500 Received: by mail-pg0-f67.google.com with SMTP id f12so8701025pgo.5; Mon, 04 Dec 2017 09:48:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FQ0IJdlFZ/dw/FO2WR2T18XOEAtQnVWMzHfV07ZNNIc=; b=ii0Cn5yr3zSEk3sFmdJbnNIc1Jd08i8obMdxKr4lDWtEvjAaytF+wDloLh1rFXmH15 IQKu9z/lGAE7x2aQWYPztOAlebL0PxJBxslFAcKOBDhwLyCKuKG5vOecGD8B0UVJp/qT ruoUqOuvLAQNOlMtdc3+Dd2wDbK4CzQeFNwPfAhPDjKa2hbfxVYMCwZYrt3TXcroFRdv nFVhHqUwOhD0sVFCCUHdeYHHPwn7vg4nWj6tErL4uJkFzICouuFDcXB5Vne+b7+48GYN bMTPBy/TXOO4hI2HO09+RhBeLd9mvVD4vfKhCOUZhTYThT++C8U05hFoAV11FDudlQPf P3rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FQ0IJdlFZ/dw/FO2WR2T18XOEAtQnVWMzHfV07ZNNIc=; b=PoFCjSyiCjozXxRbq0SzjdvFldIrZ6nX8hojBYOVJinwmG39do0zTSPLvTwrnhhwou TjkWolB5bA7Jxnyqz1G0GZmwKGEH2dWfUfQhMLgzvYtKnYS5pAT8PCyiyNgwY2excrLM Wu3wuHol2K/DXmCiUVeljip1DuKINLr6Udh9sL4u3ynt1gEn6k7IRsEFn8elwn4IxIZy GZ3O1itEmvHppxzvQYpKpD+/aTwmekJ5OMERlogmlkaCjr0Sfj3vLaoZlONKuB/Y9hcQ welkueGDAXh99n/yuwGwdfegX9pYAFLIWAKRnlpr4H0rsBQHvpeVqFG6SFVtcrkdOYA8 63pQ== X-Gm-Message-State: AKGB3mIM62AY6JVh4EEP9tgd/zElIq8DJJHSQcrS3CHe3e/Zq+nEjm5O MwREexyDBWEKPIi7V1ZdtfCJOg== X-Google-Smtp-Source: AGs4zMbGIVc/UO6peVzmq586RdLKeaRvjSfZTLZdoNlXFGTEXFvIzDm1/RsEI453uWr93jEAlVrYRw== X-Received: by 10.159.244.149 with SMTP id y21mr4261908plr.157.1512409727441; Mon, 04 Dec 2017 09:48:47 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.48.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:48:46 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 2/7 v2] net: ezchip: nps_enet: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:18 +0530 Message-Id: <1512409703-20881-3-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The platform_get_irq() function returns negative number if an error occurs, Zero if No irq is found and positive number if irq gets successful. platform_get_irq() error checking only for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2: commit message was not correct. drivers/net/ethernet/ezchip/nps_enet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchip/nps_enet.c index 659f1ad..7d4b628 100644 --- a/drivers/net/ethernet/ezchip/nps_enet.c +++ b/drivers/net/ethernet/ezchip/nps_enet.c @@ -623,9 +623,9 @@ static s32 nps_enet_probe(struct platform_device *pdev) /* Get IRQ number */ priv->irq = platform_get_irq(pdev, 0); - if (!priv->irq) { + if (priv->irq <= 0) { dev_err(dev, "failed to retrieve value from device tree\n"); - err = -ENODEV; + err = priv->irq ? priv->irq : -ENODEV; goto out_netdev; } From patchwork Mon Dec 4 17:48:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 844348 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="S2JrnyET"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yrC9d68GQz9t16 for ; Tue, 5 Dec 2017 04:51:33 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752798AbdLDRvW (ORCPT ); Mon, 4 Dec 2017 12:51:22 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:34803 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752416AbdLDRsv (ORCPT ); Mon, 4 Dec 2017 12:48:51 -0500 Received: by mail-pg0-f65.google.com with SMTP id j4so8702253pgp.1; Mon, 04 Dec 2017 09:48:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=a9XOSbs5CQZUxGIwxlLU8l//z1tddPklL65AwplANDU=; b=S2JrnyETsPLPzmfhh2/bO17CUtSjaNgQh6qkWC3LA0hI8gBgVCa36a6orUr4OK+ZT1 wAIyKtehFrh6P0hDLg4DIcKfoxNeLE3e3A8XTyRVjM6NYVigrnUETog+MPLwpaT60i9r e168VYm6wEjJQ9lzPFsxFLOa69TM57EJ4OG9UEWjHNv+M27advdkfVH+yXz5OckjK9UN /muJweou3un6K+jBLy7tUlgtsBfKH4NQLTAL4n4eiP+BF9VyD/QNvYgKEFl1Zycj4CYs Ac+ZV7R24hrkONSrpp4ycV5WdVj91yWHCM9jTAgSP3iJ6QzsxHa+E2a7/S/y++NMgq5/ o7cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=a9XOSbs5CQZUxGIwxlLU8l//z1tddPklL65AwplANDU=; b=tGEdD2cJ6m3gEzKqIEv/5VdwKUoMLS/Q4r/0+sIuJJ3mud6AyD8fMLpZI1EIRVaNXQ 57TW21p0BngCH99WnxmUNFuMB5SJ0FhBH/NG826NWhEvzs6Hryn0BK6etWgk2Qi7KRB5 Ak4SBnBXUUaJf7qZHYXpvT/C0l06Z/xxsxcdc9GCNBBYwANfPo5TioOaT93rFnOTYAh7 xmLksYkCWQzw0PG2ZKjBK4TlqRm5wRTZMlMCgc4cVNXeHIysHgyvQEBXQwJ3CVXPMHcJ ZAmyMRCs72eVHM/NAXJ4ESkkWAFfXMsOg9KcXyPsvaNGOy4RmBkR9+OVbWrtlfbtqIFZ uyag== X-Gm-Message-State: AJaThX4de7hJ6g4WEjeepf2bVoVlA8N9gUJmhtQQGBm6cJMWo5pnkp78 JIYHHc3nuZzl7N+Km3ldfgM= X-Google-Smtp-Source: AGs4zMafzYYblOVydGMYU2pfhK+Gw2On31eX4qYiZpNg7hr/oQm/dpYy743ehzInvr5bHvv091tZNA== X-Received: by 10.98.55.3 with SMTP id e3mr19817946pfa.63.1512409730541; Mon, 04 Dec 2017 09:48:50 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.48.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:48:50 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 3/7 v2] can: xilinx: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:19 +0530 Message-Id: <1512409703-20881-4-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- changes in v2: commit message was not correct. drivers/net/can/xilinx_can.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 89aec07..1b859af 100644 --- a/drivers/net/can/xilinx_can.c +++ b/drivers/net/can/xilinx_can.c @@ -1111,6 +1111,10 @@ static int xcan_probe(struct platform_device *pdev) /* Get IRQ for the device */ ndev->irq = platform_get_irq(pdev, 0); + if (ndev->irq <= 0) { + ret = ndev->irq ? ndev->irq : -ENODEV; + goto err_free; + } ndev->flags |= IFF_ECHO; /* We support local echo */ platform_set_drvdata(pdev, ndev); From patchwork Mon Dec 4 17:48:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 844347 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XRBPQyjv"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yrC8N3yndz9t3w for ; Tue, 5 Dec 2017 04:50:28 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752825AbdLDRuQ (ORCPT ); Mon, 4 Dec 2017 12:50:16 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:32808 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474AbdLDRsy (ORCPT ); Mon, 4 Dec 2017 12:48:54 -0500 Received: by mail-pf0-f195.google.com with SMTP id y89so9072246pfk.0; Mon, 04 Dec 2017 09:48:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=HVtnnuyOvyE8ocsPzZGR4MSoo1SDTNoQYRipMRHSScM=; b=XRBPQyjv9XSUMvr8x6hqq+ILMIswANxPD/oczkSwER0wumCb2iljcgvuzTsL9OH1Wo tXdeMfiJCoqI15resNtCAGXTY6f/uiiOlb5oXGzAnUGWSmKtVh6PttWUdtbZaMfJGzKz 4mxzpXNYmlOh6Md9MDTSZwF1TqsrKx3IfnHO8qwQrrooBACRIYHXhhJmQV8Y1MX4WgJO xENlNxCOxfxQfPdKCBleeKYpMmHgowtdX6oJjNYSi6eJe+sxBq8YivRYxpIH1dcboDep vamkVrmhV+iDE2WF4IiUfRjgjul1pxc4dqXCURdkA0ePD8RjY/ve9/KkeNBN0MjnRQRG zgOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HVtnnuyOvyE8ocsPzZGR4MSoo1SDTNoQYRipMRHSScM=; b=M6o6+H5dH7ScNSeUfTFD3tDNK11Z88MB4+9rohLT6VqpoJftGkTL1zDXdre8ADH4ps PSUA9KD1qrUwjfAX5T8UYwG9ILX7E7JBLK2rZNI5sYBgFOWcT1GfedRuwPgtAY3SNnRs 8xH8Om1xo8gBvkJ5xVxl6KHhYE7MDaVNVE6KQQi2ivPLnokU26Ttd1K3eBbHD1kRZa0f GlegCGsNB9yEzguL6PDul5nZSqFYsK5PYWMVYffyd8OZWIO7SF+cFbj++24UZlwV32on 8u3xalLi8OwJ+1QahXL9yH1In7hszulCcTENOqkcnLCYiDCfhociSWO0mfbZbe5IEI4/ QLVQ== X-Gm-Message-State: AJaThX61xO6H2qe7xug0ypnn+Aa96iHXOAW82SiZ9CIsSSt6uOogAxdy YmWjZ0yrUZj3wYtIAPWcDHk= X-Google-Smtp-Source: AGs4zMafXgIWpbITTDUKmzrueE1KUIZo52MYvnMndwC+DPOLPsBWFU164TNwqp5qfto0osoovjStVg== X-Received: by 10.99.39.5 with SMTP id n5mr14937714pgn.48.1512409733691; Mon, 04 Dec 2017 09:48:53 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.48.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:48:53 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 4/7 v2] net: ethernet: i825xx: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:20 +0530 Message-Id: <1512409703-20881-5-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The platform_get_irq() function returns negative number if an error occurs, Zero if No irq is found and positive number if irq gets successful. platform_get_irq() error checking only for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2: commit message was not correct. drivers/net/ethernet/i825xx/sni_82596.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/i825xx/sni_82596.c b/drivers/net/ethernet/i825xx/sni_82596.c index b2c04a7..f2a11fc 100644 --- a/drivers/net/ethernet/i825xx/sni_82596.c +++ b/drivers/net/ethernet/i825xx/sni_82596.c @@ -120,9 +120,10 @@ static int sni_82596_probe(struct platform_device *dev) netdevice->dev_addr[5] = readb(eth_addr + 0x06); iounmap(eth_addr); - if (!netdevice->irq) { + if (netdevice->irq <= 0) { printk(KERN_ERR "%s: IRQ not found for i82596 at 0x%lx\n", __FILE__, netdevice->base_addr); + retval = netdevice->irq ? netdevice->irq : -ENODEV; goto probe_failed; } From patchwork Mon Dec 4 17:48:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 844343 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="KB3nAaM7"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yrC7H53gvz9sPt for ; Tue, 5 Dec 2017 04:49:31 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752667AbdLDRtC (ORCPT ); Mon, 4 Dec 2017 12:49:02 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:45571 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752598AbdLDRs5 (ORCPT ); Mon, 4 Dec 2017 12:48:57 -0500 Received: by mail-pg0-f65.google.com with SMTP id m25so8684382pgv.12; Mon, 04 Dec 2017 09:48:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sHfA+6F9vTHh2ekUViwDNjHWbMbNHM/vAfW6Ho/GIRI=; b=KB3nAaM7wfUj17nAeZRB57lEUMfALzC93NqA7G5MM6FWlWxY7lC+4HYFW3STUD1w7E lsOsQZcx30G7JKmz7INuELSuSRuywi1C0AjytiX3C03bo+sFobZyBjHuVKOIOvmRKiYG Aw6hJLlPc35TVsNGx5IfuCQjgkBm3R767ji6/YnJtIYbcwf8v7LbqRfS5pl3jIFxLUpD nKyZFZcJyfee1oYOmjHvm+k8/bNNe5OniiZNDwn5C1kayU/aFeAjC+gJzIW0oHL/bsKq NK5ft5xWKy30GrbMVqVlS0Gzmz1EdYRrj/mgOR9D+B1foGeNa22lx/ladzqp1V/cS20M M5dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sHfA+6F9vTHh2ekUViwDNjHWbMbNHM/vAfW6Ho/GIRI=; b=qnwMmQ4Q+l5l79wZCb2vTfeyz73TWu0NCHM36TnFwyAXZZeIo07vy74Jx05xVLE8bb IkfJstWvMXrDWT8i4SBjntD2BqVpePyqY0czpqxMAdcpKKG5Mrq6liWieUb3Av94uLyy e6i9aCK+lj+cpiUMisokUnzdYfRL4wyrdPcJ2PDkcfrKn0wxsBi3IH+i6EmP6rwBG1H/ VOtCAVSb5JiTkkrSJHj0nXyv5ZFt+j+YLTuM9f87Ve88Ku3vrUoF4OBCxO/pSmkJOISR sjO7m8DkBtkfDI/n1EhulTHJr1wf93SpJhwJwdzUpgxcp7sSxI4TVOT6aLyQqGRkbPoL Qtfw== X-Gm-Message-State: AKGB3mLN5se7Nl1FhPY8Emaa8QAdLqeOOTLh9no2GlryZsQK48r8vo7k Ja9oUQUMOgOKhdtSOuHjkCo= X-Google-Smtp-Source: AGs4zMb2aOrbpcGixz4hDfyFJf+4C0yL0qT82NXiyLM3LpjI9H7KkX81zB8nxRqRRhq5o36Tw4zP4A== X-Received: by 10.99.171.69 with SMTP id k5mr3999988pgp.229.1512409736687; Mon, 04 Dec 2017 09:48:56 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.48.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:48:56 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 5/7 v2] net: ethernet: natsemi: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:21 +0530 Message-Id: <1512409703-20881-6-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- changes in v2: commit message was not correct. drivers/net/ethernet/natsemi/jazzsonic.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/natsemi/jazzsonic.c b/drivers/net/ethernet/natsemi/jazzsonic.c index d5b2888..22424e9 100644 --- a/drivers/net/ethernet/natsemi/jazzsonic.c +++ b/drivers/net/ethernet/natsemi/jazzsonic.c @@ -242,6 +242,11 @@ static int jazz_sonic_probe(struct platform_device *pdev) dev->base_addr = res->start; dev->irq = platform_get_irq(pdev, 0); + if (dev->irq <= 0) { + err = dev->irq ? dev->irq : -ENODEV; + goto out; + } + err = sonic_probe1(dev); if (err) goto out; From patchwork Mon Dec 4 17:48:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 844344 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WCgxRhPf"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yrC7c2L5zz9t16 for ; Tue, 5 Dec 2017 04:49:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752803AbdLDRtj (ORCPT ); Mon, 4 Dec 2017 12:49:39 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:38046 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbdLDRtA (ORCPT ); Mon, 4 Dec 2017 12:49:00 -0500 Received: by mail-pf0-f195.google.com with SMTP id u25so9064587pfg.5; Mon, 04 Dec 2017 09:49:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LWu3LD/6qgRdIa3DnmTL6kI3hmvkfcjPZM7Zc5irb+U=; b=WCgxRhPfgd7dwtzpk9EA8f+N2M2IIjJI3JI6sxW7W+2/kYr/BMD+e05Clm6o4uP42m Uh8N6RXzGSbenqqx9S5KvJ0F5WFmq4lvc1CetFlfvN1i3ynHfPbwehzjbR6xeijCjiZ5 IwK3BnodAC04EUH3UOGlFZ31rCmiij4JnC+02W42Tvyycr5edUabVmSPg8CKdRDO6+Ve YGVYGMRgv/QvKASkVuj6UssQz7MFVIfglHySsA/fG9eKDpSJO3z5Df8FrjDZ7rPnqf5a BrxcVksj82lGjdUoVzP7hK6kqhiV/pCWTFaqW0qfBY0z570LQhWB2CwEm7aRUrnDxQAi F92w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LWu3LD/6qgRdIa3DnmTL6kI3hmvkfcjPZM7Zc5irb+U=; b=Z2GcQC4qptMfS1Q+UDZRj1TZC575au0x2rpfkAsDWM+Cv4n11KUU91dK0nP92NBQRA 7/Py30y21Id5aPSTsEse93tHJ1rhxMuHus+VdgzsE5vJX+Sn9D09zGaqNSyEXKlKVght rdPneSrYzppBcisFkmb7rl8Me3QSZ09tiEKxjsrdo8Gh/6L5kHEAzULYLTFRpFL7lfkh wSDB+d3ftbJJy1mzvL6VgESvYzQHwmEaKAf6E6W7v08Vd1e40DTJzq6W/d8TxuNl6yG2 ihIDjU2HLh/UtIpsUx0DcS89C7SMNQoIdVf+0r5C08lihpSuztNws5D54Z2r4HS2TZ3Q Wb5w== X-Gm-Message-State: AJaThX6trh7aUkzqWhLFQgUBExUNTxR7UJC/EqKQyha5WFHgI6rvp4a5 z7YZhx+5M5sMzUm0VUdj6d0= X-Google-Smtp-Source: AGs4zMZc9Gn8ec5J5uVcdlrDA9/ZQQyVc3uOioJPDp30b5kJIsSHvwWB6oH3SJZkbnrUziaWUiDf4g== X-Received: by 10.101.70.11 with SMTP id v11mr14545199pgq.306.1512409739791; Mon, 04 Dec 2017 09:48:59 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.48.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:48:59 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 6/7 v2] net: ethernet: smsc: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:22 +0530 Message-Id: <1512409703-20881-7-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- changes in v2: commit message was not correct. drivers/net/ethernet/smsc/smc911x.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c index 0515744..5e3c7af 100644 --- a/drivers/net/ethernet/smsc/smc911x.c +++ b/drivers/net/ethernet/smsc/smc911x.c @@ -2088,6 +2088,11 @@ static int smc911x_drv_probe(struct platform_device *pdev) ndev->dma = (unsigned char)-1; ndev->irq = platform_get_irq(pdev, 0); + if (ndev->irq <= 0) { + ret = ndev->irq ? ndev->irq : -ENODEV; + goto release_both; + } + lp = netdev_priv(ndev); lp->netdev = ndev; #ifdef SMC_DYNAMIC_BUS_CONFIG From patchwork Mon Dec 4 17:48:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 844342 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EMNoFKMG"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yrC743Bs0z9t16 for ; Tue, 5 Dec 2017 04:49:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752750AbdLDRtJ (ORCPT ); Mon, 4 Dec 2017 12:49:09 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35755 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752709AbdLDRtD (ORCPT ); Mon, 4 Dec 2017 12:49:03 -0500 Received: by mail-pf0-f194.google.com with SMTP id j124so9073122pfc.2; Mon, 04 Dec 2017 09:49:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8rqQr8sXhlG0r+Vj07MdtxMVsMkG4hAOsts65oR12C4=; b=EMNoFKMG3WxChuquar0MmhTNFWu46+DVDFMiadVUIOWyoPA7RCNWSB/HKEDoa8hSDW pWarcjjYNdvBqCdqxe585lbzFNuhX0GyF/C4n5wEBwBvd/BgG6s9PiruTzXOJRmitGIa dZyN46VqOZXNBMe5cReqoO4DGwQckLQd+7BUBhJaPfZBt+R+zo3HA48rH/80VWb3Poh4 5OXZu1n/i0sVxiZVA+XaiG+wa2C3Hxl8aAc+CcRLCjRq5oc5VtyBJqHacxYW82YgIamJ PQm/exkT72ILnyeu8CLboZYkjnVfpQ6/Qhl5qL9U3C06jjsJUh9SZe5h1jcBOHWr3ckO Z5cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8rqQr8sXhlG0r+Vj07MdtxMVsMkG4hAOsts65oR12C4=; b=W2GfcVCIbmxcK1oC/XevPbQkO6S471YJL+aMorMZAGr0aFlWdALUT4/1/E0a99Z/or 4ghVl2R5tcc8krj8hC0dSwAlRZ5QTqMGlV8PL5fbWLLho+S7dIPVXI3oWf1hiT3jqUDa aoPxKaB9eoufJrpg0w8eW8H23UB3uRRrKyq1bh2bjgHQVoCJShTYCV6ZkPmeSN2/AeGJ 0ifJmTMj4G+TMltKcGgZVeqZM3ViJai83TXnNFxQ0oHrBbCy2npAQ93J7os+HwyESRrR veVY75PRUcl6Bbn54an8V7mhfAqbsskbseJucExRX5BSZyFE1WGFt0IxvIRJWPgoYYh5 JptA== X-Gm-Message-State: AJaThX6A/F3pp8NWw1PpTlZ02EORNB3QgpQscIx3ARywF9vOwKkgahYQ IU9X/61F4tDiMFzXwmOnsR8= X-Google-Smtp-Source: AGs4zMZiiiXmWsIZWwjeYh1Eedo+YhWsaub3K2CwEpG3A9i6CyA27QTLAypFOQ4CMiJfzB8HQwUi9w== X-Received: by 10.98.150.221 with SMTP id s90mr19957679pfk.151.1512409742857; Mon, 04 Dec 2017 09:49:02 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id c79sm26098071pfj.49.2017.12.04.09.49.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Dec 2017 09:49:02 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 7/7 v2] net: fjes: Fix platform_get_irq's error checking Date: Mon, 4 Dec 2017 23:18:23 +0530 Message-Id: <1512409703-20881-8-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512409703-20881-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- changes in v2: commit message was not correct. drivers/net/fjes/fjes_main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index 750954b..af7204b 100644 --- a/drivers/net/fjes/fjes_main.c +++ b/drivers/net/fjes/fjes_main.c @@ -1268,6 +1268,11 @@ static int fjes_probe(struct platform_device *plat_dev) hw->hw_res.start = res->start; hw->hw_res.size = resource_size(res); hw->hw_res.irq = platform_get_irq(plat_dev, 0); + if (hw->hw_res.irq <= 0) { + err = hw->hw_res.irq ? hw->hw_res.irq : -ENODEV; + goto err_free_netdev; + } + err = fjes_hw_init(&adapter->hw); if (err) goto err_free_netdev;