From patchwork Sat Dec 2 19:26:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843918 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="V9hrVbBh"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1RW6vxHz9sNw for ; Sun, 3 Dec 2017 06:29:27 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752312AbdLBT0k (ORCPT ); Sat, 2 Dec 2017 14:26:40 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:42680 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752233AbdLBT0h (ORCPT ); Sat, 2 Dec 2017 14:26:37 -0500 Received: by mail-pl0-f67.google.com with SMTP id bd8so8148845plb.9; Sat, 02 Dec 2017 11:26:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JfiabAyDisYZJU+0y91+jP3o+8uMbeI+e2BtLwuDaxg=; b=V9hrVbBhKOmKdIMWxi+QWUjAOIIclI663Sw3A2k2o/zRzPNkmUMrkRbM+p95Fb++9m in5TWoE0pnWrjWyg6NI+blisoPDbyrVG0bet/zQrtuegIDY3Jg4Wj+y3IOR0ZykcHDDW m2mmMwo3f5rOPIaYIerlFzpveUgLl88hW+7eDz9i4MonYmFQN+0LouLDucteZihsGrAG SLImtjECEhRlrhOGWyBy5p+PnSfZxvUA8A46dDgTAGmANYs6Fd9XuZhsqARjCCrOpGMh Yuo4EIJSmsfO3tQUkcj9A+AWLKuXO8xW5Cp6hXn7APOY55cUU1DUJdUkWmaE1i2tIUv4 wVdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JfiabAyDisYZJU+0y91+jP3o+8uMbeI+e2BtLwuDaxg=; b=Ekudk5lNpkwWqcFnjAMXLzM9S2UN8TwIiSEl80bMQAMKBWawgp+2YqXi8w1bjvPaDF HGHHqnFbcibi+J84tXuS293Yn+RRCkij5kTZDeUJFu0cNh4OoUISfbsodWD/t57ZF8FG Qqp3CJymzShMD65lWkpI29Qk2UBEaENejtqOZyCZHtT89njv32NC1ZCzosjfVbfr2jLU L4QsXaGtI6zwSNxiyAoXPOu+5ru3jIAeM4Py3FeeBEwkupxXplUzZiMjcomrg56ABMiU smeUM60FvqvmGENbXz37hDI4HQ8Qd/sXkCsrtGQsMxfV9PNUgyNiI/B+BuEmtsbK8MTC b3UQ== X-Gm-Message-State: AJaThX6UQgJABiRg8RPBTjf7NRj7sSR8EYYyKoDgvXWgh4wZMdDkCe9G Oub0mVvw4DgQqGERSY6hYQY= X-Google-Smtp-Source: AGs4zMZA6bi7hGE6AUlwQar4VzbVl8LF0NNpA/lUMmoDvjK4UehYFE03PmCze9HlQC4ovFa7hBIIZA== X-Received: by 10.84.136.135 with SMTP id 7mr10025913pll.21.1512242796829; Sat, 02 Dec 2017 11:26:36 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:36 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 01/10] net: bcmgenet: Fix platform_get_irq's error checking Date: Sun, 3 Dec 2017 00:56:13 +0530 Message-Id: <1512242782-7134-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 24b4f4c..e2f1268 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3371,7 +3371,7 @@ static int bcmgenet_probe(struct platform_device *pdev) priv->irq0 = platform_get_irq(pdev, 0); priv->irq1 = platform_get_irq(pdev, 1); priv->wol_irq = platform_get_irq(pdev, 2); - if (!priv->irq0 || !priv->irq1) { + if (priv->irq0 <= 0 || priv->irq1 <= 0 || priv->wol_irq <= 0) { dev_err(&pdev->dev, "can't find IRQs\n"); err = -EINVAL; goto err; From patchwork Sat Dec 2 19:26:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843917 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="prRzuaaq"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1RM4Y8lz9sBd for ; Sun, 3 Dec 2017 06:29:19 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752366AbdLBT0n (ORCPT ); Sat, 2 Dec 2017 14:26:43 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:34325 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752302AbdLBT0k (ORCPT ); Sat, 2 Dec 2017 14:26:40 -0500 Received: by mail-pl0-f67.google.com with SMTP id d21so8130124pll.1; Sat, 02 Dec 2017 11:26:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=c5yPUC96jn/8H+4UY4VH7zzqjk2anlVoo6BwYSe2BmA=; b=prRzuaaqDg1KEL/m8QxOyySSjSPtGnd2GBSB9lPc8CRf2nkvFRz0UsD08ItH+/o999 sr6jukDogjRWkyzHVn3jjattF1+itAyiQbRc4XzKkPOISpzk6BOCHetLfyZCfz2LO7St CzXQ5RXicYDKRufzNBPX90f4B4yhFEa2MnbFa9x/2e8LWkgQK4E/IiMi1lDgRKkll7nR bVgqbmsxwTZpNBamaXn7OVEN2elNykZnxGNYKNCagbG+3U0+41I8GXNFTDeZKk2CZivy 5BZMHwj9N2dQ4W4wRejxmtxJBC9G0OibS+CwR8Q0gSAFzqq+2Wxzvkic9z5NHb9lwu0G psXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=c5yPUC96jn/8H+4UY4VH7zzqjk2anlVoo6BwYSe2BmA=; b=tYyEkPec2XSETS1UJZ2MtETB6EQjDZiAlBCDahhrkvZLd/ZrloQr9Uii+AQJ+XyJQo nN6RrritVBWU4Sju11ZqWiXbczR7wdr4eS9118zF56ZURxYZWsxyp49Lpj2lk3tEiUmR zVDSvjGDnz3sHU0h2QaSBd9u4J83TwoWJuHCeflnmhXeESxfh2fbrA2SVjk8kgu1TINb 2w7FPkh/2O3ooJApGMHT/QENqdADRqPThRNLJUYVs/fnUECDEzG90AskyN3Stq38JYhe uV2z++RnjMv2O7mlxV+uujxK7rrOL6eYrx2drIs1n5yW/N+kN72VH9renFuVD4ID6Azd Bbow== X-Gm-Message-State: AJaThX6fvsuFsDdbeHBj9vRmzo0fElLM19SLRUhzFYu0O6TQqQ+6WEEN z1W5gO2CFWsVShA267l8mmA= X-Google-Smtp-Source: AGs4zMafBK0ePykW1chjRvGEJtdsZwWgrthlLBy+O5+HlZobOxoMXw5Sjeutyv1uBKMzh1K5v9nRNg== X-Received: by 10.84.168.193 with SMTP id f59mr9832432plb.22.1512242799975; Sat, 02 Dec 2017 11:26:39 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:39 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 02/10] net: bcmgenet: free netdev on of_match_node() error Date: Sun, 3 Dec 2017 00:56:14 +0530 Message-Id: <1512242782-7134-3-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The change is to call free_netdev(), If of_match_node() will fail. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index e2f1268..e0a8f79 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3363,8 +3363,10 @@ static int bcmgenet_probe(struct platform_device *pdev) if (dn) { of_id = of_match_node(bcmgenet_match, dn); - if (!of_id) - return -EINVAL; + if (!of_id) { + err = -EINVAL; + goto err; + } } priv = netdev_priv(dev); From patchwork Sat Dec 2 19:26:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843916 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nnP0Wk25"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1R95mwxz9sBd for ; Sun, 3 Dec 2017 06:29:09 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752674AbdLBT3A (ORCPT ); Sat, 2 Dec 2017 14:29:00 -0500 Received: from mail-pl0-f65.google.com ([209.85.160.65]:40963 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752344AbdLBT0n (ORCPT ); Sat, 2 Dec 2017 14:26:43 -0500 Received: by mail-pl0-f65.google.com with SMTP id g2so8147040pli.8; Sat, 02 Dec 2017 11:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=U5xU1EIb3TFWE3G1JhyDbFCLGf7eLplAxWrip/41w7w=; b=nnP0Wk25+PyaNbKBlUOjpw/pJivKRsuKPEX2ZEVv7VVVy9pjhz2qCNftGZXuPl7uab xVXxP2NG9zRfAryy4w+TaCnyiiADDySQ9z5LYMk5ZL94e/+S0X764rrdOz3fGSnDy1Rd VaOe7tcO9Pgcjq1vWkOfd46MPXj3ntKpqRA5NwXxrwQO+jljzyRSocn+bMCAVr3ZVwt5 GJDa7m2IlHEqyu4sq1oYtLB8P2ez+vb2SIeANI8Rh5GPmzPYE4iDQGbx5rUuns00231Z EM8doxWewlwjVm6x25EBBr5VA1dp7nbGya8DkQMBmThJfzY30Q2G4nn1S4mNqjvwzB96 lxxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=U5xU1EIb3TFWE3G1JhyDbFCLGf7eLplAxWrip/41w7w=; b=WP1ZLFPJP7iHzxGu3KIoWuejDaV+c96wn1edZY3wJEg83WTe9jgOt/bJ2fpWs0B63B /k16bSrc3rB+5yMhMKf5cDeE+lRgg3KQQI0OIyPJlNsbMKF8oGmYdD7NMFiN17UOiJDQ OdssFqOiCPhcoRJfe2pFQCfcgZ9Mr7PgTinhZpAQhEt3I7tjYG5e6Cb84Ga/abMZoHuZ WWWhJ6Osv1NI/z/oaknkK2MA9rvhNouVrGeLGFo+eDE0U0TiW4si+cliFeDsSo7i/C3t urNlU8BAJ5R/ViSQZOGW2fbLsO6MFFkPQGeThSyF/kC8wX2qYRM3FVc+PBzXnGpHyxOV sbhQ== X-Gm-Message-State: AJaThX69NDYIvZMosEgylLYayP+jzb3hi5tnMVGRazy4ULOh0SmfP886 UGRuXCSjG/i51vL3LEd85/Y= X-Google-Smtp-Source: AGs4zMYYARtNNgX0Z2I15sFO4RJ/b0HUaymnGn8tKmYEjbjswk687JsjZ/SnoDmrxwLgRPx519lTmg== X-Received: by 10.84.224.5 with SMTP id r5mr9972291plj.341.1512242803183; Sat, 02 Dec 2017 11:26:43 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:42 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking Date: Sun, 3 Dec 2017 00:56:15 +0530 Message-Id: <1512242782-7134-4-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. And remove unnecessary check for free_netdev(). Signed-off-by: Arvind Yadav --- drivers/net/ethernet/ezchip/nps_enet.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchip/nps_enet.c index 659f1ad..82dc6d0 100644 --- a/drivers/net/ethernet/ezchip/nps_enet.c +++ b/drivers/net/ethernet/ezchip/nps_enet.c @@ -623,9 +623,9 @@ static s32 nps_enet_probe(struct platform_device *pdev) /* Get IRQ number */ priv->irq = platform_get_irq(pdev, 0); - if (!priv->irq) { + if (priv->irq <= 0) { dev_err(dev, "failed to retrieve value from device tree\n"); - err = -ENODEV; + err = priv->irq ? priv->irq : -ENODEV; goto out_netdev; } @@ -646,8 +646,7 @@ static s32 nps_enet_probe(struct platform_device *pdev) out_netif_api: netif_napi_del(&priv->napi); out_netdev: - if (err) - free_netdev(ndev); + free_netdev(ndev); return err; } From patchwork Sat Dec 2 19:26:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843914 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FNY0ATTj"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1QQ2DGZz9sBd for ; Sun, 3 Dec 2017 06:28:30 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752430AbdLBT0v (ORCPT ); Sat, 2 Dec 2017 14:26:51 -0500 Received: from mail-pl0-f68.google.com ([209.85.160.68]:35464 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752402AbdLBT0r (ORCPT ); Sat, 2 Dec 2017 14:26:47 -0500 Received: by mail-pl0-f68.google.com with SMTP id b96so8150752pli.2; Sat, 02 Dec 2017 11:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2wkEKFnkLt6c0J6yaAdVLSQXa08/bN9qdqEhXeSys1Y=; b=FNY0ATTjfEafiCOER8P1nbQZKtVNKhIxkYkX5tFbOjV4NCR/gWwxFDI56v5QfNS8e9 6ny2eJ5n3bPodlJw0vB47TmTBrbxFlxLDB12dSBq7eAGYcbKYZEBC2NsrF3NrytIrptb vDusRex4T8sSzvWXyqXjAwVicp7NAiygTyvnPbef8feN/EOB/+bTqMEByvG9zv8fG9uP yGJ+zsYIexXJsEvIrSSXHx0MW2eElJQJeDT1YtTaAhvfnIQ6Hqxv8NzRXoaVJkleRUJp 4XNmyGzh/lJ+c3x9nJG6vSY7tefSfAwCDHDLOMn9mv+MpDXU3IP+yGS/JiCwbeMztFOD 3Dhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2wkEKFnkLt6c0J6yaAdVLSQXa08/bN9qdqEhXeSys1Y=; b=FcmZntugM4X1TunLjEfio4JnA8mN601bsutTJOx+EmAVCLtxK6CY05cglfc1aMm+2W IQEBOolb/R0ILF6k0SI+4/zMfdQG/v0R9VuZR4MUO1LDFwq3adS9bz7bBeV/8yu6Xyh0 82JszJZta70ayAja4NUIxOmYB9vU6uNRCmfVakxuXw2zhENfyoRKYr1V0IjYm0U7Mz81 pZGukA03PYnKW+092KwwkkLyKiSXtjoWazlTLLDh8UL6CAXM/gg7GoFrm3DYTCPhTvYQ ZZjYS79FWYm0YpdUXTPI7ImRZEUZPq1pGcR1RnAO/Q0QIhkEe2xckOvt3a+nzufPKR+0 16Cw== X-Gm-Message-State: AJaThX7KeKjHBcXFF2yNsrUgu+iwZ3QJCBaM40rztSP/A3OyWaSg1hmm GXYpGD9X9bC4FY1NAxKL7+A= X-Google-Smtp-Source: AGs4zMaYE9dwhEp4pHPsXQSKYHvtswSOb0jMwZ8rxAqEc5n8tqql0OWsLrm/mB+YHUQ5i/Vr+8fX6w== X-Received: by 10.84.172.195 with SMTP id n61mr9969446plb.49.1512242806384; Sat, 02 Dec 2017 11:26:46 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:45 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 04/10] can: xilinx: Handle return value of platform_get_irq Date: Sun, 3 Dec 2017 00:56:16 +0530 Message-Id: <1512242782-7134-5-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/can/xilinx_can.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 89aec07..e36e2a2 100644 --- a/drivers/net/can/xilinx_can.c +++ b/drivers/net/can/xilinx_can.c @@ -1111,6 +1111,10 @@ static int xcan_probe(struct platform_device *pdev) /* Get IRQ for the device */ ndev->irq = platform_get_irq(pdev, 0); + if (ndev->irq <= 0) { + ret = ndev->irq ? ndev->irq : -ENODEV; + goto err_free; + } ndev->flags |= IFF_ECHO; /* We support local echo */ platform_set_drvdata(pdev, ndev); From patchwork Sat Dec 2 19:26:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843915 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ffGQi4zv"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1Qk02P4z9sNw for ; Sun, 3 Dec 2017 06:28:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752649AbdLBT2i (ORCPT ); Sat, 2 Dec 2017 14:28:38 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:40955 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752413AbdLBT0u (ORCPT ); Sat, 2 Dec 2017 14:26:50 -0500 Received: by mail-pf0-f193.google.com with SMTP id v26so6090071pfl.7; Sat, 02 Dec 2017 11:26:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3N9N+1VLcUW/4uQzg/7SimUBvcthJGhtRDiEuoqOQ+E=; b=ffGQi4zvMNEkXraUjnnrlmDAiUUJAQh7s1JlSoaU9b2AiKKl881oNaniBDzHIvry6H 6ul5Hy+qCkJP8oi3hFn3PryJtvfAuAkNgmD1jw+ce76r0EgCh0rRALDWoINz+UdlIWMV 1jv3u72nZHdgV65Ajpxqa17nnpWl607MwZLSPprkx2pyxn2qX+GfKNQL/IRkJDEkoD9i e8tKn+lvdHAI4of+d5R5oArtIFWm+qXIQDk5K59HjNWdpqeiTUeYRpXbsgUP0zIoykXW bOVVtgelk0GIctTD4dK5UIoayFzzeOaYUMnDm4w4k/y3+ihdFllHKAN4gqqpHpzoJWRj Lonw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3N9N+1VLcUW/4uQzg/7SimUBvcthJGhtRDiEuoqOQ+E=; b=GbsCU9ym14eMeOYDjTO4KYnZgfPiQ7UOI6V2VOqATOpDywA8eMAM8q2R4RTWRngYhV /RsKynkR+Ku2DBZsCT5YJ/ktgNSz1tjmA7UKKzXyf2zfSh2/38/uYJRgOY7Pjr3BVYFQ p7DrVjzUPD1ewE1DZm58gzciTZDKJHQX0LsgKMD5BF2l1G9HpmGjfKBwY75hB6YZ1rmj MiHnHmCtipzBVqe7mmAsuaNceNqkhwmPMAcUezlMpUT0sAIELJLLgdeelfUO18o+q6nF xYmb3EMJxIh+KWTJTIrH0q63BSBfwMl6Cuqjf0ZL9B62Q5dgC7XcjGw7dEvJVhckrLPj Ecng== X-Gm-Message-State: AJaThX5CoTdV89cXj1NDMgpl4064grRchiYu9Z6NpwZ7uofEfF43hMxt 5yYR3mpSWpkd63wVFxEqpQw= X-Google-Smtp-Source: AGs4zMZH+yfsH5A0rLofzkpBM9nbHH32HE61/qd/Le69O0CYuQCNxRMXo9H5HasAy8VOjr/fbkIrqA== X-Received: by 10.101.77.210 with SMTP id q18mr5459356pgt.145.1512242809702; Sat, 02 Dec 2017 11:26:49 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:49 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 05/10] net: ethernet: i825xx: Fix platform_get_irq's error checking Date: Sun, 3 Dec 2017 00:56:17 +0530 Message-Id: <1512242782-7134-6-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/i825xx/sni_82596.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/i825xx/sni_82596.c b/drivers/net/ethernet/i825xx/sni_82596.c index b2c04a7..a6d56f5 100644 --- a/drivers/net/ethernet/i825xx/sni_82596.c +++ b/drivers/net/ethernet/i825xx/sni_82596.c @@ -120,9 +120,10 @@ static int sni_82596_probe(struct platform_device *dev) netdevice->dev_addr[5] = readb(eth_addr + 0x06); iounmap(eth_addr); - if (!netdevice->irq) { + if (netdevice->irq <= 0) { printk(KERN_ERR "%s: IRQ not found for i82596 at 0x%lx\n", __FILE__, netdevice->base_addr); + retval = netdevice->irq ? netdevice->irq : -ENODEV; goto probe_failed; } From patchwork Sat Dec 2 19:26:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843913 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="U2tmXBny"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1QD0qpJz9sBd for ; Sun, 3 Dec 2017 06:28:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752489AbdLBT0z (ORCPT ); Sat, 2 Dec 2017 14:26:55 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33492 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752412AbdLBT0x (ORCPT ); Sat, 2 Dec 2017 14:26:53 -0500 Received: by mail-pg0-f67.google.com with SMTP id g7so5891645pgs.0; Sat, 02 Dec 2017 11:26:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QgPO+53vmcPegXdhyeXpMvXzghtPjd9fKNczdhwW6NE=; b=U2tmXBnyjABksnrW1EvsJuEQej19RgkZFm1/pvD4HWYtm1/qq5tzIuheEuyadDBTJq 9tSlSVWieRAvTALWXRNTGYjysf/PFysDArSKGUZ4IkIHE0udLH9OBLORhu25LGIHClYC T/VCDCWBex+wksRBsbi6sEppd9OCQ0JjjchfCCBvxNzYRuh7kst9S70Z4dHv93AP0EZJ rqGglw13IouI9hY+tp4bXIlEoHFincjs+oD9I3Fb6+zcIEqYfJTspRpZC8Vit7EXhdNu A81QLUGXUfRjfJnwvWwSuT5puODQ9qThckHzgMox5wvf9iaiePXMF4d2KtsjyA+9bXrm YsTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QgPO+53vmcPegXdhyeXpMvXzghtPjd9fKNczdhwW6NE=; b=m1qJ+sChOM7txGuI5btnAeffCiXD9dmvFnXyS4MM61hRTE6TxkzASCPAbZlepVrLBd aoa1qpGKa+OVsmvjFVqr21OhuNYP2gI3JQZUIsBEpYkEaLRg7WdE7EMilPwNaMDBTs4J 3cauLCLZYGZmhKKEaT6y+t7ILZ+T5TdwRsTJIwzfy1bhX0SoAmYDyrw4RHAdvU2k8W++ 51ndiTbqkcEPrJawFw3RnKijTHv6wIV1p+dWN76OA2jUmTsZYn84bkyZiXiFsznKENlY 5KOr1IAdSH/PsTNhlQ3Kfv7oRN27BGuCHdd3/N///M/tpAQcCIdf6danRadxCXqcvmR5 BCrA== X-Gm-Message-State: AJaThX4rYDgE+qY9NiMtwx31Zhp9UNgqJcDk8HKHnsfiL0zkxHyZPJpO 6frpn4P0Y7Y79Z1nP1vb7hY= X-Google-Smtp-Source: AGs4zMbixsckT4zmZcU30W0Y+A7ZdPnCM5SEga3wc+izTg8t81HfYttLEWVo24YzNh+Ynh2Sx/41ug== X-Received: by 10.99.4.142 with SMTP id 136mr9442493pge.72.1512242812999; Sat, 02 Dec 2017 11:26:52 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:52 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 06/10] net: ethernet: natsemi: Handle return value of platform_get_irq Date: Sun, 3 Dec 2017 00:56:18 +0530 Message-Id: <1512242782-7134-7-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/natsemi/jazzsonic.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/natsemi/jazzsonic.c b/drivers/net/ethernet/natsemi/jazzsonic.c index d5b2888..3cf0856 100644 --- a/drivers/net/ethernet/natsemi/jazzsonic.c +++ b/drivers/net/ethernet/natsemi/jazzsonic.c @@ -242,6 +242,11 @@ static int jazz_sonic_probe(struct platform_device *pdev) dev->base_addr = res->start; dev->irq = platform_get_irq(pdev, 0); + if (dev->irq <= 0) { + err = dev->irq ? dev->irq : -ENODEV; + goto out; + } + err = sonic_probe1(dev); if (err) goto out; From patchwork Sat Dec 2 19:26:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843909 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Nl8IkjzS"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1Nn21Thz9sBd for ; Sun, 3 Dec 2017 06:27:05 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbdLBT1C (ORCPT ); Sat, 2 Dec 2017 14:27:02 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:44333 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752073AbdLBT05 (ORCPT ); Sat, 2 Dec 2017 14:26:57 -0500 Received: by mail-pf0-f194.google.com with SMTP id m26so6080927pfj.11; Sat, 02 Dec 2017 11:26:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nRQlom2cn1YQyAodDUM0fj2/PoEM0RA/qcwNM4u1u6g=; b=Nl8IkjzSCb0CIGvm4tUkA2sK2PZZ1tqJ6IU7Pcxv/4k3EU+0COSje++/PEYQtiQdnJ HgsIBMM3W3O42kfEgosaua7i3xS8yxwT2l4J+qJSPiSGY/jbUIDY2QkIwYLzQmPz5fnZ M6NYw7uA3eHS8gQtk43bFyVdfkCrjm2EhLEXK84EEWq0B+FlEyjMPuBM/cQ4cPWldUMY ZIpkl+6o7mZHvVEwciuyOXYO3IhEFnUmzVJcMgpnAmRQU8HJItesntqi3gyHVgZ7mzRA GUsn/bkvH44Ps4E8J+Z2ratebez2zldTuzvpQuFzub5eutl9P35V8N1fJ78q3Z/A5MrE Gt+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nRQlom2cn1YQyAodDUM0fj2/PoEM0RA/qcwNM4u1u6g=; b=TgKf+UE8PM5Doxa7RwBSQOm2bXCOkRDAIkxUSGIwpN5rmKlIoWAOXUVcJCcoZ//IjQ cI3aShBO5kL8prAGptPWMZ5/6XdkciyTD5lRfhpQxXHFMoK8WkfuKasTD4TVshweN+/C 0RMG+Ahu9niPp6MULYzI2vOgbEASzmLMkCk8s5sz+1dUxxa93NzO8xKbqvoS17TWSADk pyy/USwIm6DyUJYdDq/Fx2piQFoXyTpnlnyf8mtSP1xMdcDsKnkPkp0LvH8S2SPQx28U 9zSQe+HUuUzzXatDn8tGm0BP2XMhoBd001+lZDfnUXLajdeHonzZJltHuOLEmZhX7iBa 9lJQ== X-Gm-Message-State: AJaThX6BM9IsvDHFGK3J9pd4L4AohDmA0L1MsFPtmJv6kJS8eejlGVAG hH+rthSYcDzgiLUD5Nri/bE= X-Google-Smtp-Source: AGs4zMaQ1+b8rTMPLvySnf321YGBvVzqwQxdJt9yXcYSmGdNDLBLh7K+mTZFF5bBMsY/ICJ5q49v8A== X-Received: by 10.99.144.68 with SMTP id a65mr9951213pge.429.1512242817258; Sat, 02 Dec 2017 11:26:57 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:26:56 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 07/10] net: ethernet: smsc: Handle return value of platform_get_irq Date: Sun, 3 Dec 2017 00:56:19 +0530 Message-Id: <1512242782-7134-8-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/smsc/smc911x.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c index 0515744..a1cf18c 100644 --- a/drivers/net/ethernet/smsc/smc911x.c +++ b/drivers/net/ethernet/smsc/smc911x.c @@ -2088,6 +2088,11 @@ static int smc911x_drv_probe(struct platform_device *pdev) ndev->dma = (unsigned char)-1; ndev->irq = platform_get_irq(pdev, 0); + if (ndev->irq <= 0) { + ret = ndev->irq ? ndev->irq : -ENODEV; + goto release_both; + } + lp = netdev_priv(ndev); lp->netdev = ndev; #ifdef SMC_DYNAMIC_BUS_CONFIG From patchwork Sat Dec 2 19:26:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843912 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Z+yBLdUg"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1Pw6QpRz9sBd for ; Sun, 3 Dec 2017 06:28:04 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752633AbdLBT1y (ORCPT ); Sat, 2 Dec 2017 14:27:54 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:43692 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752080AbdLBT1B (ORCPT ); Sat, 2 Dec 2017 14:27:01 -0500 Received: by mail-pf0-f195.google.com with SMTP id e3so6083973pfi.10; Sat, 02 Dec 2017 11:27:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=c/w01skmvyGMwSEFlTBH0OiX5hl4ZGAKrevZLfi3YUs=; b=Z+yBLdUg29lrwIYQnWdGtjffCbWPZfZpGwL5ao3+4xkLs3YbmHwBragIqM8Jp4jOJg 5YAaMZofgRq5AZzfSBe+ktWyDRoL2/0HY4eH1DVKQrqLi7MmJrz2FVIzJunDchvdmeif dz732y5buPUkElrscwpuEHRdlMu3ZoVEeEwNK+EfVIJIheL5XbCs8Knf7f+srQZasnva 6X+k6ayIuoYihRsv2ytOS1NnzRsIwgLUjB+IRYnWL+UPRswSagoyIljrGPNY0F3N5jLB V+NKqrkAngOh9o4yfRbY8sMLg5hbGRCaedFlXYdem+aFW4NCn/PRS78JQn9Xep2jWpXG s9fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=c/w01skmvyGMwSEFlTBH0OiX5hl4ZGAKrevZLfi3YUs=; b=VrVTZ/mUIoboVQZ+uaFmfHmDKzoZFRuNwgNnGkBxXYcY4dbWXu2GG/OldhziAvTV9d n0gWiKMLcDZbLL1duPRoyH7BM4+IEiZhWttShAa1N5QcYHZ3j2ZOW+bkHNQ0FKp6R0fN /nUbBj6uyjsD5uiTssw31SZBRc2sXQIr90+NbPJ4GnQNzT8gWUsTCeUvRVZK9qaDF3XW InUCK45Swg+eqlhj6CHoaTIs6bbJetBHbYZ5NEEaesTTf0En9LrL2Q8DQH/qkUJ6WVkL kXQlpGU7mh9QrRFrCNi1lDQyJVHEBbrzEhPYQdAl0HbZR6bqGJ1xLfHtyT+zSTTXqRbx mUoQ== X-Gm-Message-State: AJaThX6mxZNcKu2APljH9Y7eunIBuJEzwgHZI+484Wo/7Z3f+4JnIYWe q0oCBfgvOMC22fPpb2U5VbM= X-Google-Smtp-Source: AGs4zMYk0LyC35SplBudAf0YsYVk6QQnMtprXhtKxPTNsw3QksdJmU3SyrZCyF6rps03suOpszneYw== X-Received: by 10.98.207.70 with SMTP id b67mr14462447pfg.220.1512242820578; Sat, 02 Dec 2017 11:27:00 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.26.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:27:00 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 08/10] net: fjes: Handle return value of platform_get_irq and platform_get_resource Date: Sun, 3 Dec 2017 00:56:20 +0530 Message-Id: <1512242782-7134-9-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() and platform_get_resource() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/fjes/fjes_main.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index 750954b..540dd51 100644 --- a/drivers/net/fjes/fjes_main.c +++ b/drivers/net/fjes/fjes_main.c @@ -1265,9 +1265,19 @@ static int fjes_probe(struct platform_device *plat_dev) adapter->interrupt_watch_enable = false; res = platform_get_resource(plat_dev, IORESOURCE_MEM, 0); + if (!res) { + err = -EINVAL; + goto err_free_netdev; + } + hw->hw_res.start = res->start; hw->hw_res.size = resource_size(res); hw->hw_res.irq = platform_get_irq(plat_dev, 0); + if (hw->hw_res.irq <= 0) { + err = hw->hw_res.irq ? hw->hw_res.irq : -ENODEV; + goto err_free_netdev; + } + err = fjes_hw_init(&adapter->hw); if (err) goto err_free_netdev; From patchwork Sat Dec 2 19:26:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843910 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="A+lLBJdo"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1Ny6MBvz9sBd for ; Sun, 3 Dec 2017 06:27:14 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752599AbdLBT1I (ORCPT ); Sat, 2 Dec 2017 14:27:08 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:42237 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752073AbdLBT1E (ORCPT ); Sat, 2 Dec 2017 14:27:04 -0500 Received: by mail-pg0-f65.google.com with SMTP id e14so5883029pgr.9; Sat, 02 Dec 2017 11:27:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=raJNXmbwVqpq83KKgT3XBuMmTgFvd7SAupVC/Uzr9r0=; b=A+lLBJdoYx/MuIjPer2wMCgl2Fut1P9YLeQ/oEL6OYV/+6XoVr/fptzUf5dZFkZndZ 4I8L5oPnJTQtOkG3Pa8qTv2QJNZBG0lHTrZdgunCSa8ljkmZHXGjl1vpIZu0DXDiGwDP UG60eGxP/DWe9pUEWFe3V4FaSAwUmLwQWFbJn67TpjlQbppheTJwyWSVHYWnTGlKTECU Mou5pSBKIF/xAK7JpMEpvmwlE0HZ9Cm1Km8n+EA0fWjDU+N7TV19RpYNgi474B3l7ZCR u1Wo/zvxNLqqjmF+OloLbtR892fy814BCUH5xHpGEFz9zp7JcVTo6E2VAtbnKppc487q dEHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=raJNXmbwVqpq83KKgT3XBuMmTgFvd7SAupVC/Uzr9r0=; b=mS0c1pp5nWBcHq15ptP4UtWjhbxDLmtv3NeotN3vUGjmyHRQXNlP/gQWQ3ZA61NTF0 c84s084H0awnVtdEJjfY8gKa9gkJ+ba6KryWX2m0G9fmKG2ZAiCupWOUJmRyZM6GiVB0 478Ry1ObSYszjpR6hPQhaXlSJ9Wcp9RXBiX4AmH3v94EbaKOpuN8XVGjh3nBVgiihsge w8M+mjxCTCgVNxcdySw6XHKyoou+mewnTEGqd1Kn3FcrNbP1+EIlVpzE8Gp7P0npVVYr pY4gDm10JJpeUtYXr4oEtTmRhv8iFyaTCCiIlA5U98SPt5bpJK225junWwZovwovAr9V eMyA== X-Gm-Message-State: AJaThX47l93MlJE6SyDkjgRtuOmorSI0mZ4oWsp1v2IyvT/mkngAHRCh xwga7lK7uiFlX4jZtMSBTaM= X-Google-Smtp-Source: AGs4zMbachQ5DScqu6fIGTVu9K0pPOsiWkTCjx/gIUIy5aPfyaTZ14613bcbfulplw0z4Ac2LOeG1A== X-Received: by 10.98.200.221 with SMTP id i90mr14445573pfk.19.1512242824062; Sat, 02 Dec 2017 11:27:04 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.27.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:27:03 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 09/10] net: ethernet: korina: Handle return value of platform_get_irq_byname Date: Sun, 3 Dec 2017 00:56:21 +0530 Message-Id: <1512242782-7134-10-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq_byname() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/korina.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index ae195f8..e778504 100644 --- a/drivers/net/ethernet/korina.c +++ b/drivers/net/ethernet/korina.c @@ -1039,7 +1039,16 @@ static int korina_probe(struct platform_device *pdev) memcpy(dev->dev_addr, bif->mac, ETH_ALEN); lp->rx_irq = platform_get_irq_byname(pdev, "korina_rx"); + if (lp->rx_irq < 0) { + rc = lp->rx_irq; + goto probe_err_out; + } + lp->tx_irq = platform_get_irq_byname(pdev, "korina_tx"); + if (lp->tx_irq < 0) { + rc = lp->tx_irq; + goto probe_err_out; + } r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "korina_regs"); dev->base_addr = r->start; From patchwork Sat Dec 2 19:26:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843911 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="hFG5oE/3"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yq1PD72PFz9sBd for ; Sun, 3 Dec 2017 06:27:28 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752620AbdLBT1U (ORCPT ); Sat, 2 Dec 2017 14:27:20 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36499 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752580AbdLBT1H (ORCPT ); Sat, 2 Dec 2017 14:27:07 -0500 Received: by mail-pf0-f196.google.com with SMTP id p84so6091044pfd.3; Sat, 02 Dec 2017 11:27:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z+6CJ3RtGM8Bou5Q7udY1q++55omMoBN8Ue3KlKf4M0=; b=hFG5oE/3TJHQX6vwTxf+Q7Q7FWemU7JFMnzMpMqCtx+6oNVjsYYWbzwu2Ke1vgEIt6 6w6GY9XHeNUIwnb5E29DEP6gbb5AC4GEDTOQB90XFK7ucDHlJPtnCYkpg34DC4Gw0lfB +Auf1/rF+jZFRgZKwIxutpc2rQGJC8DpkOdJVseeDnAwZ+wMzXmwWfAuIn6UG7/cTvcs qC6m3fAiMy/e1BN+hlFw07/m4RCL8DxH2ODUMhpsGRpPdA+IiWaD1VFGJZE1CQc9uvDI HEP05+BxdB0BOuGu3sPRyyt5PJb4RnxWP/+LZRagZXHTPzqf2m+OJTpWay4SuGq2Ug7b AU8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Z+6CJ3RtGM8Bou5Q7udY1q++55omMoBN8Ue3KlKf4M0=; b=gGBBoQrvgSMTCXA+B1YaxzVU3abfuXpfIEJg44oEYhVPYgCmOHwhJGKdJrTG4FhTqU n0pZMwV5oYprNAhPFopJJlH3hntZ7vFzCXBo2gh9QVNg3G5knmMG9jUcijWck54KxwSK v6U2zpnLUHc+o97JNcygdTgwfW63C47YZc9VA6/fg92lvtzcqecwrUN6k7dnmvsUgpuZ 2moGestA6teiVHCM9A3Ygl0DfdS6zYc/ldSE2KU+x71RtYc1uXqPLuispugLy9PPpoXe X+nBorOvDNHEXJ1nUfCU/5f/DShxvwNm8sP+OxmNECqUNZWk1VVcNgGbUHG5FcD5BGAR 2Qyw== X-Gm-Message-State: AJaThX6oB4YsMOrphVYUk+TyH9FHf1K2LC9sXUuHDQGRQr1fh3qylj+I smhNehDZznSHs4OIM74DxoY= X-Google-Smtp-Source: AGs4zMaVpJk00p57hE5+qmGKq4bvf8nxMc5jhiD/XdTnuYpjGijB2Tlf/s879A2/8QewQRwdsj/MJA== X-Received: by 10.101.68.201 with SMTP id g9mr9645893pgs.149.1512242827414; Sat, 02 Dec 2017 11:27:07 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id 140sm15167899pgd.85.2017.12.02.11.27.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Dec 2017 11:27:06 -0800 (PST) From: Arvind Yadav To: wg@grandegger.com, mkl@pengutronix.de, michal.simek@xilinx.com, opendmb@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, Vladislav.Zakharov@synopsys.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH 10/10] net: ethernet: cpmac: Handle return value of platform_get_irq_byname Date: Sun, 3 Dec 2017 00:56:22 +0530 Message-Id: <1512242782-7134-11-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512242782-7134-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq_byname() can fail here and we must check its return value Signed-off-by: Arvind Yadav --- drivers/net/ethernet/ti/cpmac.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c index 9b8a30b..f3acfc0 100644 --- a/drivers/net/ethernet/ti/cpmac.c +++ b/drivers/net/ethernet/ti/cpmac.c @@ -1124,6 +1124,10 @@ static int cpmac_probe(struct platform_device *pdev) } dev->irq = platform_get_irq_byname(pdev, "irq"); + if (dev->irq < 0) { + rc = dev->irq; + goto fail; + } dev->netdev_ops = &cpmac_netdev_ops; dev->ethtool_ops = &cpmac_ethtool_ops;