From patchwork Mon Mar 2 19:06:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1247851 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=XylaXa2T; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48WV4Z5LwRz9sPK for ; Tue, 3 Mar 2020 06:06:54 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 30C6420113; Mon, 2 Mar 2020 19:06:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vx+13olJDpd0; Mon, 2 Mar 2020 19:06:51 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 3142C20108; Mon, 2 Mar 2020 19:06:51 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 14965C1AE2; Mon, 2 Mar 2020 19:06:51 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 39CBAC013E for ; Mon, 2 Mar 2020 19:06:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 1F41A20113 for ; Mon, 2 Mar 2020 19:06:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TTyC9w52yzKm for ; Mon, 2 Mar 2020 19:06:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by silver.osuosl.org (Postfix) with ESMTPS id 853CD20108 for ; Mon, 2 Mar 2020 19:06:48 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id 7so279628pgr.2 for ; Mon, 02 Mar 2020 11:06:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=B6iMqXJiCtWATILXigOZpW76492cHHABWnxAMJRQRAM=; b=XylaXa2TIFpnwdBU39K564JH75myiHR89YdZIFNw/KNILMOpsPhIq0fVsx9/TkaILz X2afUquwPA5fxHt8XhUvrxJYz89dPwqtqprFHHRHINCiobcMqSQg5Serw79Rpaw1gTuz c5kkc/eVF+TUanR5isoTdfU+OPolARSEiSuvW5eFc5h73MYIaqGb2IGlhaJsryvHpZ50 Np33QRaEWXPI+YyMauBNRjwov/ojpTCBFGjo+ntZBXYnSxFpO6KjGUoWJBObgvqe24HC vZPVCG4g/F8D8Jx/VwVGzBITEJ415mQjHblhjhlzW6WZTEvhZKBQf429aISNlhMzAyXn BZmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=B6iMqXJiCtWATILXigOZpW76492cHHABWnxAMJRQRAM=; b=AIfmMg0ANFAR5QcIi54KnRN5bkev07jnux1VReQcp5iFhfytMEa0UHCgJ56s7+tFxp 36CHF9tMRLLc5cD040ALnVO6GH6o2zaiPGGAHr30UbfuVluB8CoDO9RiXChnNedUo+gP 8gTZz7BFC0eDmGmv+n7VUEwTpsnOfrjhNhjwMZQYoVZVsPQxV3+GRQzZYkszpSVmEQQ4 Tkb4FFnhOLqLEFIrW3m3kCjn0zO2F3SLvSvIcxZRTX4Li1Zj3dJOm30IQL/c2j5rFNcD UfkXb9VDluZzoFTdPoK/vf2EJGjGJ6xyqC7RdfaprSH4hNoYSGgQPxX2b+CWDUaoisKV kZkA== X-Gm-Message-State: ANhLgQ1eIQ2d39eLWhyuNUglMaH+uBxqx+yCzvXkXjObtjRlUEwWjWyF DkHOwnrWCEsX8zt/LrxffOdfdi3Z X-Google-Smtp-Source: ADFU+vvE9bYb+qgSNKiXufzWHyex3p3ETCSwh+b3Ml0M3Qi80zJVBqGhyvS8Cx9+VduzDTHQ0igC2g== X-Received: by 2002:a65:5306:: with SMTP id m6mr350056pgq.5.1583176007685; Mon, 02 Mar 2020 11:06:47 -0800 (PST) Received: from sc9-mailhost2.vmware.com ([66.170.99.2]) by smtp.gmail.com with ESMTPSA id i22sm22031802pgi.69.2020.03.02.11.06.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 02 Mar 2020 11:06:47 -0800 (PST) From: William Tu To: dev@openvswitch.org Date: Mon, 2 Mar 2020 11:06:21 -0800 Message-Id: <1583175981-41409-1-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 Cc: yang_y_yi@163.com, fbl@sysclose.org Subject: [ovs-dev] [PATCH] doc: Add AF_PACKET limitation on userspace tso. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" For enabling TSO on devices using AF_PACKET, minimum supported kernel version is 4.19 due to a virtio GSO fix 9d2f67e43b73 ("net/packet: fix packet drop as of virtio gso") Reported-by: Yi Yang Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2020-March/368281.html Signed-off-by: William Tu --- Documentation/topics/userspace-tso.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/topics/userspace-tso.rst b/Documentation/topics/userspace-tso.rst index 0fbac93a54d7..4c2de50075d5 100644 --- a/Documentation/topics/userspace-tso.rst +++ b/Documentation/topics/userspace-tso.rst @@ -98,6 +98,10 @@ in Open vSwitch. Currently, if the NIC supports that, then the feature is enabled, otherwise TSO can still be enabled but SCTP packets sent to the NIC will be dropped. +For enabling TSO on devices using AF_PACKET, minimum supported kernel version +is 4.19. This is due to a virtio GSO fix: +9d2f67e43b73 ("net/packet: fix packet drop as of virtio gso") + There is no software implementation of TSO, so all ports attached to the datapath must support TSO or packets using that feature will be dropped on ports without TSO support. That also means guests using vhost-user