From patchwork Thu Nov 30 15:43:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843058 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RGXjb445"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ynhYZ5ZVNz9t2f for ; Fri, 1 Dec 2017 02:45:06 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752523AbdK3Pn5 (ORCPT ); Thu, 30 Nov 2017 10:43:57 -0500 Received: from mail-pl0-f68.google.com ([209.85.160.68]:41295 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750885AbdK3Pnz (ORCPT ); Thu, 30 Nov 2017 10:43:55 -0500 Received: by mail-pl0-f68.google.com with SMTP id g2so4461632pli.8; Thu, 30 Nov 2017 07:43:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nEfH5Bh5dLis5zYJ9zXMlp73VeBckIL/dlHzsQH9uA4=; b=RGXjb445dPw7YpkqFMS8Qwu3SDsG/Eo5A37xmSMzmq4YQrJbH4o/r0oKAvdxY5xUa3 OtbeGb0Hiqu4rCOytN7Uw6s+qq5LJL8+9zj/sOwR+RO9bhy0Dnq9t7DmVTo5vnegNDC0 /E4dROeXZQM3m0VRDw6Vn5PB8I7YbPBT/7VBSYNluKhTV2IBFxS3Ud17XSPGlP346p9u TD8XNCUvEYR+BJqDuWAIf9eRAxvtR+RW/rnhSch+6Tnvk29othN/M47pOROxH3n9xaHA 7yaIQmzhcM2cXv5im4yuq6z1nHQGRZt6zzZO9SBKIbp/n/OITVea1KnQ0//GcEV3XYn0 n2iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nEfH5Bh5dLis5zYJ9zXMlp73VeBckIL/dlHzsQH9uA4=; b=ekaFwzcZTQUg6k3GYvb2+59QlhUYEf/fZT6vRZ6c+kww8d3mvUJsu1VCF4AsWjYHa9 PDJ+j7Lt3s4j168WqCUXTZZTOuhpRnAQQd0SoEWYr4FM+7BuxLgA0h8EA1TjAJfEKC5v XvU9Jo3+AZZQVE3ewkjt67q7TvmfffguTHLAF3RrqVBHM4Tm0sRomNsr1Lw75RR9wgpm uCqZ1LywjpStWBNIyD1so1uzQ3ZcoBsIDTeurvdijrCT9SM0sJEt/6Qsqi9/wDWrznNQ 9Din68vfdtXrcJBtz9IkHCEV8cj9hLdG+f4KavarSwt4Oy1VXWiq3b4PHRNtmNST8rG/ YHbQ== X-Gm-Message-State: AJaThX6PEYsznaEV3Dws8tIyQLrXUH9Qu+luO+xweAgnXat4zG9aZgCs +udCvVdyfI9pqUJ9eLyjPmc= X-Google-Smtp-Source: AGs4zMbAPpfD//En2jjFQSZ6yf4WooO+GR+hQDW5+xU2QLtpwSyxoWQxN6Oq3+2y/Q0LbjEza7cLLw== X-Received: by 10.84.245.149 with SMTP id j21mr3049046pll.315.1512056634729; Thu, 30 Nov 2017 07:43:54 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id f79sm8687440pfd.45.2017.11.30.07.43.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 30 Nov 2017 07:43:53 -0800 (PST) From: Arvind Yadav To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, samuel@sortiz.org Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, netdev@vger.kernel.org Subject: [PATCH 1/3] iio: trigger: Fix platform_get_irq's error checking Date: Thu, 30 Nov 2017 21:13:34 +0530 Message-Id: <1512056616-21065-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512056616-21065-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512056616-21065-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c index d80dcf8..f389f5c 100644 --- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c +++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c @@ -187,9 +187,9 @@ static int iio_bfin_tmr_trigger_probe(struct platform_device *pdev) return -ENOMEM; st->irq = platform_get_irq(pdev, 0); - if (!st->irq) { + if (st->irq < 0) { dev_err(&pdev->dev, "No IRQs specified"); - return -ENODEV; + return st->irq; } ret = iio_bfin_tmr_get_number(st->irq); From patchwork Thu Nov 30 15:43:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843056 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ayUCdk1y"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ynhXf4TtGz9sDB for ; Fri, 1 Dec 2017 02:44:18 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752768AbdK3PoD (ORCPT ); Thu, 30 Nov 2017 10:44:03 -0500 Received: from mail-pl0-f66.google.com ([209.85.160.66]:35510 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752434AbdK3Pn7 (ORCPT ); Thu, 30 Nov 2017 10:43:59 -0500 Received: by mail-pl0-f66.google.com with SMTP id b96so4461908pli.2; Thu, 30 Nov 2017 07:43:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=u3ynJGXQvttubZHaexcDCdkB6RlV0mhYgQRg7YbCDyE=; b=ayUCdk1ygl7Now8NWBph0ZLD6MUzgUKV+kc8WMv1rylOV8zoBd4/la/V3hdwvubnR2 vzoe5dAAoh5FR8niJSV9zlkm79h0JB/QU5lFU7UMnQnkUWqZ4L7HKRLeUx+fNZ5UjARX K5aEIQb5erHGJZPxBNl3xtd/XwD4J6oAcM91Gz+e1irOhOodhtQq/ffQt2CIGvWk8KIh Lk7Hb4xYqLxdSMe2+CG+F8go40IHVsi13gs1y68KbMV+bDNQdDULU6y+b91mLUcDBvOQ XFAzO2hrUv9+E22QTBE5h7jD1e1qD9DDmYX9xUHt/0Z32TUNy995MjnPiOzWjS3Jn8Si j7Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=u3ynJGXQvttubZHaexcDCdkB6RlV0mhYgQRg7YbCDyE=; b=EMPhtC4CYZK/yjNyN8I3DIzbevohJ6XvFLWnAh00+/MwcnuKl9aJd0HIa08Fj0yn53 x2eqRueVZGbDCcCxnox4hENCDGQ33pigTZU85XEtx3g2P67Dk+qMomSqKsZ1RxR3kLUb tPOsfWbkgDmmrSHq1yOqbZNIUevXxlM7QYCCHqI9J8pU9+szhKX1rQJEI00VqKm60/3J aqz3DBU4/LNGkouAWLdNDtRAoeiJ13y294305Uj4VqkvfMX2vVayBFryYSjo9aAwplP2 JWE0S0m+6AEqTvN8INomb62lkb847JflB1kkx6tCAmF8ltKPG+SFu93QD9jwpLQ/Vmhu 2e0g== X-Gm-Message-State: AJaThX7bJBLOmgQXynITGyWA+k7oRE2YzxGkNn9qMmDJOhexyUKU8MFS U017zLtWkau84HozVvoxSyA= X-Google-Smtp-Source: AGs4zMZiQOQNYqo8vGTfGdbyb8Sm9Xs9zZ4JB49QFYhnUF1O2vku7Iz0hOCQ/eCFNygw4ZCFU/1Nrg== X-Received: by 10.84.131.40 with SMTP id 37mr3077220pld.302.1512056638489; Thu, 30 Nov 2017 07:43:58 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id f79sm8687440pfd.45.2017.11.30.07.43.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 30 Nov 2017 07:43:57 -0800 (PST) From: Arvind Yadav To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, samuel@sortiz.org Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, netdev@vger.kernel.org Subject: [PATCH 2/3] staging: irda: Handle return value of platform_get_irq Date: Thu, 30 Nov 2017 21:13:35 +0530 Message-Id: <1512056616-21065-3-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512056616-21065-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512056616-21065-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/staging/irda/drivers/pxaficp_ir.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/staging/irda/drivers/pxaficp_ir.c b/drivers/staging/irda/drivers/pxaficp_ir.c index 1dba16b..a97ce04 100644 --- a/drivers/staging/irda/drivers/pxaficp_ir.c +++ b/drivers/staging/irda/drivers/pxaficp_ir.c @@ -960,7 +960,17 @@ static int pxa_irda_probe(struct platform_device *pdev) si->irda_base = ficp; si->stuart_base = stuart; si->uart_irq = platform_get_irq(pdev, 0); + if (si->uart_irq < 0) { + err = si->uart_irq; + goto err_mem_1; + } + si->icp_irq = platform_get_irq(pdev, 1); + if (si->icp_irq < 0) { + err = si->icp_irq; + goto err_mem_1; + } + si->sir_clk = devm_clk_get(&pdev->dev, "UARTCLK"); si->fir_clk = devm_clk_get(&pdev->dev, "FICPCLK"); From patchwork Thu Nov 30 15:43:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 843057 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kZkUfnLO"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ynhYM5F3xz9sDB for ; Fri, 1 Dec 2017 02:44:55 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752967AbdK3Pob (ORCPT ); Thu, 30 Nov 2017 10:44:31 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33873 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752031AbdK3PoC (ORCPT ); Thu, 30 Nov 2017 10:44:02 -0500 Received: by mail-pg0-f65.google.com with SMTP id j4so3151355pgp.1; Thu, 30 Nov 2017 07:44:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gL3nY7mYK+SWKmOb1csdebApUEU1YWkZQpCSHnoosEo=; b=kZkUfnLOSZA1tQ3LHmKxCSZDB8rraggr3dMMxmmTYGa7KaP2JTaF7+KB5lxb8xzLUU gX9YS5t/1S3eZs1kF2BCWDgDBqCTUSaYZ0M8D+ugQ6nr9FYBlCaKrs1UwuvMo/4vmAIP UVNz88XEvlJrVO1iaNQwyUEU3hNbwNgiuKMYAI/yv8NtYPVBz+euD081p+z0/pE+npK2 /SFdTIbbVhoLbCFVN0fkiLj4PZRoYa/LpZJYEwZdEULNEeZhL+N6gDqGJZJ0A1whO1fL 1NRH6E4wcXs6bSfa21UNhYYjnZEWr2FHuRPiWXKkaHmtx0bi4ODFyWGJhkyPd4dZKook PRGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gL3nY7mYK+SWKmOb1csdebApUEU1YWkZQpCSHnoosEo=; b=BxF541zIRBp6BvwsCB8iv57IgyARchJIUKfCwxanlte+BU5HH986z/kxULEQleMnyY HS5VDKmk1+CphIQvwfpANBRk/ESjL8Mt6HGeqY9D5+NK7MmS8HiT+eOzQTZw3oZPQbHN M7X5EOfNR9u4t3lpwDeJTlQFl0rTHEnscXQnm/yK4qZwBvPlr7duQ9pvfiGgaUydn1Jo pZVhLhUuJTkjf0QlOfFGeCVGy+Dbg3DbSMV3MStPapTIGcmBsCZpubMUh+kyxvHrR4q0 nnReBzkPfUXcp5HyrxsQF9RcnPp1sSFSKq7sEk+Ax31JwyxB11RzoueVAdOFqzgRFEIX 1wtg== X-Gm-Message-State: AJaThX7eUqBDEWeQ/E/Hk6JUYVUHQSEzVHsiM+L/6xp9K6W29VV8iVCD BXspiFQaBWsy63t8s9JDdPQ= X-Google-Smtp-Source: AGs4zMa18yGw790KuJVoJWF9l1B5llZd7Aa+A7XR0hsw4kVvz0zir9D5E/M40goDpBQ+MMU6FpsJSw== X-Received: by 10.101.70.70 with SMTP id k6mr2735090pgr.292.1512056641986; Thu, 30 Nov 2017 07:44:01 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id f79sm8687440pfd.45.2017.11.30.07.43.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 30 Nov 2017 07:44:01 -0800 (PST) From: Arvind Yadav To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, samuel@sortiz.org Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, netdev@vger.kernel.org Subject: [PATCH 3/3] staging: irda: Remove unnecessary 'err' initialization. Date: Thu, 30 Nov 2017 21:13:36 +0530 Message-Id: <1512056616-21065-4-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1512056616-21065-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1512056616-21065-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Here, variable 'err' is already initialised. So no need to reinitialize. Signed-off-by: Arvind Yadav --- drivers/staging/irda/drivers/pxaficp_ir.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/irda/drivers/pxaficp_ir.c b/drivers/staging/irda/drivers/pxaficp_ir.c index a97ce04..6c77370 100644 --- a/drivers/staging/irda/drivers/pxaficp_ir.c +++ b/drivers/staging/irda/drivers/pxaficp_ir.c @@ -807,7 +807,6 @@ static int pxa_irda_start(struct net_device *dev) * Open a new IrLAP layer instance. */ si->irlap = irlap_open(dev, &si->qos, "pxa"); - err = -ENOMEM; if (!si->irlap) goto err_irlap;