From patchwork Thu Feb 20 14:43:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 1241460 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=inria.fr Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48Ncm211F3z9sRG for ; Fri, 21 Feb 2020 01:43:46 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728317AbgBTOnm (ORCPT ); Thu, 20 Feb 2020 09:43:42 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:44391 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727298AbgBTOnm (ORCPT ); Thu, 20 Feb 2020 09:43:42 -0500 X-IronPort-AV: E=Sophos;i="5.70,464,1574118000"; d="scan'208";a="339864857" Received: from unknown (HELO hadrien) ([132.227.124.212]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2020 15:43:40 +0100 Date: Thu, 20 Feb 2020 15:43:40 +0100 (CET) From: Julia Lawall X-X-Sender: julia@hadrien To: Jack Ping CHNG cc: Jeff Kirsher , Amireddy Mallikarjuna reddy , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kbuild-all@lists.01.org Subject: [PATCH] gwdpa: gswip: fix odd_ptr_err.cocci warnings Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: kbuild test robot PTR_ERR should typically access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Fixes: 69fab0a67a95 ("gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver") CC: Jack Ping CHNG Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- Maybe the code is correct, but just unnecessarily obscure. tree: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue head: 7a6fc7fc71cf6316739b60fcffdb86e0c43f99b5 commit: 69fab0a67a95208a25af95de20a0301298ee23f6 [43/47] gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver :::::: branch date: 9 hours ago :::::: commit date: 9 hours ago gswip_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/intel/gwdpa/gswip/gswip_dev.c +++ b/drivers/net/ethernet/intel/gwdpa/gswip/gswip_dev.c @@ -96,7 +96,7 @@ static int np_gswip_parse_dt(struct plat pdata->sw_clk = devm_clk_get(dev, "switch"); if (IS_ERR(pdata->sw_clk)) - return PTR_ERR(priv->pdata.sw_clk); + return PTR_ERR(pdata->sw_clk); for_each_node_by_name(node, GSWIP_MAC_DEV_NAME) { priv->num_subdev_mac++;