From patchwork Mon Feb 3 11:25:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Schwab X-Patchwork-Id: 1232717 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-109118-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha1 header.s=default header.b=JK2QbUaK; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48B58y45T9z9sPK for ; Mon, 3 Feb 2020 22:25:22 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type; q=dns; s=default; b=Kl6wTpZUrTInlSVvgpb/BblrH2vl0 z8cAKFobVrLnqn+KEeKQtHJx/c2Jd1Yw1dqUpbmxAkvFXBqnVemjfyXsPviKPA+n lFdZVWWukMO3nl+nWWRJYtpdkDBda/Wo3utSS0Pkui9zpnEvTun52hzakDVUA4rL isFZoEce2xORmg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:mime-version :content-type; s=default; bh=DPZmtSpI0v5BHcmq4lDdiet49PA=; b=JK2 QbUaKBDCMYDrHgog3Dzam3L8t9H4A3WPZGNweh3qkEpxjj7BD+gS44NZUUCuR4WS pnFpWaPstcWK3693NbQ79QHrv8mG3Jtz6BUQJRCJIvx8H03tP5szIySmNMCFLzij kyP11NXPTXCbWPjZrrrwFr9BPVEEXOf6hnyoM8b0= Received: (qmail 6156 invoked by alias); 3 Feb 2020 11:25:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 6144 invoked by uid 89); 3 Feb 2020 11:25:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy=labs, Labs X-HELO: mx2.suse.de From: Andreas Schwab To: libc-alpha@sourceware.org Subject: [PATCH] Use correct exit status in ldd (bug 24150) X-Yow: ...PENGUINS are floating by... Date: Mon, 03 Feb 2020 12:25:11 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 The message "not a dynamic executable" is not an error, so don't exit with a nonzero status. --- elf/ldd.bash.in | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/elf/ldd.bash.in b/elf/ldd.bash.in index 467cbf44e9..a879ddd640 100644 --- a/elf/ldd.bash.in +++ b/elf/ldd.bash.in @@ -166,10 +166,7 @@ warning: you do not have execution permission for" "\`$file'" >&2 case $ret in 1) # This can be a non-ELF binary or no binary at all. - nonelf "$file" || { - echo $" not a dynamic executable" >&2 - result=1 - } + nonelf "$file" || echo $" not a dynamic executable" ;; 0|2) try_trace "$RTLD" "$file" || result=1