From patchwork Tue Nov 28 21:38:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 842326 X-Patchwork-Delegate: sr@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZYWXgYr5"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3ymcVx0fMDz9ryk for ; Wed, 29 Nov 2017 08:39:03 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 4719CC21DA9; Tue, 28 Nov 2017 21:38:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 565ABC21D75; Tue, 28 Nov 2017 21:38:53 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id B9B5FC21D75; Tue, 28 Nov 2017 21:38:52 +0000 (UTC) Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66]) by lists.denx.de (Postfix) with ESMTPS id B6E03C21D56 for ; Tue, 28 Nov 2017 21:38:50 +0000 (UTC) Received: by mail-pg0-f66.google.com with SMTP id j9so507317pgc.11 for ; Tue, 28 Nov 2017 13:38:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=sduWadRAMkXEy/JEk5HEUc634yiVEU1tt/XnVa4p7WU=; b=ZYWXgYr50QlDAs8XGyqwYP0u7jWbrGHsPhz5WAilBl35XYVaPbSz7rQkQWmWfG+uMz afLi0TZ2+Qlyfhm6pIFmX2tgioEJC867R/xlXA/UCoh8XtulMNwszf3V7NhsWfN/EYL9 PVcCUM05lgXmxfg9B244/EkI1J8GqH9H4dZtY8DBvfbF8Yg28wptxys3BEAAUDgtCMLp xOZp2VkvQKZl1ilOr6Pq/dgK1V0WtKLIzsSz42C0PmEZ441CnxC0LMVQEcl1mXfMw7ex Jo7voKAfJyNu9+BGw2yDST/IpbMOd7UdHEvdJgvOHi/T0hujNO3alHXTLlgdlWG7giJn NAmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=sduWadRAMkXEy/JEk5HEUc634yiVEU1tt/XnVa4p7WU=; b=Y1lM8LtZlPkshjyA4+uQDYESbDmQy7R8cJws9ELTxSovFa3yMtkhdHaEOdtKH0xZw9 Y/sUJ5liKYXHGiGRb9MQO9PFZRp7ZlGK0IPT47Mu4dtQrf+xwxnKxjUd2MFvLZLbrviY wUDUFpc9inhAYCyEBKFqRzssGd7vR5UIUt23zYNeI3zpmiKZJ2cBu9lqj+aNiSNb0LI7 zjOdkX8J0xMR+s0XmKwFURKV6PP8GHlkRND/vmg12gOaEp2uFgdEvOQkbpPI5NvmSwNX HDgkmMHldmBzS8BfE5M/KcJ6RLXxKNXirfCd0edB8gUnPxqhuFp2KAVJBl5GoUiEOeG/ faHg== X-Gm-Message-State: AJaThX4rb0Lmj1L6Rlbm6rtHH7ofHWtVOu9RNUgRm3qyBwek5WnovG5N z7ZkY0+UQtpVH0pRPWaZS9oOXGzU X-Google-Smtp-Source: AGs4zMYZdKCv7ht5TOQuUeDOO6pqvkovumR6NvFB4dBYwEVlW7MKaZJxm7w3bYJHkKULbrMZaqXalQ== X-Received: by 10.101.67.140 with SMTP id m12mr522687pgp.51.1511905128932; Tue, 28 Nov 2017 13:38:48 -0800 (PST) Received: from chrisp-dl.ws.atlnz.lc ([2001:df5:b000:22:3a2c:4aff:fe70:2b02]) by smtp.gmail.com with ESMTPSA id j14sm122060pfj.93.2017.11.28.13.38.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 Nov 2017 13:38:48 -0800 (PST) From: Chris Packham To: u-boot@lists.denx.de Date: Wed, 29 Nov 2017 10:38:34 +1300 Message-Id: <20171128213834.13102-1-judge.packham@gmail.com> X-Mailer: git-send-email 2.15.0 Cc: Mario Six , Chris Packham , Dirk Eibach , Stefan Roese , Chris Packham Subject: [U-Boot] [PATCH] arm: mvebu: correct comments around cas_wl/cas_l X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The order of members in struct hws_topology_map is cas_wl, cas_l. The comments in the original db-88f6820-gp.c had this wrong and have been copied to other Armada-385 based boards. Practically this hasn't made a difference since all these boards set both cas_wl and cas_l to 0 (autodetect) but if there were ever a board that did need to set these explicitly they would run into unexpected issued. Update the comments to reflect the correct order of structure members. Reported-by: Tobi Wulff Signed-off-by: Chris Packham Reviewed-by: Stefan Roese --- board/CZ.NIC/turris_omnia/turris_omnia.c | 4 ++-- board/Marvell/db-88f6820-amc/db-88f6820-amc.c | 2 +- board/Marvell/db-88f6820-gp/db-88f6820-gp.c | 2 +- board/gdsys/a38x/controlcenterdc.c | 2 +- board/solidrun/clearfog/clearfog.c | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c index af66837909de..b03c0a3714b1 100644 --- a/board/CZ.NIC/turris_omnia/turris_omnia.c +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c @@ -212,7 +212,7 @@ static struct hws_topology_map board_topology_map_1g = { BUS_WIDTH_16, /* memory_width */ MEM_4G, /* mem_size */ DDR_FREQ_800, /* frequency */ - 0, 0, /* cas_l cas_wl */ + 0, 0, /* cas_wl cas_l */ HWS_TEMP_NORMAL, /* temperature */ HWS_TIM_2T} }, /* timing (force 2t) */ 5, /* Num Of Bus Per Interface*/ @@ -231,7 +231,7 @@ static struct hws_topology_map board_topology_map_2g = { BUS_WIDTH_16, /* memory_width */ MEM_8G, /* mem_size */ DDR_FREQ_800, /* frequency */ - 0, 0, /* cas_l cas_wl */ + 0, 0, /* cas_wl cas_l */ HWS_TEMP_NORMAL, /* temperature */ HWS_TIM_2T} }, /* timing (force 2t) */ 5, /* Num Of Bus Per Interface*/ diff --git a/board/Marvell/db-88f6820-amc/db-88f6820-amc.c b/board/Marvell/db-88f6820-amc/db-88f6820-amc.c index ac58f9085266..7db0095f75ef 100644 --- a/board/Marvell/db-88f6820-amc/db-88f6820-amc.c +++ b/board/Marvell/db-88f6820-amc/db-88f6820-amc.c @@ -68,7 +68,7 @@ static struct hws_topology_map board_topology_map = { BUS_WIDTH_8, /* memory_width */ MEM_2G, /* mem_size */ DDR_FREQ_800, /* frequency */ - 0, 0, /* cas_l cas_wl */ + 0, 0, /* cas_wl cas_l */ HWS_TEMP_LOW, /* temperature */ HWS_TIM_DEFAULT} }, /* timing */ 5, /* Num Of Bus Per Interface*/ diff --git a/board/Marvell/db-88f6820-gp/db-88f6820-gp.c b/board/Marvell/db-88f6820-gp/db-88f6820-gp.c index a1974cb4bd21..b95cd1d4aab5 100644 --- a/board/Marvell/db-88f6820-gp/db-88f6820-gp.c +++ b/board/Marvell/db-88f6820-gp/db-88f6820-gp.c @@ -89,7 +89,7 @@ static struct hws_topology_map board_topology_map = { BUS_WIDTH_8, /* memory_width */ MEM_4G, /* mem_size */ DDR_FREQ_800, /* frequency */ - 0, 0, /* cas_l cas_wl */ + 0, 0, /* cas_wl cas_l */ HWS_TEMP_LOW, /* temperature */ HWS_TIM_DEFAULT} }, /* timing */ 5, /* Num Of Bus Per Interface*/ diff --git a/board/gdsys/a38x/controlcenterdc.c b/board/gdsys/a38x/controlcenterdc.c index 32168d35768a..3d74a6dfb897 100644 --- a/board/gdsys/a38x/controlcenterdc.c +++ b/board/gdsys/a38x/controlcenterdc.c @@ -52,7 +52,7 @@ static struct hws_topology_map ddr_topology_map = { BUS_WIDTH_16, /* memory_width */ MEM_4G, /* mem_size */ DDR_FREQ_533, /* frequency */ - 0, 0, /* cas_l cas_wl */ + 0, 0, /* cas_wl cas_l */ HWS_TEMP_LOW, /* temperature */ HWS_TIM_DEFAULT} }, /* timing */ 5, /* Num Of Bus Per Interface*/ diff --git a/board/solidrun/clearfog/clearfog.c b/board/solidrun/clearfog/clearfog.c index 8906636f7646..1472e9793e5f 100644 --- a/board/solidrun/clearfog/clearfog.c +++ b/board/solidrun/clearfog/clearfog.c @@ -82,7 +82,7 @@ static struct hws_topology_map board_topology_map = { BUS_WIDTH_16, /* memory_width */ MEM_4G, /* mem_size */ DDR_FREQ_800, /* frequency */ - 0, 0, /* cas_l cas_wl */ + 0, 0, /* cas_wl cas_l */ HWS_TEMP_LOW, /* temperature */ HWS_TIM_DEFAULT} }, /* timing */ 5, /* Num Of Bus Per Interface*/