From patchwork Tue Jan 28 21:02:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: DJ Delorie X-Patchwork-Id: 1230654 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-109007-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha1 header.s=default header.b=lUTK+3Q9; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FIVKb+eV; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 486fGW4JGWz9sNT for ; Wed, 29 Jan 2020 08:03:15 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:message-id:from:to:subject:content-type :content-transfer-encoding; q=dns; s=default; b=MkAjn7dgvG8p8DDU gyKfk8tEAIErzf+HTZE0K2sXzLV+PZOgmMWAmtNDUztsZvgVrdXO9XHG4UbKZS8N c4d4JyVp7ZuAB7jyjZxhLQjrTbrfjAOz++n9NF+eyST1Ubqp/1mZqPcybJYBfLUO KpIv4tKc0JVyAZUMh4/DXn0p1Mw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:message-id:from:to:subject:content-type :content-transfer-encoding; s=default; bh=nJdJCCwX9n46FDM2o57QRn bU5t8=; b=lUTK+3Q9tQxQTk3vXeEvGOnu7qmymTEGUzQKcgr85R+v3KZpNTOSTb Ih956gNvZFXz/Lk+t/bZxwEq10u9b5V9u2XJN7S7s9xuxjPijr/057FQg9JiTH3i jLOCAQJwHo+B1m2ePBSwm1xTCEqIE3Cfuk3GmLgne5VdHfjY20pPY= Received: (qmail 78047 invoked by alias); 28 Jan 2020 21:03:09 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 78037 invoked by uid 89); 28 Jan 2020 21:03:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=filterout, filter-out X-HELO: us-smtp-delivery-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580245386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RpVFrzf+juUGTp7PtWDkwGxDq1uZg8y8TvahwLR9oHY=; b=FIVKb+eViXPjzX275zgZb+uQ1Uy+JPtaLSxhiVHS32EqW+fm+80xs3pHUHEWqAdFC54mwK nhJr4f3WLnjxJdrZ5/yhPK6HK7E2VFYXrLR2Ub8I0Bw48ekNllSBut94o2dDaJKHokckvF q7c/W6Nf4VjLc4e/CqRqrRdqe47kJEs= Date: Tue, 28 Jan 2020 16:02:47 -0500 Message-Id: From: DJ Delorie To: libc-alpha@sourceware.org Subject: containerize nptl/tst-pthread-getaddr X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com As found and discussed in a Fedora bug... https://bugzilla.redhat.com/show_bug.cgi?id=1653942 This test depends on the kernel's assignment of memory regions, but running under ld.so explicitly changes those assignments, sometimes sufficiently to cause the test to fail (esp with address space randomization). The easiest way to "fix" the test, is to run it the way the user would - without ld.so. Running it in a container does that. There are other ways to make this test not fail (see bz) but I'm not sure if any of those ways retain the vailidity of the test. Reviewed-by: Carlos O'Donell diff --git a/nptl/Makefile b/nptl/Makefile index 584e0ffd96..ae530a5bae 100644 --- a/nptl/Makefile +++ b/nptl/Makefile @@ -296,7 +296,7 @@ tests = tst-attr1 tst-attr2 tst-attr3 tst-default-attr \ tst-exec1 tst-exec2 tst-exec3 tst-exec4 tst-exec5 \ tst-exit1 tst-exit2 tst-exit3 \ tst-stdio1 tst-stdio2 \ - tst-stack1 tst-stack2 tst-stack3 tst-stack4 tst-pthread-getattr \ + tst-stack1 tst-stack2 tst-stack3 tst-stack4 \ tst-pthread-attr-affinity tst-pthread-mutexattr \ tst-unload \ tst-dlsym1 \ @@ -326,6 +326,8 @@ tests = tst-attr1 tst-attr2 tst-attr3 tst-default-attr \ tst-rwlock-tryrdlock-stall tst-rwlock-trywrlock-stall \ tst-unwind-thread +tests-container = tst-pthread-getattr + tests-internal := tst-rwlock19 tst-rwlock20 \ tst-sem11 tst-sem12 tst-sem13 \ tst-barrier5 tst-signal7 tst-mutex8 tst-mutex8-static \ @@ -642,7 +644,7 @@ ifeq ($(build-shared),yes) $(addprefix $(objpfx), \ $(filter-out $(tests-static) $(xtests-static) $(tests-reverse) \ $(tests-nolibpthread), \ - $(tests) $(tests-internal) $(xtests) $(test-srcs))): \ + $(tests) $(tests-internal) $(xtests) $(test-srcs) $(tests-container))): \ $(objpfx)libpthread.so $(objpfx)tst-unload: $(libdl) # $(objpfx)../libc.so is used instead of $(common-objpfx)libc.so,