From patchwork Tue Jan 28 12:03:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Wunderlich X-Patchwork-Id: 1230303 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=public-files.de Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=EutWaDVk; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 486QJP1RkLz9sNF for ; Tue, 28 Jan 2020 23:04:01 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 70E0281ADC; Tue, 28 Jan 2020 13:03:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=public-files.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="EutWaDVk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 082ED81ADD; Tue, 28 Jan 2020 13:03:50 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 97E35817F2 for ; Tue, 28 Jan 2020 13:03:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=public-files.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=frank-w@public-files.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1580213011; bh=pGbUR6AXufeJzx50zei3gfwQ9Yy0eVOHt6cLO+H0Hv8=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=EutWaDVkrbJ6kvM/eOorV+Ev6PiSOLx5Gpod51EAvONZzOMP49EXz7M+MfOEH9v2i 5IzRerhFXt7SqSX0AELHtYR/5jL24yERNx7xRTv+Uh6W3dqWxtKWdi8oEwixMoSRQ5 c4+23ISPZEgtJfsrxTjmN9/pubVct+wuTjNBO2b0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [80.208.215.171] ([80.208.215.171]) by web-mail.gmx.net (3c-app-gmx-bs07.server.lan [172.19.170.56]) (via HTTP); Tue, 28 Jan 2020 13:03:31 +0100 MIME-Version: 1.0 Message-ID: From: "Frank Wunderlich" To: "Tom Rini" Subject: Aw: Re: [U-boot, 4/4] configs: mediatek: enable mt7622 ethernet support Date: Tue, 28 Jan 2020 13:03:31 +0100 Importance: normal Sensitivity: Normal In-Reply-To: <20200127184906.GA21028@bill-the-cat> References: <20200121113200.24259-1-Mark-MC.Lee@mediatek.com> <20200121113200.24259-5-Mark-MC.Lee@mediatek.com> <20200127184906.GA21028@bill-the-cat> X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K1:HDtDDyJwn+Gk8OT7Ev2aza0UalVrNIoZyWG2vZigabnviD9mUdHGDslqgMuQqYrfmHpf1 Dm2Ypqv26U9dyXcEiW+HwniFHcVQFqxUrGkem6zZqVtxBT0CCIt9aSKUNpvyt30Ev25fGgkxNRs8 bGaSvMoQeQp0mdDyq6+dTd90QT9ORRPD+sWTMWwWUx+w74kfoBZh/R0PMPAC+QoPHMabX6lH7SbS JBgxuYVmcNuCUj0UDKsl3wOsq879ihwFE4gY71Fp1bzTpV9z+gdVcTpbhAq0yO/T8jjXOuyT7X7q ls= X-UI-Out-Filterresults: notjunk:1; V03:K0:McDCdqgngwQ=:GGWgVdC+QonNLguV5qfU6u SJlEvsOvGj4F1E7QcxJIrUmsZFAo58XfMN7HvKnMc6pZjbIGUwdhI5NyzcyAFmmq0hTGivdA7 4KsQ2/yontC+v4EmyfQ1t1yXB5hbDQ1xKhHLW/y1aDQJD+qw+pB5dftOAIJsuVSXa5pZ3l55B b/GfE2YZ/wmXCVRx2vdTsLznivWdD39QVFfc8Jot5fqMMHkY5y3Spqf/cnqw7LCQ+cQJ/exAs tH2nVL+/XECRAv18871N+Cv36xP+qfq9T4xRaadsVqd++GytotSVwCV74RlfQZc4XhgB3LKVB OknrGRgXifyr/7XSWy14T7ieL77+hphVHgju9sJynJNX6SXhLbDVKduE68dhu/g62eQQvivtl iWhz3JVm/FuVIIYqeMCL10TlqZ6oKadMEVLV+EA+PUrLHpRwQ6//qroM3q4vqRsTOg5C8jaRC NIOpFuBKjGPI9f55WlyX9bFoKtzKQNdRL6zLEO8hedQw6R0j+/29yBY5ZgtKLklBnos+6Jnah TUXlojsIIk6hmL5yhSdd0wtvyUynJZCGWEl+5nseuekmj6OdfIFoGj5djif26saYJa+3YkJ5X BZ/KNiGiT2APsj8phMCJnn4m2sPvHUEAhWyKj9h/e75OY7DoY0rDRRngORlpKOZpDs5w3UI8/ 4vD+0Vw4C93mXe8zeEF4St3TGtbaZJswUEtsiYMf27rBTtYXDVFQ1GbdnBURm80mt1QE= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.26 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Albert Aribaud , Ryder Lee , Steven Liu , u-boot@lists.denx.de, Joe Hershberger , GSS_MTK_Uboot_upstream , MarkLee Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.101.4 at phobos.denx.de X-Virus-Status: Clean Hi tom, thanks for testing imho the first 3 can be fixed by this: did not get the last 2 (after fixing the first 3)... i can send full patch if it's ok regards Frank > Gesendet: Montag, 27. Januar 2020 um 19:49 Uhr > Von: "Tom Rini" > An: MarkLee > Cc: "Albert Aribaud" , "Ryder Lee" , "Steven Liu" , "Joe Hershberger" , u-boot@lists.denx.de, GSS_MTK_Uboot_upstream > Betreff: Re: [U-boot,4/4] configs: mediatek: enable mt7622 ethernet support > > On Tue, Jan 21, 2020 at 07:32:00PM +0800, MarkLee wrote: > > > This patch enable mt7622 ethernet support in its defconfig > > > > Signed-off-by: MarkLee > > --- > > configs/mt7622_rfb_defconfig | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/configs/mt7622_rfb_defconfig b/configs/mt7622_rfb_defconfig > > index e1917e70e7..806087a3d6 100644 > > --- a/configs/mt7622_rfb_defconfig > > +++ b/configs/mt7622_rfb_defconfig > > @@ -34,6 +34,10 @@ CONFIG_SPI_FLASH_SPANSION=y > > CONFIG_SPI_FLASH_STMICRO=y > > CONFIG_SPI_FLASH_WINBOND=y > > CONFIG_DM_ETH=y > > +CONFIG_PHY_FIXED=y > > +CONFIG_MEDIATEK_ETH=y > > +CONFIG_NET_RANDOM_ETHADDR=y > > +CONFIG_CMD_PING=y > > CONFIG_PINCTRL=y > > CONFIG_PINCONF=y > > CONFIG_PINCTRL_MT7622=y > > This leads to warnings in the ethernet driver: > drivers/net/mtk_eth.c: In function 'mtk_eth_fifo_init': > drivers/net/mtk_eth.c:856:21: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > flush_dcache_range((u32)pkt_base, (u32)(pkt_base + TOTAL_PKT_BUF_SIZE)); > ^ > drivers/net/mtk_eth.c:856:36: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > ^ > drivers/net/mtk_eth.c: In function 'mtk_eth_send': > drivers/net/mtk_eth.c:968:21: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > flush_dcache_range((u32)pkt_base, (u32)pkt_base + > drivers/net/mtk_eth.c:968:36: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > drivers/net/mtk_eth.c: In function 'mtk_eth_recv': > drivers/net/mtk_eth.c:994:26: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > invalidate_dcache_range((u32)pkt_base, (u32)pkt_base + > ^ > drivers/net/mtk_eth.c:994:41: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > ^ > drivers/net/mtk_eth.c: In function 'mtk_eth_probe': > drivers/net/mtk_eth.c:1026:18: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] > priv->fe_base = (void *)iobase; > ^ > drivers/net/mtk_eth.c:1029:20: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] > priv->gmac_base = (void *)(iobase + GMAC_BASE); > > -- > Tom > diff --git a/drivers/net/mtk_eth.c b/drivers/net/mtk_eth.c index 6cffc3f32a..d13020a624 100644 --- a/drivers/net/mtk_eth.c +++ b/drivers/net/mtk_eth.c @@ -853,7 +853,7 @@ static void mtk_eth_fifo_init(struct mtk_eth_priv *priv) memset(priv->rx_ring_noc, 0, NUM_RX_DESC * sizeof(struct pdma_rxdesc)); memset(priv->pkt_pool, 0, TOTAL_PKT_BUF_SIZE); - flush_dcache_range((u32)pkt_base, (u32)(pkt_base + TOTAL_PKT_BUF_SIZE)); + flush_dcache_range((int)pkt_base, (int)(pkt_base + TOTAL_PKT_BUF_SIZE)); priv->rx_dma_owner_idx0 = 0; priv->tx_cpu_owner_idx0 = 0; @@ -965,7 +965,7 @@ static int mtk_eth_send(struct udevice *dev, void *packet, int length) pkt_base = (void *)phys_to_virt(priv->tx_ring_noc[idx].txd_info1.SDP0); memcpy(pkt_base, packet, length); - flush_dcache_range((u32)pkt_base, (u32)pkt_base + + flush_dcache_range((int)pkt_base, (int)pkt_base + roundup(length, ARCH_DMA_MINALIGN)); priv->tx_ring_noc[idx].txd_info2.SDL0 = length; @@ -991,8 +991,8 @@ static int mtk_eth_recv(struct udevice *dev, int flags, uchar **packetp) length = priv->rx_ring_noc[idx].rxd_info2.PLEN0; pkt_base = (void *)phys_to_virt(priv->rx_ring_noc[idx].rxd_info1.PDP0); - invalidate_dcache_range((u32)pkt_base, (u32)pkt_base + - roundup(length, ARCH_DMA_MINALIGN)); + invalidate_dcache_range((int)pkt_base, (unsigned int)(pkt_base + + roundup(length, ARCH_DMA_MINALIGN))); if (packetp) *packetp = pkt_base;