From patchwork Wed Jan 22 08:56:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sven Auhagen X-Patchwork-Id: 1227123 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=voleatech.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=voleatech.de header.i=@voleatech.de header.a=rsa-sha256 header.s=selector2 header.b=F5TJjUzr; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 482fQr73fNz9sP6 for ; Wed, 22 Jan 2020 19:56:36 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726049AbgAVI4f (ORCPT ); Wed, 22 Jan 2020 03:56:35 -0500 Received: from mail-eopbgr30123.outbound.protection.outlook.com ([40.107.3.123]:45215 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725862AbgAVI4f (ORCPT ); Wed, 22 Jan 2020 03:56:35 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jYi+Ap+C6vuAaIRKMZwpEqxeOsJXUDle37LfUmXHD08G63QoXm/uhnJsourr+kVGS68T+q/0rKTYcssPylqlLSiFw4wyCd23THEBsOs5ERII7cJqjfMOZudYHWE3krp5k+/r+COUCTPFW5jK46LU+hMZUGknshCn1zQw3cERNKihkkKGIbmJXOrS8Ld0kTUfRi0AlpN48K/8lnwgX5QYfEclmk+U7Z8dQVJnVGTjJboQ3FMpQnmsP7xMnb2xo1P1kD1skZbrqnSRv3cdheQ1YqcrpDUK8xBbGWBxrDuYxFzdVUZui76xqTTG/bKltRTg9xfcGQtxcQUbikbzwU1axg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r+pE8rYtRPkOuNsNFF+9JekgCvkwlUyq2VL1Lkzrjhc=; b=NuHm9y5uvZHqjCq361Gv23BsgH4Plwob3rDWbAaQPW9a838Ja8V+dS0AZQla/5c7ZpIQND57DrfSgMFmj6zAH7GXf0PeW4v9mGNGjOHbKNtE0vPBdQMM2gXnNr33xlnz9TpcQktctNmP/qc4wYB4VqSfiYtrFavvvzwjwUdrLPJ5REfWjKQhS6NXtIVr6Faik9Iae5sm5Yx/OwMTbF7XOfq7R2h91nVNcK9SYRahu5/1yGQqkhYVbqHwydXC95UZwnmMe+lak+qeVPcSTTcFG9M0IXG7Kzige7SWM2wA4H9vdLAaIOerNrkp234+CEqroAQAHKZVqeFCH7qRiZJIrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=voleatech.de; dmarc=pass action=none header.from=voleatech.de; dkim=pass header.d=voleatech.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=voleatech.de; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r+pE8rYtRPkOuNsNFF+9JekgCvkwlUyq2VL1Lkzrjhc=; b=F5TJjUzrx6fgR3lX8n15Jq5amXAwaTvM/uxymHPV/oKnAygkyoe1Ep4bCaujM7wFOr1CWGsn/I7qBG+eITZvdmtn9UK4j5c8BdjwVWtsYZAWap2574N0w9BZc56gRD5rSkmQFmi+WEG1I//Wj7KqVj1uC3bPMCwLlD+YgAbSF9w= Received: from AM0PR05MB5156.eurprd05.prod.outlook.com (20.178.20.19) by AM0PR05MB5617.eurprd05.prod.outlook.com (20.178.114.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.20; Wed, 22 Jan 2020 08:56:31 +0000 Received: from AM0PR05MB5156.eurprd05.prod.outlook.com ([fe80::28cb:442b:6907:83e7]) by AM0PR05MB5156.eurprd05.prod.outlook.com ([fe80::28cb:442b:6907:83e7%6]) with mapi id 15.20.2644.027; Wed, 22 Jan 2020 08:56:31 +0000 From: Sven Auhagen To: "netdev@vger.kernel.org" CC: "lorenzo.bianconi@redhat.com" , "davem@davemloft.net" , "thomas.petazzoni@bootlin.com" , "brouer@redhat.com" , "ilias.apalodimas@linaro.org" , "matteo.croce@redhat.com" , "mw@semihalf.com" , "jakub.kicinski@netronome.com" Subject: [PATCH] mvneta driver disallow XDP program on hardware buffer management Thread-Topic: [PATCH] mvneta driver disallow XDP program on hardware buffer management Thread-Index: AQHV0QHXhq9dlCCNu0aI+Ym7zKijkA== Date: Wed, 22 Jan 2020 08:56:31 +0000 Message-ID: <581AE616-51FA-41F0-B4F1-E0CA761D68F2@voleatech.de> Accept-Language: en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sven.auhagen@voleatech.de; x-originating-ip: [37.24.174.42] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 952d5ce9-6521-48ef-b0fc-08d79f18f9ed x-ms-traffictypediagnostic: AM0PR05MB5617: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 029097202E x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(39830400003)(366004)(376002)(346002)(136003)(396003)(189003)(199004)(316002)(2616005)(66574012)(44832011)(33656002)(71200400001)(76116006)(66446008)(64756008)(66556008)(66476007)(54906003)(66946007)(86362001)(6512007)(8676002)(6486002)(508600001)(186003)(26005)(4326008)(81156014)(8936002)(6916009)(81166006)(2906002)(15974865002)(36756003)(5660300002)(6506007)(309714004); DIR:OUT; SFP:1102; SCL:1; SRVR:AM0PR05MB5617; H:AM0PR05MB5156.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: voleatech.de does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vCHGe+7MoiFsUv+cmlO7MslFlI04d99qvjV/NFpZ+5YD0Y8jN0sIYFh19/LHqjdUlkEE8F7OiWE2IHp8Q1Fi8WuN1R5uoo5ufMYWrQImViibdMEZRStYKpYJgWAoiemxIMAtqY8z8l2iLh5oKOPt+PMCtD4cgmdBs9NHU3KFCArOTmSA6FRAXC8tYCO8YmlVdvXywMT+LMNsQNblcP4pB0qh8pEeSoP37ZJcd7Pmac/8BkMM5oClc1f7EyhH7a/fzD1iqyMb2PDOQ5iB3QZJQLOtZ7w7IfQ48lu/aFWhZksTIuJxrJE5Zzi26F4FMyLbIo/MxI2dSZ10aZS4Ttg40Ai0IDIha4UtPjguGTePXPAOE2U+8vOs01ZGNjIIKUjtV8Rq1AfjwnFQeQVAdQYSMadMPl4OEc9FD3s40Kh9X+EFoKBdBJ/lNdKyBavZSboPt3HlnRyzNQ2AhVWpleqSRLu4se2WMWeHA6TUB7HKHSNyRoNmMrKdg8o9H34fi8hG x-ms-exchange-transport-forked: True Content-ID: <44B5A7BC45E4C14D835EC431197D6EB3@eurprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: voleatech.de X-MS-Exchange-CrossTenant-Network-Message-Id: 952d5ce9-6521-48ef-b0fc-08d79f18f9ed X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2020 08:56:31.6370 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b82a99f6-7981-4a72-9534-4d35298f847b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xQSyDZpbeYizPN8a57qct9y1AXTI8BA8g/JVabhBH7A5/wI75G8OAs0/1mQIJ2j4LfVp9CgScrUFa7hxEBSDMIbBD+kzyiPAhED+kqxuVAM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5617 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Recently XDP Support was added to the mvneta driver for software buffer management only. It is still possible to attach an XDP program if hardware buffer management is used. It is not doing anything at that point. The patch disallows attaching XDP programs to mvneta if hardware buffer management is used. Signed-off-by: Sven Auhagen +++ Voleatech auf der E-World, 11. bis 13. Februar 2020, Halle 5, Stand 521 +++ Beste Grüße/Best regards Sven Auhagen Dipl. Math. oec., M.Sc. Voleatech GmbH HRB: B 754643 USTID: DE303643180 Grathwohlstr. 5 72762 Reutlingen Tel: +49 7121539550 Fax: +49 7121539551 E-Mail: sven.auhagen@voleatech.de www.voleatech.de Diese Information ist ausschließlich für den Adressaten bestimmt und kann vertraulich oder gesetzlich geschützte Informationen enthalten. Wenn Sie nicht der bestimmungsgemäße Adressat sind, unterrichten Sie bitte den Absender und vernichten Sie diese Mail. Anderen als dem bestimmungsgemäßen Adressaten ist es untersagt, diese E-Mail zu lesen, zu speichern, weiterzuleiten oder ihren Inhalt auf welche Weise auch immer zu verwenden. Für den Adressaten sind die Informationen in dieser Mail nur zum persönlichen Gebrauch. Eine Weiterleitung darf nur nach Rücksprache mit dem Absender erfolgen. Wir verwenden aktuelle Virenschutzprogramme. Für Schäden, die dem Empfänger gleichwohl durch von uns zugesandte mit Viren befallene E-Mails entstehen, schließen wir jede Haftung aus. --- drivers/net/ethernet/marvell/mvneta.c 2020-01-22 08:44:05.611395960 +0000 +++ drivers/net/ethernet/marvell/mvneta.c 2020-01-22 08:45:23.472263795 +0000 @@ -4225,6 +4225,11 @@ static int mvneta_xdp_setup(struct net_d return -EOPNOTSUPP; } + if (pp->bm_priv) { + NL_SET_ERR_MSG_MOD(extack, "Hardware Buffer Management not supported on XDP"); + return -EOPNOTSUPP; + } + need_update = !!pp->xdp_prog != !!prog; if (running && need_update) mvneta_stop(dev);