From patchwork Sun Dec 1 15:15:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Hubicka X-Patchwork-Id: 1202879 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-514928-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="iaLWV3sS"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47QsJZ2zHLz9sR7 for ; Mon, 2 Dec 2019 02:15:58 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; q=dns; s= default; b=hpM9BjQAs3LAn/M6HAnectma3wRTXSkeF8h4mdWYjMCdsSw/stpPj lmruvkStTsvWZLq/1PtfTJSWLH0Bkwm0iLxxJ4EJhfIYyyhwvkz8DP32IdD1uYlw 5RnxApjJsE7RJBO+YPsy791C72BMdPnijxhSScBTjZrIDuueCQXCAY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; s= default; bh=tle4pIAyFqUpbBXPi6VAsB9lLeA=; b=iaLWV3sSz3B+6PUw+APB aLhs/svSkUIsR8LsSMYFxCrPTZH4hA24P8zxw7AMVLVjCXcgjF2ZT5qZuSF4pmFL wZBnIY47ysvPKCzjw+pSjoLt7TyBx5oyvbt3W2Dz2yCL+zhcCrVZE4jUD7x8th+N 5jVR9fAplDjOoTV3A1LaVvA= Received: (qmail 119889 invoked by alias); 1 Dec 2019 15:15:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 119788 invoked by uid 89); 1 Dec 2019 15:15:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=clearing X-HELO: nikam.ms.mff.cuni.cz Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 01 Dec 2019 15:15:51 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id 30D5E2805F1; Sun, 1 Dec 2019 16:15:49 +0100 (CET) Date: Sun, 1 Dec 2019 16:15:49 +0100 From: Jan Hubicka To: gcc-patches@gcc.gnu.org, mjambor@suse.cz Subject: Fix jump function update in inliner Message-ID: <20191201151549.justeyetbjpgfm6z@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) Hi, this patch fixes the problem with clearing bits and m_vr in inliner update we discussed earlier. I am not sure if dete_type_change_from_memory_writes needs the clear? Bootstrapped/regtested x86_64-linux, Martin, does it make sense? Honza * ipa-prop.c (ipa_set_jf_unknown): Do not clear bits and m_vr. (detect_type_change_from_memory_writes): Clear it here. Index: ipa-prop.c =================================================================== --- ipa-prop.c (revision 278877) +++ ipa-prop.c (working copy) @@ -512,8 +512,6 @@ static void ipa_set_jf_unknown (struct ipa_jump_func *jfunc) { jfunc->type = IPA_JF_UNKNOWN; - jfunc->bits = NULL; - jfunc->m_vr = NULL; } /* Set JFUNC to be a copy of another jmp (to be used by jump function @@ -819,6 +817,8 @@ detect_type_change_from_memory_writes (i return false; ipa_set_jf_unknown (jfunc); + jfunc->bits = NULL; + jfunc->m_vr = NULL; return true; }