From patchwork Tue Nov 26 22:20:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 1201225 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linutronix.de Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 47Myyt6SH9z9sS6 for ; Wed, 27 Nov 2019 09:20:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726984AbfKZWUi (ORCPT ); Tue, 26 Nov 2019 17:20:38 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:43032 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726050AbfKZWUh (ORCPT ); Tue, 26 Nov 2019 17:20:37 -0500 Received: from localhost ([127.0.0.1] helo=flow.W.breakpoint.cc) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1iZjCF-0008Na-FC; Tue, 26 Nov 2019 23:20:35 +0100 From: Sebastian Andrzej Siewior To: netdev@vger.kernel.org Cc: "David S. Miller" , Thomas Gleixner , Sebastian Andrzej Siewior , Tom Lendacky Subject: [PATCH net 1/2] amd-xgbe: Use __napi_schedule() in BH context Date: Tue, 26 Nov 2019 23:20:12 +0100 Message-Id: <20191126222013.1904785-2-bigeasy@linutronix.de> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191126222013.1904785-1-bigeasy@linutronix.de> References: <20191126222013.1904785-1-bigeasy@linutronix.de> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The driver uses __napi_schedule_irqoff() which is fine as long as it is invoked with disabled interrupts by everybody. Since the commit mentioned below the driver may invoke xgbe_isr_task() in tasklet/softirq context. This may lead to list corruption if another driver uses __napi_schedule_irqoff() in IRQ context. Use __napi_schedule() which safe to use from IRQ and softirq context. Fixes: 85b85c853401d ("amd-xgbe: Re-issue interrupt if interrupt status not cleared") Cc: Tom Lendacky Signed-off-by: Sebastian Andrzej Siewior Acked-by: Tom Lendacky --- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c index 98f8f20331544..3bd20f7651207 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c @@ -514,7 +514,7 @@ static void xgbe_isr_task(unsigned long data) xgbe_disable_rx_tx_ints(pdata); /* Turn on polling */ - __napi_schedule_irqoff(&pdata->napi); + __napi_schedule(&pdata->napi); } } else { /* Don't clear Rx/Tx status if doing per channel DMA From patchwork Tue Nov 26 22:20:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 1201226 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linutronix.de Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 47Myz12cHsz9sS6 for ; Wed, 27 Nov 2019 09:20:45 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727026AbfKZWUo (ORCPT ); Tue, 26 Nov 2019 17:20:44 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:43035 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726050AbfKZWUo (ORCPT ); Tue, 26 Nov 2019 17:20:44 -0500 Received: from localhost ([127.0.0.1] helo=flow.W.breakpoint.cc) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1iZjCL-0008Na-9s; Tue, 26 Nov 2019 23:20:41 +0100 From: Sebastian Andrzej Siewior To: netdev@vger.kernel.org Cc: "David S. Miller" , Thomas Gleixner , Sebastian Andrzej Siewior , Eric Dumazet Subject: [PATCH net 2/2] net: gro: Let the timeout timer expire in softirq context with `threadirqs' Date: Tue, 26 Nov 2019 23:20:13 +0100 Message-Id: <20191126222013.1904785-3-bigeasy@linutronix.de> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191126222013.1904785-1-bigeasy@linutronix.de> References: <20191126222013.1904785-1-bigeasy@linutronix.de> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The timer callback (napi_watchdog()) invokes __napi_schedule_irqoff() with disabled interrupts. With the `threadirqs' commandline option all interrupt handler are threaded and using __napi_schedule_irqoff() is not an issue because everyone is using it in threaded context which is synchronised with local_bh_disable(). The napi_watchdog() timer is still expiring in hardirq context and may interrupt a threaded handler which is in the middle of __napi_schedule_irqoff() leading to list corruption. Let the napi_watchdog() expire in softirq context if `threadirqs' is used. Fixes: 3b47d30396bae ("net: gro: add a per device gro flush timer") Cc: Eric Dumazet Signed-off-by: Sebastian Andrzej Siewior --- net/core/dev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index 99ac84ff398f4..ec533d20931bc 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -5994,6 +5994,8 @@ bool napi_complete_done(struct napi_struct *n, int work_done) napi_gro_flush(n, !!timeout); if (timeout) hrtimer_start(&n->timer, ns_to_ktime(timeout), + force_irqthreads ? + HRTIMER_MODE_REL_PINNED_SOFT : HRTIMER_MODE_REL_PINNED); } if (unlikely(!list_empty(&n->poll_list))) { @@ -6225,7 +6227,9 @@ void netif_napi_add(struct net_device *dev, struct napi_struct *napi, int (*poll)(struct napi_struct *, int), int weight) { INIT_LIST_HEAD(&napi->poll_list); - hrtimer_init(&napi->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL_PINNED); + hrtimer_init(&napi->timer, CLOCK_MONOTONIC, + force_irqthreads ? + HRTIMER_MODE_REL_PINNED_SOFT : HRTIMER_MODE_REL_PINNED); napi->timer.function = napi_watchdog; init_gro_hash(napi); napi->skb = NULL;