From patchwork Tue Nov 26 12:24:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Angelo Compagnucci X-Patchwork-Id: 1201015 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="HYkUb03m"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47MjlL1Q6mz9sPV for ; Tue, 26 Nov 2019 23:24:46 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 93F2D85FDB; Tue, 26 Nov 2019 12:24:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EOQcTd4UlHn8; Tue, 26 Nov 2019 12:24:42 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 2900985F32; Tue, 26 Nov 2019 12:24:42 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 3D4E21BF30D for ; Tue, 26 Nov 2019 12:24:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 2E7CF20495 for ; Tue, 26 Nov 2019 12:24:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0Ma0PlZJ4oF3 for ; Tue, 26 Nov 2019 12:24:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by silver.osuosl.org (Postfix) with ESMTPS id 4795A220A2 for ; Tue, 26 Nov 2019 12:24:33 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id l1so2999608wme.2 for ; Tue, 26 Nov 2019 04:24:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id; bh=AiY78G3nnyuZq0bzk71Ux/8G8PAX1rRCR2raxWsZ3CM=; b=HYkUb03mTjiPFq87mqBR5X9gs7/GMEEuaLXsFInNfTO17CL/oW+cDtzSgaOMfh4bi0 YlmuqX8GOFygJ6BuQaPuelgTmw003EOmw6RsKa44KC70bPNwu8DW64qd4xczQlAZlJBM lNKb2usRYa8y/Yj8pcCdXs+NDcRnOu7D69Kas= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AiY78G3nnyuZq0bzk71Ux/8G8PAX1rRCR2raxWsZ3CM=; b=ugwfkex9v1ucSBaJA6aG1YnsqKoo8K+W9g2mOAeRo4JeylUDjhpUjUA1QaYIiWaQEI /j4ciEDgxSM5IlXmgoDEEagef9UszUdrhWzBm7JJaNuOi6uKJvCFE6q8Uk0tgYft+tNZ ph/mRHVAcIDx4IfbESEHSVCB162qM6+1YoQaqydDkfu/Es3p7wxWND9j4IAfzQjEKOGb GlMW3vCe5SVg3W/kgs/uqr1CR2dnpBblyS+NTg22YSW6P2B2m7L5zMUgd+ggn2R9DW8F TODGYjUZJKxI9tIW6XiIq3qQJmxLhMNXI+Tf7KPXj9ARAnwUHmJHPbSJl3QQjEwCcFHj /h0g== X-Gm-Message-State: APjAAAU9ZobYnGweg/48N74JTIV9uXmO5AwUp7vZs9GgRmP55ztgrH3y SMVOr53Vql+OHw6pu4bdrDud1c5nf+c= X-Google-Smtp-Source: APXvYqyYVis3byZuqTq5cCmsHZrrFG/praiVa2m09bKzR1Qnxtl6ZDl4dPrY0h5YX1Dz/+AIpfzC7Q== X-Received: by 2002:a7b:ce92:: with SMTP id q18mr4187748wmj.164.1574771071370; Tue, 26 Nov 2019 04:24:31 -0800 (PST) Received: from localhost.localdomain ([89.202.204.147]) by smtp.gmail.com with ESMTPSA id 205sm5080630wmb.3.2019.11.26.04.24.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Nov 2019 04:24:30 -0800 (PST) From: Angelo Compagnucci To: buildroot@buildroot.org Date: Tue, 26 Nov 2019 13:24:23 +0100 Message-Id: <1574771063-29218-1-git-send-email-angelo@amarulasolutions.com> X-Mailer: git-send-email 2.7.4 Subject: [Buildroot] [PATCH v2] package/pkg-kconfig: fix reconfigure for kconfig packages X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Angelo Compagnucci , Angelo Compagnucci MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Angelo Compagnucci Commit 4b81badbcc0b25678ac6627548160702731cf393 Currently, calling foo-reconfigure for a kconfig-based package will not re-trigger the configuration (kconfig-wise) step for the package. already solved this problem, but it was lately regressed by Commit 05fea6e4a60a38a797d9bacbf318a2cd7dbd435f infra/pkg-kconfig: do not rely on package's .config as a timestamp that introduced the .stamp_dotconfig file. For this reason, to trigger a kconfig package reconfigure is now necessary to remove the .stamp_dotconfig file. Signed-off-by: Angelo Compagnucci --- package/pkg-kconfig.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/pkg-kconfig.mk b/package/pkg-kconfig.mk index 86d7c14..f1931b8 100644 --- a/package/pkg-kconfig.mk +++ b/package/pkg-kconfig.mk @@ -175,7 +175,7 @@ $$($(2)_TARGET_CONFIGURE): $$($(2)_DIR)/.stamp_kconfig_fixup_done $(1)-clean-for-reconfigure: $(1)-clean-kconfig-for-reconfigure $(1)-clean-kconfig-for-reconfigure: - rm -f $$($(2)_DIR)/.stamp_kconfig_fixup_done + rm -f $$($(2)_DIR)/$$($(2)_KCONFIG_STAMP_DOTCONFIG) # Only enable the foo-*config targets when the package is actually enabled. # Note: the variable $(2)_KCONFIG_VAR is not related to the kconfig