From patchwork Thu Oct 31 13:55:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Andre Vieira (lists)" X-Patchwork-Id: 1187504 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-512154-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="nqfBxrm7"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 473n0F2YwFz9s7T for ; Fri, 1 Nov 2019 00:55:38 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=bBHZjFMthjs3IfUoAB0zQCqtccPQ17aEg4UHIjBtKZvqARG7YU /H0O2X2GFz8lgiOUjIR3JzEzME5m8XwMcg3dC8e0iFXpdiuTeXBUQqzhEbM4GPiZ a4KRHF3XBmdIo0sIoZZD68izMg7r58wS1yVGmcqy57vSEYHxmASiTtz28= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=aotjNXRA/lfMgs5rw/SNQxXz7/I=; b=nqfBxrm7VEnUWzramCA3 CkY1pMBxtV03XG0UthjQAx5fxFCbplYCOCwW6sTku8canT0NtDbkAhaocf+KSx4j y7IGrWZsixuD+9bPeTh0r05s/WACsJ+C0fxMqRf8heWKFP3sOBhmI171YFkHju4L X5QjuLl1sTmLS9NzeRQthe0= Received: (qmail 22159 invoked by alias); 31 Oct 2019 13:55:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 22151 invoked by uid 89); 31 Oct 2019 13:55:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy=pr80481c, pr80481C, UD:pr80481.C, pr80481.C X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.110.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Oct 2019 13:55:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D5D71FB; Thu, 31 Oct 2019 06:55:28 -0700 (PDT) Received: from [10.2.206.37] (e107157-lin.cambridge.arm.com [10.2.206.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B72523F71E; Thu, 31 Oct 2019 06:55:27 -0700 (PDT) To: gcc-patches , jakub@redhat.com From: "Andre Vieira (lists)" Subject: [PATCH][testuite] Fix pr80481.C after epilogue vectorization Message-ID: <90a15a74-0eb4-7719-cff5-53345764ba30@arm.com> Date: Thu, 31 Oct 2019 13:55:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 X-IsSubscribed: yes Hi, I used to have this testcase in my patch when testing but forgot to include it in the patch I sent upstream. This testcase checks that a vmovaps isn't generated when vectorizing the loop. When I turn epilogue vectorization it seems to come back. @Jakub: This test has -fopenmp but I debuged through the testcase and loop->simdlen always seems to be 0 for any loop we analyze, so I don't think this is a conflict between my epilogue vectorization and openmp code paths in vect_analyze_loop. I suspect the vmovaps is introduced because of the epilogue and it is just a testism, but would like a second opinion. Cheers, Andre gcc/testsuite/ChangeLog: 2019-10-31 Andre Vieira * g++.dg/pr80481.C: Disable epilogue vectorization. diff --git a/gcc/testsuite/g++.dg/pr80481.C b/gcc/testsuite/g++.dg/pr80481.C index bd5002c89d5137012f36f16946eec3d4ea7dc97c..1f2697825cd854287a7209328ff5e6e90fbab481 100644 --- a/gcc/testsuite/g++.dg/pr80481.C +++ b/gcc/testsuite/g++.dg/pr80481.C @@ -1,6 +1,8 @@ // { dg-do compile { target { i?86-*-* x86_64-*-* } && { ! *-*-solaris* } } } // { dg-options "-Ofast -funroll-loops -fopenmp -march=knl" } // { dg-final { scan-assembler-not "vmovaps" } } +// Disabling epilogues until we find a better way to deal with scans. +// { dg-additional-options "--param vect-epilogues-nomask=0" } #include