From patchwork Fri Oct 25 13:36:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell Bryant X-Patchwork-Id: 1184170 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ovn.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4704sY0mFYz9sPL for ; Sat, 26 Oct 2019 00:37:03 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id F2F22CDE; Fri, 25 Oct 2019 13:37:00 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 7DE9BB0B for ; Fri, 25 Oct 2019 13:37:00 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id D194D89D for ; Fri, 25 Oct 2019 13:36:59 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-242-RkesLSYSOQ-_4D-4NhuhMQ-1; Fri, 25 Oct 2019 09:36:50 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B58F91005500; Fri, 25 Oct 2019 13:36:49 +0000 (UTC) Received: from t480s.redhat.com (ovpn-121-119.rdu2.redhat.com [10.10.121.119]) by smtp.corp.redhat.com (Postfix) with ESMTP id 806385D70E; Fri, 25 Oct 2019 13:36:48 +0000 (UTC) From: Russell Bryant To: dev@openvswitch.org Date: Fri, 25 Oct 2019 09:36:46 -0400 Message-Id: <20191025133646.4635-1-russell@ovn.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: RkesLSYSOQ-_4D-4NhuhMQ-1 X-Mimecast-Spam-Score: 0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH ovn] controller: Downgrade a warning log message X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org This log message was introduced in commit 5344f24ecb. It gets hit under normal circumstances, so it would be better as a debug message instead of a warning. I also expanded it to clarify that the next step will be to create the chassis record. This was found by trying to run the system-ovn.at tests, and they failed because of these unexpected warning log messages. Signed-off-by: Russell Bryant Acked-by: Numan Siddique --- controller/chassis.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/controller/chassis.c b/controller/chassis.c index 699b66281..978273e19 100644 --- a/controller/chassis.c +++ b/controller/chassis.c @@ -484,8 +484,9 @@ chassis_get_record(struct ovsdb_idl_txn *ovnsb_idl_txn, chassis_rec = chassis_lookup_by_name(sbrec_chassis_by_name, chassis_info_id(&chassis_state)); if (!chassis_rec) { - VLOG_WARN("Could not find Chassis : stored (%s) ovs (%s)", - chassis_info_id(&chassis_state), chassis_id); + VLOG_DBG("Could not find Chassis, will create it" + ": stored (%s) ovs (%s)", + chassis_info_id(&chassis_state), chassis_id); if (ovnsb_idl_txn) { /* Recreate the chassis record. */ chassis_rec = sbrec_chassis_insert(ovnsb_idl_txn);