From patchwork Thu Nov 16 04:27:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838403 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZLBFlPD0"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpDT37QBz9s7G for ; Thu, 16 Nov 2017 15:29:29 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757688AbdKPE3Z (ORCPT ); Wed, 15 Nov 2017 23:29:25 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:49985 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756328AbdKPE2z (ORCPT ); Wed, 15 Nov 2017 23:28:55 -0500 Received: by mail-pg0-f66.google.com with SMTP id 70so7187246pgf.6; Wed, 15 Nov 2017 20:28:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=LGg+QPPj67kt0zlEKQf9Z1xyoFzCEl02BtdUEIPIpRc=; b=ZLBFlPD05Io7VEwo5mV1+XRL3Im1b+QTms+ZU3hqUHsUajmYgD2bf+x2dihBiWZGLy ca0TXc0rl4R33c8fyG9ebIHEimxoornvoTUMfSLAsELu3TDfgvpaVXgH3kBLY/6Q/PtA BbVMKqjduaJ5cp9kqi4VeY0DkXUYm6QPpuqS9CSB0OWhW62IVWfjcPUP92FcnViJReE4 tq6ANc+dnHPVwBQT396HW07FzYe5czleXzh5cLLgG8bAJ5m2hgfG63JkCJFXcxHrVEY1 uKjqE6m/TEA04HXEkH8jy7FFF8pjGzJ+WEDTZZlsbw0yudos9zvHrOF9he34cQctCoMX gayw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=LGg+QPPj67kt0zlEKQf9Z1xyoFzCEl02BtdUEIPIpRc=; b=MjpwJEPm1rI/1Ba8AkSWGlRA1XVEzSIn60xHAINAkiaV3T4pVk/730BqNMHnJR+TfQ mHh2Qsgt8PAMEf4tEF1N71iN3Yw3KnVLuojXI6Wyeo42VnvwIzLIRmoOcEA/sA1MzrFO ltDCDfm8xeWoJRjhO3PuPiE14iOfllosIRayDfK9fw2mGaOeC16yOCG70xq9lWazIBAc eTXHrBa07v0x2MmdJKhvnrCICeCwAQ5wxn85nWEXfIvknu5b4uMDCcrlDDUa8Zh+e8sp j0+NzKOPM3CWB06q/f425ueg8zJEeD9SODkrT5jPdAhmfD/shq6hxHypEKpTJbVNQonr 1woA== X-Gm-Message-State: AJaThX5hgvwTDKfQv0mZOA7nIYpLyjnUuxLvzLSTkK/EIn4BlgDypkoR wlJLf7OkKezrw5wFn7k+gR8bwg== X-Google-Smtp-Source: AGs4zMZvJm0qo//1YzfUK0v1p5Y8tBKBFc+DTlJR2yeFC+Gx/7S37hgc6HIqcKGwJOiRkHCUzlwDRQ== X-Received: by 10.99.3.146 with SMTP id 140mr399551pgd.275.1510806534445; Wed, 15 Nov 2017 20:28:54 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.28.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:28:53 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 01/12] isdn: hisax: Fix pnp_irq's error checking for setup_asuscom Date: Thu, 16 Nov 2017 09:57:18 +0530 Message-Id: <1103d4f44048f944961fbab0fbc16131c7f54d23.1510805781.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/asuscom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/asuscom.c b/drivers/isdn/hisax/asuscom.c index 62f9c43..74c8714 100644 --- a/drivers/isdn/hisax/asuscom.c +++ b/drivers/isdn/hisax/asuscom.c @@ -348,7 +348,7 @@ int setup_asuscom(struct IsdnCard *card) } card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "AsusPnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d); From patchwork Thu Nov 16 04:27:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838412 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jljRhUvv"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpJM5bt3z9s7g for ; Thu, 16 Nov 2017 15:32:51 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932359AbdKPE3O (ORCPT ); Wed, 15 Nov 2017 23:29:14 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:57284 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757688AbdKPE25 (ORCPT ); Wed, 15 Nov 2017 23:28:57 -0500 Received: by mail-pf0-f195.google.com with SMTP id q4so10577911pfg.13; Wed, 15 Nov 2017 20:28:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=9VlEMkQnYW0EJtBWOPxVioj2m2eWpIhIJDCeNas65iM=; b=jljRhUvv9eGf5W31+WhGztQpYYxGcze3uf8i8RRwF58zPyb8LIWYQKQ3Uj3tOhtGpt JTWNGu/jBozWNzneVBllHGMGIikWkge3TiZWF5iSuIREYUqojEPQbYMN7BmokTu6uyOE 4EQSUMNHhNRAedFnrDR0gj0qjNtUZz9wk/Hetd1b7pMVcWaLO+ivPZjS1r32cKj1d5/l pyNDDtDHqaz2vzk8BgzjMWZk58756dqyERKOAiSKx8CUWhAaLkpf46wHzan3TAvj042K X0P6uUYMjKBOE1YXbyrODyULMFb26XdHG8YNU8t2ZogF0TAFpspE8RgzhoihNxclRXS0 PQoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=9VlEMkQnYW0EJtBWOPxVioj2m2eWpIhIJDCeNas65iM=; b=jAvtLEBjDmgKWf9VcjHBM2UhKwtLlCalvQU0H3ky3OO9mXATtzOQTdCaiSVbo8FxL9 6OtxkxgK5OCVgyGeP2/FvANRFrah/QljkEdeCAndWUzGtmzCjD/d01GrsYKthiMnAlun dX42ufLHe40tzmajkrSwizQGNZ3T+g2BqVwkmcQtizVq9MK1j2obyJwcXV7zr72wrIZo 8yjmuEmwwSj2bl3kTCI1fCGvyN0klVHtIwDkW0t9xwYMxizQtxZR10EP7xR5G1BkyzP/ QI+RIrAyDfsdbUe9bxBlclKMyRpjcjZXrfRyxN/nlJwj4GjGyRaN8knHUtJ11/WinipF GmJg== X-Gm-Message-State: AJaThX6tS8tuD+Ed5Sdnhu2K324pa2YWuTGsQue29r3zYf83lgqogQva VAwz+sjGrML/SyGqYFe1N60= X-Google-Smtp-Source: AGs4zMbEW74V5L7lbvoTJEbPOTzcXj7Ydy3or/uCd9QJEgLx9hZ48RcdQJXZCLOEO7hvNgfnfN76TA== X-Received: by 10.84.132.42 with SMTP id 39mr405396ple.382.1510806537088; Wed, 15 Nov 2017 20:28:57 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.28.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:28:56 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 02/12] isdn: hisax: Fix pnp_irq's error checking for avm_pnp_setup Date: Thu, 16 Nov 2017 09:57:19 +0530 Message-Id: <14ab3ba543bf96791f5284e1ed16f48a2f460842.1510805781.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/avm_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/avm_pci.c b/drivers/isdn/hisax/avm_pci.c index daf3742..a18b605 100644 --- a/drivers/isdn/hisax/avm_pci.c +++ b/drivers/isdn/hisax/avm_pci.c @@ -805,7 +805,7 @@ static int avm_pnp_setup(struct IsdnCardState *cs) cs->hw.avm.cfg_reg = pnp_port_start(pnp_avm_d, 0); cs->irq = pnp_irq(pnp_avm_d, 0); - if (!cs->irq) { + if (cs->irq == -1) { printk(KERN_ERR "FritzPnP:No IRQ\n"); return (0); } From patchwork Thu Nov 16 04:27:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838402 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ENgqzvx4"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpDJ5yM5z9s7g for ; Thu, 16 Nov 2017 15:29:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932580AbdKPE3S (ORCPT ); Wed, 15 Nov 2017 23:29:18 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:55866 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758656AbdKPE3A (ORCPT ); Wed, 15 Nov 2017 23:29:00 -0500 Received: by mail-pf0-f195.google.com with SMTP id 17so18694686pfn.12; Wed, 15 Nov 2017 20:29:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=mKIkFPAH8dfhxT2PuwoyNQrOAlcHd3smE1fgNj2pOms=; b=ENgqzvx4jtuvVW0DUwTxZtwr0x6tI44F0BgWSdoNNuvDCMc8bgR0UNeMsA5PMjpBj6 p/HCrNcqf7gi7kdDJxae8l7jpmK6mn8QhR7d0UMg7wZVnQH4GKVhKITqXVBIi+0n3dEx A12EULl7cXazFkUSSm73CQ9cqwtqPI35+36jlZGKzL7jHerh2U9XTryz/88EubkAz9cj pqNJTBVMvAt5Lurtn+8oT72ICEF9CHo3HIcFxzl95tRhFc0yCUvCkMbdgD3tpFCSoM5v MeCRJcmiYU6bN+KFMYQnb4S2oQWdSsyDSkiMo6jNh1GDyq+XBSQATw54/JYKg6d3JpGS nFAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=mKIkFPAH8dfhxT2PuwoyNQrOAlcHd3smE1fgNj2pOms=; b=WioI4oOpN28AP10tszhBKurIwq3EAkp60Gweh6ONdQr3vTgQfAvjBh+By9uYWX71Ia nQzUqM4AtH+dOV8PBUVnGZc8ymSlzkaNBMZD317xTRWLE0E3GETQ+i1CBvsHfX3iSAVO y1Chtq0HNpkQkHlpnNuslx3atxPmvLQJKXlZkYrkOHO4kuGEpSKO3T4rBOzRglaUXUcI cfBItCvqC3PSlRnkQQHL5hO3m4GlwlvPGhShERk3CWws1Wln2iWBAgzaF8zsJ7GMPefR btn51OJHy6jpwo/ma9rlNbTH58Ws1TslneLyP8VveZ/v620hqAKPzZA9OtPWOY1RuxHa RqkA== X-Gm-Message-State: AJaThX4ywwQ1xz7av+bexpTB40jg4ZQahQWtUHqRR9aJZDfI5S7ksTMe V5TAoEDKuHLPBvNVrHUxLk8= X-Google-Smtp-Source: AGs4zMbjkmLPwU1gMsGHwUNqD3NFvxABtvHcJVDQyEjSPWN7/ro7huUSAfHhCPYJOpycua4qD3dNNw== X-Received: by 10.99.159.25 with SMTP id g25mr420925pge.176.1510806539748; Wed, 15 Nov 2017 20:28:59 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.28.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:28:59 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 03/12] isdn: hisax: Fix pnp_irq's error checking for setup_diva_isapnp Date: Thu, 16 Nov 2017 09:57:20 +0530 Message-Id: <6e647b3996ac5e67c40f52c3ce2c55d8b044f44e.1510805781.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/diva.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/diva.c b/drivers/isdn/hisax/diva.c index 3fc94e7..bed749c 100644 --- a/drivers/isdn/hisax/diva.c +++ b/drivers/isdn/hisax/diva.c @@ -1094,7 +1094,7 @@ static int setup_diva_isapnp(struct IsdnCard *card) } card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "Diva PnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d); From patchwork Thu Nov 16 04:27:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838404 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="C/g6d3/w"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpDY56T6z9s7G for ; Thu, 16 Nov 2017 15:29:33 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932744AbdKPE3b (ORCPT ); Wed, 15 Nov 2017 23:29:31 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:50984 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbdKPE3D (ORCPT ); Wed, 15 Nov 2017 23:29:03 -0500 Received: by mail-pg0-f67.google.com with SMTP id u3so4543535pgn.7; Wed, 15 Nov 2017 20:29:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=WMPKL2IxkQOOxMl/iLySB4uO0jSLNOpPSROH7sCkoWg=; b=C/g6d3/wbmH5eqrz5oVB+Zb+4Nu7cA7IZTN2TPBQTL17rzS3VZC36+YA95RHpayC2O DmZjRqg1dejgiJqGRYWimAGFAvnZILctq1kwWL6NPRBxNQMPPS6FyhM4Nf/zs2lW3Im1 56bMWzfOMKMhOPx0fF0NKUmG3yqvoHmdtC7S1JJ+xmvYZyoc5V+v6m4sDAsBto8SgT30 A2WbVL7zWKQKWelOfDRShsDFUWLjOjiRsM9w+TV2FaKrbJB8l0aqOQU4tZU7T1K1hOx4 KeohkJI0hbW/NjZ0ncpg7wnfpNkne5usXDqYFHc6AjiAnPZ/Vkx4h7V8hCbMFEzlAP76 9RUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=WMPKL2IxkQOOxMl/iLySB4uO0jSLNOpPSROH7sCkoWg=; b=Dvi0pGsSHfxiCeHeDbNpWnZ9L5eLNYFAmMcRVlMAxJv8/2r8e683JQlkvOScbR/emx Hm+qSBMOhZP3qa3NpNNAbYzsb3iluqek743UtxgagIB4wZTf2cx9gpTbiF3T1j/eP1T6 mBBANcZx8LoOmWlGZSeZ+D6XwsQr4x8FueicW2Jsf5C4AvXQtt83ZwT1KNej5eeOKShj lEy9CX0kgX/BjLYpqToWC/2qWKsej/ahNUneF6pVXTKSoCHMgX61gVmeDMiHI6qkWWN8 IZ7y8L2nOvrhh3nSh+k48COYnkllg1G2dndtFOSA8mRUfs5F0c2M/8NyCt1E6+RdcmFZ OIFA== X-Gm-Message-State: AJaThX4EgFev9qj80gQKI5vDZ9APvGCJHbR5uZSel/8+gCyazWb8VC+I nZru78mFbOoit6EGxhljwYQ= X-Google-Smtp-Source: AGs4zMaIFOe8fK/mX29rJ4dY4iGtIWnzrdYbh6JuDF0G+/xoU0JzMIGp3b8ss7WGW2P2ITr2iPko0A== X-Received: by 10.101.80.200 with SMTP id s8mr415356pgp.23.1510806542389; Wed, 15 Nov 2017 20:29:02 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.28.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:01 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 04/12] isdn: hisax: Fix pnp_irq's error checking for setup_elsa_isapnp Date: Thu, 16 Nov 2017 09:57:21 +0530 Message-Id: <2d169e32d2abac9872ad4cbb172e1fb3398db8df.1510805781.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/elsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/elsa.c b/drivers/isdn/hisax/elsa.c index 03bc5d5..f8dcac8 100644 --- a/drivers/isdn/hisax/elsa.c +++ b/drivers/isdn/hisax/elsa.c @@ -945,7 +945,7 @@ static int setup_elsa_isapnp(struct IsdnCard *card) card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "Elsa PnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d); From patchwork Thu Nov 16 04:27:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838405 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ks/RCTVR"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpDj3j5lz9sNc for ; Thu, 16 Nov 2017 15:29:41 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758822AbdKPE3h (ORCPT ); Wed, 15 Nov 2017 23:29:37 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:49771 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758692AbdKPE3G (ORCPT ); Wed, 15 Nov 2017 23:29:06 -0500 Received: by mail-pf0-f196.google.com with SMTP id l24so6280585pfj.6; Wed, 15 Nov 2017 20:29:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=RD4vYSiyGfWfM8+zBSilB1VFrlPVw0KeRxNFGzToHPQ=; b=ks/RCTVR7lLvdQW1b0tEO62pd0VJilHrJJrgUY79mvrz1fDLkyDDdXhHtpFE3sqORg JSoJ1UxYWTXbhf5CHzpms3Ix42a7xEue5nO9pPRh+XuF/F9ZE+ed2dCiCcbX3oVRTckx +eq4epFL1xBXTNtyDs3py7dCa+aEVSPTvGcdBZwmUdq70XW/RLot8LvpxN+PxCz+pCHi RH5VbYgnj9P0nDh6XCee/y1sHUjBsqbmVDjUk4rfqjxR75TwnLu9zfgyqjMAYoY8Q2Rh HBUFD24+XFRBMQjctwNd8V+8326IpO0I1ZxK96t5jk4EcG8JOpiqErOZj78OLHEQaneE nqXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=RD4vYSiyGfWfM8+zBSilB1VFrlPVw0KeRxNFGzToHPQ=; b=mkc8VMdqwOzaN82v7DdrRMQTrUShpOE41nzhr+dUl0OUnus1E/CYASLt/AXlPm06AC 3WwgJz8BDeWgSUdD2rTuq3mjeY5J0KQp6JKESRejd9Sg8pppDIP7e/mTV4PbdCWvohSW kGos/h3wr+MbOSdkWJTuD/ziCURtm3CYQ3XRtMXESawElHexqEk4qZUfLryi/eHjyBHy 3/yMrz7W2SkmNKV2/R1DVohdBW1TgX+iLb0D/0Hs+tiNx8H4LYM7xBMyDQixB2DBohsQ MHmGsLiEEzYYbjo9HdKDDi/ZpxXFfIY01skhIFOjjyGbOqjcAPdVvmSqTHlkq52wsh5g hPTg== X-Gm-Message-State: AJaThX5VivhuNBaN9isV2g/mpE80OKqa9KJxODz2zK/CcbW/Lk/3hzOb i/tuU3sB4Fmupg3AKrgmfqU= X-Google-Smtp-Source: AGs4zMaYtj5DDazpIS9Hfbhsnp8Ca7qjQMUBKOvXbNlXq6JNiYqG+X1clrpg/809uyRJCpBf6ZcccA== X-Received: by 10.98.198.28 with SMTP id m28mr429258pfg.217.1510806545068; Wed, 15 Nov 2017 20:29:05 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.29.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:04 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 05/12] isdn: hisax: Fix pnp_irq's error checking for setup_hfcsx Date: Thu, 16 Nov 2017 09:57:22 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/hfc_sx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/hfc_sx.c b/drivers/isdn/hisax/hfc_sx.c index 3aef8e1..99f5a93 100644 --- a/drivers/isdn/hisax/hfc_sx.c +++ b/drivers/isdn/hisax/hfc_sx.c @@ -1422,7 +1422,7 @@ int setup_hfcsx(struct IsdnCard *card) } card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "HFC PnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d); From patchwork Thu Nov 16 04:27:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838410 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="cUgQSf/A"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpHR6rSxz9s7G for ; Thu, 16 Nov 2017 15:32:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758863AbdKPE3o (ORCPT ); Wed, 15 Nov 2017 23:29:44 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:50991 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758697AbdKPE3I (ORCPT ); Wed, 15 Nov 2017 23:29:08 -0500 Received: by mail-pg0-f68.google.com with SMTP id u3so4543692pgn.7; Wed, 15 Nov 2017 20:29:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=rFJkt4SkxzlTentuBGwPeu3HrPpBLGVubixF6z0NtUM=; b=cUgQSf/AQvLFcYpvHVXv7jNPBRL3y1Z6W4TMMRaE7YIIucSVs7HSUsHHqhKdoquWB5 HXGr2UXLz0LvNDGlxP6Qq8Okym1XUzoUMMotlvceg4WlCsSC18BPb2UNTRIWqcWeOLyT WGiVSUfxTYlbn2ncnbwmywvHKfwOuEjBp9pyonhD/a+CC8YDOrYhaR0MjDQIhPmvINgO s52TSggpNQFey+YGjjB3FmcBcgGNlMTeHvTpfV84cOMyNdK3h38lGWmUL64f3CLQi9H9 S8Q3S8Q9w3JH/GYVafGyqsUMhnWUc2PLZtGyzt/Swu+xIcH0JR5r+E7ykZZAz2yRqM7o IOnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=rFJkt4SkxzlTentuBGwPeu3HrPpBLGVubixF6z0NtUM=; b=uBliaUXghRQImAnVRpohuH9wASrmIyxU5eYZtb6SSH0DtCSzkMrGi4okbiZqO21VLY /SOBHxslIfp9MTqKt1oE8ETAwyLMF3N+KaZ+BAwrUk6w97tJs5uVuLXVcC4j591xQmEj 5RGXhwyd+WJBIDoLn22X00a2cyXFpTbKMFCXgjlX6EeMSQCPZShVCzO0BBjVWBsIDjj4 pl1weVF6mMVrm+sPGxuJquRA9qS/sNoP3A0eRqkgu8H4Nc+Z92biq6fLR7WtmSjHv9et qx0PkuWkTBF9R0O/D6Zi/8jgO3Ef1j7MY4qNzJCHl3gnEtlAh5ahjtN8rD3SFjXy8+ya b/Cg== X-Gm-Message-State: AJaThX5gYKJ9SwoVFzmnhfRuzW1aPKO4Ogk0iOsRe352lntrMFRCGNqp 79GjFthJG8ZSgFdM7Ex4dSQ= X-Google-Smtp-Source: AGs4zMakRdmwmxJpdzmKzvsKRX9I7ZN1wVnDVb7seOVzokYPtgwfsctiAGo5qcALwvqNY0pZnMnIbw== X-Received: by 10.98.87.13 with SMTP id l13mr437140pfb.193.1510806547746; Wed, 15 Nov 2017 20:29:07 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.29.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:07 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 06/12] isdn: hisax: Fix pnp_irq's error checking for setup_hfcs Date: Thu, 16 Nov 2017 09:57:23 +0530 Message-Id: <1372461dd91a1471b52a55207a527ce6580396b2.1510805781.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/hfcscard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/hfcscard.c b/drivers/isdn/hisax/hfcscard.c index 4672870..3cbde72 100644 --- a/drivers/isdn/hisax/hfcscard.c +++ b/drivers/isdn/hisax/hfcscard.c @@ -195,7 +195,7 @@ int setup_hfcs(struct IsdnCard *card) } card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "HFC PnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d); From patchwork Thu Nov 16 04:27:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838414 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FDYYBmRM"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpJg0Lgdz9ryr for ; Thu, 16 Nov 2017 15:33:07 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759331AbdKPEdC (ORCPT ); Wed, 15 Nov 2017 23:33:02 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:44879 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758706AbdKPE3L (ORCPT ); Wed, 15 Nov 2017 23:29:11 -0500 Received: by mail-pg0-f67.google.com with SMTP id 4so10791300pge.1; Wed, 15 Nov 2017 20:29:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=YQ1OLXoxUZ2TM1JkgqvBqDQV1croUbRYwaVqSOQUcg8=; b=FDYYBmRMpEWgMY1XHsWvHOjlts+nrLrOAF69JQ8veQNwRoTafV3PnW0olrhb+N9IEA x/B68bsaK395mrBE9GLsS9DEbFF2cHn2T5luMcDpbAy7KLChBNsWS6UHZaYxUtqGmq7R 5UrZkm/gL3MgsRjdiVSQJFQC/G8bDxNl95tKoUNHXoYETF2knlusrOTQozt+71faJscU lJi+RndbQvfbJNY2JL0OGDa0Ydr8OH7hddfG2H8FFnk3esamSUCdDdJeAkZg65QAXgk8 8UBpo7pj/KlxF051FvbNnBWUO7mHFdkZb+aZ4rG8edqFU3IzNalyJb58I/5is3xBOn0v WqJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=YQ1OLXoxUZ2TM1JkgqvBqDQV1croUbRYwaVqSOQUcg8=; b=sATUa+nCXILKBLUp4q2RuNo9+iELH1B34Uoboa4O9a7J07YQjCdGgWP3BDK9N8rMkq byaJj++qOZhgd+hwRUOdX/zYwHQ2H2vUEgiRhniJ+Y4UstzHSGhXXpLo2eIdEoSO0Vz4 TtDOCCaBiRBbpX3XEeuY2dxZdaCICzUvWoP5lY4TOtuV6wlJF4+xMX7D7bDISG0GQ9Ps 4seCOnCG5hWQ2wbDvserzFbWZNuSlZLXJcq/3Pw/C7ot1U/jk054kBlnBrGqnJ9Gpvlg yqxsbfIhTXBs2Yj22lG+/H3wOiB1B2aj8etzoQ8YOUCZtGOiHrw5dhizw+Phyg2AQT25 x+Gg== X-Gm-Message-State: AJaThX7Qk8+5bvgZIi48XluRWlFgHOJ65lPFPl4pxXFDYFW/jeWcYTMl 1A3eT3+hz+sn4ZShkbwvGfc= X-Google-Smtp-Source: AGs4zMZ0XybadRncOfNHMLWcuXZwkVfFMPBZSiBVyKNV662NKkJEI1S8vlcCRFgRLfcBBHXv8lOQBg== X-Received: by 10.98.97.1 with SMTP id v1mr440164pfb.105.1510806550543; Wed, 15 Nov 2017 20:29:10 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.29.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:09 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 07/12] isdn: hisax: Handle return value of pnp_irq and pnp_port_start Date: Thu, 16 Nov 2017 09:57:24 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org pnp_irq() and pnp_port_start() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/hisax_fcpcipnp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/isdn/hisax/hisax_fcpcipnp.c b/drivers/isdn/hisax/hisax_fcpcipnp.c index e4f7573..7a7137d 100644 --- a/drivers/isdn/hisax/hisax_fcpcipnp.c +++ b/drivers/isdn/hisax/hisax_fcpcipnp.c @@ -940,6 +940,8 @@ static int fcpnp_probe(struct pnp_dev *pdev, const struct pnp_device_id *dev_id) } adapter->io = pnp_port_start(pdev, 0); adapter->irq = pnp_irq(pdev, 0); + if (!adapter->io || adapter->irq == -1) + goto err_free; printk(KERN_INFO "hisax_fcpcipnp: found adapter %s at IO %#x irq %d\n", (char *) dev_id->driver_data, adapter->io, adapter->irq); From patchwork Thu Nov 16 04:27:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838413 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="mi1K2KTr"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpJZ2zL8z9ryr for ; Thu, 16 Nov 2017 15:33:02 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759318AbdKPEc6 (ORCPT ); Wed, 15 Nov 2017 23:32:58 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:49792 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932181AbdKPE3N (ORCPT ); Wed, 15 Nov 2017 23:29:13 -0500 Received: by mail-pf0-f196.google.com with SMTP id l24so6280918pfj.6; Wed, 15 Nov 2017 20:29:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=6pF6gwfTlKPSTJZDvrlF3yxeY1NYhMav+oF3TopfMzc=; b=mi1K2KTrx8+23GrHTWXzeuC/BE9+oqqP0shqWuVthYKn+YulDW0o3We+LNsGQVaW45 1qBnTcamua2gGTeG/sbCDeBe2xEUeFeCk2FL4FQL89z3jKyl9Jpo6XuT4k0anQe6+8yg AVH0I2iPiHa7uZ/wr/m32ninT8FO4sixUtUz0WfkAyr39QJDQA+SDeLE2pR2waxo0Cl/ jsdXA3nzTOMK47/TGHktquTZ0pqGKCVO6oW+1XzqmxPQTRphGGJlJbfTjEj9fwxDoS6F MwvtQktz0VpT/jPCcXiXbLdKUrtaj4ihpqA62BIlrOTLt35Hi/shLnawo3O7Ax+EbnWk 7TNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=6pF6gwfTlKPSTJZDvrlF3yxeY1NYhMav+oF3TopfMzc=; b=Nm3dhOBsUDNs8MYvtk+hPcrryFqKhaepVOzj1MjKe2LKFWHSzMsytP840oYTmI1Hqs Y4Yn2mnDGcobfEgeWX01PLruyEFeALCdCnkjhs8p6lAtCm1JeyKhxsv2SYaVko+7rkwA x5jyTto3VOx//Ao9BrV5U+TWo7Kebm8vxkcOeEoD/TrKEp0jiIukutHuYHluAikJy5EW cDJSWuYs4dPFmhjwUoULH3J8ek1XdsijDtWsoBIda3U/PcWog+qdWSr60sqKnzjx7RKK UinpFaH9AcbqTjIl2ZfIzOLljc3tUmi5K6KpdvNm5ChfcWxV3M6u7/trlCmMKa1vaAcr mOow== X-Gm-Message-State: AJaThX4/I6QJuz6/n16YhHuTrl5l3S0Qz4MFWMBMiFJLm3NXlq61hlDR klR7q4Jbwp+mkJ4cL4xFhYoK9A== X-Google-Smtp-Source: AGs4zMYtJgyZvrZZbuT4Fc+jeWC/fP137KH+u6coDik69KU26v3FhZYSoemsPNDjN+KiESlRUt7A+w== X-Received: by 10.99.120.7 with SMTP id t7mr408773pgc.360.1510806553223; Wed, 15 Nov 2017 20:29:13 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.29.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:12 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 08/12] isdn: hisax: Fix pnp_irq's error checking for setup_isurf Date: Thu, 16 Nov 2017 09:57:25 +0530 Message-Id: <68eb2d0c02e1da7f91d522219e32780a7b7996a8.1510805781.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/isurf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/isurf.c b/drivers/isdn/hisax/isurf.c index 1399ddd..53e299b 100644 --- a/drivers/isdn/hisax/isurf.c +++ b/drivers/isdn/hisax/isurf.c @@ -238,7 +238,7 @@ int setup_isurf(struct IsdnCard *card) cs->hw.isurf.reset = pnp_port_start(pnp_d, 0); cs->hw.isurf.phymem = pnp_mem_start(pnp_d, 1); cs->irq = pnp_irq(pnp_d, 0); - if (!cs->irq || !cs->hw.isurf.reset || !cs->hw.isurf.phymem) { + if (cs->irq == -1 || !cs->hw.isurf.reset || !cs->hw.isurf.phymem) { printk(KERN_ERR "ISurfPnP:some resources are missing %d/%x/%lx\n", cs->irq, cs->hw.isurf.reset, cs->hw.isurf.phymem); pnp_disable_dev(pnp_d); From patchwork Thu Nov 16 04:27:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838406 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kBO1o9hb"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpDz1q7vz9s7g for ; Thu, 16 Nov 2017 15:29:55 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758885AbdKPE3v (ORCPT ); Wed, 15 Nov 2017 23:29:51 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:44888 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932446AbdKPE3R (ORCPT ); Wed, 15 Nov 2017 23:29:17 -0500 Received: by mail-pg0-f67.google.com with SMTP id 4so10791502pge.1; Wed, 15 Nov 2017 20:29:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=3DZpcFVmM7AVNQ/tpF5oL6g3acrRbTdDfkmZdv6xfNM=; b=kBO1o9hbmnFbONZ7Y5CP2Net7j8hf+HltfyJ1aMSfL3abc8fx2amdbm1+tJnlDApNy MLPW39mBryKj21oFHxFwWVDI0qsHjrWrTFUhRc/Gk51JXEki/vkFK42gTRygpaBPRXX+ HkXRTwSGxArTyjrqr9oJ1RhRPyVgMCBDngI4mwv4yBl4o8iUGZljFLDkgC5cNvQax8ny xVLGPh0Bpc6ZGJnq6nix7zQsQMaD97qOGsQazc6ysIgq+OeU7ZhWfXn/jaizA1e3rI2A ROvVdGqMeTlspG5aBTV4FGCndxhhGkzvhStwdJuLJMHgPc8LH4l7Dp3frvbwXZzodEIa /w4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=3DZpcFVmM7AVNQ/tpF5oL6g3acrRbTdDfkmZdv6xfNM=; b=Q/fMuWu9pHUFoFCirfBOfTIOr8qPh97+lWmUD8742UcZgkO5C8ySNXS+y1CytgjmbD 3bhMPXWPskLrkgDPBksKJaZOmO9MYVW/8pZYpEdx9Q8VsSdR5hiKDKLrYO9QSFFFIHQ2 yzh+odLWUQuN1gCUpYf/NNgqcVxGhDO7+4EV1+50jram0XVeutHAJUhBRBCwsuHTyRjH 6vA/Y6YGZaHWwh2frdT9fFzWV+gDGdYlylzmoq9jbZ8lhuSqfoJvQEipGofU9vNYAfuF gznmVxjoWg0mdp0kPWplPRPGLgZX5A78gVhIRDVopbx0Ub16II3k/A2AsFsayIMrf+9y +VbA== X-Gm-Message-State: AJaThX5PyZjdZFA6WjTf6YGFzwm9fy2A8bEUYcVniXkC5lAete8TwE5d GFvDj4j09FJQr9pk1EHZwCg= X-Google-Smtp-Source: AGs4zMbr/3mYjtXHEonUB8jAn4opxv0MgwTp+eR5hB9zmhjpTjTDl1EGGGzRab2Aw62SY6K85+If8Q== X-Received: by 10.159.254.12 with SMTP id r12mr430436pls.218.1510806555949; Wed, 15 Nov 2017 20:29:15 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.29.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:15 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 09/12] isdn: hisax: Fix pnp_irq's error checking for setup_ix1micro Date: Thu, 16 Nov 2017 09:57:26 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/ix1_micro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/ix1_micro.c b/drivers/isdn/hisax/ix1_micro.c index 7ae39f5..bfb79f3 100644 --- a/drivers/isdn/hisax/ix1_micro.c +++ b/drivers/isdn/hisax/ix1_micro.c @@ -256,7 +256,7 @@ int setup_ix1micro(struct IsdnCard *card) } card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "ITK PnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d); From patchwork Thu Nov 16 04:27:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838407 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ogPSQ0Ew"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpF85jFcz9s7g for ; Thu, 16 Nov 2017 15:30:04 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758936AbdKPE36 (ORCPT ); Wed, 15 Nov 2017 23:29:58 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:56336 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758668AbdKPE3T (ORCPT ); Wed, 15 Nov 2017 23:29:19 -0500 Received: by mail-pg0-f65.google.com with SMTP id z184so14293638pgd.13; Wed, 15 Nov 2017 20:29:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=gIGE11Ld59ADzdaCyZhx5QBSlxIZw3CigOf8BfbvA4Y=; b=ogPSQ0EwGyh2yyYmuiJn0nDoRAgOLtDMMUNIOKHXiPNviLRhg+gfJTaWCqtMV26zMm 2vnvroqOircjMW2Ilkc1QT3bZXF6iArVv0wR5y5azARIJd0HgSvMiIcfme9VF56ntwU9 xPwXgn0thQvRuhDt+SlS3dz4cmSieP/FiVDrRVSUcdMzIkpHCgO6JN0FgOFW4kbGRT9e +RnI+h0cc45Luj72AZWiUxM5i853geRAb3+PjOT7TaSFpfUMkyycFSkomQTgP1QLgUwN 7HxGkkPebGIezHjyZjJAqaoRwueScMxrbu8iKv4QKIL56gHFUTbcK3yuRegJa/iw84mb KsYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=gIGE11Ld59ADzdaCyZhx5QBSlxIZw3CigOf8BfbvA4Y=; b=OQNsktrvuAhfIGDXi1Vca3YpYVoRoKgOLeM5NxKYIxXb/WNLGiU0BfbHG95uspK8au fwr/7xUjX1dKhyKh0EMbJnRqlMBZB5K5zRqNlhV+KrKiYpJ4opfcD7qQVyL9tDNd7vHc P1gfCdUMTooRwR5HJYx8DXIE/HP4NH93OQcr6m+C47My5tyYneBMAAN870ovNclCkv+S Q6IEQJasz/iq0nioe60rttSdqRSyeew+PjiyWqk/KeinndUVt7YGsI95yOj97MFgfcBP WaAfPVkiHJRsk+aa+XEgksEqdW6rNcDcYtjULHfQHcgQoHLJ1nDJ2x/3bX63GWmThVQJ Sdbg== X-Gm-Message-State: AJaThX7Q/39gw/hDhGNQr0XZqIhv6p+u+Z3o/8086rE7t1jPluiwkoVs 3eME7jXG//nPRtTpOwlnr68= X-Google-Smtp-Source: AGs4zMZl2YFXsCgoem4iSW2EzUvAcpnMzOtTZY+wOno4Kq+6d5ObVU8teL4/n8NsmmNJt63nAsFzrg== X-Received: by 10.159.197.67 with SMTP id d3mr385337plo.409.1510806558935; Wed, 15 Nov 2017 20:29:18 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.29.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:18 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 10/12] isdn: hisax: Fix pnp_irq's error checking for setup_niccy Date: Thu, 16 Nov 2017 09:57:27 +0530 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/niccy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/niccy.c b/drivers/isdn/hisax/niccy.c index e4c33cf..dfbcd2e 100644 --- a/drivers/isdn/hisax/niccy.c +++ b/drivers/isdn/hisax/niccy.c @@ -261,7 +261,7 @@ int setup_niccy(struct IsdnCard *card) card->para[1] = pnp_port_start(pnp_d, 0); card->para[2] = pnp_port_start(pnp_d, 1); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1] || + if (card->para[0] == -1 || !card->para[1] || !card->para[2]) { printk(KERN_ERR "NiccyPnP:some resources are " "missing %ld/%lx/%lx\n", From patchwork Thu Nov 16 04:27:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838408 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="vcyjA2YP"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpFQ40ktz9sBZ for ; Thu, 16 Nov 2017 15:30:18 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758985AbdKPEaF (ORCPT ); Wed, 15 Nov 2017 23:30:05 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:44899 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758750AbdKPE3W (ORCPT ); Wed, 15 Nov 2017 23:29:22 -0500 Received: by mail-pg0-f66.google.com with SMTP id 4so10791684pge.1; Wed, 15 Nov 2017 20:29:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=TQYbha2GK805nYlpg+QUnTO+9keCiXmJyIoDsrk9a1c=; b=vcyjA2YP2M70eP6YxQ7QsjOrVBYGC6j1tgxHqKEKsfbfZV8w/G7bajm9BW6c5oTmpr 6iOzAayRXBmmyecWmNV1HnukbiwvB0fvv9wm78RwRLei/vzmI+IN3fXOsi7e0DQzNKat +H2h5Yw4few6UiEzopTnFmAVKYjz82nFpIdSJct7O/ZoPozojB48iquK2YIS5N1Yqq8r xitt7fu4cJFNnH199UJsCxujCVxiVzHY160adPfKNAQUr5R2aQncDy5pxcybTJoD+bBR 5N/2GCzcpX255HYtyOzD3VYPofSroTogy2EsPK4r/KWGbdSK7N5Ihouc5Su4g/inhUfN nNZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=TQYbha2GK805nYlpg+QUnTO+9keCiXmJyIoDsrk9a1c=; b=lxRcGq2dS8ESuNY5M2U/PEibmHePtIr8jcVkN2AgiehFYefOhb6T9ZLN+QVmUdvqgl ye6UZxIuTO4tT+RlSfxlwpcj6ZPX/SpukT1fL/agMswfWKNXHkAzK0ZholsYT+U6gS0d yd14JbnJvSX4k0Sc2CJQP7cN3kPpz+S0f0H/QNhLT4Kd9sMsQjRXnAHd5LcptiAg51jk vd/rHWgnl/gk7nhgC4uQKp73ajC42SsKLcx9qsghYdENMxaJFtQN5FWU+vWgsn8BdwWi ZUwysgHi+ZUETC/ygn5LWPuDEPbyQG+wCeXo7LI16ZqCjx57FXLgWmlGeRHVWOL4Fuda q1QQ== X-Gm-Message-State: AJaThX7GuYfaCOzfZAukGNMrg1SgVtwg1aP2SglHxsvVWUeFm2jf5RAh 2hrrgg7DxcGKAcYHKm8zzPo= X-Google-Smtp-Source: AGs4zMYOsPWBS/yXTF+SPMPe8yleKzoF++2Bd364MVD2X/eG1Bz8PiumFpT0keoKG+ycveSrtIoaEQ== X-Received: by 10.99.97.200 with SMTP id v191mr405293pgb.300.1510806561558; Wed, 15 Nov 2017 20:29:21 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.29.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:21 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 11/12] isdn: hisax: Fix pnp_irq's error checking for setup_sedlbauer_isapnp Date: Thu, 16 Nov 2017 09:57:28 +0530 Message-Id: <35eb61ef566cb62e6ca555f5167c0bf3655c9eed.1510805781.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/sedlbauer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/sedlbauer.c b/drivers/isdn/hisax/sedlbauer.c index f16a47b..c0b97b8 100644 --- a/drivers/isdn/hisax/sedlbauer.c +++ b/drivers/isdn/hisax/sedlbauer.c @@ -558,7 +558,7 @@ static int setup_sedlbauer_isapnp(struct IsdnCard *card, int *bytecnt) card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "Sedlbauer PnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d); From patchwork Thu Nov 16 04:27:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838411 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="TbRqVhRl"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpJ34L6Sz9ryr for ; Thu, 16 Nov 2017 15:32:35 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759128AbdKPEcc (ORCPT ); Wed, 15 Nov 2017 23:32:32 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:43889 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932612AbdKPE3Z (ORCPT ); Wed, 15 Nov 2017 23:29:25 -0500 Received: by mail-pf0-f194.google.com with SMTP id a84so13802219pfl.0; Wed, 15 Nov 2017 20:29:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=R7t7+m+x62uKP90LgigSpVBXRBWwge7M1S3zc9A4x3U=; b=TbRqVhRlaEiO/wn47dcHz8dpTCsBS5FwjDMUXYzl+iGXTwMbuKqBenLEP+tge/mYfH DJX2kUjYgTdX5iaTZsK/CMqqM+BTtKfFwf5aQ0+TK3ab8VEcnKPHDTxlKOJ7+GSADk8e zeqfvhskulogWTC+Pd4WZgYI1CLDBIXkywW4IH8YdAzt2L/OOhy9C0RjD+Etjtt9L3EH GQkc2BDNldpEEPpfEaA67jKzuLKMn/+JS4FXO7JUWZptil5duVmmvcd3KtT9TnRGTF7D 3GLDdK6AEx4AuTY6sjDI/oz2HfQmnBP4yPG6VCg9PrEsxJ44L1p/jpZ9xNtUpvibCEmq KCNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=R7t7+m+x62uKP90LgigSpVBXRBWwge7M1S3zc9A4x3U=; b=hy1F2AtFKDO7Ihzv3QWluM+M6UqYoKaiHqs+NL8Lj8lrcz75n301u7FhaN56jb9Pf4 AzzIkA0DwNFB5t4adqtf8o0cnf/5C52QlmF7j+lPiE6DXY0A9isXpC9hJccfaFTBILiY hBongMKcl8Epn/F42Y6+LIguygO7Z+7oV86uUyIgsgjiAjC5NNHD+phyXJ9mZD6OtxZB 9Wp9XDuHL2Bs/EDfUzGMud2WgMpenhTD58n1u/QAvsthT8lF7s1OMfdK1ch64k2/dDcM t/VNsVt9h7TGpd3royXHFcVd9Oy1s666YKfZDWlY2EvmvIThL/OwCL2PQ6Jirvm/axMv 85cQ== X-Gm-Message-State: AJaThX6N/aWA7kuOFiusQK94sVNPzs54SuQeOpKtsRr4E6sc0/TNNTF/ jK9UqRxVGbFQh7jkTaGb0Fc= X-Google-Smtp-Source: AGs4zMZmGcR2OT1G79xKG49amqqZcFh5sBx3i/OdrPfdQC8uAoR0OrEmn9/mLfyIH4FJ/Ww9nwLpmQ== X-Received: by 10.99.154.66 with SMTP id e2mr390165pgo.287.1510806564222; Wed, 15 Nov 2017 20:29:24 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.29.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:23 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 12/12] isdn: hisax: Fix pnp_irq's error checking for setup_teles3 Date: Thu, 16 Nov 2017 09:57:29 +0530 Message-Id: <685ec4c014979a2a93303195c14e631c3c54f107.1510805781.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/teles3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/teles3.c b/drivers/isdn/hisax/teles3.c index 38fb2c1..1eef693 100644 --- a/drivers/isdn/hisax/teles3.c +++ b/drivers/isdn/hisax/teles3.c @@ -306,7 +306,7 @@ int setup_teles3(struct IsdnCard *card) card->para[2] = pnp_port_start(pnp_d, 1); card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1] || !card->para[2]) { + if (card->para[0] == -1 || !card->para[1] || !card->para[2]) { printk(KERN_ERR "Teles PnP:some resources are missing %ld/%lx/%lx\n", card->para[0], card->para[1], card->para[2]); pnp_disable_dev(pnp_d);