From patchwork Tue Oct 22 08:10:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Zissulescu X-Patchwork-Id: 1181121 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-511477-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="ILRIer4P"; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="A1ekMTXW"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46y5mH5GHPz9sP4 for ; Tue, 22 Oct 2019 19:10:39 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version :content-transfer-encoding; q=dns; s=default; b=dfUis76SzTwu8oLk piYdMyCL0XBzN74B65PnNzfHsHD93LHqUySjxZZuOel1qqd4l5nMrAbHhJfyLupc qiLmmLxXq5ATgZ9+iWkExGZCMT/vwnNyRAuDvyjIy3PDUh9W+dPJoZ8+1spGAjYb 03c1j2dgiUDPFQERuonZy8KcE4A= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=default; bh=uh90j5BCO77HNZEG+u6RGK 9sBbE=; b=ILRIer4P4/DzgGNsTk8/l/U57lu3uCKEFnaYVM0DvX/HJZ2j4lGIV5 kYeHMTJ9v2IEFhLpBr+ORL1XpniVbFo03ovMuRpuOjthwmJBLDX67JggLz1CokJB SkP/UMVabm2r2hdHWQtnMAdyihtDmDHoTY8YWyFfRVnErgmSTK6IA= Received: (qmail 76795 invoked by alias); 22 Oct 2019 08:10:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 76781 invoked by uid 89); 22 Oct 2019 08:10:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=our, HContent-Transfer-Encoding:8bit X-HELO: mail-wm1-f66.google.com Received: from mail-wm1-f66.google.com (HELO mail-wm1-f66.google.com) (209.85.128.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Oct 2019 08:10:30 +0000 Received: by mail-wm1-f66.google.com with SMTP id r19so16084787wmh.2 for ; Tue, 22 Oct 2019 01:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eU7UcIqb75P3ly9jiw7OWsMpXwarj7Y20BK1y6lm8YU=; b=A1ekMTXWIkal2EHDc/V61lT4aRTQsOySCABU3UQrI8SMF71apsUP1lMttrrQTVLtYg 8ACxQ+HW5/EF9zYvIj9N8743UUjjtYadjhrWT5tFiFE/LCSxg09HsD2TaDgLvIjUVAcG U+wdROJFy5FFQ5MXQSM1hAeSTGGZ+u+lGOsZko1wNpmYkDusDRJVd51mTctNKTwogNqX j7IzduEEx2FjJf77LBA7pHUMCZyR0lVP7O9bsx+x4vhiJ5h89PbUr3GovFeI+wuAwGzb vxQZMfh0BD2srag7Sx1fvGCUtO5w6fG6APaJl7zkw+zKPKCdE5d8uRduDuFUWXd3bPqW MJyA== Received: from localhost.localdomain ([86.121.123.248]) by smtp.gmail.com with ESMTPSA id q22sm14899396wmj.31.2019.10.22.01.10.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 01:10:27 -0700 (PDT) From: Claudiu Zissulescu To: gcc-patches@gcc.gnu.org Cc: fbedard@synopsys.com, andrew.burgess@embecosm.com, claziss@synopsys.com Subject: [PATCH] [ARC] Fix legitimize pic address. Date: Tue, 22 Oct 2019 11:10:14 +0300 Message-Id: <20191022081014.15747-1-claziss@gmail.com> MIME-Version: 1.0 X-IsSubscribed: yes Hi Andrew, There are cases when an pic address gets complicated, and it needs to be resolved via force_reg function found in prepare_move_operands. When this happens, we need to disambiguate the pic address and re-legitimize it. Testcase added as well. The patch needs to be applied to trunk and gcc9 branch as well. OK to apply? Claudiu gcc/ xxxx-xx-xx Claudiu Zissulescu * config/arc/arc.c (arc_legitimize_pic_address): Consider UNSPECs as well, if interesting recover the symbol and re-legitimize the pic address. gcc/testsuite/ xxxx-xx-xx Claudiu Zissulescu * gcc.target/arc/pic-2.c: New file. --- gcc/config/arc/arc.c | 16 ++++++++++++++++ gcc/testsuite/gcc.target/arc/pic-2.c | 23 +++++++++++++++++++++++ 2 files changed, 39 insertions(+) create mode 100644 gcc/testsuite/gcc.target/arc/pic-2.c diff --git a/gcc/config/arc/arc.c b/gcc/config/arc/arc.c index 8e9db4c652d..0e838910e9d 100644 --- a/gcc/config/arc/arc.c +++ b/gcc/config/arc/arc.c @@ -6234,6 +6234,22 @@ arc_legitimize_pic_address (rtx addr) switch (GET_CODE (addr)) { + case UNSPEC: + /* Can be one or our GOT or GOTOFFPC unspecs. This situation + happens when an address is not a legitimate constant and we + need the resolve it via force_reg in + prepare_move_operands. */ + switch (XINT (addr, 1)) + { + case ARC_UNSPEC_GOT: + case ARC_UNSPEC_GOTOFFPC: + /* Recover the symbol ref. */ + addr = XVECEXP (addr, 0, 0); + break; + default: + return addr; + } + /* Fall through. */ case SYMBOL_REF: /* TLS symbols are handled in different place. */ if (SYMBOL_REF_TLS_MODEL (addr)) diff --git a/gcc/testsuite/gcc.target/arc/pic-2.c b/gcc/testsuite/gcc.target/arc/pic-2.c new file mode 100644 index 00000000000..fed20e0a84c --- /dev/null +++ b/gcc/testsuite/gcc.target/arc/pic-2.c @@ -0,0 +1,23 @@ +/* { dg-do compile } */ +/* { dg-skip-if "PIC not available for ARC6xx" { arc6xx } } */ +/* { dg-options "-mno-sdata -O2 -fpic" } */ + +/* Check if we resolve correctly complex PIC addresses. */ + +char *foo (unsigned size) +{ + static char buf[32]; + register int i; + + if (size > 31) + size = 31; + + for (i = 0; i < size; i++) + { + buf[i] = ' '; + } + buf[size] = '\0'; + return buf; +} + +/* { dg-final { scan-assembler "@buf.\[0-9\]\+@pcl-1" } } */