From patchwork Tue Oct 22 07:05:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 1181070 X-Patchwork-Delegate: sr@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YfcfycJd"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 46y4KL71d2z9sP3 for ; Tue, 22 Oct 2019 18:05:42 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 8355DC21DB5; Tue, 22 Oct 2019 07:05:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 1B97EC21C29; Tue, 22 Oct 2019 07:05:38 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 1277CC21C29; Tue, 22 Oct 2019 07:05:37 +0000 (UTC) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by lists.denx.de (Postfix) with ESMTPS id 7456DC21BE5 for ; Tue, 22 Oct 2019 07:05:36 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id b4so1121567pfr.12 for ; Tue, 22 Oct 2019 00:05:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XlPCmpKaUeALE+7980dRBZCMzOKHXIj4KDOgbTx+CZM=; b=YfcfycJdRhfKC0ls3JVNbTGdbTPceKQbiTT+kvFGg9ihwEd+9Nw1qxDv22Ksznh4bU qxEJ58Q8MWmDoxHRAPOGU7r8ZpGkw8sWPAul/22UHJgpJ6QeM8LJY9NVcGgh4k5TRYAX EnXxe++cw8RcEFM3pVI7/I0L9fMrEOyX6Ud1oq3gC5flytb5VOz1CWWtHTRTUcw1s1qX yPbspzUtj/gqYdDZGInkHRcKpOE0JIvbqGQrT1fGWmrLejps0A8CWzfsSYou2h/y1Hal wWK754xrwXZP5iOd/brxhfbsNDR4FIQm04i2RnhJ1/cg0a0ASfJW1z6lSUR9YpRxz8rr RpmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XlPCmpKaUeALE+7980dRBZCMzOKHXIj4KDOgbTx+CZM=; b=h8aGnd4rtIujegNirDYgi2otT44X58PJwM9rh3G3lKHi3Hd+v2dOBvrKty43Bh8Gr5 sFWW9YROYT1qOq/szPEiKkvxCqUSiLdO6nBifFkMlsD0GTHi23nu03x/tAm8H/KPkYXJ j991lpzRVi6vWl9/WmylBaKgzqAA+GWTPSFFCv9e3uoo1KEifbmTScCtH+HTAVVjxWYj tnU1LJRgEZTwTnLk50GdXJMs79Ybe82pjyNrDay1fPp8LwSIpRU8n2uURbqgygKpI9mI er0fmVg2hfo5t3+K0zIC7jnZcPoYDiWbi/EUn/3DFYJq44ZI++B8g9Ht2ENMhcR3RC+z Zu7A== X-Gm-Message-State: APjAAAUCwK8vJ1IQxpL3RfhJUn5mAPIVolxVk4rKpZDQ9Wv0kNfX+DrD yba1lqXykkjUvBAoqqlswr+E04P7 X-Google-Smtp-Source: APXvYqyjMnWppcKJ/8qfTnah491VBrmrf6jYsAzGnMKOTZbjKOm6rrFMj1w6aJQ6iPpbTa9vsUz2+g== X-Received: by 2002:a17:90a:858a:: with SMTP id m10mr2925022pjn.128.1571727934298; Tue, 22 Oct 2019 00:05:34 -0700 (PDT) Received: from chrisp-dl.atlnz.lc ([2001:df5:b000:22:a0a7:2bd4:9fed:473b]) by smtp.gmail.com with ESMTPSA id q13sm20116937pjq.0.2019.10.22.00.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 00:05:33 -0700 (PDT) From: Chris Packham To: u-boot@lists.denx.de Date: Tue, 22 Oct 2019 20:05:25 +1300 Message-Id: <20191022070525.13648-1-judge.packham@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Cc: Tom Rini , Stefan Roese , Chris Packham Subject: [U-Boot] [PATCH] ARM: mvebu: don't dereference null bd pointer X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" As mentioned in doc/README.arm-relocation gd->bd is not available in dram_init() so we shouldn't attempt to access it. Signed-off-by: Chris Packham Reviewed-by: Stefan Roese --- arch/arm/mach-mvebu/dram.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/arch/arm/mach-mvebu/dram.c b/arch/arm/mach-mvebu/dram.c index fa8c799a462e..ba8ebc62887f 100644 --- a/arch/arm/mach-mvebu/dram.c +++ b/arch/arm/mach-mvebu/dram.c @@ -281,16 +281,6 @@ int dram_init(void) size = MVEBU_SDRAM_SIZE_MAX; } - for (; i < CONFIG_NR_DRAM_BANKS; i++) { - /* If above loop terminated prematurely, we need to set - * remaining banks' start address & size as 0. Otherwise other - * u-boot functions and Linux kernel gets wrong values which - * could result in crash */ - gd->bd->bi_dram[i].start = 0; - gd->bd->bi_dram[i].size = 0; - } - - if (ecc_enabled()) dram_ecc_scrubbing();