From patchwork Sat Sep 28 06:34:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 1168799 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-509750-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="Ct6ieYjY"; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LuqXdgxL"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46gJnM0dJ1z9sNf for ; Sat, 28 Sep 2019 16:35:16 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=c9yA/7QRttjrA4pBs2JL+8/hXw89abQPhE9T6iuYkN1XsqgRNN 0xvsz109+hSPZ7G1LDX5e0Ih6PaxA/ZQPb9RRB7CQ0t8csQDPOF1ocCoYVwSPjgO jo1OtLKeC/tZocViagoohXYphQS6rMKAMUuKcIx1xwXZlKtDwwSb170os= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=kR8njLG7NTI+1OzWDrI4RfmdGbI=; b=Ct6ieYjYKhd9NYNzdkht 3czpHMpPWfM2HTJEvt90LnWKyWquw9bbm5XN4ipU/Frnrs46vouOJmZbvrpqotH8 t3u4MMiG+R76m6iXVkJoFd0UfRllW3oHOXpXF9el04LGODE7+xuFHjhuv+z/rsJM 2oTrVWuZF2Cp4N/BcLUP8Z4= Received: (qmail 116961 invoked by alias); 28 Sep 2019 06:35:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 116946 invoked by uid 89); 28 Sep 2019 06:35:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-pf1-f176.google.com Received: from mail-pf1-f176.google.com (HELO mail-pf1-f176.google.com) (209.85.210.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 28 Sep 2019 06:35:06 +0000 Received: by mail-pf1-f176.google.com with SMTP id v4so2721830pff.6; Fri, 27 Sep 2019 23:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=7H0+7t1XvlFgsldXfwdn7gRwqHh7PFAWIw3Af7sj72o=; b=LuqXdgxLkam9frcb8VGURtMrxgRskJqtmrVrKMnM9bSoM4mhLavBxEF3m1tM+Rc4kT lmZ6WSzF9JqOHSLG17Sv8tmPjoAfrS8Cl4wYdBYvovDxVzZsX0qSlauGcMu5Quamp3rb VlWq5fpiyshR7+c7TQMS1v2rgWHkmDP2I5mzXtEA5O1s6s20EKMbOtvMj8OxIQ9TmSTQ l6LMden5uB0oXEogiaYpicnddkecJGbOAxDk2HLW9SjuFn1AEuQtJSbyFx1nDd4d2IZ7 OFPjlCWoK/Mge0gR8ZVUIpgr9bAKDMsay1MRcLCVr80Jwis+UAXv6w5EkybIRJyOKOa2 RVNA== Received: from bubble.grove.modra.org ([2406:3400:51d:8cc0:10c7:1c50:6573:70aa]) by smtp.gmail.com with ESMTPSA id b16sm9451314pfb.54.2019.09.27.23.35.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2019 23:35:03 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 4C555804DE; Sat, 28 Sep 2019 16:04:59 +0930 (ACST) Date: Sat, 28 Sep 2019 16:04:59 +0930 From: Alan Modra To: gcc-patches@gcc.gnu.org Cc: rguenth@gcc.gnu.org Subject: Fix endian issue in pr91656 testcases Message-ID: <20190928063459.GA20197@bubble.grove.modra.org> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-IsSubscribed: yes Tested on powerpc64le-linux and powerpc64-linux. OK? pr91656-3.c didn't really need to be changed since popcount doesn't care which bits are set, but I figured it was better to make the test set the low 16 bits of the 64-bit value in both big and litte endian. PR testsuite/91676 PR rtl-optimization/91656 * gcc.dg/torture/pr91656-1.c: Correct for big and pdp endian. * gcc.dg/torture/pr91656-2.c: Likewise. * gcc.dg/torture/pr91656-3.c: Likewise. diff --git a/gcc/testsuite/gcc.dg/torture/pr91656-1.c b/gcc/testsuite/gcc.dg/torture/pr91656-1.c index 6c1e73c7f01..fae17de1112 100644 --- a/gcc/testsuite/gcc.dg/torture/pr91656-1.c +++ b/gcc/testsuite/gcc.dg/torture/pr91656-1.c @@ -6,7 +6,17 @@ int a, b, c, d, e; static __attribute__ ((__noipa__)) int foo (int i) { +#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ __builtin_memmove (&i, &e, 1); +#elif __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ + __builtin_memmove ((char *) &i + sizeof (i) - 1, + (char *) &e + sizeof (e) - 1, 1); +#elif __BYTE_ORDER__ == __ORDER_PDP_ENDIAN__ + __builtin_memmove ((char *) &i + sizeof (i) - 2, + (char *) &e + sizeof (e) - 2, 1); +#else +#error "endian unknown?" +#endif if (a > 0) i /= e; e /= 5; diff --git a/gcc/testsuite/gcc.dg/torture/pr91656-2.c b/gcc/testsuite/gcc.dg/torture/pr91656-2.c index 90374becae0..29a619b280e 100644 --- a/gcc/testsuite/gcc.dg/torture/pr91656-2.c +++ b/gcc/testsuite/gcc.dg/torture/pr91656-2.c @@ -12,7 +12,17 @@ d (u16 g) { u64 f = __builtin_bswap64 (c); f = g == a; +#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ __builtin_memmove (&f, &e, 1); +#elif __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ + __builtin_memmove ((char *) &f + sizeof (f) - 1, + (char *) &e + sizeof (e) - 1, 1); +#elif __BYTE_ORDER__ == __ORDER_PDP_ENDIAN__ + __builtin_memmove ((char *) &f + sizeof (f) - 2, + (char *) &e + sizeof (e) - 2, 1); +#else +#error "endian unknown?" +#endif e >>= b; return a + f; } diff --git a/gcc/testsuite/gcc.dg/torture/pr91656-3.c b/gcc/testsuite/gcc.dg/torture/pr91656-3.c index 8e65d24a21d..f84e51af4a4 100644 --- a/gcc/testsuite/gcc.dg/torture/pr91656-3.c +++ b/gcc/testsuite/gcc.dg/torture/pr91656-3.c @@ -10,7 +10,14 @@ int d (u16 e, u64 f) { b |= e; +#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ __builtin_memset (&f, e, 2); +#elif (__BYTE_ORDER__ == __ORDER_BIG_ENDIAN__ \ + || __BYTE_ORDER__ == __ORDER_PDP_ENDIAN__) + __builtin_memset ((char *) &f + sizeof (f) - 2, e, 2); +#else +#error "endian unknown?" +#endif a = (u16) - e >= 2 ? : __builtin_popcountll (f); return a + c; }