From patchwork Wed Sep 11 00:37:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Navid Emamdoost X-Patchwork-Id: 1160581 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OBm4mmF1"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46Sjgt2NC9z9sNT for ; Wed, 11 Sep 2019 10:38:50 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726504AbfIKAiK (ORCPT ); Tue, 10 Sep 2019 20:38:10 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:43702 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbfIKAiJ (ORCPT ); Tue, 10 Sep 2019 20:38:09 -0400 Received: by mail-io1-f67.google.com with SMTP id r8so16916240iol.10; Tue, 10 Sep 2019 17:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=dRI+UdAuaAbnPtCUSwMls+vSMICgBec5wWc6vxh4hkk=; b=OBm4mmF1te/FWhD/LX89H9UprVV9vS9/H2Np6nhNmwprVCnmDCcbySPjxXw4clpFPp g7IniQTiq4FgQPuztxxZjPuzChPi9IND59ptii0SCMHs7dyRHBKzLhxxa/CVbinoj8fc OoMlRTXgQQcD8M2ajqUiY7ECsGiApYfCIoAJqLNW44rpYVJ17S6KWEOmGz04Lei/159U B1NOCZFLKdX9b6wt7wXNJ7XB7upIPjm59+grmrdCWFJXtptKZCY6g7COllw44qXqaYWw yGWDj3gq0s548XMqOkpYybiorQAvmIbiDsZr3Gaxn3WdDZlQuEkIb0L7BqrkgUcC8EW3 euZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dRI+UdAuaAbnPtCUSwMls+vSMICgBec5wWc6vxh4hkk=; b=fzq7zyQbHJjngSc/03P76LBCYEvFfgARX6uvKOuzCnri6JlrJ3E15ANu0pqtB/dkPM WX7ak06+SXRooWvk+oU3QSlWQl31wOOQk9urPQBS2BiMVMpSGkJljT1vkgbYapYcf5eN 4OTg28zAn+UJmJUwxD/YrrUHmyS6lqM+w/pQ9l3sBmerXDbj0U2cg7Q9fj/WWMw9tbls And4LACtoYb1gQxcT6m5jOZB+a+HSb2ZyVKmORCpcKhjGTbByfc7sO1tjAK2BHYyp5ZR j+goAQ4LPLRw3KqGOjdb6PhA0iEQhR2EqDRpyluD5QA5BqpYdcNLxk9cAY+sPmTnvhz/ Jf8Q== X-Gm-Message-State: APjAAAXxQTNc/Q8aMLEgwNnoagvYuEabsQC5YW0grsymIeg7HRiJqPM1 l0//+o8eejap6iergxX6b3A= X-Google-Smtp-Source: APXvYqwp9FZpJ5cxlCa56IMz05LQ68eyqQTkw8sXV1jbfhzeViymUH1fmKgEyuj7eYkyl7WCVDII2A== X-Received: by 2002:a6b:acc5:: with SMTP id v188mr39248679ioe.268.1568162288759; Tue, 10 Sep 2019 17:38:08 -0700 (PDT) Received: from cs-dulles.cs.umn.edu (cs-dulles.cs.umn.edu. [128.101.35.54]) by smtp.googlemail.com with ESMTPSA id s201sm48548116ios.83.2019.09.10.17.38.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2019 17:38:08 -0700 (PDT) From: Navid Emamdoost Cc: emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu, Navid Emamdoost , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: qrtr: fix memort leak in qrtr_tun_write_iter Date: Tue, 10 Sep 2019 19:37:45 -0500 Message-Id: <20190911003748.26841-1-navid.emamdoost@gmail.com> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In qrtr_tun_write_iter the allocated kbuf should be release in case of error happening. Signed-off-by: Navid Emamdoost --- net/qrtr/tun.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/net/qrtr/tun.c b/net/qrtr/tun.c index ccff1e544c21..1dba8b92560e 100644 --- a/net/qrtr/tun.c +++ b/net/qrtr/tun.c @@ -84,12 +84,18 @@ static ssize_t qrtr_tun_write_iter(struct kiocb *iocb, struct iov_iter *from) if (!kbuf) return -ENOMEM; - if (!copy_from_iter_full(kbuf, len, from)) + if (!copy_from_iter_full(kbuf, len, from)) { + kfree(kbuf); return -EFAULT; + } ret = qrtr_endpoint_post(&tun->ep, kbuf, len); + if (ret < 0) { + kfree(kbuf); + return ret; + } - return ret < 0 ? ret : len; + return len; } static __poll_t qrtr_tun_poll(struct file *filp, poll_table *wait)