From patchwork Sun Sep 3 20:26:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zahari Doychev X-Patchwork-Id: 809354 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.b="tAnEEUHu"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xlkyc6GR0z9s7v for ; Mon, 4 Sep 2017 06:26:16 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752105AbdICU0O (ORCPT ); Sun, 3 Sep 2017 16:26:14 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36904 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbdICU0M (ORCPT ); Sun, 3 Sep 2017 16:26:12 -0400 Received: by mail-wm0-f66.google.com with SMTP id x189so4761493wmg.4 for ; Sun, 03 Sep 2017 13:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=EMwmXwMzWmxzqPo/mMT/5WTWr3lMaFndos90BMelTRU=; b=tAnEEUHu8SDfHu4Ozzs7L01jAB7nq/y19KjbiveBF5YoQOZXFZB45e1wAMMlxFDe/M tt1zyft7amLcfOyv2AQXSDO1afbeR3SefX8HSTc2u7kng/in36L7wxnXVb4T4WQyA0Is kvAtth/4Zsb5kh2+tBHfnHamrer9IJAr1b5uajj1B4j60vUjuJat5I10NiMkvY63Y70h 00+RHlcGmMD2QnqulgxWQAMRZcYGHGqWduQV54GN41wiaCRlyfn+S2w/JG7KSIj+/wY7 09lBdtqnkSI5OBEp5Pk/GikgMMfC/qmmA4aCHX2km0H/cuTR+3d/qfDEicsq6b+slDq2 u0Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=EMwmXwMzWmxzqPo/mMT/5WTWr3lMaFndos90BMelTRU=; b=ngWG50zBxWsufb1YV4eLBY6X+M9neRy3rxQFKtvQT8fM735NyQRB9L0lZ+LKN8wybX +YsrVOTen4TfSeNrkLXnPb0wGVP1+abN1DuTNUKwTHK4/SeEWhC/ogwdmrnen0iafGk6 PAcKXaatC8KM6tkUFcL6ZnfXP3ZYw6y4FrFLv+uh35+dawjJEfjD/NL30pftDScGADYf XBRYNPv6n7hlMs/r7xdpe/iTvkKYxtxu1ADGFHJ09r3KWdWsVgREqakH3aWUZHKkyF9I bruIVziZIfCxtvhnx3VqAz9Tk23ZwbF5XPevSs011KUz9ph0tBun8ErijfOyAAEX0Q0a lbAA== X-Gm-Message-State: AHPjjUg+8AP6PE/146B6vJVN5diYG3JC94WyTjYFTXqBzV/DGiuf1vIv zDM9z73R2NWTWd9w X-Google-Smtp-Source: ADKCNb5eTr4Q+6BjXpRjJsx5Desr/DOW1GLpopz1xEvs+xiRUlWfOL2wqTcuoRQ9691Tw8c0HJSgJA== X-Received: by 10.28.52.149 with SMTP id b143mr2357486wma.86.1504470371676; Sun, 03 Sep 2017 13:26:11 -0700 (PDT) Received: from revolt.blackmail ([2a02:810d:1500:e01:4216:7eff:feaa:ea6b]) by smtp.gmail.com with ESMTPSA id x45sm1806770wrb.6.2017.09.03.13.26.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Sep 2017 13:26:11 -0700 (PDT) From: Zahari Doychev To: jiri@resnulli.us, netdev@vger.kernel.org Cc: Zahari Doychev Subject: [PATCH][next] rocker: fix kcalloc parameter order Date: Sun, 3 Sep 2017 22:26:03 +0200 Message-Id: <4d8a3c58c2a4e89319034f5faf41ba4682dc15ae.1504461594.git.zahari.doychev@linux.com> X-Mailer: git-send-email 2.13.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The function calls to kcalloc use wrong parameter order. The flags have to be passed as last parameter. The change was done using the following coccinelle script: @@ expression E1,E2; type T; @@ -kcalloc(E1, E2, sizeof(T)) +kcalloc(E2, sizeof(T), E1) Signed-off-by: Zahari Doychev --- drivers/net/ethernet/rocker/rocker_ofdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c b/drivers/net/ethernet/rocker/rocker_ofdpa.c index da4e26b53a52..2708451ce22a 100644 --- a/drivers/net/ethernet/rocker/rocker_ofdpa.c +++ b/drivers/net/ethernet/rocker/rocker_ofdpa.c @@ -1177,7 +1177,7 @@ static int ofdpa_group_l2_fan_out(struct ofdpa_port *ofdpa_port, entry->group_id = group_id; entry->group_count = group_count; - entry->group_ids = kcalloc(flags, group_count, sizeof(u32)); + entry->group_ids = kcalloc(group_count, sizeof(u32), flags); if (!entry->group_ids) { kfree(entry); return -ENOMEM; @@ -1456,7 +1456,7 @@ static int ofdpa_port_vlan_flood_group(struct ofdpa_port *ofdpa_port, int err = 0; int i; - group_ids = kcalloc(flags, port_count, sizeof(u32)); + group_ids = kcalloc(port_count, sizeof(u32), flags); if (!group_ids) return -ENOMEM;