From patchwork Mon Aug 26 07:06:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kamlesh kumar X-Patchwork-Id: 1152996 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-507681-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="IizTUAq/"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="JOzrJNh7"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46H33K5zzkz9s7T for ; Mon, 26 Aug 2019 17:07:07 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=ktuuDnDZwj7+wpduKrTqndzlEHbhKGbbuoqRp9BoLdUpNu FlcJJzE7TZcYnKK8eXxSolNfs8bpI5ha0mPXlUMkB8NvdEXomw6WWUwWkT35HWep Zwljg8WrkbaK5PDzGqar6QBiqDh1HfO6hW5P9PXXa0B/1MgniOCQckAalGy88= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=e7yfFpy2mnzxEezJQ5hwGGKTPHs=; b=IizTUAq/YfSJcDcOzG6s gwVqFt2d/pDHoTAZzaktKIh9/wBflQIRVGmRp8PoSoCVcv+2fjg1sFTM3A+wvqkU mNvXp+Ihh7PbCsnxKmIeY6OIoQOg0NziapKeMr5wis8RmIVaYJNHHp7vHCA6NYgf BUWATTXANh4hbM2Kwl4siyI= Received: (qmail 88923 invoked by alias); 26 Aug 2019 07:06:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 88911 invoked by uid 89); 26 Aug 2019 07:06:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.6 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:209.85.166, dgfinal, dg-final, H*c:alternative X-HELO: mail-io1-f49.google.com Received: from mail-io1-f49.google.com (HELO mail-io1-f49.google.com) (209.85.166.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Aug 2019 07:06:57 +0000 Received: by mail-io1-f49.google.com with SMTP id x4so34745875iog.13; Mon, 26 Aug 2019 00:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=ShJ1GkPWyDVJXSBOm7kRUjXRNQc+9Aiq/TSRfNoikZo=; b=JOzrJNh75OeODQ/CrMX1IT04sdGXUAhZgZHfTO0BeLHrITvtLe+m7xn656xfWCxPtp /CFSTZqmdX/TUJYsqwBbRtkBryfHtOK15hIDNjG8wxX/0gLtTkVOply2Z0Gl5EONW+SZ N8LdQut8MhxOjwfmofwOZ7mJaAiARei4lcMFcrGKfFpnoEbWVO59gVeicU0+eZlg1wCi tlyT3LZcsK2FtH3FsRcRz3SOUF3nBvvK81WSai3iFhtdEfXhRRzpwd9dEE+TIg25H6H+ uHea34CFNZ0YWqidhf5X4MOGH32rHGAMO4xPzan4M2QXyRgFOAPuN6Q2tVNIUemv8kfY 1ojg== MIME-Version: 1.0 From: kamlesh kumar Date: Mon, 26 Aug 2019 12:36:43 +0530 Message-ID: Subject: [Patch][PR91504] Inlining misses some logical operation folding To: gcc-patches@gcc.gnu.org, rguenth@gcc.gnu.org X-IsSubscribed: yes 2019-08-26 Kamlesh Kumar * gcc/match.pd: Added simplification pattern. * gcc.dg/tree-ssa/pr91504.c: New test. ==================== diff --git a/gcc/match.pd b/gcc/match.pd index 93dcef9..b3734f8 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -831,6 +831,11 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (bit_xor:c (bit_and:cs @0 (bit_not @1)) (bit_not @0)) (bit_not (bit_and @0 @1))) +/* (~a & b) ^ a --> (a | b) */ +(simplify + (bit_xor:c (bit_and:cs (bit_not @0) @1) @0) + (bit_ior @0 @1)) + /* (a | b) & ~(a ^ b) --> a & b */ (simplify (bit_and:c (bit_ior @0 @1) (bit_not (bit_xor:c @0 @1))) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr91504.c b/gcc/testsuite/gcc.dg/tree-ssa/pr91504.c new file mode 100644 index 0000000..a52dea4 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr91504.c @@ -0,0 +1,18 @@ +/* { dg-do compile } */ +/* { dg-options "-O -fdump-tree-optimized-raw" } */ + +static inline unsigned deposit32(unsigned value, int start, int length, + unsigned fieldval) +{ + unsigned mask = (~0U >> (32 - length)) << start; + return (value & ~mask) | ((fieldval << start) & mask); +} + +unsigned foo(unsigned value) +{ + return deposit32(value, 10, 1, 1); +} + +/* { dg-final { scan-tree-dump-not "bit_and_expr" "optimized" } } */ +/* { dg-final { scan-tree-dump-not "bit_xor_expr" "optimized" } } */ +/* { dg-final { scan-tree-dump-not "bit_not_expr" "optimized" } } */